From 9d83e807e7179aea4ca709c0b5a08e8f9377367f Mon Sep 17 00:00:00 2001 From: Fredia Huya-Kouadio Date: Mon, 6 Feb 2023 17:04:29 -0800 Subject: [PATCH] Downgrade the vulkan abort logic to a warning This addresses issues where some drivers are reporting they don't meet the vulkan hardware level 1 support requirements even though they render as expected when the check is removed. --- platform/android/java/editor/src/main/res/values/dimens.xml | 2 +- platform/android/java/lib/res/values/strings.xml | 2 +- .../android/java/lib/src/org/godotengine/godot/Godot.java | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/platform/android/java/editor/src/main/res/values/dimens.xml b/platform/android/java/editor/src/main/res/values/dimens.xml index 03fb6184d21..98bfe401797 100644 --- a/platform/android/java/editor/src/main/res/values/dimens.xml +++ b/platform/android/java/editor/src/main/res/values/dimens.xml @@ -1,5 +1,5 @@ 600dp - 800dp + 1024dp diff --git a/platform/android/java/lib/res/values/strings.xml b/platform/android/java/lib/res/values/strings.xml index f76f597140e..03752e092ec 100644 --- a/platform/android/java/lib/res/values/strings.xml +++ b/platform/android/java/lib/res/values/strings.xml @@ -14,7 +14,7 @@ Cancel Verification Error! Unable to setup the Godot Engine! Aborting… - This device does not meet the requirements for Vulkan support! Aborting… + Warning - this device does not meet the requirements for Vulkan support diff --git a/platform/android/java/lib/src/org/godotengine/godot/Godot.java b/platform/android/java/lib/src/org/godotengine/godot/Godot.java index 307fa7bae16..a03da7292bf 100644 --- a/platform/android/java/lib/src/org/godotengine/godot/Godot.java +++ b/platform/android/java/lib/src/org/godotengine/godot/Godot.java @@ -83,6 +83,7 @@ import android.widget.Button; import android.widget.FrameLayout; import android.widget.ProgressBar; import android.widget.TextView; +import android.widget.Toast; import androidx.annotation.CallSuper; import androidx.annotation.Keep; @@ -277,9 +278,7 @@ public class Godot extends Fragment implements SensorEventListener, IDownloaderC if (usesVulkan()) { if (!meetsVulkanRequirements(activity.getPackageManager())) { - Log.e(TAG, "Missing requirements for vulkan support! Aborting..."); - alert(R.string.error_missing_vulkan_requirements_message, R.string.text_error_title, this::forceQuit); - return false; + Log.w(TAG, "Missing requirements for vulkan support!"); } mRenderView = new GodotVulkanRenderView(activity, this); } else {