Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-10 14:12:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve time to close scene with many 3D gizmos

Browse Source 
Changed EditorNode3DGizmoPlugin::current_gizmos from List to HashSet, to avoid having to iterate through all gizmos when ~EditorNode3DGizmo unregisters itself.
This commit is contained in:
aaronp64 2024-07-24 10:27:52 -04:00
parent 4e5ed0bbfb
commit 4d0e2ee47d
4 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
editor/plugins/gizmos/joint_3d_gizmo_plugin.cpp
View File

@ -293,9 +293,15 @@ Joint3DGizmoPlugin::Joint3DGizmoPlugin() {
void Joint3DGizmoPlugin::incremental_update_gizmos() {
if (!current_gizmos.is_empty()) {
update_idx++;
update_idx = update_idx % current_gizmos.size();
redraw(current_gizmos.get(update_idx));
HashSet<EditorNode3DGizmo *>::Iterator E = current_gizmos.find(last_drawn);
if (E) {
++E;
}
if (!E) {
E = current_gizmos.begin();
}
redraw(*E);
last_drawn = *E;
}
}

2
editor/plugins/gizmos/joint_3d_gizmo_plugin.h
View File

@ -37,7 +37,7 @@ class Joint3DGizmoPlugin : public EditorNode3DGizmoPlugin {
GDCLASS(Joint3DGizmoPlugin, EditorNode3DGizmoPlugin);
Timer *update_timer = nullptr;
uint64_t update_idx = 0;
EditorNode3DGizmo *last_drawn = nullptr;
void incremental_update_gizmos();

2
editor/plugins/node_3d_editor_gizmos.cpp
View File

@ -1023,7 +1023,7 @@ Ref<EditorNode3DGizmo> EditorNode3DGizmoPlugin::get_gizmo(Node3D *p_spatial) {
ref->set_node_3d(p_spatial);
ref->set_hidden(current_state == HIDDEN);
current_gizmos.push_back(ref.ptr());
current_gizmos.insert(ref.ptr());
return ref;
}

2
editor/plugins/node_3d_editor_gizmos.h
View File

@ -152,7 +152,7 @@ public:
protected:
int current_state;
List<EditorNode3DGizmo *> current_gizmos;
HashSet<EditorNode3DGizmo *> current_gizmos;
HashMap<String, Vector<Ref<StandardMaterial3D>>> materials;
static void _bind_methods();