From 4c84cb6ae8dc241eb3f50dd8899132024592dee2 Mon Sep 17 00:00:00 2001 From: Thaddeus Crews Date: Wed, 28 Aug 2024 15:29:42 -0500 Subject: [PATCH] SCons: Pass `/Zc:__cplusplus` in MSVC builds --- SConstruct | 2 ++ core/typedefs.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/SConstruct b/SConstruct index 0297cd6e616..5c1ccd24492 100644 --- a/SConstruct +++ b/SConstruct @@ -791,6 +791,8 @@ else: # Note that this is still not complete conformance, as certain Windows-related headers # don't compile under complete conformance. env.Prepend(CCFLAGS=["/permissive-"]) + # Allow use of `__cplusplus` macro to determine C++ standard universally. + env.Prepend(CXXFLAGS=["/Zc:__cplusplus"]) # Disable exception handling. Godot doesn't use exceptions anywhere, and this # saves around 20% of binary size and very significant build time (GH-80513). diff --git a/core/typedefs.h b/core/typedefs.h index 0de803293d3..35c4668581b 100644 --- a/core/typedefs.h +++ b/core/typedefs.h @@ -44,6 +44,9 @@ #include "core/error/error_list.h" #include +// Ensure that C++ standard is at least C++17. If on MSVC, also ensures that the `Zc:__cplusplus` flag is present. +static_assert(__cplusplus >= 201703L); + // Turn argument to string constant: // https://gcc.gnu.org/onlinedocs/cpp/Stringizing.html#Stringizing #ifndef _STR