Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-10 06:03:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Metal: fix out of bounds crash when using debug draw modes

Browse Source
This commit is contained in:
Stuart Carnie 2024-09-11 06:08:42 +10:00
parent 97ef3c8372
commit 34190fc360
No known key found for this signature in database
GPG Key ID: 848D9C9718D78B4F
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/metal/metal_objects.mm
View File

@ -560,10 +560,10 @@ void MDCommandBuffer::_render_clear_render_area() {
} }
} }
uint32_t ds_index = subpass.depth_stencil_reference.attachment; uint32_t ds_index = subpass.depth_stencil_reference.attachment;
MDAttachment const &attachment = pass.attachments[ds_index]; bool shouldClearDepth = (ds_index != RDD::AttachmentReference::UNUSED && pass.attachments[ds_index].shouldClear(subpass, false));
bool shouldClearDepth = (ds_index != RDD::AttachmentReference::UNUSED && attachment.shouldClear(subpass, false)); bool shouldClearStencil = (ds_index != RDD::AttachmentReference::UNUSED && pass.attachments[ds_index].shouldClear(subpass, true));
bool shouldClearStencil = (ds_index != RDD::AttachmentReference::UNUSED && attachment.shouldClear(subpass, true));
if (shouldClearDepth || shouldClearStencil) { if (shouldClearDepth || shouldClearStencil) {
MDAttachment const &attachment = pass.attachments[ds_index];
BitField<RDD::TextureAspectBits> bits; BitField<RDD::TextureAspectBits> bits;
if (shouldClearDepth && attachment.type & MDAttachmentType::Depth) { if (shouldClearDepth && attachment.type & MDAttachmentType::Depth) {
bits.set_flag(RDD::TEXTURE_ASPECT_DEPTH_BIT); bits.set_flag(RDD::TEXTURE_ASPECT_DEPTH_BIT);