Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-15 16:43:10 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
155a94fabe
godot/editor/editor_node.cpp

7352 lines
266 KiB
C++
Raw Normal View History

GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
/*************************************************************************/
/* editor_node.cpp */
/*************************************************************************/
/* This file is part of: */
/* GODOT ENGINE */
Use HTTPS URL for Godot's website in the headers
2017-08-27 12:16:55 +00:00
/* https://godotengine.org */
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
/*************************************************************************/
Update copyright statements to 2022 Happy new year to the wonderful Godot community!
2022-01-03 20:27:34 +00:00
/* Copyright (c) 2007-2022 Juan Linietsky, Ariel Manzur. */
/* Copyright (c) 2014-2022 Godot Engine contributors (cf. AUTHORS.md). */
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
/* */
/* Permission is hereby granted, free of charge, to any person obtaining */
/* a copy of this software and associated documentation files (the */
/* "Software"), to deal in the Software without restriction, including */
/* without limitation the rights to use, copy, modify, merge, publish, */
/* distribute, sublicense, and/or sell copies of the Software, and to */
/* permit persons to whom the Software is furnished to do so, subject to */
/* the following conditions: */
/* */
/* The above copyright notice and this permission notice shall be */
/* included in all copies or substantial portions of the Software. */
/* */
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.*/
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/*************************************************************************/
Add missing copyright headers and fix formatting Using `misc/scripts/fix_headers.py` on all Godot files. Some missing header guards were added, and the header inclusion order was fixed in the Bullet module.
2018-01-04 23:50:27 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
#include "editor_node.h"
Style: Cleanups, added headers, renamed files Made sure files in core/ and tools/ have a proper Godot license header when written by us. Also renamed aabb.{cpp,h} and object_type_db.{cpp,h} to rect3.{cpp,h} and class_db.{cpp,h} respectively. Also added a proper header to core/io/base64.{c,h} after clarifying the licensing with the original author (public domain).
2017-01-16 07:04:19 +00:00
Reorganized core/ directory, it was too fatty already -Removed FuncRef, since Callable makes it obsolete -Removed int_types.h as its obsolete in c++11+ -Changed color names code
2020-11-07 22:33:38 +00:00
#include "core/config/project_settings.h"
Implement native extension system * Deprecates GDNative in favor of a simpler, lower level interface. * New extension system allows registering core engine classes. * Simple header interface in gdnative_interace.h
2021-06-19 15:58:49 +00:00
#include "core/extension/native_extension_manager.h"
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 13:19:37 +00:00
#include "core/input/input.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "core/io/config_file.h"
Core: Move DirAccess and FileAccess to `core/io` File handling APIs are typically considered part of I/O, and we did have most `FileAccess` implementations in `core/io` already.
2021-06-11 12:51:48 +00:00
#include "core/io/file_access.h"
Resize custom class icon
2019-10-23 18:11:04 +00:00
#include "core/io/image_loader.h"
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
#include "core/io/resource_loader.h"
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
#include "core/io/resource_saver.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "core/io/stream_peer_ssl.h"
Reorganized core/ directory, it was too fatty already -Removed FuncRef, since Callable makes it obsolete -Removed int_types.h as its obsolete in c++11+ -Changed color names code
2020-11-07 22:33:38 +00:00
#include "core/object/class_db.h"
#include "core/object/message_queue.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "core/os/keyboard.h"
#include "core/os/os.h"
Add Time singleton
2021-05-24 11:54:05 +00:00
#include "core/os/time.h"
Reorganized core/ directory, it was too fatty already -Removed FuncRef, since Callable makes it obsolete -Removed int_types.h as its obsolete in c++11+ -Changed color names code
2020-11-07 22:33:38 +00:00
#include "core/string/print_string.h"
#include "core/string/translation.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "core/version.h"
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
#include "main/main.h"
GLTF for game templates. Convert GLTF Document to use ImporterMeshInstance3D. Add a GLTFDocument extension list and an extension for converting the importer mesh instance 3d to mesh instance 3d. Use GLTF module when the editor tools are disabled. Modified the render server to be less restrictive on matching blend arrays and have more logging. Misc bugs with multimesh. Always index the meshes.
2021-09-21 01:24:31 +00:00
#include "scene/3d/importer_mesh_instance_3d.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "scene/gui/center_container.h"
#include "scene/gui/control.h"
#include "scene/gui/dialogs.h"
#include "scene/gui/file_dialog.h"
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 00:20:54 +00:00
#include "scene/gui/link_button.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "scene/gui/menu_button.h"
#include "scene/gui/panel.h"
#include "scene/gui/panel_container.h"
#include "scene/gui/split_container.h"
Rename `Tabs` to `TabBar`
2021-10-17 16:55:44 +00:00
#include "scene/gui/tab_bar.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "scene/gui/tab_container.h"
Rename the TextureProgress node to TextureProgressBar Advantages: - When searching for "progressbar", you'll see both nodes in the search results. - More consistent with Button/TextureButton.
2020-12-14 20:10:09 +00:00
#include "scene/gui/texture_progress_bar.h"
PVRTC: Move compress func to `modules/pvr`, drop obsolete PVRTexTool code The code we had for PVRTexTool doesn't work as it's not compatible with current PVRTexTool CLI options, and likely hasn't been for years. Instead, we have our own vendored pvrtccompressor thirdparty library which all users have thus de-facto been using. This commit moves the compress code to `modules/pvr` where it belongs. There's no proper compress function for PVRTC 2-bit format, that's a bug that will need to be fixed (currently it's compressed as 4-bit format even if you use Image::FORMAT_PVRTC2). Fixes #28669.
2020-12-10 14:44:05 +00:00
#include "scene/main/window.h"
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
#include "scene/resources/packed_scene.h"
PVRTC: Move compress func to `modules/pvr`, drop obsolete PVRTexTool code The code we had for PVRTexTool doesn't work as it's not compatible with current PVRTexTool CLI options, and likely hasn't been for years. Instead, we have our own vendored pvrtccompressor thirdparty library which all users have thus de-facto been using. This commit moves the compress code to `modules/pvr` where it belongs. There's no proper compress function for PVRTC 2-bit format, that's a bug that will need to be fixed (currently it's compressed as 4-bit format even if you use Image::FORMAT_PVRTC2). Fixes #28669.
2020-12-10 14:44:05 +00:00
#include "servers/display_server.h"
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
#include "servers/navigation_server_2d.h"
#include "servers/navigation_server_3d.h"
#include "servers/physics_server_2d.h"
Ability to create local RenderingDevice instances.
2020-04-18 23:30:57 +00:00
#include "servers/rendering/rendering_device.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
Editor: Cleanup some includes dependencies Removes some unnecessary includes from `editor_node.h`, and instead add those where they're used. Removes unnecessary `editor_node.h` includes in various editor classes. Renames `dynamicfont` to `dynamic_font` in a couple files. Misc cleanup while jumping through that rabbit hole.
2022-02-14 13:00:03 +00:00
#include "editor/animation_track_editor.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/audio_stream_preview.h"
Implemented initial DAP support Implemented "output" event Refactored "seq" field generation Prevent debugging when editor and client are in different projects Removed unneeded references to peer on the parser Refactored way to detect project path Implemented "setBreakpoints" request Fix double events when terminating from client Refactored "stopped" event Implemented "stopped" with breakpoint event Implemented "stackTrace", "scopes" and "variables" request Report incoming number of stack dump variables Implemented proper reporting of scopes and variables from stack frames Prevent editor from grabbing focus when a DAP session is active Implemented "next" and "stepIn" requests Implemented "Source" checksum computing Switched expected errors from macros to silent guards Refactored message_id Respect client settings regarding lines/columns behavior Refactored nested DAP fields Implement reporting of "Members" and "Globals" scopes as well Fix error messages not being shown, and improved wrong path message
2021-06-04 18:39:38 +00:00
#include "editor/debugger/debug_adapter/debug_adapter_server.h"
Move Debug menu logic to DebuggerEditorPlugin
2020-03-08 17:58:31 +00:00
#include "editor/debugger/editor_debugger_node.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/dependency_editor.h"
#include "editor/editor_about.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/editor_audio_buses.h"
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
#include "editor/editor_command_palette.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 01:46:22 +00:00
#include "editor/editor_data.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/editor_export.h"
#include "editor/editor_feature_profile.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 01:46:22 +00:00
#include "editor/editor_file_dialog.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/editor_file_system.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 01:46:22 +00:00
#include "editor/editor_folding.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/editor_help.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/editor_inspector.h"
#include "editor/editor_layouts_dialog.h"
#include "editor/editor_log.h"
Implement shader caching * Shader compilation is now cached. Subsequent loads take less than a millisecond. * Improved game, editor and project manager startup time. * Editor uses .godot/shader_cache to store shaders. * Game uses user://shader_cache * Project manager uses $config_dir/shader_cache * Options to tweak shader caching in project settings. * Editor path configuration moved from EditorSettings to new class, EditorPaths, so it can be available early on (before shaders are compiled). * Reworked ShaderCompilerRD to ensure deterministic shader code creation (else shader may change and cache will be invalidated). * Added shader compression with SMOLV: https://github.com/aras-p/smol-v
2021-05-25 00:25:11 +00:00
#include "editor/editor_paths.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/editor_plugin.h"
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 20:12:35 +00:00
#include "editor/editor_properties.h"
i18n: Make property paths and categories translatable
2022-03-03 10:25:11 +00:00
#include "editor/editor_property_name_processor.h"
Add EditorResourcePicker control based on the Inspector editor for Resources Fix formatting for the docs
2021-05-17 12:25:38 +00:00
#include "editor/editor_resource_picker.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/editor_resource_preview.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 01:46:22 +00:00
#include "editor/editor_run.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/editor_run_native.h"
#include "editor/editor_run_script.h"
#include "editor/editor_scale.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/editor_settings.h"
Minor fixes/refactoring of project and editor setting dialogs
2022-01-31 23:19:01 +00:00
#include "editor/editor_settings_dialog.h"
expose EditorSpinSlider to GDScript
2019-10-20 15:43:14 +00:00
#include "editor/editor_spin_slider.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/editor_themes.h"
Implement toast notifications in the editor
2021-09-22 15:36:40 +00:00
#include "editor/editor_toaster.h"
Add translation parser plugin support
2020-06-23 11:48:59 +00:00
#include "editor/editor_translation_parser.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/export_template_manager.h"
#include "editor/filesystem_dock.h"
Editor: Cleanup some includes dependencies Removes some unnecessary includes from `editor_node.h`, and instead add those where they're used. Removes unnecessary `editor_node.h` includes in various editor classes. Renames `dynamicfont` to `dynamic_font` in a couple files. Misc cleanup while jumping through that rabbit hole.
2022-02-14 13:00:03 +00:00
#include "editor/import/dynamic_font_import_settings.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/import/editor_import_collada.h"
Removed PBM bitmap loader, added abiliy to importi mages as bitmap. Fixes #14828
2018-01-06 19:36:49 +00:00
#include "editor/import/resource_importer_bitmask.h"
Makes FontData importable resource. Adds multi-channel SDF font texture generation and rendering support. Adds per-font oversampling support. Adds FontData import plugins (for dynamic fonts, BMFonts and monospaced image fonts), font texture cache pre-generation and loading. Adds BMFont binary format and outline support.
2020-12-27 13:30:33 +00:00
#include "editor/import/resource_importer_bmfont.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/import/resource_importer_csv_translation.h"
Editor: Cleanup some includes dependencies Removes some unnecessary includes from `editor_node.h`, and instead add those where they're used. Removes unnecessary `editor_node.h` includes in various editor classes. Renames `dynamicfont` to `dynamic_font` in a couple files. Misc cleanup while jumping through that rabbit hole.
2022-02-14 13:00:03 +00:00
#include "editor/import/resource_importer_dynamic_font.h"
It is now possible to import images as a separate resource, closes #5738 and likely many others
2018-07-29 19:45:23 +00:00
#include "editor/import/resource_importer_image.h"
Makes FontData importable resource. Adds multi-channel SDF font texture generation and rendering support. Adds per-font oversampling support. Adds FontData import plugins (for dynamic fonts, BMFonts and monospaced image fonts), font texture cache pre-generation and loading. Adds BMFont binary format and outline support.
2020-12-27 13:30:33 +00:00
#include "editor/import/resource_importer_imagefont.h"
Added proper import support for 3D and Array textures
2018-08-06 17:56:06 +00:00
#include "editor/import/resource_importer_layered_texture.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/import/resource_importer_obj.h"
#include "editor/import/resource_importer_scene.h"
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 02:19:21 +00:00
#include "editor/import/resource_importer_shader_file.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/import/resource_importer_texture.h"
Added ability for multiple images to be imported as an atlas This adds support for groups in the import system, which point to a single file. Add property hint for saving files in file field
2019-04-19 18:54:33 +00:00
#include "editor/import/resource_importer_texture_atlas.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/import/resource_importer_wav.h"
Improved 3D Scene Importer * Added option for importers to show an Advanced settings dialog * Created advanced settings dialog for Scene Importer * Cleaned up importers (remove many old/unused options) * Added the ability to customize every node, material, mesh and animation individually * Saving to animations and meshes to files is now a manual process, making it more predictable * Added the ability for materials to be replaced by external files (or to be made external, up to you). * When doubleclicking an impoted scene in the filesystem dock, it automatically shows the import settings instead of asking to open it. WARNING: Lightmap UV unwrap is not working, it needs to be re-made.
2021-03-19 12:57:52 +00:00
#include "editor/import/scene_import_settings.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/import_dock.h"
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 08:37:51 +00:00
#include "editor/multi_node_edit.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/node_dock.h"
#include "editor/plugin_config_dialog.h"
added BlendSpace1D editor plugin This commit also fixes a crash in the BlendSpace2D as well as correct the drawing of the x-zero indicator in the BlendSpace2D editor plugin.
2018-06-22 19:52:13 +00:00
#include "editor/plugins/animation_blend_space_1d_editor.h"
#include "editor/plugins/animation_blend_space_2d_editor.h"
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
#include "editor/plugins/animation_blend_tree_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/animation_player_editor_plugin.h"
State machine animation node
2018-06-25 19:21:57 +00:00
#include "editor/plugins/animation_state_machine_editor.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/animation_tree_editor_plugin.h"
#include "editor/plugins/asset_library_editor_plugin.h"
Add audio stream preview to Inspector dock
2018-07-16 07:30:27 +00:00
#include "editor/plugins/audio_stream_editor_plugin.h"
Add AudioStreamRandomizer, replacing AudioStreamRandomPitch Add additional randomization options.
2021-09-12 06:57:09 +00:00
#include "editor/plugins/audio_stream_randomizer_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 07:44:44 +00:00
#include "editor/plugins/camera_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/canvas_item_editor_plugin.h"
#include "editor/plugins/collision_polygon_2d_editor_plugin.h"
#include "editor/plugins/collision_shape_2d_editor_plugin.h"
Reorganize inspector layout workflow for Control nodes
2021-11-08 20:53:41 +00:00
#include "editor/plugins/control_editor_plugin.h"
Add Emission Mask to CPUParticle2D Add ability to load emission masks to CPUParticle2D.
2019-03-19 16:28:57 +00:00
#include "editor/plugins/cpu_particles_2d_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 07:44:44 +00:00
#include "editor/plugins/cpu_particles_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/curve_editor_plugin.h"
Huge Debugger/EditorDebugger refactor.
2020-02-07 01:52:05 +00:00
#include "editor/plugins/debugger_editor_plugin.h"
Added debugger plugin support Changes: * EngineDebugger is exposed to gdscript. Game side of communication can be implemented through it. * EditorDebuggerPlugin is added which handles the editor side of communication.
2020-05-18 14:55:49 +00:00
#include "editor/plugins/editor_debugger_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/editor_preview_plugins.h"
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
#include "editor/plugins/font_editor_plugin.h"
Implement GDExtension export plugin.
2022-03-10 07:48:25 +00:00
#include "editor/plugins/gdextension_export_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 07:44:44 +00:00
#include "editor/plugins/gpu_particles_2d_editor_plugin.h"
#include "editor/plugins/gpu_particles_3d_editor_plugin.h"
Implement GPU Particle Collisions -Sphere Attractor -Box Attractor -Vector Field -Sphere Collider -Box Collider -Baked SDF Collider -Heightmap Collider
2020-10-08 00:29:49 +00:00
#include "editor/plugins/gpu_particles_collision_sdf_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/gradient_editor_plugin.h"
Add GradientTexture2D editor plugin
2022-02-22 04:35:20 +00:00
#include "editor/plugins/gradient_texture_2d_editor_plugin.h"
Added EditorInspectorPlugin to aid in editing InputEvents in resources and shortcuts
2021-06-27 14:15:56 +00:00
#include "editor/plugins/input_event_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/light_occluder_2d_editor_plugin.h"
Rename GI Classes * GIProbe is now VoxelGI * BakedLightmap is now LightmapGI As godot adds more ways to provide GI (as an example, SDFGI in 4.0), the different techniques (which have different pros/cons) need to be properly named to avoid confusion.
2021-06-04 22:47:26 +00:00
#include "editor/plugins/lightmap_gi_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/line_2d_editor_plugin.h"
#include "editor/plugins/material_editor_plugin.h"
#include "editor/plugins/mesh_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 07:44:44 +00:00
#include "editor/plugins/mesh_instance_3d_editor_plugin.h"
Fix MeshLibrary editor
2018-08-21 22:06:52 +00:00
#include "editor/plugins/mesh_library_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/multimesh_editor_plugin.h"
#include "editor/plugins/navigation_polygon_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 07:44:44 +00:00
#include "editor/plugins/node_3d_editor_plugin.h"
Implement occlusion culling Added an occlusion culling system with support for static occluder meshes. It can be enabled via `Project Settings > Rendering > Occlusion Culling > Use Occlusion Culling`. Occluders are defined via the new `Occluder3D` resource and instanced using the new `OccluderInstance3D` node. The occluders can also be automatically baked from a scene using the built-in editor plugin.
2021-04-20 16:40:24 +00:00
#include "editor/plugins/occluder_instance_3d_editor_plugin.h"
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
#include "editor/plugins/ot_features_plugin.h"
Add translation parser plugin support
2020-06-23 11:48:59 +00:00
#include "editor/plugins/packed_scene_translation_parser_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/path_2d_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 07:44:44 +00:00
#include "editor/plugins/path_3d_editor_plugin.h"
#include "editor/plugins/physical_bone_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/polygon_2d_editor_plugin.h"
Improvements and fixes to occluders Improvements: * Occluder3D is now an abstract type inherited by: ArrayOccluder3D, QuadOccluder3D, BoxOccluder3D, SphereOccluder3D and PolygonOccluder3D. ArrayOccluder3D serves the same purpose as the old Occluder3D (triangle mesh occluder) while the rest are primitives that can be used to manually place simple occluders. * Occluder baking can now apply simplification. The "bake_simplification_distance" property can be used to set a world-space distance as the desired maximum error, set to 0.1 by default. * Occluders can now be generated on import. Using the "occ" and "occonly" keywords (similar to "col" and "colonly" for colliders) or by enabling on MeshInstance3Ds in the scene's import window. Fixes: * Fixed saving of occluder files after bake. * Fixed a small error where occluders didn't correctly update in the rendering server. Bonus content: * Generalized "CollisionPolygon3DEditor" so it can also be used to edit Resources. Renamed it to "Polygon3DEditor" since it was already being used by other things, not just colliders. * Fixed a small bug in "EditorPropertyArray" where a call to "remove" was left after the "remove_at" rename.
2022-02-04 15:28:18 +00:00
#include "editor/plugins/polygon_3d_editor_plugin.h"
[Editor] Replication plugin to configure MultiplayerSynchronizers. Allows configuring the MultiplayerSynchornizer in a way similar to AnimationPlayer. Properties are added manually, edither as plain properties, or via the NodePath format for child nodes' properties "path/to/node:property" relative to the MultiplayerSynchronizer root path. Nice things to add would be: - Moving properties up/down in the list. - Some form of keying, autmatic filling of the replication properity line edit.
2021-12-01 07:24:46 +00:00
#include "editor/plugins/replication_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/resource_preloader_editor_plugin.h"
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-26 22:05:11 +00:00
#include "editor/plugins/root_motion_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/script_editor_plugin.h"
#include "editor/plugins/script_text_editor.h"
#include "editor/plugins/shader_editor_plugin.h"
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 02:19:21 +00:00
#include "editor/plugins/shader_file_editor_plugin.h"
2D Skeletons WORK IN PROGRESS
2018-02-21 20:23:27 +00:00
#include "editor/plugins/skeleton_2d_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 07:44:44 +00:00
#include "editor/plugins/skeleton_3d_editor_plugin.h"
#include "editor/plugins/skeleton_ik_3d_editor_plugin.h"
#include "editor/plugins/sprite_2d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/sprite_frames_editor_plugin.h"
#include "editor/plugins/style_box_editor_plugin.h"
Add viewport preview plugin Also includes a minor refactor of TextureEditorPlugin.
2021-03-21 21:33:17 +00:00
#include "editor/plugins/sub_viewport_preview_editor_plugin.h"
Add functions for getting name and font style from dynamic and bitmap fonts. Add font selection toolbar editor plugin.
2021-10-26 06:40:11 +00:00
#include "editor/plugins/text_control_editor_plugin.h"
Allow opening and editing of any utf_8 file in script editor
2018-05-28 15:52:28 +00:00
#include "editor/plugins/text_editor.h"
Implement 3D textures as import and resource format.
2020-09-09 15:40:51 +00:00
#include "editor/plugins/texture_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/texture_editor_plugin.h"
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 12:34:23 +00:00
#include "editor/plugins/texture_layered_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/plugins/texture_region_editor_plugin.h"
#include "editor/plugins/theme_editor_plugin.h"
Rework the TileSet resource and TileMap nodes: - Move most properties from TileMap to TileSet, - Make TileSet more flexible, supporting more feature (several collision layers, etc...), - Fusion both the TileMap and TileSet editor, - Implement TileSetSources, and thus a new way to index tiles in the TileSet, - Rework the TileSet and TileMap editors completely, - Implement an editor zoom widget (and use it in several places)
2021-05-07 13:41:39 +00:00
#include "editor/plugins/tiles/tiles_editor_plugin.h"
Add VCS editor plugin UI elements to editor
2019-09-03 14:42:08 +00:00
#include "editor/plugins/version_control_editor_plugin.h"
Visual Shaders are back.
2018-07-14 21:15:42 +00:00
#include "editor/plugins/visual_shader_editor_plugin.h"
Rename GI Classes * GIProbe is now VoxelGI * BakedLightmap is now LightmapGI As godot adds more ways to provide GI (as an example, SDFGI in 4.0), the different techniques (which have different pros/cons) need to be properly named to avoid confusion.
2021-06-04 22:47:26 +00:00
#include "editor/plugins/voxel_gi_editor_plugin.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/progress_dialog.h"
#include "editor/project_export.h"
#include "editor/project_settings_editor.h"
#include "editor/quick_open.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
#include "editor/register_exporters.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 01:46:22 +00:00
#include "editor/scene_tree_dock.h"
PVRTC: Move compress func to `modules/pvr`, drop obsolete PVRTexTool code The code we had for PVRTexTool doesn't work as it's not compatible with current PVRTexTool CLI options, and likely hasn't been for years. Instead, we have our own vendored pvrtccompressor thirdparty library which all users have thus de-facto been using. This commit moves the compress code to `modules/pvr` where it belongs. There's no proper compress function for PVRTC 2-bit format, that's a bug that will need to be fixed (currently it's compressed as 4-bit format even if you use Image::FORMAT_PVRTC2). Fixes #28669.
2020-12-10 14:44:05 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
#include <stdio.h>
Exit the editor export process with a non-zero exit code on error This closes #34672.
2019-12-29 15:11:58 +00:00
#include <stdlib.h>
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 04:21:06 +00:00
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
EditorNode *EditorNode::singleton = nullptr;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 00:20:54 +00:00
// The metadata key used to store and retrieve the version text to copy to the clipboard.
static const String META_TEXT_TO_COPY = "text_to_copy";
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 04:49:05 +00:00
void EditorNode::disambiguate_filenames(const Vector<String> p_full_paths, Vector<String> &r_filenames) {
// Keep track of a list of "index sets," i.e. sets of indices
// within disambiguated_scene_names which contain the same name.
Vector<Set<int>> index_sets;
Map<String, int> scene_name_to_set_index;
for (int i = 0; i < r_filenames.size(); i++) {
String scene_name = r_filenames[i];
if (!scene_name_to_set_index.has(scene_name)) {
index_sets.append(Set<int>());
scene_name_to_set_index.insert(r_filenames[i], index_sets.size() - 1);
}
index_sets.write[scene_name_to_set_index[scene_name]].insert(i);
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// For each index set with a size > 1, we need to disambiguate.
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 04:49:05 +00:00
for (int i = 0; i < index_sets.size(); i++) {
Set<int> iset = index_sets[i];
while (iset.size() > 1) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Append the parent folder to each scene name.
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 04:49:05 +00:00
for (Set<int>::Element *E = iset.front(); E; E = E->next()) {
int set_idx = E->get();
String scene_name = r_filenames[set_idx];
String full_path = p_full_paths[set_idx];
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Get rid of file extensions and res:// prefixes.
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 04:49:05 +00:00
if (scene_name.rfind(".") >= 0) {
scene_name = scene_name.substr(0, scene_name.rfind("."));
}
if (full_path.begins_with("res://")) {
full_path = full_path.substr(6);
}
if (full_path.rfind(".") >= 0) {
full_path = full_path.substr(0, full_path.rfind("."));
}
int scene_name_size = scene_name.size();
int full_path_size = full_path.size();
int difference = full_path_size - scene_name_size;
// Find just the parent folder of the current path and append it.
// If the current name is foo.tscn, and the full path is /some/folder/foo.tscn
// then slash_idx is the second '/', so that we select just "folder", and
// append that to yield "folder/foo.tscn".
if (difference > 0) {
String parent = full_path.substr(0, difference);
int slash_idx = parent.rfind("/");
slash_idx = parent.rfind("/", slash_idx - 1);
parent = slash_idx >= 0 ? parent.substr(slash_idx + 1) : parent;
r_filenames.write[set_idx] = parent + r_filenames[set_idx];
}
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Loop back through scene names and remove non-ambiguous names.
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 04:49:05 +00:00
bool can_proceed = false;
Set<int>::Element *E = iset.front();
while (E) {
String scene_name = r_filenames[E->get()];
bool duplicate_found = false;
for (Set<int>::Element *F = iset.front(); F; F = F->next()) {
if (E->get() == F->get()) {
continue;
}
String other_scene_name = r_filenames[F->get()];
if (other_scene_name == scene_name) {
duplicate_found = true;
break;
}
}
Set<int>::Element *to_erase = duplicate_found ? nullptr : E;
// We need to check that we could actually append anymore names
// if we wanted to for disambiguation. If we can't, then we have
// to abort even with ambiguous names. We clean the full path
// and the scene name first to remove extensions so that this
// comparison actually works.
String path = p_full_paths[E->get()];
if (path.begins_with("res://")) {
path = path.substr(6);
}
if (path.rfind(".") >= 0) {
path = path.substr(0, path.rfind("."));
}
if (scene_name.rfind(".") >= 0) {
scene_name = scene_name.substr(0, scene_name.rfind("."));
}
// We can proceed iff the full path is longer than the scene name,
// meaning that there is at least one more parent folder we can
// tack onto the name.
can_proceed = can_proceed || (path.size() - scene_name.size()) >= 1;
E = E->next();
if (to_erase) {
iset.erase(to_erase);
}
}
if (!can_proceed) {
break;
}
}
}
}
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
// TODO: This REALLY should be done in a better way than replacing all tabs after almost EVERY action.
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
void EditorNode::_update_scene_tabs() {
EditorSettings: Move scene tab options to their dedicated category Fixes #14870.
2017-12-20 18:41:02 +00:00
bool show_rb = EditorSettings::get_singleton()->get("interface/scene_tabs/show_script_button");
-fixed tabs
2015-11-18 07:47:41 +00:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_GLOBAL_MENU)) {
DisplayServer::get_singleton()->global_menu_clear("_dock");
}
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 13:57:06 +00:00
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
// Get all scene names, which may be ambiguous.
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 04:49:05 +00:00
Vector<String> disambiguated_scene_names;
Vector<String> full_path_names;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
disambiguated_scene_names.append(editor_data.get_scene_title(i));
full_path_names.append(editor_data.get_scene_path(i));
}
disambiguate_filenames(full_path_names, disambiguated_scene_names);
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
// Workaround to ignore the tab_changed signal from the first added tab.
scene_tabs->disconnect("tab_changed", callable_mp(this, &EditorNode::_scene_tab_changed));
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
scene_tabs->clear_tabs();
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
Ref<Texture2D> script_icon = gui_base->get_theme_icon(SNAME("Script"), SNAME("EditorIcons"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Show in tabs non default class icons
2019-03-11 21:54:23 +00:00
Node *type_node = editor_data.get_edited_scene_root(i);
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
Ref<Texture2D> icon;
Show in tabs non default class icons
2019-03-11 21:54:23 +00:00
if (type_node) {
icon = EditorNode::get_singleton()->get_object_icon(type_node, "Node");
-added icons for root node types on tabs
2015-07-24 17:18:02 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
int current = editor_data.get_edited_scene();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool unsaved = (i == current) ? saved_version != editor_data.get_undo_redo().get_version() : editor_data.get_scene_version(i) != 0;
implement generic filename disambiguation A static function is added to EditorNode which allows for filename disambiguation given a list of filenames and the corresponding list of absolute paths for those files. This function is then used to disambiguate scene and script tabs in the editor.
2020-05-27 04:49:05 +00:00
scene_tabs->add_tab(disambiguated_scene_names[i] + (unsaved ? "(*)" : ""), icon);
-added icons for root node types on tabs
2015-07-24 17:18:02 +00:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_GLOBAL_MENU)) {
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 16:02:54 +00:00
DisplayServer::get_singleton()->global_menu_add_item("_dock", editor_data.get_scene_title(i) + (unsaved ? "(*)" : ""), callable_mp(this, &EditorNode::_global_menu_scene), i);
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
}
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 13:57:06 +00:00
-fixed tabs
2015-11-18 07:47:41 +00:00
if (show_rb && editor_data.get_scene_root_script(i).is_valid()) {
Bring `TabBar` to full parity with the `TabContainer` implementation.
2022-01-19 16:11:44 +00:00
scene_tabs->set_tab_button_icon(i, script_icon);
QOL, script buttons in scene tabs
2015-07-26 13:44:10 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_GLOBAL_MENU)) {
DisplayServer::get_singleton()->global_menu_add_separator("_dock");
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 16:02:54 +00:00
DisplayServer::get_singleton()->global_menu_add_item("_dock", TTR("New Window"), callable_mp(this, &EditorNode::_global_menu_new_window));
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
}
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 13:57:06 +00:00
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
if (scene_tabs->get_tab_count() > 0) {
scene_tabs->set_current_tab(editor_data.get_edited_scene());
}
add scene button and tab scrolling
2017-11-16 22:57:57 +00:00
if (scene_tabs->get_offset_buttons_visible()) {
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
// Move the add button to a fixed position.
add scene button and tab scrolling
2017-11-16 22:57:57 +00:00
if (scene_tab_add->get_parent() == scene_tabs) {
scene_tabs->remove_child(scene_tab_add);
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
scene_tab_add_ph->add_child(scene_tab_add);
scene_tab_add->set_position(Point2());
add scene button and tab scrolling
2017-11-16 22:57:57 +00:00
}
} else {
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
// Move the add button to be after the last tab.
if (scene_tab_add->get_parent() == scene_tab_add_ph) {
scene_tab_add_ph->remove_child(scene_tab_add);
add scene button and tab scrolling
2017-11-16 22:57:57 +00:00
scene_tabs->add_child(scene_tab_add);
}
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
if (scene_tabs->get_tab_count() == 0) {
scene_tab_add->set_position(Point2());
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
Rect2 last_tab = scene_tabs->get_tab_rect(scene_tabs->get_tab_count() - 1);
int hsep = scene_tabs->get_theme_constant(SNAME("hseparation"));
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
if (scene_tabs->is_layout_rtl()) {
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
scene_tab_add->set_position(Point2(last_tab.position.x - scene_tab_add->get_size().x - hsep, last_tab.position.y));
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
} else {
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
scene_tab_add->set_position(Point2(last_tab.position.x + last_tab.size.width + hsep, last_tab.position.y));
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
}
add scene button and tab scrolling
2017-11-16 22:57:57 +00:00
}
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
// Reconnect after everything is done.
scene_tabs->connect("tab_changed", callable_mp(this, &EditorNode::_scene_tab_changed));
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
Add VCS editor plugin UI elements to editor
2019-09-03 14:42:08 +00:00
void EditorNode::_version_control_menu_option(int p_idx) {
switch (vcs_actions_menu->get_item_id(p_idx)) {
Allow creating .gitignore and .gitattributes when creating a new project Also allow creating these files later, and also allow disabling creating the default environment in editor settings.
2020-09-29 19:01:26 +00:00
case RUN_VCS_METADATA: {
VersionControlEditorPlugin::get_singleton()->popup_vcs_metadata_dialog();
} break;
Add VCS editor plugin UI elements to editor
2019-09-03 14:42:08 +00:00
case RUN_VCS_SETTINGS: {
VersionControlEditorPlugin::get_singleton()->popup_vcs_set_up_dialog(gui_base);
} break;
case RUN_VCS_SHUT_DOWN: {
VersionControlEditorPlugin::get_singleton()->shut_down();
} break;
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void EditorNode::_update_title() {
Improve the editor window title for better usability - Display the scene name, then the project name, then "Godot Engine". - Display the "modified" mark before anytihng else. Both of these changes ensure important, project-specific elements can always be seen in the task bar which may truncate strings due to its low per-item width. - Use "Unnamed Project" if the project has no name (similar to the Project Manager).
2021-04-06 17:28:23 +00:00
const String appname = ProjectSettings::get_singleton()->get("application/config/name");
String title = (appname.is_empty() ? "Unnamed Project" : appname) + String(" - ") + VERSION_NAME;
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
const String edited = editor_data.get_edited_scene_root() ? editor_data.get_edited_scene_root()->get_scene_file_path() : String();
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (!edited.is_empty()) {
Improve the editor window title for better usability - Display the scene name, then the project name, then "Godot Engine". - Display the "modified" mark before anytihng else. Both of these changes ensure important, project-specific elements can always be seen in the task bar which may truncate strings due to its low per-item width. - Use "Unnamed Project" if the project has no name (similar to the Project Manager).
2021-04-06 17:28:23 +00:00
// Display the edited scene name before the program name so that it can be seen in the OS task bar.
title = vformat("%s - %s", edited.get_file(), title);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (unsaved_cache) {
Improve the editor window title for better usability - Display the scene name, then the project name, then "Godot Engine". - Display the "modified" mark before anytihng else. Both of these changes ensure important, project-specific elements can always be seen in the task bar which may truncate strings due to its low per-item width. - Use "Unnamed Project" if the project has no name (similar to the Project Manager).
2021-04-06 17:28:23 +00:00
// Display the "modified" mark before anything else so that it can always be seen in the OS task bar.
title = vformat("(*) %s", title);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
DisplayServer::get_singleton()->window_set_title(title);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
void EditorNode::unhandled_input(const Ref<InputEvent> &p_event) {
Fix crashes in *_input functions
2021-04-05 06:52:21 +00:00
ERR_FAIL_COND(p_event.is_null());
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Ref<InputEventKey> k = p_event;
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
if ((k.is_valid() && k->is_pressed() && !k->is_echo()) || Object::cast_to<InputEventShortcut>(*p_event)) {
Fix pressing `F3` do both changing to script editor AND find next text As `KEY_F3` was used both for changing to script editor window and, in the script editor, for finding the next result in the last search, and the key event is **not** consumed, the resulting behaviour was similar to press `F3` twice, first to change to script editor and second to find the next result of a previous search. This PR sets the `key_pressed` status of `InputEvent` to `false` if this event is responsible of an editor change, simulating the consumption of the event. Fix #17334
2018-03-13 20:20:59 +00:00
EditorPlugin *old_editor = editor_plugin_screen;
Configurable shortcuts for tabs switching
2016-06-25 04:42:09 +00:00
if (ED_IS_SHORTCUT("editor/next_tab", p_event)) {
int next_tab = editor_data.get_edited_scene() + 1;
next_tab %= editor_data.get_edited_scene_count();
_scene_tab_changed(next_tab);
}
if (ED_IS_SHORTCUT("editor/prev_tab", p_event)) {
int next_tab = editor_data.get_edited_scene() - 1;
next_tab = next_tab >= 0 ? next_tab : editor_data.get_edited_scene_count() - 1;
_scene_tab_changed(next_tab);
}
Remove Quick Filter Files and fix FS search hotkey The new Quick Filter Files behaviour since 8b47e26 had not been implemented, so this implements it and makes it an editor hotkey instead of a menu entry. Fixes #7582.
2017-01-21 12:07:29 +00:00
if (ED_IS_SHORTCUT("editor/filter_files", p_event)) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
FileSystemDock::get_singleton()->focus_on_filter();
Remove Quick Filter Files and fix FS search hotkey The new Quick Filter Files behaviour since 8b47e26 had not been implemented, so this implements it and makes it an editor hotkey instead of a menu entry. Fixes #7582.
2017-01-21 12:07:29 +00:00
}
Added fullscreen and distraction free mode shorcuts
2016-06-15 16:25:17 +00:00
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 19:26:32 +00:00
if (ED_IS_SHORTCUT("editor/editor_2d", p_event)) {
_editor_select(EDITOR_2D);
} else if (ED_IS_SHORTCUT("editor/editor_3d", p_event)) {
_editor_select(EDITOR_3D);
} else if (ED_IS_SHORTCUT("editor/editor_script", p_event)) {
_editor_select(EDITOR_SCRIPT);
} else if (ED_IS_SHORTCUT("editor/editor_help", p_event)) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("request_help_search"), "");
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 13:28:34 +00:00
} else if (ED_IS_SHORTCUT("editor/editor_assetlib", p_event) && StreamPeerSSL::is_available()) {
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 19:26:32 +00:00
_editor_select(EDITOR_ASSETLIB);
} else if (ED_IS_SHORTCUT("editor/editor_next", p_event)) {
_editor_select_next();
} else if (ED_IS_SHORTCUT("editor/editor_prev", p_event)) {
_editor_select_prev();
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
} else if (ED_IS_SHORTCUT("editor/command_palette", p_event)) {
_open_command_palette();
} else {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Make KEY_ESCAPE close all output/debugger docks on bottom
2018-01-19 08:04:55 +00:00
Fix pressing `F3` do both changing to script editor AND find next text As `KEY_F3` was used both for changing to script editor window and, in the script editor, for finding the next result in the last search, and the key event is **not** consumed, the resulting behaviour was similar to press `F3` twice, first to change to script editor and second to find the next result of a previous search. This PR sets the `key_pressed` status of `InputEvent` to `false` if this event is responsible of an editor change, simulating the consumption of the event. Fix #17334
2018-03-13 20:20:59 +00:00
if (old_editor != editor_plugin_screen) {
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
get_tree()->get_root()->set_input_as_handled();
Fix pressing `F3` do both changing to script editor AND find next text As `KEY_F3` was used both for changing to script editor window and, in the script editor, for finding the next result in the last search, and the key event is **not** consumed, the resulting behaviour was similar to press `F3` twice, first to change to script editor and second to find the next result of a previous search. This PR sets the `key_pressed` status of `InputEvent` to `false` if this event is responsible of an editor change, simulating the consumption of the event. Fix #17334
2018-03-13 20:20:59 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
void EditorNode::_update_from_settings() {
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
int current_filter = GLOBAL_GET("rendering/textures/canvas_textures/default_texture_filter");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
if (current_filter != scene_root->get_default_canvas_item_texture_filter()) {
Viewport::DefaultCanvasItemTextureFilter tf = (Viewport::DefaultCanvasItemTextureFilter)current_filter;
scene_root->set_default_canvas_item_texture_filter(tf);
}
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
int current_repeat = GLOBAL_GET("rendering/textures/canvas_textures/default_texture_repeat");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
if (current_repeat != scene_root->get_default_canvas_item_texture_repeat()) {
Viewport::DefaultCanvasItemTextureRepeat tr = (Viewport::DefaultCanvasItemTextureRepeat)current_repeat;
scene_root->set_default_canvas_item_texture_repeat(tr);
}
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::DOFBokehShape dof_shape = RS::DOFBokehShape(int(GLOBAL_GET("rendering/camera/depth_of_field/depth_of_field_bokeh_shape")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->camera_effects_set_dof_blur_bokeh_shape(dof_shape);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::DOFBlurQuality dof_quality = RS::DOFBlurQuality(int(GLOBAL_GET("rendering/camera/depth_of_field/depth_of_field_bokeh_quality")));
bool dof_jitter = GLOBAL_GET("rendering/camera/depth_of_field/depth_of_field_use_jitter");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->camera_effects_set_dof_blur_quality(dof_quality, dof_jitter);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::get_singleton()->environment_set_ssao_quality(RS::EnvironmentSSAOQuality(int(GLOBAL_GET("rendering/environment/ssao/quality"))), GLOBAL_GET("rendering/environment/ssao/half_size"), GLOBAL_GET("rendering/environment/ssao/adaptive_target"), GLOBAL_GET("rendering/environment/ssao/blur_passes"), GLOBAL_GET("rendering/environment/ssao/fadeout_from"), GLOBAL_GET("rendering/environment/ssao/fadeout_to"));
RS::get_singleton()->screen_space_roughness_limiter_set_active(GLOBAL_GET("rendering/anti_aliasing/screen_space_roughness_limiter/enabled"), GLOBAL_GET("rendering/anti_aliasing/screen_space_roughness_limiter/amount"), GLOBAL_GET("rendering/anti_aliasing/screen_space_roughness_limiter/limit"));
bool glow_bicubic = int(GLOBAL_GET("rendering/environment/glow/upscale_mode")) > 0;
Added SSIL post processing effect
2021-08-03 07:07:32 +00:00
RS::get_singleton()->environment_set_ssil_quality(RS::EnvironmentSSILQuality(int(GLOBAL_GET("rendering/environment/ssil/quality"))), GLOBAL_GET("rendering/environment/ssil/half_size"), GLOBAL_GET("rendering/environment/ssil/adaptive_target"), GLOBAL_GET("rendering/environment/ssil/blur_passes"), GLOBAL_GET("rendering/environment/ssil/fadeout_from"), GLOBAL_GET("rendering/environment/ssil/fadeout_to"));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->environment_glow_set_use_bicubic_upscale(glow_bicubic);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
bool glow_high_quality = GLOBAL_GET("rendering/environment/glow/use_high_quality");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->environment_glow_set_use_high_quality(glow_high_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::EnvironmentSSRRoughnessQuality ssr_roughness_quality = RS::EnvironmentSSRRoughnessQuality(int(GLOBAL_GET("rendering/environment/screen_space_reflection/roughness_quality")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->environment_set_ssr_roughness_quality(ssr_roughness_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::SubSurfaceScatteringQuality sss_quality = RS::SubSurfaceScatteringQuality(int(GLOBAL_GET("rendering/environment/subsurface_scattering/subsurface_scattering_quality")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->sub_surface_scattering_set_quality(sss_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
float sss_scale = GLOBAL_GET("rendering/environment/subsurface_scattering/subsurface_scattering_scale");
float sss_depth_scale = GLOBAL_GET("rendering/environment/subsurface_scattering/subsurface_scattering_depth_scale");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->sub_surface_scattering_set_scale(sss_scale, sss_depth_scale);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
uint32_t directional_shadow_size = GLOBAL_GET("rendering/shadows/directional_shadow/size");
uint32_t directional_shadow_16_bits = GLOBAL_GET("rendering/shadows/directional_shadow/16_bits");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->directional_shadow_atlas_set_size(directional_shadow_size, directional_shadow_16_bits);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::ShadowQuality shadows_quality = RS::ShadowQuality(int(GLOBAL_GET("rendering/shadows/shadows/soft_shadow_quality")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->shadows_quality_set(shadows_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::ShadowQuality directional_shadow_quality = RS::ShadowQuality(int(GLOBAL_GET("rendering/shadows/directional_shadow/soft_shadow_quality")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->directional_shadow_quality_set(directional_shadow_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
float probe_update_speed = GLOBAL_GET("rendering/lightmapping/probe_capture/update_speed");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->lightmap_set_probe_capture_update_speed(probe_update_speed);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::EnvironmentSDFGIFramesToConverge frames_to_converge = RS::EnvironmentSDFGIFramesToConverge(int(GLOBAL_GET("rendering/global_illumination/sdfgi/frames_to_converge")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->environment_set_sdfgi_frames_to_converge(frames_to_converge);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::EnvironmentSDFGIRayCount ray_count = RS::EnvironmentSDFGIRayCount(int(GLOBAL_GET("rendering/global_illumination/sdfgi/probe_ray_count")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->environment_set_sdfgi_ray_count(ray_count);
Rename GI Classes * GIProbe is now VoxelGI * BakedLightmap is now LightmapGI As godot adds more ways to provide GI (as an example, SDFGI in 4.0), the different techniques (which have different pros/cons) need to be properly named to avoid confusion.
2021-06-04 22:47:26 +00:00
RS::VoxelGIQuality voxel_gi_quality = RS::VoxelGIQuality(int(GLOBAL_GET("rendering/global_illumination/voxel_gi/quality")));
RS::get_singleton()->voxel_gi_set_quality(voxel_gi_quality);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
RS::get_singleton()->environment_set_volumetric_fog_volume_size(GLOBAL_GET("rendering/environment/volumetric_fog/volume_size"), GLOBAL_GET("rendering/environment/volumetric_fog/volume_depth"));
RS::get_singleton()->environment_set_volumetric_fog_filter_active(bool(GLOBAL_GET("rendering/environment/volumetric_fog/use_filter")));
RS::get_singleton()->canvas_set_shadow_texture_size(GLOBAL_GET("rendering/2d/shadow_atlas/size"));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
bool use_half_res_gi = GLOBAL_DEF("rendering/global_illumination/gi/use_half_resolution", false);
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
RS::get_singleton()->gi_set_use_half_resolution(use_half_res_gi);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
bool snap_2d_transforms = GLOBAL_GET("rendering/2d/snap/snap_2d_transforms_to_pixel");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
scene_root->set_snap_2d_transforms_to_pixel(snap_2d_transforms);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
bool snap_2d_vertices = GLOBAL_GET("rendering/2d/snap/snap_2d_vertices_to_pixel");
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
scene_root->set_snap_2d_vertices_to_pixel(snap_2d_vertices);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
Viewport::SDFOversize sdf_oversize = Viewport::SDFOversize(int(GLOBAL_GET("rendering/2d/sdf/oversize")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
scene_root->set_sdf_oversize(sdf_oversize);
Reorganize Project Settings -Advanced Settings toggle also hides advanced properties when disabled -Simplified Advanced Bar (errors were just plain redundant) -Reorganized rendering quality settings. -Reorganized miscelaneous settings for clean up.
2021-02-17 16:44:49 +00:00
Viewport::SDFScale sdf_scale = Viewport::SDFScale(int(GLOBAL_GET("rendering/2d/sdf/scale")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
scene_root->set_sdf_scale(sdf_scale);
Rename Lod Threshold to Mesh Lod Threshold This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
2021-12-28 23:10:41 +00:00
float mesh_lod_threshold = GLOBAL_GET("rendering/mesh_lod/lod_change/threshold_pixels");
scene_root->set_mesh_lod_threshold(mesh_lod_threshold);
Implement more rendering options as specialization constants * Shadow quality settings now specialization constant. * Decal and light projector filters can be set. * Changing those settings forces re-creation of the pipelines. These changes should help improve performance related to shadow mapping, and allows improving performance by sacrificing decal and light projector quality.
2021-07-19 19:41:55 +00:00
RS::get_singleton()->decals_set_filter(RS::DecalFilter(int(GLOBAL_GET("rendering/textures/decals/filter"))));
RS::get_singleton()->light_projectors_set_filter(RS::LightProjectorFilter(int(GLOBAL_GET("rendering/textures/light_projectors/filter"))));
Update SceneTree debug colors when settings changed
2022-03-28 02:49:18 +00:00
SceneTree *tree = get_tree();
tree->set_debug_collisions_color(GLOBAL_GET("debug/shapes/collision/shape_color"));
tree->set_debug_collision_contact_color(GLOBAL_GET("debug/shapes/collision/contact_color"));
tree->set_debug_navigation_color(GLOBAL_GET("debug/shapes/navigation/geometry_color"));
tree->set_debug_navigation_disabled_color(GLOBAL_GET("debug/shapes/navigation/disabled_geometry_color"));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
}
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 03:14:39 +00:00
void EditorNode::_select_default_main_screen_plugin() {
if (EDITOR_3D < main_editor_buttons.size() && main_editor_buttons[EDITOR_3D]->is_visible()) {
// If the 3D editor is enabled, use this as the default.
_editor_select(EDITOR_3D);
return;
}
// Switch to the first main screen plugin that is enabled. Usually this is
// 2D, but may be subsequent ones if 2D is disabled in the feature profile.
for (int i = 0; i < main_editor_buttons.size(); i++) {
Button *editor_button = main_editor_buttons[i];
if (editor_button->is_visible()) {
_editor_select(i);
return;
}
}
_editor_select(-1);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void EditorNode::_notification(int p_what) {
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
switch (p_what) {
case NOTIFICATION_PROCESS: {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (opening_prev && !confirmation->is_visible()) {
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
opening_prev = false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Changed Godot exit to be clean. -Added more debug information on memory cleanliness on exit (if run with -v) -Fixed several memory leaks, fixes #1731, fixes #755
2015-04-20 22:38:02 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
if (unsaved_cache != (saved_version != editor_data.get_undo_redo().get_version())) {
unsaved_cache = (saved_version != editor_data.get_undo_redo().get_version());
_update_title();
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
if (last_checked_version != editor_data.get_undo_redo().get_version()) {
_update_scene_tabs();
last_checked_version = editor_data.get_undo_redo().get_version();
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Save all 64 bits of get_ticks_msec() in more cases
2021-10-26 06:44:50 +00:00
// Update the animation frame of the update spinner.
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
uint64_t frame = Engine::get_singleton()->get_frames_drawn();
Save all 64 bits of get_ticks_msec() in more cases
2021-10-26 06:44:50 +00:00
uint64_t tick = OS::get_singleton()->get_ticks_msec();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
if (frame != update_spinner_step_frame && (tick - update_spinner_step_msec) > (1000 / 8)) {
update_spinner_step++;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (update_spinner_step >= 8) {
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
update_spinner_step = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
update_spinner_step_msec = tick;
update_spinner_step_frame = frame + 1;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Save all 64 bits of get_ticks_msec() in more cases
2021-10-26 06:44:50 +00:00
// Update the icon itself only when the spinner is visible.
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
if (EditorSettings::get_singleton()->get("interface/editor/show_update_spinner")) {
Add missing SNAME macro optimization for StringName in some functions
2021-08-20 12:48:34 +00:00
update_spinner->set_icon(gui_base->get_theme_icon("Progress" + itos(update_spinner_step + 1), SNAME("EditorIcons")));
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
editor_selection->update();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
ResourceImporterTexture::get_singleton()->update_imports();
DOF fully implemented, can be edited on the fly.
2020-01-16 00:23:21 +00:00
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
if (settings_changed) {
_update_from_settings();
settings_changed = false;
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("project_settings_changed"));
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 01:24:07 +00:00
}
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
ResourceImporterTexture::get_singleton()->update_imports();
// if using a main thread only renderer, we need to update the resource previews
EditorResourcePreview::get_singleton()->update();
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
case NOTIFICATION_ENTER_TREE: {
Engine::get_singleton()->set_editor_hint(true);
Properly adjust the visible editor rect and make limits respected, closes #8328
2017-06-12 19:18:17 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/low_processor_mode_sleep_usec")));
Organize methods in Viewport and explicitly name 3D methods with 3D
2021-08-02 17:31:51 +00:00
get_tree()->get_root()->set_as_audio_listener_3d(false);
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
get_tree()->get_root()->set_as_audio_listener_2d(false);
Refactor pixel snapping. -Rename pixel_snap to snap_2d_to_vertices -Added snap_2d_to_transforms which is more useful Fixes #41814 Solves proposal https://github.com/godotengine/godot-proposals/issues/1666 Supersedes #35606, supersedes #41535, supersedes #41534
2020-10-29 21:09:16 +00:00
get_tree()->get_root()->set_snap_2d_transforms_to_pixel(false);
get_tree()->get_root()->set_snap_2d_vertices_to_pixel(false);
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
get_tree()->set_auto_accept_quit(false);
Android port of the Godot Editor These set of changes focus primarily on getting the core logic and overall Godot Editor UI and functionality up and running natively on Android devices. UI tweaks / cleanup / polish, as well configuration for Android specific functionality / restrictions will be addressed in follow-up PRs iteratively based on feedback. Co-authored-by: thebestnom <shoval.arad@gmail.com>
2021-06-25 13:45:16 +00:00
#ifdef ANDROID_ENABLED
get_tree()->set_quit_on_go_back(false);
#endif
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
get_tree()->get_root()->connect("files_dropped", callable_mp(this, &EditorNode::_dropped_files));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
command_palette->register_shortcuts_as_command();
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
/* DO NOT LOAD SCENES HERE, WAIT FOR FILE SCANNING AND REIMPORT TO COMPLETE */
} break;
Adds editor_hint to Engine class
2017-08-13 14:21:45 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
case NOTIFICATION_EXIT_TREE: {
editor_data.save_editor_external_data();
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
FileAccess::set_file_close_fail_notify_callback(nullptr);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
log->deinit(); // Do not get messages anymore.
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
editor_data.clear_edited_scenes();
} break;
Make sure restoring opened scenes happens after scanning is done.
2019-02-27 14:00:11 +00:00
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
case Control::NOTIFICATION_THEME_CHANGED: {
scene_tab_add_ph->set_custom_minimum_size(scene_tab_add->get_minimum_size());
} break;
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
case NOTIFICATION_READY: {
Revert "Load assets before enabling editor plugins" This reverts commit 1963c63b918cdab81f10d3ab48bbb225c95b9246. Fixes #52968, fixes #52995.
2021-11-15 15:08:19 +00:00
{
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
_initializing_plugins = true;
Revert "Load assets before enabling editor plugins" This reverts commit 1963c63b918cdab81f10d3ab48bbb225c95b9246. Fixes #52968, fixes #52995.
2021-11-15 15:08:19 +00:00
Vector<String> addons;
if (ProjectSettings::get_singleton()->has_setting("editor_plugins/enabled")) {
addons = ProjectSettings::get_singleton()->get("editor_plugins/enabled");
}
for (int i = 0; i < addons.size(); i++) {
set_addon_plugin_enabled(addons[i], true);
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
_initializing_plugins = false;
Revert "Load assets before enabling editor plugins" This reverts commit 1963c63b918cdab81f10d3ab48bbb225c95b9246. Fixes #52968, fixes #52995.
2021-11-15 15:08:19 +00:00
}
Clean up RenderingServer and its bindings * Rewrote bindings for RenderingServer. * They are now all up to date. * Several unused methods and deprecated features were cleaned up.
2021-07-01 02:17:47 +00:00
RenderingServer::get_singleton()->viewport_set_disable_2d(get_scene_root()->get_viewport_rid(), true);
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->viewport_set_disable_environment(get_viewport()->get_viewport_rid(), true);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
feature_profile_manager->notify_changed();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 03:14:39 +00:00
_select_default_main_screen_plugin();
New option to send canvas to render buffer allows to use 3D environment effects for post processing such as Glow, Bloom, HDR, etc. in 2D.
2015-03-16 03:47:37 +00:00
Don't save project on startup in headless mode
2021-07-23 10:44:35 +00:00
// Save the project after opening to mark it as last modified, except in headless mode.
if (DisplayServer::get_singleton()->window_can_draw()) {
ProjectSettings::get_singleton()->save();
}
Save project after opening
2021-03-26 13:10:41 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
/* DO NOT LOAD SCENES HERE, WAIT FOR FILE SCANNING AND REIMPORT TO COMPLETE */
} break;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
Add a separate application focus/in notification out from Window focus notification.
2020-06-29 23:47:18 +00:00
case NOTIFICATION_APPLICATION_FOCUS_IN: {
Add a "save on focus loss" editor setting (disabled by default) This performs a Ctrl + S action every time the editor window loses focus, saving both scenes and scripts as needed.
2021-04-11 13:39:31 +00:00
// Restore the original FPS cap after focusing back on the editor.
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/low_processor_mode_sleep_usec")));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
EditorFileSystem::get_singleton()->scan_changes();
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
_scan_external_changes();
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Add a separate application focus/in notification out from Window focus notification.
2020-06-29 23:47:18 +00:00
case NOTIFICATION_APPLICATION_FOCUS_OUT: {
Add a "save on focus loss" editor setting (disabled by default) This performs a Ctrl + S action every time the editor window loses focus, saving both scenes and scripts as needed.
2021-04-11 13:39:31 +00:00
// Save on focus loss before applying the FPS limit to avoid slowing down the saving process.
if (EDITOR_GET("interface/editor/save_on_focus_loss")) {
_menu_option_confirm(FILE_SAVE_SCENE, false);
}
// Set a low FPS cap to decrease CPU/GPU usage while the editor is unfocused.
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/unfocused_low_processor_mode_sleep_usec")));
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
case NOTIFICATION_WM_ABOUT: {
Remove Editor dependency from SceneTree
2019-08-05 17:46:23 +00:00
show_about();
} break;
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 16:36:09 +00:00
case NOTIFICATION_WM_CLOSE_REQUEST: {
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
_menu_option_confirm(FILE_QUIT, false);
} break;
Decrease the editor FPS cap when the window is unfocused This decreases CPU/GPU usage when the window is unfocused, which can be beneficial to laptop users. This also makes the low-processor mode sleep project setting no longer affect the editor. Instead, two new editor settings now define the duration of sleeping when the editor is focused and unfocused. This closes #24209 and partially addresses #29257.
2019-05-29 21:12:19 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
case EditorSettings::NOTIFICATION_EDITOR_SETTINGS_CHANGED: {
Improve scene tab close button options
2022-03-13 01:03:26 +00:00
scene_tabs->set_tab_close_display_policy((TabBar::CloseButtonDisplayPolicy)EDITOR_GET("interface/scene_tabs/display_close_button").operator int());
Made use of EditorSettings 'settings changed' to optimise settings changed notifications.
2021-10-15 12:34:52 +00:00
bool theme_changed =
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/theme") ||
[Editor] Fix reloading editor theme on font / font size setting change.
2022-03-21 06:20:09 +00:00
EditorSettings::get_singleton()->check_changed_settings_in_group("text_editor/theme") ||
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/editor/font") ||
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/editor/main_font") ||
EditorSettings::get_singleton()->check_changed_settings_in_group("interface/editor/code_font");
Made use of EditorSettings 'settings changed' to optimise settings changed notifications.
2021-10-15 12:34:52 +00:00
if (theme_changed) {
theme = create_custom_theme(theme_base->get_theme());
theme_base->set_theme(theme);
gui_base->set_theme(theme);
gui_base->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("Background"), SNAME("EditorStyles")));
scene_root_parent->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("Content"), SNAME("EditorStyles")));
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("panel"), SNAME("TabContainer")));
scene_tabs->add_theme_style_override("tab_selected", gui_base->get_theme_stylebox(SNAME("SceneTabFG"), SNAME("EditorStyles")));
scene_tabs->add_theme_style_override("tab_unselected", gui_base->get_theme_stylebox(SNAME("SceneTabBG"), SNAME("EditorStyles")));
file_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
project_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
debug_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
settings_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
help_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
}
Fix drop-down size when resizing font #12207 Fixes Scene > Open Recent Fixes ScriptEditor > File > Open Recent
2017-10-20 10:24:00 +00:00
Replace `TabBar`'s `min_width` with `max_tab_width` and expose it
2022-02-03 05:45:31 +00:00
scene_tabs->set_max_tab_width(int(EDITOR_GET("interface/scene_tabs/maximum_width")) * EDSCALE);
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
_update_scene_tabs();
Remove set_as_minsize()
2022-03-05 23:57:42 +00:00
recent_scenes->reset_size();
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Update debugger area.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (EditorDebuggerNode::get_singleton()->is_visible()) {
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("BottomPanelDebuggerOverride"), SNAME("EditorStyles")));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
fixed bottom panel debugger exception - make it work in combination with the border for tabs - fixed updating when changing theme
2017-09-18 19:06:55 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Update icons.
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
for (int i = 0; i < singleton->main_editor_buttons.size(); i++) {
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
Button *tb = singleton->main_editor_buttons[i];
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
EditorPlugin *p_editor = singleton->editor_table[i];
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
Ref<Texture2D> icon = p_editor->get_icon();
Add method to set main screen plugin icon
2017-12-06 22:27:45 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
if (icon.is_valid()) {
tb->set_icon(icon);
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
} else if (singleton->gui_base->has_theme_icon(p_editor->get_name(), SNAME("EditorIcons"))) {
tb->set_icon(singleton->gui_base->get_theme_icon(p_editor->get_name(), SNAME("EditorIcons")));
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
}
Add method to set main screen plugin icon
2017-12-06 22:27:45 +00:00
}
Update icons when theme changed
2018-02-25 16:04:16 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
_build_icon_type_cache();
Update icons when theme changed
2018-02-25 16:04:16 +00:00
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_button->set_icon(gui_base->get_theme_icon(SNAME("MainPlay"), SNAME("EditorIcons")));
play_scene_button->set_icon(gui_base->get_theme_icon(SNAME("PlayScene"), SNAME("EditorIcons")));
play_custom_scene_button->set_icon(gui_base->get_theme_icon(SNAME("PlayCustom"), SNAME("EditorIcons")));
pause_button->set_icon(gui_base->get_theme_icon(SNAME("Pause"), SNAME("EditorIcons")));
stop_button->set_icon(gui_base->get_theme_icon(SNAME("Stop"), SNAME("EditorIcons")));
added icon updating to most ui elements
2017-08-29 23:03:13 +00:00
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
prev_scene->set_icon(gui_base->get_theme_icon(SNAME("PrevScene"), SNAME("EditorIcons")));
distraction_free->set_icon(gui_base->get_theme_icon(SNAME("DistractionFree"), SNAME("EditorIcons")));
scene_tab_add->set_icon(gui_base->get_theme_icon(SNAME("Add"), SNAME("EditorIcons")));
added icon updating to most ui elements
2017-08-29 23:03:13 +00:00
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
bottom_panel_raise->set_icon(gui_base->get_theme_icon(SNAME("ExpandBottomDock"), SNAME("EditorIcons")));
Make the expand icon in the bottom panel always be the same
2019-07-29 21:08:05 +00:00
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
if (gui_base->is_layout_rtl()) {
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
dock_tab_move_left->set_icon(theme->get_icon(SNAME("Forward"), SNAME("EditorIcons")));
dock_tab_move_right->set_icon(theme->get_icon(SNAME("Back"), SNAME("EditorIcons")));
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
} else {
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
dock_tab_move_left->set_icon(theme->get_icon(SNAME("Back"), SNAME("EditorIcons")));
dock_tab_move_right->set_icon(theme->get_icon(SNAME("Forward"), SNAME("EditorIcons")));
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
}
Update icons when theme changed
2018-02-25 16:04:16 +00:00
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
PopupMenu *p = help_menu->get_popup();
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
p->set_item_icon(p->get_item_index(HELP_SEARCH), gui_base->get_theme_icon(SNAME("HelpSearch"), SNAME("EditorIcons")));
p->set_item_icon(p->get_item_index(HELP_DOCS), gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")));
p->set_item_icon(p->get_item_index(HELP_QA), gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")));
p->set_item_icon(p->get_item_index(HELP_REPORT_A_BUG), gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")));
p->set_item_icon(p->get_item_index(HELP_SUGGEST_A_FEATURE), gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")));
p->set_item_icon(p->get_item_index(HELP_SEND_DOCS_FEEDBACK), gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")));
p->set_item_icon(p->get_item_index(HELP_COMMUNITY), gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")));
p->set_item_icon(p->get_item_index(HELP_ABOUT), gui_base->get_theme_icon(SNAME("Godot"), SNAME("EditorIcons")));
p->set_item_icon(p->get_item_index(HELP_SUPPORT_GODOT_DEVELOPMENT), gui_base->get_theme_icon(SNAME("Heart"), SNAME("EditorIcons")));
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
Use bold fonts in editor * Labels are now bold * Categories in trees are bold * Main editor buttons are bold * Fixed section folding arrows in inspector
2021-05-27 15:32:30 +00:00
for (int i = 0; i < main_editor_buttons.size(); i++) {
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
main_editor_buttons.write[i]->add_theme_font_override("font", gui_base->get_theme_font(SNAME("main_button_font"), SNAME("EditorFonts")));
main_editor_buttons.write[i]->add_theme_font_size_override("font_size", gui_base->get_theme_font_size(SNAME("main_button_font_size"), SNAME("EditorFonts")));
Use bold fonts in editor * Labels are now bold * Categories in trees are bold * Main editor buttons are bold * Fixed section folding arrows in inspector
2021-05-27 15:32:30 +00:00
}
Add TextFile support across the editor
2021-09-23 21:09:15 +00:00
Set<String> updated_textfile_extensions;
bool extensions_match = true;
const Vector<String> textfile_ext = ((String)(EditorSettings::get_singleton()->get("docks/filesystem/textfile_extensions"))).split(",", false);
for (const String &E : textfile_ext) {
updated_textfile_extensions.insert(E);
if (extensions_match && !textfile_extensions.has(E)) {
extensions_match = false;
}
}
if (!extensions_match || updated_textfile_extensions.size() < textfile_extensions.size()) {
textfile_extensions = updated_textfile_extensions;
EditorFileSystem::get_singleton()->scan();
}
Use switch instead of if statement
2019-07-14 10:26:22 +00:00
_update_update_spinner();
} break;
add scene button and tab scrolling
2017-11-16 22:57:57 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
void EditorNode::_update_update_spinner() {
update_spinner->set_visible(EditorSettings::get_singleton()->get("interface/editor/show_update_spinner"));
Change the editor update spinner color when updating continuously Updating continuously should only be enabled for troubleshooting purposes, as it uses a lot of CPU/GPU power. The update spinner is now displayed in red when the Update Continuously editor setting is enabled.
2021-08-03 15:22:46 +00:00
const bool update_continuously = EditorSettings::get_singleton()->get("interface/editor/update_continuously");
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
PopupMenu *update_popup = update_spinner->get_popup();
update_popup->set_item_checked(update_popup->get_item_index(SETTINGS_UPDATE_CONTINUOUSLY), update_continuously);
update_popup->set_item_checked(update_popup->get_item_index(SETTINGS_UPDATE_WHEN_CHANGED), !update_continuously);
Change the editor update spinner color when updating continuously Updating continuously should only be enabled for troubleshooting purposes, as it uses a lot of CPU/GPU power. The update spinner is now displayed in red when the Update Continuously editor setting is enabled.
2021-08-03 15:22:46 +00:00
if (update_continuously) {
update_spinner->set_tooltip(TTR("Spins when the editor window redraws.\nUpdate Continuously is enabled, which can increase power usage. Click to disable it."));
// Use a different color for the update spinner when Update Continuously is enabled,
// as this feature should only be enabled for troubleshooting purposes.
// Make the icon modulate color overbright because icons are not completely white on a dark theme.
// On a light theme, icons are dark, so we need to modulate them with an even brighter color.
const bool dark_theme = EditorSettings::get_singleton()->is_dark_theme();
update_spinner->set_self_modulate(
Add missing SNAME macro optimization for StringName in some functions
2021-08-20 12:48:34 +00:00
gui_base->get_theme_color(SNAME("error_color"), SNAME("Editor")) * (dark_theme ? Color(1.1, 1.1, 1.1) : Color(4.25, 4.25, 4.25)));
Change the editor update spinner color when updating continuously Updating continuously should only be enabled for troubleshooting purposes, as it uses a lot of CPU/GPU power. The update spinner is now displayed in red when the Update Continuously editor setting is enabled.
2021-08-03 15:22:46 +00:00
} else {
update_spinner->set_tooltip(TTR("Spins when the editor window redraws."));
update_spinner->set_self_modulate(Color(1, 1, 1));
}
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
OS::get_singleton()->set_low_processor_usage_mode(!update_continuously);
}
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 15:34:22 +00:00
void EditorNode::_on_plugin_ready(Object *p_script, const String &p_activate_name) {
Ref<Script> script = Object::cast_to<Script>(p_script);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (script.is_null()) {
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 15:34:22 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 15:34:22 +00:00
if (p_activate_name.length()) {
set_addon_plugin_enabled(p_activate_name, true);
}
Minor fixes/refactoring of project and editor setting dialogs
2022-01-31 23:19:01 +00:00
project_settings_editor->update_plugins();
project_settings_editor->hide();
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 15:34:22 +00:00
push_item(script.operator->());
}
Remove plugin from enabled if there's an error inform user in warning message Co-authored-by: Rémi Verschelde <rverschelde@gmail.com> Refactor remove plugin from enabled
2021-05-09 12:17:15 +00:00
void EditorNode::_remove_plugin_from_enabled(const String &p_name) {
ProjectSettings *ps = ProjectSettings::get_singleton();
PackedStringArray enabled_plugins = ps->get("editor_plugins/enabled");
for (int i = 0; i < enabled_plugins.size(); ++i) {
if (enabled_plugins.get(i) == p_name) {
Rename `remove()` to `remove_at()` when removing by index
2021-07-03 22:17:03 +00:00
enabled_plugins.remove_at(i);
Remove plugin from enabled if there's an error inform user in warning message Co-authored-by: Rémi Verschelde <rverschelde@gmail.com> Refactor remove plugin from enabled
2021-05-09 12:17:15 +00:00
break;
}
}
ps->set("editor_plugins/enabled", enabled_plugins);
}
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
void EditorNode::_resources_changed(const Vector<String> &p_resources) {
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 06:33:00 +00:00
List<Ref<Resource>> changed;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
int rc = p_resources.size();
for (int i = 0; i < rc; i++) {
Ref<Resource> res(ResourceCache::get(p_resources.get(i)));
if (res.is_null()) {
continue;
}
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!res->editor_can_reload_from_file()) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Rename `String.is_abs_path()` to `String.is_absolute_path()` This is more consistent with `NodePath.is_absolute()`.
2021-06-03 13:41:22 +00:00
if (!res->get_path().is_resource_file() && !res->get_path().is_absolute_path()) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (!FileAccess::exists(res->get_path())) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
export from command line
2016-02-10 06:41:48 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!res->get_import_path().is_empty()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// This is an imported resource, will be reloaded if reimported via the _resources_reimported() callback.
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
continue;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
changed.push_back(res);
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 17:18:40 +00:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
if (changed.size()) {
Use Ref<T> references as iterators where relevant And const when possible.
2021-07-26 15:50:35 +00:00
for (Ref<Resource> &res : changed) {
res->reload_from_file();
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
}
}
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 17:18:40 +00:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
void EditorNode::_fs_changed() {
for (Set<FileDialog *>::Element *E = file_dialogs.front(); E; E = E->next()) {
E->get()->invalidate();
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 17:18:40 +00:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
for (Set<EditorFileDialog *>::Element *E = editor_file_dialogs.front(); E; E = E->next()) {
E->get()->invalidate();
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 17:18:40 +00:00
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 17:37:54 +00:00
_mark_unsaved_scenes();
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 09:39:09 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// FIXME: Move this to a cleaner location, it's hacky to do this in _fs_changed.
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
String export_error;
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!export_defer.preset.is_empty() && !EditorFileSystem::get_singleton()->is_scanning()) {
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
String preset_name = export_defer.preset;
// Ensures export_project does not loop infinitely, because notifications may
// come during the export.
export_defer.preset = "";
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
Ref<EditorExportPreset> export_preset;
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 09:39:09 +00:00
for (int i = 0; i < EditorExport::get_singleton()->get_export_preset_count(); ++i) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
export_preset = EditorExport::get_singleton()->get_export_preset(i);
if (export_preset->get_name() == preset_name) {
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 09:39:09 +00:00
break;
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
export_preset.unref();
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 09:39:09 +00:00
}
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-05 23:44:15 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (export_preset.is_null()) {
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-05 23:44:15 +00:00
DirAccessRef da = DirAccess::create(DirAccess::ACCESS_RESOURCES);
if (da->file_exists("res://export_presets.cfg")) {
export_error = vformat(
"Invalid export preset name: %s.\nThe following presets were detected in this project's `export_presets.cfg`:\n\n",
preset_name);
for (int i = 0; i < EditorExport::get_singleton()->get_export_preset_count(); ++i) {
// Write the preset name between double quotes since it needs to be written between quotes on the command line if it contains spaces.
export_error += vformat(" \"%s\"\n", EditorExport::get_singleton()->get_export_preset(i)->get_name());
}
} else {
export_error = "This project doesn't have an `export_presets.cfg` file at its root.\nCreate an export preset from the \"Project > Export\" dialog and try again.";
}
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 09:39:09 +00:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
Ref<EditorExportPlatform> platform = export_preset->get_platform();
const String export_path = export_defer.path.is_empty() ? export_preset->get_export_path() : export_defer.path;
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (export_path.is_empty()) {
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-05 23:44:15 +00:00
export_error = vformat("Export preset \"%s\" doesn't have a default export path, and none was specified.", preset_name);
Fix CLI export when export_path is in preset. Export presets contains the export_path option, to specify the default export location, but the CLI export option disregarded that, and always required and export path to be specified. After this commit, if the export path is not specified in the command, the one in the preset will be used, erroring only if it's not present or invalid.
2020-11-17 17:02:41 +00:00
} else if (platform.is_null()) {
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-05 23:44:15 +00:00
export_error = vformat("Export preset \"%s\" doesn't have a matching platform.", preset_name);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 09:39:09 +00:00
} else {
Fix Coverity reports of uninitialized scalar variable Fixes most current reports on Coverity Scan of uninitialized scalar variable (CWE-457): https://cwe.mitre.org/data/definitions/457.html These happen most of the time (in our code) when instanciating structs without a constructor (or with an incomplete one), and later returning the instance. This is sometimes intended though, as some parameters are only used in some situations and should not be double-initialized for performance reasons (e.g. `constant` in ShaderLanguage::Token).
2018-04-19 11:04:41 +00:00
Error err = OK;
Export: Add dedicated --export-pack option to export data pack The previous behavior relying on the provided extension was problematic on macOS since .zip is the main extension used for the full project export (binary + data pack). We add a dedicated `--export-pack` command line option to define when only the data pack should be exported. Its extension will still be inferred from the path. Fixes #23073.
2020-01-08 13:22:50 +00:00
if (export_defer.pack_only) { // Only export .pck or .zip data pack.
Fix CLI export when export_path is in preset. Export presets contains the export_path option, to specify the default export location, but the CLI export option disregarded that, and always required and export path to be specified. After this commit, if the export path is not specified in the command, the one in the preset will be used, erroring only if it's not present or invalid.
2020-11-17 17:02:41 +00:00
if (export_path.ends_with(".zip")) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
err = platform->export_zip(export_preset, export_defer.debug, export_path);
Fix CLI export when export_path is in preset. Export presets contains the export_path option, to specify the default export location, but the CLI export option disregarded that, and always required and export path to be specified. After this commit, if the export path is not specified in the command, the one in the preset will be used, erroring only if it's not present or invalid.
2020-11-17 17:02:41 +00:00
} else if (export_path.ends_with(".pck")) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
err = platform->export_pack(export_preset, export_defer.debug, export_path);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 09:39:09 +00:00
}
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
} else { // Normal project export.
String config_error;
bool missing_templates;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (!platform->can_export(export_preset, config_error, missing_templates)) {
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-05 23:44:15 +00:00
ERR_PRINT(vformat("Cannot export project with preset \"%s\" due to configuration errors:\n%s", preset_name, config_error));
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
err = missing_templates ? ERR_FILE_NOT_FOUND : ERR_UNCONFIGURED;
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
err = platform->export_project(export_preset, export_defer.debug, export_path);
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
}
Explicitly print an error when --export fails. Previously this would not explicitly say the export failed. Sure you might see another error somewhere, but that's not very reliable/obvious.
2018-04-04 14:13:06 +00:00
}
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
switch (err) {
case OK:
break;
case ERR_FILE_NOT_FOUND:
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-05 23:44:15 +00:00
export_error = vformat("Project export failed for preset \"%s\". The export template appears to be missing.", preset_name);
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
break;
case ERR_FILE_BAD_PATH:
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-05 23:44:15 +00:00
export_error = vformat("Project export failed for preset \"%s\". The target path \"%s\" appears to be invalid.", preset_name, export_path);
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
break;
default:
Improve error messages for missing export presets when using `--export` - Display a specific error message if the project doesn't have an `export_presets.cfg` file. - Display a list of detected export presets if an invalid export preset name is supplied.
2021-04-05 23:44:15 +00:00
export_error = vformat("Project export failed with error code %d for preset \"%s\".", (int)err, preset_name);
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
break;
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 09:39:09 +00:00
}
}
}
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (!export_error.is_empty()) {
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
ERR_PRINT(export_error);
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 11:48:12 +00:00
_exit_editor(EXIT_FAILURE);
} else {
_exit_editor(EXIT_SUCCESS);
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 12:29:02 +00:00
}
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 09:39:09 +00:00
}
Lot of work in new importer, importing textures now works.
2017-02-01 12:45:45 +00:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 17:18:40 +00:00
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 21:57:03 +00:00
void EditorNode::_resources_reimported(const Vector<String> &p_resources) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
List<String> scenes;
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
int current_tab = scene_tabs->get_current_tab();
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 21:57:03 +00:00
for (int i = 0; i < p_resources.size(); i++) {
String file_type = ResourceLoader::get_resource_type(p_resources[i]);
if (file_type == "PackedScene") {
scenes.push_back(p_resources[i]);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Reload later if needed, first go with normal resources.
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 21:57:03 +00:00
continue;
}
if (!ResourceCache::has(p_resources[i])) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Not loaded, no need to reload.
continue;
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 21:57:03 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Reload normally.
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 21:57:03 +00:00
Resource *resource = ResourceCache::get(p_resources[i]);
if (resource) {
resource->reload_from_file();
}
}
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const String &E : scenes) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
reload_scene(E);
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 21:57:03 +00:00
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
scene_tabs->set_current_tab(current_tab);
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 21:57:03 +00:00
}
Lot of work in new importer, importing textures now works.
2017-02-01 12:45:45 +00:00
void EditorNode::_sources_changed(bool p_exist) {
if (waiting_for_first_scan) {
Avoid docks to be overriden while scanning, fixes #26359
2019-02-27 21:14:24 +00:00
waiting_for_first_scan = false;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Implement global and per instance shader uniforms. Adds two keywords to shader language for uniforms: -'global' -'instance' This allows them to reference values outside the material.
2020-04-17 02:52:00 +00:00
// Reload the global shader variables, but this time
Fix various typos with codespell Found via `codespell -q 3 -S ./thirdparty,*.po,./DONORS.md -L ackward,ang,ans,ba,beng,cas,childs,childrens,dof,doubleclick,fave,findn,hist,inout,leapyear,lod,nd,numer,ois,ony,paket,seeked,sinc,switchs,te,uint`
2021-07-07 15:17:32 +00:00
// loading textures, as they are now properly imported.
Implement global and per instance shader uniforms. Adds two keywords to shader language for uniforms: -'global' -'instance' This allows them to reference values outside the material.
2020-04-17 02:52:00 +00:00
RenderingServer::get_singleton()->global_variables_load_settings(true);
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 10:32:15 +00:00
// Start preview thread now that it's safe.
if (!singleton->cmdline_export_mode) {
EditorResourcePreview::get_singleton()->start();
}
-Fix problem of order of import plugins, closes #26340 -Ensure resource previewer does not start until first import is done
2019-02-27 16:31:11 +00:00
Make sure restoring opened scenes happens after scanning is done.
2019-02-27 14:00:11 +00:00
_load_docks();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!defer_load_scene.is_empty()) {
Lot of work in new importer, importing textures now works.
2017-02-01 12:45:45 +00:00
load_scene(defer_load_scene);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
defer_load_scene = "";
Lot of work in new importer, importing textures now works.
2017-02-01 12:45:45 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
void EditorNode::_scan_external_changes() {
disk_changed_list->clear();
TreeItem *r = disk_changed_list->create_item();
disk_changed_list->set_hide_root(true);
bool need_reload = false;
// Check if any edited scene has changed.
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Don't check modified time if file doesn't exist
2021-02-26 22:18:50 +00:00
DirAccessRef da = DirAccess::create(DirAccess::ACCESS_RESOURCES);
if (editor_data.get_scene_path(i) == "" || !da->file_exists(editor_data.get_scene_path(i))) {
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
continue;
}
uint64_t last_date = editor_data.get_scene_modified_time(i);
uint64_t date = FileAccess::get_modified_time(editor_data.get_scene_path(i));
if (date > last_date) {
TreeItem *ti = disk_changed_list->create_item(r);
ti->set_text(0, editor_data.get_scene_path(i).get_file());
need_reload = true;
}
}
Detect external modification of project.godot
2021-01-17 00:09:17 +00:00
String project_settings_path = ProjectSettings::get_singleton()->get_resource_path().plus_file("project.godot");
if (FileAccess::get_modified_time(project_settings_path) > ProjectSettings::get_singleton()->get_last_saved_time()) {
TreeItem *ti = disk_changed_list->create_item(r);
ti->set_text(0, "project.godot");
need_reload = true;
}
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
if (need_reload) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
disk_changed->call_deferred(SNAME("popup_centered_ratio"), 0.5);
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
}
}
void EditorNode::_resave_scenes(String p_str) {
save_all_scenes();
Detect external modification of project.godot
2021-01-17 00:09:17 +00:00
ProjectSettings::get_singleton()->save();
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
disk_changed->hide();
}
void EditorNode::_reload_modified_scenes() {
int current_idx = editor_data.get_edited_scene();
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == "") {
continue;
}
uint64_t last_date = editor_data.get_scene_modified_time(i);
uint64_t date = FileAccess::get_modified_time(editor_data.get_scene_path(i));
if (date > last_date) {
String filename = editor_data.get_scene_path(i);
editor_data.set_edited_scene(i);
_remove_edited_scene(false);
Error err = load_scene(filename, false, false, true, false, true);
if (err != OK) {
Detect external modification of project.godot
2021-01-17 00:09:17 +00:00
ERR_PRINT(vformat("Failed to load scene: %s", filename));
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
}
editor_data.move_edited_scene_to_index(i);
}
}
get_undo_redo()->clear_history(false);
set_current_scene(current_idx);
_update_scene_tabs();
disk_changed->hide();
}
Detect external modification of project.godot
2021-01-17 00:09:17 +00:00
void EditorNode::_reload_project_settings() {
ProjectSettings::get_singleton()->setup(ProjectSettings::get_singleton()->get_resource_path(), String(), true);
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
settings_changed = true;
Detect external modification of project.godot
2021-01-17 00:09:17 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void EditorNode::_vp_resized() {
}
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 00:20:54 +00:00
void EditorNode::_version_button_pressed() {
DisplayServer::get_singleton()->clipboard_set(version_btn->get_meta(META_TEXT_TO_COPY));
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void EditorNode::_node_renamed() {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
if (InspectorDock::get_inspector_singleton()) {
InspectorDock::get_inspector_singleton()->update_tree();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 19:26:32 +00:00
void EditorNode::_editor_select_next() {
int editor = _get_current_main_editor();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
do {
if (editor == editor_table.size() - 1) {
editor = 0;
} else {
editor++;
}
Fixes infinite loop when switching editor
2019-12-11 05:27:21 +00:00
} while (!main_editor_buttons[editor]->is_visible());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 19:26:32 +00:00
_editor_select(editor);
}
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
void EditorNode::_open_command_palette() {
command_palette->open_popup();
}
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 19:26:32 +00:00
void EditorNode::_editor_select_prev() {
int editor = _get_current_main_editor();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
do {
if (editor == 0) {
editor = editor_table.size() - 1;
} else {
editor--;
}
Fixes infinite loop when switching editor
2019-12-11 05:27:21 +00:00
} while (!main_editor_buttons[editor]->is_visible());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 19:26:32 +00:00
_editor_select(editor);
}
Let user fix dependencies in resources
2018-11-02 03:44:40 +00:00
Error EditorNode::load_resource(const String &p_resource, bool p_ignore_broken_deps) {
dependency_errors.clear();
Error err;
Add TextFile support across the editor
2021-09-23 21:09:15 +00:00
RES res;
if (ResourceLoader::exists(p_resource, "")) {
res = ResourceLoader::load(p_resource, "", ResourceFormatLoader::CACHE_MODE_REUSE, &err);
} else if (textfile_extensions.has(p_resource.get_extension())) {
res = ScriptEditor::get_singleton()->open_file(p_resource);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ERR_FAIL_COND_V(!res.is_valid(), ERR_CANT_OPEN);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Let user fix dependencies in resources
2018-11-02 03:44:40 +00:00
if (!p_ignore_broken_deps && dependency_errors.has(p_resource)) {
Vector<String> errors;
for (Set<String>::Element *E = dependency_errors[p_resource].front(); E; E = E->next()) {
errors.push_back(E->get());
}
dependency_error->show(DependencyErrorDialog::MODE_RESOURCE, p_resource, errors);
dependency_errors.erase(p_resource);
return ERR_FILE_MISSING_DEPENDENCIES;
}
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_singleton()->edit_resource(res);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return OK;
}
void EditorNode::edit_node(Node *p_node) {
push_item(p_node);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::save_resource_in_path(const Ref<Resource> &p_resource, const String &p_path) {
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
editor_data.apply_changes_in_editors();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int flg = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (EditorSettings::get_singleton()->get("filesystem/on_save/compress_binary_resources")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
flg |= ResourceSaver::FLAG_COMPRESS;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 20:00:46 +00:00
String path = ProjectSettings::get_singleton()->localize_path(p_path);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Error err = ResourceSaver::save(path, p_resource, flg | ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS);
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err != OK) {
Better warnings when resources can't be saved. Fixes #26531
2019-03-04 14:06:15 +00:00
if (ResourceLoader::is_imported(p_resource->get_path())) {
show_accept(TTR("Imported resources can't be saved."), TTR("OK"));
} else {
show_accept(TTR("Error saving resource!"), TTR("OK"));
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
return;
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
((Resource *)p_resource.ptr())->set_path(path);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("resource_saved"), p_resource);
Added EditorPlugin 'resource_saved' signal
2018-01-12 21:43:29 +00:00
editor_data.notify_resource_saved(p_resource);
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::save_resource(const Ref<Resource> &p_resource) {
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
if (p_resource->get_path().is_resource_file()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
save_resource_in_path(p_resource, p_resource->get_path());
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
} else {
save_resource_as(p_resource);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::save_resource_as(const Ref<Resource> &p_resource, const String &p_at_path) {
Better warnings when resources can't be saved. Fixes #26531
2019-03-04 14:06:15 +00:00
{
String path = p_resource->get_path();
int srpos = path.find("::");
if (srpos != -1) {
String base = path.substr(0, srpos);
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
if (!get_edited_scene() || get_edited_scene()->get_scene_file_path() != base) {
Better warnings when resources can't be saved. Fixes #26531
2019-03-04 14:06:15 +00:00
show_warning(TTR("This resource can't be saved because it does not belong to the edited scene. Make it unique first."));
return;
}
}
}
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
file->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
Add Save option to resource property menu
2018-11-18 14:17:04 +00:00
saving_resource = p_resource;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = RESOURCE_SAVE_AS;
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Ref<PackedScene> sd = memnew(PackedScene);
ResourceSaver::get_recognized_extensions(p_resource, &extensions);
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
file->clear_filters();
properly implement save as from script editor, fixes #2415
2015-12-31 16:12:27 +00:00
List<String> preferred;
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const String &E : extensions) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (p_resource->is_class("Script") && (E == "tres" || E == "res")) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// This serves no purpose and confused people.
properly implement save as from script editor, fixes #2415
2015-12-31 16:12:27 +00:00
continue;
}
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
file->add_filter("*." + E + " ; " + E.to_upper());
preferred.push_back(E);
Save resource: implement extension priority give .res less priority and .tres more priority as preferred extensions.
2020-12-13 01:37:23 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Lowest priority extension.
Save resource: implement extension priority give .res less priority and .tres more priority as preferred extensions.
2020-12-13 01:37:23 +00:00
List<String>::Element *res_element = preferred.find("res");
if (res_element) {
preferred.move_to_back(res_element);
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Highest priority extension.
Save resource: implement extension priority give .res less priority and .tres more priority as preferred extensions.
2020-12-13 01:37:23 +00:00
List<String>::Element *tres_element = preferred.find("tres");
if (tres_element) {
preferred.move_to_front(tres_element);
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!p_at_path.is_empty()) {
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
file->set_current_dir(p_at_path);
if (p_resource->get_path().is_resource_file()) {
file->set_current_file(p_resource->get_path().get_file());
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (extensions.size()) {
Name new resource files with `snake_case`
2021-07-30 00:42:07 +00:00
String resource_name_snake_case = p_resource->get_class().camelcase_to_underscore();
file->set_current_file("new_" + resource_name_snake_case + "." + preferred.front()->get().to_lower());
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
} else {
file->set_current_file(String());
}
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
} else if (!p_resource->get_path().is_empty()) {
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
file->set_current_path(p_resource->get_path());
if (extensions.size()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
String ext = p_resource->get_path().get_extension().to_lower();
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
if (extensions.find(ext) == nullptr) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
file->set_current_path(p_resource->get_path().replacen("." + ext, "." + extensions.front()->get()));
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
}
}
properly implement save as from script editor, fixes #2415
2015-12-31 16:12:27 +00:00
} else if (preferred.size()) {
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
String existing;
if (extensions.size()) {
Name new resource files with `snake_case`
2021-07-30 00:42:07 +00:00
String resource_name_snake_case = p_resource->get_class().camelcase_to_underscore();
existing = "new_" + resource_name_snake_case + "." + preferred.front()->get().to_lower();
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
}
file->set_current_path(existing);
}
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 17:36:01 +00:00
file->set_title(TTR("Save Resource As..."));
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 16:45:19 +00:00
file->popup_file_dialog();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
void EditorNode::_menu_option(int p_option) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
_menu_option_confirm(p_option, false);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
void EditorNode::_menu_confirm_current() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
_menu_option_confirm(current_menu_option, true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
void EditorNode::_dialog_display_save_error(String p_file, Error p_error) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (p_error) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
switch (p_error) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case ERR_FILE_CANT_WRITE: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("Can't open file for writing:") + " " + p_file.get_extension(), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case ERR_FILE_UNRECOGNIZED: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("Requested file format unknown:") + " " + p_file.get_extension(), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
default: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("Error while saving."), TTR("OK"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
}
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
void EditorNode::_dialog_display_load_error(String p_file, Error p_error) {
if (p_error) {
switch (p_error) {
case ERR_CANT_OPEN: {
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 11:05:09 +00:00
show_accept(vformat(TTR("Can't open file '%s'. The file could have been moved or deleted."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
} break;
case ERR_PARSE_ERROR: {
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 11:05:09 +00:00
show_accept(vformat(TTR("Error while parsing file '%s'."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
} break;
case ERR_FILE_CORRUPT: {
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 11:05:09 +00:00
show_accept(vformat(TTR("Scene file '%s' appears to be invalid/corrupt."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
} break;
case ERR_FILE_NOT_FOUND: {
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 11:05:09 +00:00
show_accept(vformat(TTR("Missing file '%s' or one its dependencies."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
} break;
default: {
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 11:05:09 +00:00
show_accept(vformat(TTR("Error while loading file '%s'."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
} break;
}
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_get_scene_metadata(const String &p_file) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!scene) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
EditorSettings: Rename settings_path to settings_dir Also to prepare for upcoming refactoring for XDG support.
2017-11-17 14:50:18 +00:00
String path = EditorSettings::get_singleton()->get_project_settings_dir().plus_file(p_file.get_file() + "-editstate-" + p_file.md5_text() + ".cfg");
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
Ref<ConfigFile> cf;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
cf.instantiate();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
Error err = cf->load(path);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (err != OK || !cf->has_section("editor_states")) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Must not exist.
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
List<String> esl;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
cf->get_section_keys("editor_states", &esl);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
Dictionary md;
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const String &E : esl) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
Variant st = cf->get_value("editor_states", E);
Changed some code showed in LGTM and Coverage
2019-07-20 06:09:57 +00:00
if (st.get_type() != Variant::NIL) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
md[E] = st;
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
editor_data.set_editor_states(md);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_set_scene_metadata(const String &p_file, int p_idx) {
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 03:54:17 +00:00
Node *scene = editor_data.get_edited_scene_root(p_idx);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!scene) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
EditorSettings: Rename settings_path to settings_dir Also to prepare for upcoming refactoring for XDG support.
2017-11-17 14:50:18 +00:00
String path = EditorSettings::get_singleton()->get_project_settings_dir().plus_file(p_file.get_file() + "-editstate-" + p_file.md5_text() + ".cfg");
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
Ref<ConfigFile> cf;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
cf.instantiate();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Fix editor states saving, and remove related error messages
2016-07-17 19:59:15 +00:00
Dictionary md;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_idx < 0 || editor_data.get_edited_scene() == p_idx) {
Fix editor states saving, and remove related error messages
2016-07-17 19:59:15 +00:00
md = editor_data.get_editor_states();
} else {
md = editor_data.get_scene_editor_states(p_idx);
}
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
List<Variant> keys;
md.get_key_list(&keys);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const Variant &E : keys) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
cf->set_value("editor_states", E, md[E]);
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
Error err = cf->save(path);
Added some obvious errors explanations
2019-09-25 08:28:50 +00:00
ERR_FAIL_COND_MSG(err != OK, "Cannot save config file to '" + path + "'.");
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Updated function argument names
2017-08-12 16:52:50 +00:00
bool EditorNode::_find_and_save_resource(RES p_res, Map<RES, bool> &processed, int32_t flags) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_res.is_null()) {
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
return false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
Updated function argument names
2017-08-12 16:52:50 +00:00
if (processed.has(p_res)) {
return processed[p_res];
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
Updated function argument names
2017-08-12 16:52:50 +00:00
bool changed = p_res->is_edited();
p_res->set_edited(false);
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
Updated function argument names
2017-08-12 16:52:50 +00:00
bool subchanged = _find_and_save_edited_subresources(p_res.ptr(), processed, flags);
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
Updated function argument names
2017-08-12 16:52:50 +00:00
if (p_res->get_path().is_resource_file()) {
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
if (changed || subchanged) {
Updated function argument names
2017-08-12 16:52:50 +00:00
ResourceSaver::save(p_res->get_path(), p_res, flags);
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
processed[p_res] = false; // Because it's a file.
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
return false;
} else {
Updated function argument names
2017-08-12 16:52:50 +00:00
processed[p_res] = changed;
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
return changed;
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool EditorNode::_find_and_save_edited_subresources(Object *obj, Map<RES, bool> &processed, int32_t flags) {
bool ret_changed = false;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
List<PropertyInfo> pi;
obj->get_property_list(&pi);
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const PropertyInfo &E : pi) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (!(E.usage & PROPERTY_USAGE_STORAGE)) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
switch (E.type) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case Variant::OBJECT: {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
RES res = obj->get(E.name);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (_find_and_save_resource(res, processed, flags)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ret_changed = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case Variant::ARRAY: {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
Array varray = obj->get(E.name);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int len = varray.size();
for (int i = 0; i < len; i++) {
Removed unused variables, add some constants numbers
2019-12-10 04:13:02 +00:00
const Variant &v = varray.get(i);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
RES res = v;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (_find_and_save_resource(res, processed, flags)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ret_changed = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case Variant::DICTIONARY: {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
Dictionary d = obj->get(E.name);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
List<Variant> keys;
d.get_key_list(&keys);
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const Variant &F : keys) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
Variant v = d[F];
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
RES res = v;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (_find_and_save_resource(res, processed, flags)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ret_changed = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 16:11:55 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Style: Apply new changes from clang-format 8.0 It seems to stay compatible with formatting done by clang-format 6.0 and 7.0, so contributors can keep using those versions for now (they will not undo those changes).
2019-04-09 15:08:36 +00:00
default: {
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
return ret_changed;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_save_edited_subresources(Node *scene, Map<RES, bool> &processed, int32_t flags) {
_find_and_save_edited_subresources(scene, processed, flags);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < scene->get_child_count(); i++) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Node *n = scene->get_child(i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (n->get_owner() != editor_data.get_edited_scene_root()) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
_save_edited_subresources(n, processed, flags);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_find_node_types(Node *p_node, int &count_2d, int &count_3d) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_node->is_class("Viewport") || (p_node != editor_data.get_edited_scene_root() && p_node->get_owner() != editor_data.get_edited_scene_root())) {
work in progress, resource previews
2015-05-31 04:59:42 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_node->is_class("CanvasItem")) {
work in progress, resource previews
2015-05-31 04:59:42 +00:00
count_2d++;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else if (p_node->is_class("Node3D")) {
work in progress, resource previews
2015-05-31 04:59:42 +00:00
count_3d++;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
for (int i = 0; i < p_node->get_child_count(); i++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
_find_node_types(p_node->get_child(i), count_2d, count_3d);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
work in progress, resource previews
2015-05-31 04:59:42 +00:00
}
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 03:48:00 +00:00
void EditorNode::_save_scene_with_preview(String p_file, int p_idx) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
EditorProgress save("save", TTR("Saving Scene"), 4);
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
if (editor_data.get_edited_scene_root() != nullptr) {
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
save.step(TTR("Analyzing"), 0);
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
int c2d = 0;
int c3d = 0;
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 03:23:50 +00:00
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
_find_node_types(editor_data.get_edited_scene_root(), c2d, c3d);
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
save.step(TTR("Creating Thumbnail"), 1);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Current view?
Fix pixelized previews, but also instances of breaking ImageTexture cache. Closes #25378.
2019-01-27 16:39:16 +00:00
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
Ref<Image> img;
Improve scene preview generation for empty scenes and disabled features
2020-07-06 15:55:07 +00:00
// If neither 3D or 2D nodes are present, make a 1x1 black texture.
// We cannot fallback on the 2D editor, because it may not have been used yet,
// which would result in an invalid texture.
if (c3d == 0 && c2d == 0) {
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
img.instantiate();
Style: Apply clang-tidy's `modernize-use-bool-literals`
2021-04-05 11:16:16 +00:00
img->create(1, 1, false, Image::FORMAT_RGB8);
Improve scene preview generation for empty scenes and disabled features
2020-07-06 15:55:07 +00:00
} else if (c3d < c2d) {
Fix errors saving a 2D scene preview when the 2D editor was never opened
2020-07-27 13:49:56 +00:00
Ref<ViewportTexture> viewport_texture = scene_root->get_texture();
if (viewport_texture->get_width() > 0 && viewport_texture->get_height() > 0) {
Rename Texture.get_data() to get_image()
2021-03-28 11:32:17 +00:00
img = viewport_texture->get_image();
Fix errors saving a 2D scene preview when the 2D editor was never opened
2020-07-27 13:49:56 +00:00
}
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
} else {
Improve scene preview generation for empty scenes and disabled features
2020-07-06 15:55:07 +00:00
// The 3D editor may be disabled as a feature, but scenes can still be opened.
// This check prevents the preview from regenerating in case those scenes are then saved.
Fix 3D scene preview generation. File system dock previews will now be generated for 3D scenes when no editor feature profile is set.
2021-03-19 19:54:29 +00:00
// The preview will be generated if no feature profile is set (as the 3D editor is enabled by default).
Improve scene preview generation for empty scenes and disabled features
2020-07-06 15:55:07 +00:00
Ref<EditorFeatureProfile> profile = feature_profile_manager->get_current_profile();
Fix 3D scene preview generation. File system dock previews will now be generated for 3D scenes when no editor feature profile is set.
2021-03-19 19:54:29 +00:00
if (!profile.is_valid() || !profile->is_feature_disabled(EditorFeatureProfile::FEATURE_3D)) {
Rename Texture.get_data() to get_image()
2021-03-28 11:32:17 +00:00
img = Node3DEditor::get_singleton()->get_editor_viewport(0)->get_viewport_node()->get_texture()->get_image();
Improve scene preview generation for empty scenes and disabled features
2020-07-06 15:55:07 +00:00
}
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
}
Fix pixelized previews, but also instances of breaking ImageTexture cache. Closes #25378.
2019-01-27 16:39:16 +00:00
Fix errors saving a 2D scene preview when the 2D editor was never opened
2020-07-27 13:49:56 +00:00
if (img.is_valid() && img->get_width() > 0 && img->get_height() > 0) {
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
img = img->duplicate();
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
save.step(TTR("Creating Thumbnail"), 2);
save.step(TTR("Creating Thumbnail"), 3);
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
int preview_size = EditorSettings::get_singleton()->get("filesystem/file_dialog/thumbnail_size");
preview_size *= EDSCALE;
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Consider a square region.
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
int vp_size = MIN(img->get_width(), img->get_height());
int x = (img->get_width() - vp_size) / 2;
int y = (img->get_height() - vp_size) / 2;
Improved packed scene previews.
2017-11-18 03:42:14 +00:00
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
if (vp_size < preview_size) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Just square it.
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
img->crop_from_point(x, y, vp_size, vp_size);
} else {
int ratio = vp_size / preview_size;
int size = preview_size * MAX(1, ratio / 2);
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
x = (img->get_width() - size) / 2;
y = (img->get_height() - size) / 2;
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
img->crop_from_point(x, y, size, size);
img->resize(preview_size, preview_size, Image::INTERPOLATE_LANCZOS);
}
img->convert(Image::FORMAT_RGB8);
work in progress, resource previews
2015-05-31 04:59:42 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Save thumbnail directly, as thumbnailer may not update due to actual scene not changing md5.
Implement shader caching * Shader compilation is now cached. Subsequent loads take less than a millisecond. * Improved game, editor and project manager startup time. * Editor uses .godot/shader_cache to store shaders. * Game uses user://shader_cache * Project manager uses $config_dir/shader_cache * Options to tweak shader caching in project settings. * Editor path configuration moved from EditorSettings to new class, EditorPaths, so it can be available early on (before shaders are compiled). * Reworked ShaderCompilerRD to ensure deterministic shader code creation (else shader may change and cache will be invalidated). * Added shader compression with SMOLV: https://github.com/aras-p/smol-v
2021-05-25 00:25:11 +00:00
String temp_path = EditorPaths::get_singleton()->get_cache_dir();
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
String cache_base = ProjectSettings::get_singleton()->globalize_path(p_file).md5_text();
cache_base = temp_path.plus_file("resthumb-" + cache_base);
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 03:23:50 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Does not have it, try to load a cached thumbnail.
Don't create preview of empty scene.
2019-12-26 08:15:36 +00:00
String file = cache_base + ".png";
post_process_preview(img);
img->save_png(file);
}
work in progress, resource previews
2015-05-31 04:59:42 +00:00
}
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 03:23:50 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
save.step(TTR("Saving Scene"), 4);
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 03:48:00 +00:00
_save_scene(p_file, p_idx);
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 10:32:15 +00:00
if (!singleton->cmdline_export_mode) {
EditorResourcePreview::get_singleton()->check_for_invalidation(p_file);
}
work in progress, resource previews
2015-05-31 04:59:42 +00:00
}
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 21:56:31 +00:00
bool EditorNode::_validate_scene_recursive(const String &p_filename, Node *p_node) {
for (int i = 0; i < p_node->get_child_count(); i++) {
Node *child = p_node->get_child(i);
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
if (child->get_scene_file_path() == p_filename) {
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 21:56:31 +00:00
return true;
}
if (_validate_scene_recursive(p_filename, child)) {
return true;
}
}
return false;
}
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 06:33:00 +00:00
static bool _find_edited_resources(const Ref<Resource> &p_resource, Set<Ref<Resource>> &edited_resources) {
If resources on disk have subresources and they are edited, also save the resource on ctrl-s
2019-02-27 02:48:30 +00:00
if (p_resource->is_edited()) {
edited_resources.insert(p_resource);
return true;
}
List<PropertyInfo> plist;
p_resource->get_property_list(&plist);
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const PropertyInfo &E : plist) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (E.type == Variant::OBJECT && E.usage & PROPERTY_USAGE_STORAGE && !(E.usage & PROPERTY_USAGE_RESOURCE_NOT_PERSISTENT)) {
RES res = p_resource->get(E.name);
If resources on disk have subresources and they are edited, also save the resource on ctrl-s
2019-02-27 02:48:30 +00:00
if (res.is_null()) {
continue;
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (res->get_path().is_resource_file()) { // Not a subresource, continue.
If resources on disk have subresources and they are edited, also save the resource on ctrl-s
2019-02-27 02:48:30 +00:00
continue;
}
if (_find_edited_resources(res, edited_resources)) {
return true;
}
}
}
return false;
}
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
int EditorNode::_save_external_resources() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Save external resources and its subresources if any was modified.
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
int flg = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (EditorSettings::get_singleton()->get("filesystem/on_save/compress_binary_resources")) {
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
flg |= ResourceSaver::FLAG_COMPRESS;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
flg |= ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS;
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 06:33:00 +00:00
Set<Ref<Resource>> edited_subresources;
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
int saved = 0;
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 06:33:00 +00:00
List<Ref<Resource>> cached;
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
ResourceCache::get_cached_resources(&cached);
Use Ref<T> references as iterators where relevant And const when possible.
2021-07-26 15:50:35 +00:00
for (const Ref<Resource> &res : cached) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!res->get_path().is_resource_file()) {
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Rename `Tabs` to `TabBar`
2021-10-17 16:55:44 +00:00
// not only check if this resource is edited, check contained subresources too
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
if (_find_edited_resources(res, edited_subresources)) {
ResourceSaver::save(res->get_path(), res, flg);
saved++;
}
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Clear later, because user may have put the same subresource in two different resources,
// which will be shared until the next reload.
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 06:33:00 +00:00
for (Set<Ref<Resource>>::Element *E = edited_subresources.front(); E; E = E->next()) {
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
Ref<Resource> res = E->get();
res->set_edited(false);
}
return saved;
}
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 10:46:44 +00:00
static void _reset_animation_players(Node *p_node, List<Ref<AnimatedValuesBackup>> *r_anim_backups) {
for (int i = 0; i < p_node->get_child_count(); i++) {
AnimationPlayer *player = Object::cast_to<AnimationPlayer>(p_node->get_child(i));
if (player && player->is_reset_on_save_enabled() && player->can_apply_reset()) {
Ref<AnimatedValuesBackup> old_values = player->apply_reset();
Fixes crash when AnimationPlayer reset on save
2021-08-12 02:53:35 +00:00
if (old_values.is_valid()) {
r_anim_backups->push_back(old_values);
}
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 10:46:44 +00:00
}
_reset_animation_players(p_node->get_child(i), r_anim_backups);
}
}
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 03:54:17 +00:00
void EditorNode::_save_scene(String p_file, int idx) {
Node *scene = editor_data.get_edited_scene_root(idx);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (!scene) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("This operation can't be done without a tree root."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!scene->get_scene_file_path().is_empty() && _validate_scene_recursive(scene->get_scene_file_path(), scene)) {
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 21:56:31 +00:00
show_accept(TTR("This scene can't be saved because there is a cyclic instancing inclusion.\nPlease resolve it and then attempt to save again."), TTR("OK"));
return;
}
New and improved IK system for Skeleton2D This PR and commit adds a new IK system for 2D with the Skeleton2D node that adds several new IK solvers, a way to control bones in a Skeleton2D node similar to that in Skeleton3D. It also adds additional changes and functionality. This work was sponsored by GSoC 2020 and TwistedTwigleg. Full list of changes: * Adds a SkeletonModifier2D resource * This resource is the base where all IK code is written and executed * Has a function for clamping angles, since it is so commonly used * Modifiers are unique when duplicated so it works with instancing * Adds a SkeletonModifierStack2D resource * This resource manages a series of SkeletonModification2Ds * This is what the Skeleton2D directly interfaces with to make IK possible * Adds SkeletonModifier2D resources for LookAt, CCDIK, FABRIK, Jiggle, and TwoBoneIK * Each modification is in its own file * There is also a SkeletonModifier2D resource that acts as a stack for using multiple stacks together * Adds a PhysicalBone2D node * Works similar to the PhysicalBone3D node, but uses a RigidBody2D node * Changes to Skeleton2D listed below: * Skeleton2D now holds a single SkeletonModificationStack2D for IK * Skeleton2D now has a local_pose_override, which overrides the Bone2D position similar to how the overrides work in Skeleton3D * Changes to Bone2D listed below: * The default_length property has been changed to length. Length is the length of the bone to its child bone node * New bone_angle property, which is the angle the bone has to its first child bone node * Bone2D caches its transform when not modified by IK for IK interpolation purposes * Bone2D draws its own editor gizmo, though this is stated to change in the future * Changes to CanvasItemEditor listed below: * Bone2D gizmo drawing code removed * The 2D IK code is removed. Now Bone2D is the only bone system for 2D * Transform2D now has a looking_at function for rotating to face a position * Two new node notifications: NOTIFICATION_EDITOR_PRE_SAVE and NOTIFICATION_EDITOR_POST_SAVE * These notifications only are called in the editor right before and after saving a scene * Needed for not saving the IK position when executing IK in the editor * Documentation for all the changes listed above.
2020-08-03 18:02:24 +00:00
scene->propagate_notification(NOTIFICATION_EDITOR_PRE_SAVE);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
editor_data.apply_changes_in_editors();
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 10:46:44 +00:00
List<Ref<AnimatedValuesBackup>> anim_backups;
_reset_animation_players(scene, &anim_backups);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
_save_default_environment();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
_set_scene_metadata(p_file, idx);
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-13 23:39:01 +00:00
Ref<PackedScene> sdata;
if (ResourceCache::has(p_file)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Something may be referencing this resource and we are good with that.
// We must update it, but also let the previous scene state go, as
// old version still work for referencing changes in instantiated or inherited scenes.
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-13 23:39:01 +00:00
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
sdata = Ref<PackedScene>(Object::cast_to<PackedScene>(ResourceCache::get(p_file)));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (sdata.is_valid()) {
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-13 23:39:01 +00:00
sdata->recreate_state();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
sdata.instantiate();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-13 23:39:01 +00:00
} else {
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
sdata.instantiate();
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-13 23:39:01 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Error err = sdata->pack(scene);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err != OK) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("Couldn't save scene. Likely dependencies (instances or inheritance) couldn't be satisfied."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int flg = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (EditorSettings::get_singleton()->get("filesystem/on_save/compress_binary_resources")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
flg |= ResourceSaver::FLAG_COMPRESS;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
flg |= ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
err = ResourceSaver::save(p_file, sdata, flg);
If resources on disk have subresources and they are edited, also save the resource on ctrl-s
2019-02-27 02:48:30 +00:00
Improve save handling for built-in scripts
2021-11-06 01:15:19 +00:00
// This needs to be emitted before saving external resources.
emit_signal(SNAME("scene_saved"), p_file);
-Fix in animationplayback, sound would be cut on loop -Fix on scene importer, keeping changes to animation tracks was not working
2018-07-01 20:44:15 +00:00
Improve save handling for built-in scripts
2021-11-06 01:15:19 +00:00
_save_external_resources();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
editor_data.save_editor_external_data();
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 10:46:44 +00:00
Use Ref<T> references as iterators where relevant And const when possible.
2021-07-26 15:50:35 +00:00
for (Ref<AnimatedValuesBackup> &E : anim_backups) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
E->restore();
Add animation reset track feature As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 10:46:44 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err == OK) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
scene->set_scene_file_path(ProjectSettings::get_singleton()->localize_path(p_file));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (idx < 0 || idx == editor_data.get_edited_scene()) {
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 03:54:17 +00:00
set_current_version(editor_data.get_undo_redo().get_version());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
editor_data.set_edited_scene_version(0, idx);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
editor_data.set_scene_modified_time(idx, FileAccess::get_modified_time(p_file));
Moved folding outside the resource files, now saved outside the project.
2018-10-29 19:36:31 +00:00
editor_folding.save_scene_folding(scene, p_file);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
_update_title();
update scene tabs on save - fix
2015-08-12 20:35:37 +00:00
_update_scene_tabs();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} else {
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
_dialog_display_save_error(p_file, err);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
New and improved IK system for Skeleton2D This PR and commit adds a new IK system for 2D with the Skeleton2D node that adds several new IK solvers, a way to control bones in a Skeleton2D node similar to that in Skeleton3D. It also adds additional changes and functionality. This work was sponsored by GSoC 2020 and TwistedTwigleg. Full list of changes: * Adds a SkeletonModifier2D resource * This resource is the base where all IK code is written and executed * Has a function for clamping angles, since it is so commonly used * Modifiers are unique when duplicated so it works with instancing * Adds a SkeletonModifierStack2D resource * This resource manages a series of SkeletonModification2Ds * This is what the Skeleton2D directly interfaces with to make IK possible * Adds SkeletonModifier2D resources for LookAt, CCDIK, FABRIK, Jiggle, and TwoBoneIK * Each modification is in its own file * There is also a SkeletonModifier2D resource that acts as a stack for using multiple stacks together * Adds a PhysicalBone2D node * Works similar to the PhysicalBone3D node, but uses a RigidBody2D node * Changes to Skeleton2D listed below: * Skeleton2D now holds a single SkeletonModificationStack2D for IK * Skeleton2D now has a local_pose_override, which overrides the Bone2D position similar to how the overrides work in Skeleton3D * Changes to Bone2D listed below: * The default_length property has been changed to length. Length is the length of the bone to its child bone node * New bone_angle property, which is the angle the bone has to its first child bone node * Bone2D caches its transform when not modified by IK for IK interpolation purposes * Bone2D draws its own editor gizmo, though this is stated to change in the future * Changes to CanvasItemEditor listed below: * Bone2D gizmo drawing code removed * The 2D IK code is removed. Now Bone2D is the only bone system for 2D * Transform2D now has a looking_at function for rotating to face a position * Two new node notifications: NOTIFICATION_EDITOR_PRE_SAVE and NOTIFICATION_EDITOR_POST_SAVE * These notifications only are called in the editor right before and after saving a scene * Needed for not saving the IK position when executing IK in the editor * Documentation for all the changes listed above.
2020-08-03 18:02:24 +00:00
scene->propagate_notification(NOTIFICATION_EDITOR_POST_SAVE);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 20:23:56 +00:00
void EditorNode::save_all_scenes() {
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
_menu_option_confirm(RUN_STOP, true);
_save_all_scenes();
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 20:23:56 +00:00
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
void EditorNode::save_scene_list(Vector<String> p_scene_filenames) {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Node *scene = editor_data.get_edited_scene_root(i);
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
if (scene && (p_scene_filenames.find(scene->get_scene_file_path()) >= 0)) {
_save_scene(scene->get_scene_file_path(), i);
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
}
}
}
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 20:23:56 +00:00
void EditorNode::restart_editor() {
exiting = true;
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
String to_reopen;
if (get_tree()->get_edited_scene_root()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
to_reopen = get_tree()->get_edited_scene_root()->get_scene_file_path();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
}
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 11:48:12 +00:00
_exit_editor(EXIT_SUCCESS);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
List<String> args;
args.push_back("--path");
args.push_back(ProjectSettings::get_singleton()->get_resource_path());
args.push_back("-e");
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!to_reopen.is_empty()) {
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
args.push_back(to_reopen);
}
OS::get_singleton()->set_restart_on_exit(true, args);
}
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
void EditorNode::_save_all_scenes() {
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 10:14:02 +00:00
bool all_saved = true;
Revert "Fix saving unmodified scenes and resources" This reverts commits 28ab60422d648d43d219186ea0ecffce1645188f and 7821b70a00768cb99c0b48450eabe5a687ae276c. Fixes #19576, and likely the fact that subresources are no longer saved when saving scenes with no change.
2018-06-29 06:38:15 +00:00
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
Node *scene = editor_data.get_edited_scene_root(i);
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 10:14:02 +00:00
if (scene) {
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!scene->get_scene_file_path().is_empty() && DirAccess::exists(scene->get_scene_file_path().get_base_dir())) {
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 10:14:02 +00:00
if (i != editor_data.get_edited_scene()) {
_save_scene(scene->get_scene_file_path(), i);
} else {
_save_scene_with_preview(scene->get_scene_file_path());
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
} else if (!scene->get_scene_file_path().is_empty()) {
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 10:14:02 +00:00
all_saved = false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 01:35:13 +00:00
}
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
}
Fixed editor attempting to save a blank scene with save all scenes
2021-10-12 10:14:02 +00:00
if (!all_saved) {
show_warning(TTR("Could not save one or more scenes!"), TTR("Save All Scenes"));
}
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
_save_default_environment();
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 17:37:54 +00:00
void EditorNode::_mark_unsaved_scenes() {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Node *node = editor_data.get_edited_scene_root(i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!node) {
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 17:37:54 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 17:37:54 +00:00
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
String path = node->get_scene_file_path();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!(path.is_empty() || FileAccess::exists(path))) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (i == editor_data.get_edited_scene()) {
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 17:37:54 +00:00
set_current_version(-1);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 17:37:54 +00:00
editor_data.set_edited_scene_version(-1, i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 17:37:54 +00:00
}
}
_update_title();
_update_scene_tabs();
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void EditorNode::_dialog_action(String p_file) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
switch (current_menu_option) {
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 12:09:09 +00:00
case FILE_NEW_INHERITED_SCENE: {
Change empty scene closing on new inherented scene to a better approach
2019-05-08 06:12:39 +00:00
Node *scene = editor_data.get_edited_scene_root();
// If the previous scene is rootless, just close it in favor of the new one.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!scene) {
Fix crash when inherit in rootless unsaved scene
2019-05-31 00:08:37 +00:00
_menu_option_confirm(FILE_CLOSE, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Change empty scene closing on new inherented scene to a better approach
2019-05-08 06:12:39 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
load_scene(p_file, false, true);
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 12:09:09 +00:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case FILE_OPEN_SCENE: {
load_scene(p_file);
} break;
Ask about selecting a main scene if one has not been selected.
2016-06-27 22:59:33 +00:00
case SETTINGS_PICK_MAIN_SCENE: {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 20:00:46 +00:00
ProjectSettings::get_singleton()->set("application/run/main_scene", p_file);
ProjectSettings::get_singleton()->save();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// TODO: Would be nice to show the project manager opened with the highlighted field.
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
if (pick_main_scene->has_meta("from_native") && (bool)pick_main_scene->get_meta("from_native")) {
run_native->resume_run_native();
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
_run(false, ""); // Automatically run the project.
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
case FILE_CLOSE:
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
case FILE_CLOSE_ALL_AND_QUIT:
case FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER:
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
case FILE_CLOSE_ALL_AND_RELOAD_CURRENT_PROJECT:
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
case SCENE_TAB_CLOSE:
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case FILE_SAVE_SCENE:
case FILE_SAVE_AS_SCENE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
int scene_idx = (current_menu_option == FILE_SAVE_SCENE || current_menu_option == FILE_SAVE_AS_SCENE) ? -1 : tab_closing_idx;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
Prevent overwriting open scenes when saving Prevent overwriting open scenes when saving, this fixes #17628
2018-09-07 13:54:26 +00:00
bool same_open_scene = false;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (editor_data.get_scene_path(i) == p_file && i != scene_idx) {
Prevent overwriting open scenes when saving Prevent overwriting open scenes when saving, this fixes #17628
2018-09-07 13:54:26 +00:00
same_open_scene = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Prevent overwriting open scenes when saving Prevent overwriting open scenes when saving, this fixes #17628
2018-09-07 13:54:26 +00:00
}
if (same_open_scene) {
show_warning(TTR("Can't overwrite scene that is still open!"));
return;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
_save_default_environment();
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 03:48:00 +00:00
_save_scene_with_preview(p_file, scene_idx);
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
_add_to_recent_scenes(p_file);
Save opened scenes when necessary
2019-04-15 20:17:49 +00:00
save_layout();
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (scene_idx != -1) {
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
_discard_changes();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
} break;
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 22:28:25 +00:00
case FILE_SAVE_AND_RUN: {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
_save_default_environment();
work in progress, resource previews
2015-05-31 04:59:42 +00:00
_save_scene_with_preview(p_file);
Fix Regression: running current scene (unsaved) will ask for main scene
2017-11-19 21:59:05 +00:00
_run(false, p_file);
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 22:28:25 +00:00
}
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case FILE_EXPORT_MESH_LIBRARY: {
Ref<MeshLibrary> ml;
if (file_export_lib_merge->is_pressed() && FileAccess::exists(p_file)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ml = ResourceLoader::load(p_file, "MeshLibrary");
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (ml.is_null()) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("Can't load MeshLibrary for merging!"), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
}
}
if (ml.is_null()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ml = Ref<MeshLibrary>(memnew(MeshLibrary));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
implement individual mesh transform for meshlibrary items
2021-08-31 23:17:33 +00:00
MeshLibraryEditor::update_library_file(editor_data.get_edited_scene_root(), ml, true, file_export_lib_apply_xforms->is_pressed());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Error err = ResourceSaver::save(p_file, ml);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (err) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("Error saving MeshLibrary!"), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
}
} break;
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
case RESOURCE_SAVE:
case RESOURCE_SAVE_AS: {
Fix error macro calls not ending with semicolon It's not necessary, but the vast majority of calls of error macros do have an ending semicolon, so it's best to be consistent. Most WARN_DEPRECATED calls did *not* have a semicolon, but there's no reason for them to be treated differently.
2019-06-11 12:49:34 +00:00
ERR_FAIL_COND(saving_resource.is_null());
Add Save option to resource property menu
2018-11-18 14:17:04 +00:00
save_resource_in_path(saving_resource, p_file);
saving_resource = Ref<Resource>();
ObjectID current = editor_history.get_current();
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
Object *current_obj = current.is_valid() ? ObjectDB::get_instance(current) : nullptr;
Add Save option to resource property menu
2018-11-18 14:17:04 +00:00
ERR_FAIL_COND(!current_obj);
Removed _change_notify -For inspector refresh, the inspector now detects if a property change by polling a few times per second and then does update the control if so. This process is very cheap. -For property list refresh, a new signal (property_list_changed) was added to Object. _change_notify() is replaced by notify_property_list_changed() -Changed all objects using the old method to the signal, or just deleted the calls to _change_notify(<property>) since they are unnecesary now.
2021-02-10 20:18:45 +00:00
current_obj->notify_property_list_changed();
Editor layouts menu
2015-11-22 18:11:17 +00:00
} break;
case SETTINGS_LAYOUT_SAVE: {
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (p_file.is_empty()) {
Editor layouts menu
2015-11-22 18:11:17 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Editor layouts menu
2015-11-22 18:11:17 +00:00
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
config.instantiate();
Use new XDG folders to dehardcode paths
2017-11-17 20:48:24 +00:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
Fix editor layout saving
2016-01-01 17:48:14 +00:00
Fix layout saving error As a result of commit b49226e085 FileAccess::open no longer returns ERR_CANT_OPEN if the file cannot be found/opened. Instead check against ERR_FILE_NOT_FOUND or ERR_FILE_CANT_OPEN.
2019-10-23 13:02:51 +00:00
if (err == ERR_FILE_CANT_OPEN || err == ERR_FILE_NOT_FOUND) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
config.instantiate();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
} else if (err != OK) {
Improve messages related to overriding the default editor layout This closes #33884.
2020-08-02 12:12:50 +00:00
show_warning(TTR("An error occurred while trying to save the editor layout.\nMake sure the editor's user data path is writable."));
Fix editor layout saving
2016-01-01 17:48:14 +00:00
return;
Editor layouts menu
2015-11-22 18:11:17 +00:00
}
_save_docks_to_config(config, p_file);
Use new XDG folders to dehardcode paths
2017-11-17 20:48:24 +00:00
config->save(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 18:11:17 +00:00
layout_dialog->hide();
_update_layouts_menu();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_file == "Default") {
Improve messages related to overriding the default editor layout This closes #33884.
2020-08-02 12:12:50 +00:00
show_warning(TTR("Default editor layout overridden.\nTo restore the Default layout to its base settings, use the Delete Layout option and delete the Default layout."));
Allow to override the default editor layout
2016-01-11 21:23:45 +00:00
}
Editor layouts menu
2015-11-22 18:11:17 +00:00
} break;
case SETTINGS_LAYOUT_DELETE: {
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (p_file.is_empty()) {
Editor layouts menu
2015-11-22 18:11:17 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Editor layouts menu
2015-11-22 18:11:17 +00:00
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
config.instantiate();
Use new XDG folders to dehardcode paths
2017-11-17 20:48:24 +00:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 18:11:17 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err != OK || !config->has_section(p_file)) {
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
show_warning(TTR("Layout name not found!"));
Editor layouts menu
2015-11-22 18:11:17 +00:00
return;
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Erase key values.
Editor layouts menu
2015-11-22 18:11:17 +00:00
List<String> keys;
config->get_section_keys(p_file, &keys);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
for (const String &key : keys) {
config->set_value(p_file, key, Variant());
Editor layouts menu
2015-11-22 18:11:17 +00:00
}
Use new XDG folders to dehardcode paths
2017-11-17 20:48:24 +00:00
config->save(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 18:11:17 +00:00
layout_dialog->hide();
_update_layouts_menu();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_file == "Default") {
Improve messages related to overriding the default editor layout This closes #33884.
2020-08-02 12:12:50 +00:00
show_warning(TTR("Restored the Default layout to its base settings."));
Allow to override the default editor layout
2016-01-11 21:23:45 +00:00
}
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
} break;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
default: {
// Save scene?
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
work in progress, resource previews
2015-05-31 04:59:42 +00:00
_save_scene_with_preview(p_file);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
remove trailing whitespace
2016-03-08 23:00:52 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
}
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
bool EditorNode::item_has_editor(Object *p_object) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
if (_is_class_editor_disabled_by_feature_profile(p_object->get_class())) {
return false;
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
return editor_data.get_subeditors(p_object).size() > 0;
}
Added a workaround to avoid crashes due to how TileSet editor works, fixes #23672 Also fixed a few uninitialized memory variables.
2019-02-22 20:42:29 +00:00
void EditorNode::edit_item_resource(RES p_resource) {
edit_item(p_resource.ptr());
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
bool EditorNode::_is_class_editor_disabled_by_feature_profile(const StringName &p_class) {
Ref<EditorFeatureProfile> profile = EditorFeatureProfileManager::get_singleton()->get_current_profile();
if (profile.is_null()) {
return false;
}
StringName class_name = p_class;
while (class_name != StringName()) {
Changes to to feature profile editor Changed "Disable Editor" to "Contextual Editor Enabled" Do not show contextual editors for disabled classes.
2019-04-08 23:20:20 +00:00
if (profile->is_class_disabled(class_name)) {
return true;
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
if (profile->is_class_editor_disabled(class_name)) {
return true;
}
class_name = ClassDB::get_parent_class(class_name);
}
return false;
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
void EditorNode::edit_item(Object *p_object) {
Fix crashes, ability to add blendpsace into blendtree, ability to delete with delete key
2018-06-21 21:08:11 +00:00
Vector<EditorPlugin *> sub_plugins;
if (p_object) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
if (_is_class_editor_disabled_by_feature_profile(p_object->get_class())) {
return;
}
Fix crashes, ability to add blendpsace into blendtree, ability to delete with delete key
2018-06-21 21:08:11 +00:00
sub_plugins = editor_data.get_subeditors(p_object);
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (!sub_plugins.is_empty()) {
Don't hide/show top editor if they did not change, fixes #26644
2019-03-06 15:42:01 +00:00
bool same = true;
if (sub_plugins.size() == editor_plugins_over->get_plugins_list().size()) {
for (int i = 0; i < sub_plugins.size(); i++) {
if (sub_plugins[i] != editor_plugins_over->get_plugins_list()[i]) {
same = false;
}
}
} else {
same = false;
}
if (!same) {
_display_top_editors(false);
_set_top_editors(sub_plugins);
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
_set_editing_top_editors(p_object);
_display_top_editors(true);
Fix crashes, ability to add blendpsace into blendtree, ability to delete with delete key
2018-06-21 21:08:11 +00:00
} else {
Remove the "Open Editor" button, it will open automatically.
2019-03-04 19:44:39 +00:00
hide_top_editors();
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
}
}
void EditorNode::push_item(Object *p_object, const String &p_property, bool p_inspector_only) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (!p_object) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_inspector_singleton()->edit(nullptr);
NodeDock::get_singleton()->set_node(nullptr);
SceneTreeDock::get_singleton()->set_selected(nullptr);
InspectorDock::get_singleton()->update(nullptr);
Disable active editors when node gets deselected
2020-10-30 22:29:07 +00:00
_display_top_editors(false);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
}
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 17:24:06 +00:00
ObjectID id = p_object->get_instance_id();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (id != editor_history.get_current()) {
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
if (p_inspector_only) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
editor_history.add_object(id, String(), true);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
} else if (p_property.is_empty()) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
editor_history.add_object(id);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
editor_history.add_object(id, p_property);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
_edit_current();
}
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
void EditorNode::_save_default_environment() {
Change non-existent World to World3D
2020-04-18 09:00:51 +00:00
Ref<Environment> fallback = get_tree()->get_root()->get_world_3d()->get_fallback_environment();
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
if (fallback.is_valid() && fallback->get_path().is_resource_file()) {
Map<RES, bool> processed;
_find_and_save_edited_subresources(fallback.ptr(), processed, 0);
Revert "Fix saving unmodified scenes and resources" This reverts commits 28ab60422d648d43d219186ea0ecffce1645188f and 7821b70a00768cb99c0b48450eabe5a687ae276c. Fixes #19576, and likely the fact that subresources are no longer saved when saving scenes with no change.
2018-06-29 06:38:15 +00:00
save_resource_in_path(fallback, fallback->get_path());
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
}
}
Remove the "Open Editor" button, it will open automatically.
2019-03-04 19:44:39 +00:00
void EditorNode::hide_top_editors() {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
_display_top_editors(false);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
editor_plugins_over->clear();
}
void EditorNode::_display_top_editors(bool p_display) {
editor_plugins_over->make_visible(p_display);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_set_top_editors(Vector<EditorPlugin *> p_editor_plugins_over) {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
editor_plugins_over->set_plugins_list(p_editor_plugins_over);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_set_editing_top_editors(Object *p_current_object) {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
editor_plugins_over->edit(p_current_object);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Fixes language overridden external editors
2017-09-03 19:23:36 +00:00
static bool overrides_external_editor(Object *p_object) {
Script *script = Object::cast_to<Script>(p_object);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!script) {
Fixes language overridden external editors
2017-09-03 19:23:36 +00:00
return false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fixes language overridden external editors
2017-09-03 19:23:36 +00:00
return script->get_language()->overrides_external_editor();
}
Don't edit foreign resources when restoring scene
2021-09-12 19:17:34 +00:00
void EditorNode::_edit_current(bool p_skip_foreign) {
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 17:24:06 +00:00
ObjectID current = editor_history.get_current();
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
Object *current_obj = current.is_valid() ? ObjectDB::get_instance(current) : nullptr;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Don't edit foreign resources when restoring scene
2021-09-12 19:17:34 +00:00
RES res = Object::cast_to<Resource>(current_obj);
if (p_skip_foreign && res.is_valid()) {
if (res->get_path().find("::") > -1 && res->get_path().get_slice("::", 0) != editor_data.get_scene_path(get_current_tab())) {
// Trying to edit resource that belongs to another scene; abort.
current_obj = nullptr;
}
}
bool inspector_only = editor_history.is_current_inspector_only();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
this->current = current_obj;
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 13:38:59 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (!current_obj) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
SceneTreeDock::get_singleton()->set_selected(nullptr);
InspectorDock::get_inspector_singleton()->edit(nullptr);
NodeDock::get_singleton()->set_node(nullptr);
InspectorDock::get_singleton()->update(nullptr);
Fix editor crash after closing scene with certain types of nodes
2015-12-03 15:30:55 +00:00
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
_display_top_editors(false);
Fix editor crash after closing scene with certain types of nodes
2015-12-03 15:30:55 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
}
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
Object *prev_inspected_object = InspectorDock::get_inspector_singleton()->get_edited_object();
Fixed Inspector update when a node is renamed Whenever any node is renamed, EditorNode::_edit_current() is called and it resets plugins used for current edited properties. This change forces the inspector to update even though the same object is edited, to make sure all plugins are restored properly from unfolded properties/resources/etc. Fixes #32832
2020-01-24 17:08:27 +00:00
Fix path typo for editor def capitalize_properties
2018-06-14 18:36:38 +00:00
bool disable_folding = bool(EDITOR_GET("interface/inspector/disable_folding"));
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 02:03:46 +00:00
bool is_resource = current_obj->is_class("Resource");
bool is_node = current_obj->is_class("Node");
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 06:01:47 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
String editable_warning; // None by default.
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 21:56:31 +00:00
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
if (is_resource) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
Resource *current_res = Object::cast_to<Resource>(current_obj);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
ERR_FAIL_COND(!current_res);
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_inspector_singleton()->edit(current_res);
SceneTreeDock::get_singleton()->set_selected(nullptr);
NodeDock::get_singleton()->set_node(nullptr);
InspectorDock::get_singleton()->update(nullptr);
ImportDock::get_singleton()->set_edit_path(current_res->get_path());
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 13:38:59 +00:00
int subr_idx = current_res->get_path().find("::");
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-14 22:38:38 +00:00
if (subr_idx != -1) {
String base_path = current_res->get_path().substr(0, subr_idx);
if (FileAccess::exists(base_path + ".import")) {
editable_warning = TTR("This resource belongs to a scene that was imported, so it's not editable.\nPlease read the documentation relevant to importing scenes to better understand this workflow.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 13:38:59 +00:00
} else {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
if ((!get_edited_scene() || get_edited_scene()->get_scene_file_path() != base_path) && ResourceLoader::get_resource_type(base_path) == "PackedScene") {
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
editable_warning = TTR("This resource belongs to a scene that was instantiated or inherited.\nChanges to it won't be kept when saving the current scene.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 13:38:59 +00:00
}
}
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-14 22:38:38 +00:00
} else if (current_res->get_path().is_resource_file()) {
if (FileAccess::exists(current_res->get_path() + ".import")) {
Adjusted editable_warning for "This resource was imported...." alert: - fixed a typo from it's to its - added 'then' to make it clearer
2017-10-20 02:40:12 +00:00
editable_warning = TTR("This resource was imported, so it's not editable. Change its settings in the import panel and then re-import.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 13:38:59 +00:00
}
}
do not show help on multi node selection, array editing, etc, closes #5550
2016-07-09 14:46:59 +00:00
} else if (is_node) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
Node *current_node = Object::cast_to<Node>(current_obj);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
ERR_FAIL_COND(!current_node);
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_inspector_singleton()->edit(current_node);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
if (current_node->is_inside_tree()) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
NodeDock::get_singleton()->set_node(current_node);
SceneTreeDock::get_singleton()->set_selected(current_node);
InspectorDock::get_singleton()->update(current_node);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
} else {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
NodeDock::get_singleton()->set_node(nullptr);
SceneTreeDock::get_singleton()->set_selected(nullptr);
InspectorDock::get_singleton()->update(nullptr);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 00:46:48 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (get_edited_scene() && !get_edited_scene()->get_scene_file_path().is_empty()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
String source_scene = get_edited_scene()->get_scene_file_path();
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-14 22:38:38 +00:00
if (FileAccess::exists(source_scene + ".import")) {
Improve wording of various messages and make casing more consistent This also adds the number of selected projects to the confirmation dialog that appears before removing projects.
2019-03-25 00:54:29 +00:00
editable_warning = TTR("This scene was imported, so changes to it won't be kept.\nInstancing it or inheriting will allow making changes to it.\nPlease read the documentation relevant to importing scenes to better understand this workflow.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 13:38:59 +00:00
}
}
Multiple, simultaneous node editing spuport!! ..but will you be brave enough to try it? :)
2015-08-25 03:08:45 +00:00
} else {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
Node *selected_node = nullptr;
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 08:37:51 +00:00
Huge Debugger/EditorDebugger refactor.
2020-02-07 01:52:05 +00:00
if (current_obj->is_class("EditorDebuggerRemoteObject")) {
Improve wording of various messages and make casing more consistent This also adds the number of selected projects to the confirmation dialog that appears before removing projects.
2019-03-25 00:54:29 +00:00
editable_warning = TTR("This is a remote object, so changes to it won't be kept.\nPlease read the documentation relevant to debugging to better understand this workflow.");
Fix path typo for editor def capitalize_properties
2018-06-14 18:36:38 +00:00
disable_folding = true;
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 08:37:51 +00:00
} else if (current_obj->is_class("MultiNodeEdit")) {
Node *scene = get_edited_scene();
if (scene) {
MultiNodeEdit *multi_node_edit = Object::cast_to<MultiNodeEdit>(current_obj);
int node_count = multi_node_edit->get_node_count();
if (node_count > 0) {
List<Node *> multi_nodes;
for (int node_index = 0; node_index < node_count; ++node_index) {
Node *node = scene->get_node(multi_node_edit->get_node(node_index));
if (node) {
multi_nodes.push_back(node);
}
}
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (!multi_nodes.is_empty()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Pick the top-most node.
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 08:37:51 +00:00
multi_nodes.sort_custom<Node::Comparator>();
selected_node = multi_nodes.front()->get();
}
}
}
Better supported for remote object editing with the inspector with a simple dictionary editor implement
2017-10-17 14:39:31 +00:00
}
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_inspector_singleton()->edit(current_obj);
NodeDock::get_singleton()->set_node(nullptr);
SceneTreeDock::get_singleton()->set_selected(selected_node);
InspectorDock::get_singleton()->update(nullptr);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Fixed Inspector update when a node is renamed Whenever any node is renamed, EditorNode::_edit_current() is called and it resets plugins used for current edited properties. This change forces the inspector to update even though the same object is edited, to make sure all plugins are restored properly from unfolded properties/resources/etc. Fixes #32832
2020-01-24 17:08:27 +00:00
if (current_obj == prev_inspected_object) {
// Make sure inspected properties are restored.
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_inspector_singleton()->update_tree();
Fixed Inspector update when a node is renamed Whenever any node is renamed, EditorNode::_edit_current() is called and it resets plugins used for current edited properties. This change forces the inspector to update even though the same object is edited, to make sure all plugins are restored properly from unfolded properties/resources/etc. Fixes #32832
2020-01-24 17:08:27 +00:00
}
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_singleton()->set_warning(editable_warning);
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 13:38:59 +00:00
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
if (InspectorDock::get_inspector_singleton()->is_using_folding() == disable_folding) {
InspectorDock::get_inspector_singleton()->set_use_folding(!disable_folding);
Fix path typo for editor def capitalize_properties
2018-06-14 18:36:38 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Take care of the main editor plugin.
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
if (!inspector_only) {
EditorPlugin *main_plugin = editor_data.get_editor(current_obj);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Fix out of sync separate distraction-free mode
2021-06-08 23:27:30 +00:00
int plugin_index = 0;
for (; plugin_index < editor_table.size(); plugin_index++) {
if (editor_table[plugin_index] == main_plugin) {
if (!main_editor_buttons[plugin_index]->is_visible()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
main_plugin = nullptr; // If button is not visible, then no plugin is active.
Fix out of sync separate distraction-free mode
2021-06-08 23:27:30 +00:00
}
break;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
}
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
if (main_plugin) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Special case if use of external editor is true.
Fix compilation error after 4c30963
2022-01-04 09:40:17 +00:00
Resource *current_res = Object::cast_to<Resource>(current_obj);
Refactor some object type checking code with `cast_to` Less stringly typed logic, and less String allocations and comparisons.
2022-02-06 13:12:19 +00:00
if (main_plugin->get_name() == "Script" && current_obj->is_class("VisualScript") && current_res && !current_res->is_built_in() && (bool(EditorSettings::get_singleton()->get("text_editor/external/use_external_editor")) || overrides_external_editor(current_obj))) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!changing_scene) {
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
main_plugin->edit(current_obj);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
else if (main_plugin != editor_plugin_screen && (!ScriptEditor::get_singleton() || !ScriptEditor::get_singleton()->is_visible_in_tree() || ScriptEditor::get_singleton()->can_take_away_focus())) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Update screen main_plugin.
Fix out of sync separate distraction-free mode
2021-06-08 23:27:30 +00:00
_editor_select(plugin_index);
main_plugin->edit(current_obj);
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
} else {
editor_plugin_screen->edit(current_obj);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
Vector<EditorPlugin *> sub_plugins;
if (!_is_class_editor_disabled_by_feature_profile(current_obj->get_class())) {
sub_plugins = editor_data.get_subeditors(current_obj);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (!sub_plugins.is_empty()) {
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
_display_top_editors(false);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
_set_top_editors(sub_plugins);
_set_editing_top_editors(current_obj);
_display_top_editors(true);
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
} else if (!editor_plugins_over->get_plugins_list().is_empty()) {
Remove the "Open Editor" button, it will open automatically.
2019-03-04 19:44:39 +00:00
hide_top_editors();
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 01:10:48 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_singleton()->update(current_obj);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_run(bool p_current, const String &p_custom) {
if (editor_run.get_status() == EditorRun::STATUS_PLAY) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_button->set_pressed(!_playing_edited);
play_scene_button->set_pressed(_playing_edited);
return;
}
play_button->set_pressed(false);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_button->set_icon(gui_base->get_theme_icon(SNAME("MainPlay"), SNAME("EditorIcons")));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_scene_button->set_pressed(false);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_scene_button->set_icon(gui_base->get_theme_icon(SNAME("PlayScene"), SNAME("EditorIcons")));
Added option to restart custom scene
2016-02-17 19:51:56 +00:00
play_custom_scene_button->set_pressed(false);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_custom_scene_button->set_icon(gui_base->get_theme_icon(SNAME("PlayCustom"), SNAME("EditorIcons")));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
String run_filename;
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (p_current || (editor_data.get_edited_scene_root() && !p_custom.is_empty() && p_custom == editor_data.get_edited_scene_root()->get_scene_file_path())) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (!scene) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("There is no defined scene to run."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (scene->get_scene_file_path().is_empty()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = -1;
Made save dialog open immediately when running unsaved scene. Previously there was an unneeded confirmation dialog.
2021-01-06 01:17:56 +00:00
_menu_option(FILE_SAVE_AS_SCENE);
// Set the option to save and run so when the dialog is accepted, the scene runs.
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = FILE_SAVE_AND_RUN;
Made save dialog open immediately when running unsaved scene. Previously there was an unneeded confirmation dialog.
2021-01-06 01:17:56 +00:00
file->set_title(TTR("Save scene before running..."));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
}
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
run_filename = scene->get_scene_file_path();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
} else if (!p_custom.is_empty()) {
fix custom scene arguments from the editor sequel of #7347 Play edited scene and Play custom scene didn't worked when main_run_args hadn't $scene as argument. Changes/Fixes the way how the editor handles scene paths when starting the project/a scene Play the project - no scene path Play the edited scene - scene path of active scene in the editor Play custom scene - scene path of custom scene main_arg_runs is now empty by default and $scene won't be replaced by the scene path anymore Changed declaration if EditorRun::run, to remove a unused value
2017-02-27 14:20:47 +00:00
run_filename = p_custom;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (run_filename.is_empty()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Evidently, run the scene.
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
if (!ensure_main_scene(false)) {
Properly complain when a scene file has not be selected, closes #3811
2016-06-27 13:59:37 +00:00
return;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 21:02:16 +00:00
if (bool(EDITOR_GET("run/auto_save/save_before_running"))) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (unsaved_cache) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (scene && !scene->get_scene_file_path().is_empty()) { // Only autosave if there is a scene and if it has a path.
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
_save_scene_with_preview(scene->get_scene_file_path());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 03:54:17 +00:00
_menu_option(FILE_SAVE_ALL_SCENES);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
editor_data.save_editor_external_data();
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!call_build()) {
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 21:59:20 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 21:59:20 +00:00
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 21:02:16 +00:00
if (bool(EDITOR_GET("run/output/always_clear_output_on_play"))) {
Added automatic clear output on Play in Godot Settings
2015-07-29 22:03:25 +00:00
log->clear();
}
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 21:02:16 +00:00
if (bool(EDITOR_GET("run/output/always_open_output_on_play"))) {
Add new option to always open output on play
2016-12-24 22:39:16 +00:00
make_bottom_panel_item_visible(log);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Support multiple debug protocols.
2020-03-16 08:37:43 +00:00
EditorDebuggerNode::get_singleton()->start();
Auto-Increment Debugger Port Note: This PR also changes the port of the GDScript Language Server from 6008 to 6005. This opens enough ports above the debug port (6007) for this change to be useful.
2021-09-30 02:06:28 +00:00
Error error = editor_run.run(run_filename);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (error != OK) {
Support multiple debug protocols.
2020-03-16 08:37:43 +00:00
EditorDebuggerNode::get_singleton()->stop();
Auto-Increment Debugger Port Note: This PR also changes the port of the GDScript Language Server from 6008 to 6005. This opens enough ports above the debug port (6007) for this change to be useful.
2021-09-30 02:06:28 +00:00
show_accept(TTR("Could not start subprocess(es)!"), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
}
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("play_pressed"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (p_current) {
play_scene_button->set_pressed(true);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_scene_button->set_icon(gui_base->get_theme_icon(SNAME("Reload"), SNAME("EditorIcons")));
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
} else if (!p_custom.is_empty()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
run_custom_filename = p_custom;
Added option to restart custom scene
2016-02-17 19:51:56 +00:00
play_custom_scene_button->set_pressed(true);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_custom_scene_button->set_icon(gui_base->get_theme_icon(SNAME("Reload"), SNAME("EditorIcons")));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} else {
play_button->set_pressed(true);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_button->set_icon(gui_base->get_theme_icon(SNAME("Reload"), SNAME("EditorIcons")));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Fix stop button always enabled (issue #13933)
2017-12-04 19:48:46 +00:00
stop_button->set_disabled(false);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
_playing_edited = p_current;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Support multiple debug protocols.
2020-03-16 08:37:43 +00:00
void EditorNode::_run_native(const Ref<EditorExportPreset> &p_preset) {
bool autosave = EDITOR_GET("run/auto_save/save_before_running");
if (autosave) {
_menu_option_confirm(FILE_SAVE_ALL_SCENES, false);
}
if (run_native->is_deploy_debug_remote_enabled()) {
_menu_option_confirm(RUN_STOP, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!call_build()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
return; // Build failed.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Support multiple debug protocols.
2020-03-16 08:37:43 +00:00
EditorDebuggerNode::get_singleton()->start(p_preset->get_platform()->get_debug_protocol());
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("play_pressed"));
Support multiple debug protocols.
2020-03-16 08:37:43 +00:00
editor_run.run_native_notify();
}
}
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 13:12:56 +00:00
void EditorNode::_android_build_source_selected(const String &p_file) {
export_template_manager->install_android_template_from_file(p_file);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_menu_option_confirm(int p_option, bool p_confirmed) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (!p_confirmed) { // FIXME: this may be a hack.
current_menu_option = (MenuOptions)p_option;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
switch (p_option) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case FILE_NEW_SCENE: {
Allow to create scene from FileSystem dock
2019-08-15 17:47:21 +00:00
new_scene();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 12:09:09 +00:00
case FILE_NEW_INHERITED_SCENE:
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case FILE_OPEN_SCENE: {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
file->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ResourceLoader::get_recognized_extensions_for_type("PackedScene", &extensions);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
file->clear_filters();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < extensions.size(); i++) {
file->add_filter("*." + extensions[i] + " ; " + extensions[i].to_upper());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
remove trailing whitespace
2016-03-08 23:00:52 +00:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (scene) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
file->set_current_path(scene->get_scene_file_path());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
};
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
file->set_title(p_option == FILE_OPEN_SCENE ? TTR("Open Scene") : TTR("Open Base Scene"));
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 16:45:19 +00:00
file->popup_file_dialog();
remove trailing whitespace
2016-03-08 23:00:52 +00:00
Add Quick Open dialog This dialog searches every Resource-derived file in the project, making it extremely useful for searching everything from audio files to scripts. Unlike the Quick Open Script and Quick Open Scene dialogs, you don't need to think about the type of file you're opening, just its name. Shift + Alt + O was chosen to match the existing shortcuts for Quick Open Scene and Quick Open Script.
2019-05-09 20:06:35 +00:00
} break;
case FILE_QUICK_OPEN: {
quick_open->popup_dialog("Resource", true);
quick_open->set_title(TTR("Quick Open..."));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case FILE_QUICK_OPEN_SCENE: {
Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor] Fixes the following Clang 7 warnings: ``` editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual] servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual] core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] ```
2018-10-02 10:07:44 +00:00
quick_open->popup_dialog("PackedScene", true);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 17:36:01 +00:00
quick_open->set_title(TTR("Quick Open Scene..."));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case FILE_QUICK_OPEN_SCRIPT: {
Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor] Fixes the following Clang 7 warnings: ``` editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual] servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual] core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] ```
2018-10-02 10:07:44 +00:00
quick_open->popup_dialog("Script", true);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 17:36:01 +00:00
quick_open->set_title(TTR("Quick Open Script..."));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case FILE_OPEN_PREV: {
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (previous_scenes.is_empty()) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
opening_prev = true;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
open_request(previous_scenes.back()->get());
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
previous_scenes.pop_back();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
} break;
case FILE_CLOSE_OTHERS:
case FILE_CLOSE_RIGHT:
case FILE_CLOSE_ALL: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (editor_data.get_edited_scene_count() > 1 && (current_menu_option != FILE_CLOSE_RIGHT || editor_data.get_edited_scene() < editor_data.get_edited_scene_count() - 1)) {
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
int next_tab = editor_data.get_edited_scene() + 1;
next_tab %= editor_data.get_edited_scene_count();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
_scene_tab_closed(next_tab, current_menu_option);
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (current_menu_option != FILE_CLOSE_ALL) {
current_menu_option = -1;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
_scene_tab_closed(editor_data.get_edited_scene());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_confirmed) {
Fix saving scenes when multi-closing scene tabs
2019-05-17 21:47:02 +00:00
_menu_option_confirm(SCENE_TAB_CLOSE, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fix saving scenes when multi-closing scene tabs
2019-05-17 21:47:02 +00:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
} break;
case FILE_CLOSE: {
Make closing current scene faster
2020-07-19 23:09:36 +00:00
_scene_tab_closed(editor_data.get_edited_scene());
} break;
case FILE_CLOSE_ALL_AND_QUIT:
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
case FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER:
case FILE_CLOSE_ALL_AND_RELOAD_CURRENT_PROJECT: {
Fixes prompt closes the wrong scene when exiting
2019-12-06 13:46:01 +00:00
if (!p_confirmed) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
tab_closing_idx = _next_unsaved_scene(false);
_scene_tab_changed(tab_closing_idx);
Fixes prompt closes the wrong scene when exiting
2019-12-06 13:46:01 +00:00
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
if (unsaved_cache || p_option == FILE_CLOSE_ALL_AND_QUIT || p_option == FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER || p_option == FILE_CLOSE_ALL_AND_RELOAD_CURRENT_PROJECT) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
Node *scene_root = editor_data.get_edited_scene_root(tab_closing_idx);
Fix crash on closing empty modified scene
2021-03-13 17:19:29 +00:00
if (scene_root) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
String scene_filename = scene_root->get_scene_file_path();
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
if (p_option == FILE_CLOSE_ALL_AND_RELOAD_CURRENT_PROJECT) {
save_confirmation->get_ok_button()->set_text(TTR("Save & Reload"));
save_confirmation->set_text(vformat(TTR("Save changes to '%s' before reloading?"), !scene_filename.is_empty() ? scene_filename : "unsaved scene"));
} else {
save_confirmation->get_ok_button()->set_text(TTR("Save & Quit"));
save_confirmation->set_text(vformat(TTR("Save changes to '%s' before closing?"), !scene_filename.is_empty() ? scene_filename : "unsaved scene"));
}
Fix crash on closing empty modified scene
2021-03-13 17:19:29 +00:00
save_confirmation->popup_centered();
break;
}
Fixes prompt closes the wrong scene when exiting
2019-12-06 13:46:01 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (!editor_data.get_edited_scene_root(tab_closing_idx)) {
// Empty tab.
_scene_tab_closed(tab_closing_idx);
context menu improvements
2018-01-02 07:10:49 +00:00
break;
}
Fixed close current scene closing the wrong scene, issue 13844
2017-12-10 12:48:03 +00:00
Replace FALLTHROUGH macro by C++17 [[fallthrough]] This attribute is now part of the standard we target so we no longer need compiler-specific hacks. Also enables -Wimplicit-fallthrough for Clang now that we can properly support it. It's already on by default for GCC's -Wextra. Fixes new warnings raised by Clang's -Wimplicit-fallthrough.
2020-02-22 19:47:50 +00:00
[[fallthrough]];
Fix -Wimplicit-fallthrough warnings from GCC 8 Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional. Can be replaced by `[[fallthrough]]` if/when we switch to C++17. The warning is now enabled by default for GCC on `extra` warnings level (part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet, but we could enable it manually once we switch to C++11. There's no equivalent feature in MSVC for now. Fixes #26135.
2019-04-05 12:06:16 +00:00
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
case SCENE_TAB_CLOSE:
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case FILE_SAVE_SCENE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
int scene_idx = (p_option == FILE_SAVE_SCENE) ? -1 : tab_closing_idx;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
Node *scene = editor_data.get_edited_scene_root(scene_idx);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (scene && !scene->get_scene_file_path().is_empty()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
if (DirAccess::exists(scene->get_scene_file_path().get_base_dir())) {
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 01:35:13 +00:00
if (scene_idx != editor_data.get_edited_scene()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
_save_scene_with_preview(scene->get_scene_file_path(), scene_idx);
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 01:35:13 +00:00
} else {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
_save_scene_with_preview(scene->get_scene_file_path());
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 01:35:13 +00:00
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 01:35:13 +00:00
if (scene_idx != -1) {
_discard_changes();
}
save_layout();
} else {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
show_save_accept(vformat(TTR("%s no longer exists! Please specify a new save location."), scene->get_scene_file_path().get_base_dir()), TTR("OK"));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
break;
}
Replace FALLTHROUGH macro by C++17 [[fallthrough]] This attribute is now part of the standard we target so we no longer need compiler-specific hacks. Also enables -Wimplicit-fallthrough for Clang now that we can properly support it. It's already on by default for GCC's -Wextra. Fixes new warnings raised by Clang's -Wimplicit-fallthrough.
2020-02-22 19:47:50 +00:00
[[fallthrough]];
Fix -Wimplicit-fallthrough warnings from GCC 8 Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional. Can be replaced by `[[fallthrough]]` if/when we switch to C++17. The warning is now enabled by default for GCC on `extra` warnings level (part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet, but we could enable it manually once we switch to C++11. There's no equivalent feature in MSVC for now. Fixes #26135.
2019-04-05 12:06:16 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case FILE_SAVE_AS_SCENE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
int scene_idx = (p_option == FILE_SAVE_SCENE || p_option == FILE_SAVE_AS_SCENE) ? -1 : tab_closing_idx;
remove trailing whitespace
2016-03-08 23:00:52 +00:00
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
Node *scene = editor_data.get_edited_scene_root(scene_idx);
remove trailing whitespace
2016-03-08 23:00:52 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (!scene) {
Save the current script when pressing Ctrl + S if no scene is open - Tweak the dialog messages to be more informative. - The "Saved N modified resources" dialog is not a warning per se, so make it more explicit.
2021-05-09 10:29:50 +00:00
if (p_option == FILE_SAVE_SCENE) {
// Pressing Ctrl + S saves the current script if a scene is currently open, but it won't if the scene has no root node.
// Work around this by explicitly saving the script in this case (similar to pressing Ctrl + Alt + S).
ScriptEditor::get_singleton()->save_current_script();
}
const int saved = _save_external_resources();
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
if (saved > 0) {
Save the current script when pressing Ctrl + S if no scene is open - Tweak the dialog messages to be more informative. - The "Saved N modified resources" dialog is not a warning per se, so make it more explicit.
2021-05-09 10:29:50 +00:00
show_accept(
vformat(TTR("The current scene has no root node, but %d modified external resource(s) were saved anyway."), saved),
TTR("OK"));
} else if (p_option == FILE_SAVE_AS_SCENE) {
// Don't show this dialog when pressing Ctrl + S to avoid interfering with script saving.
show_accept(
TTR("A root node is required to save the scene. You can add a root node using the Scene tree dock."),
TTR("OK"));
Save resources even if no scene is present, closes #26273
2019-02-27 23:00:40 +00:00
}
remove trailing whitespace
2016-03-08 23:00:52 +00:00
break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
remove trailing whitespace
2016-03-08 23:00:52 +00:00
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
file->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Ref<PackedScene> sd = memnew(PackedScene);
ResourceSaver::get_recognized_extensions(sd, &extensions);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
file->clear_filters();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < extensions.size(); i++) {
file->add_filter("*." + extensions[i] + " ; " + extensions[i].to_upper());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
remove trailing whitespace
2016-03-08 23:00:52 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!scene->get_scene_file_path().is_empty()) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
String path = scene->get_scene_file_path();
Enhance editor file dialog 1. show valid directory path when opening editor file dialog 2. keep file name when changing path by entering path 3. add first extension in filter automatically if not given 4. remove directory in recent list if it's not valid anymore
2020-10-13 18:28:45 +00:00
file->set_current_path(path);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (extensions.size()) {
Enhance editor file dialog 1. show valid directory path when opening editor file dialog 2. keep file name when changing path by entering path 3. add first extension in filter automatically if not given 4. remove directory in recent list if it's not valid anymore
2020-10-13 18:28:45 +00:00
String ext = path.get_extension().to_lower();
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
if (extensions.find(ext) == nullptr) {
Enhance editor file dialog 1. show valid directory path when opening editor file dialog 2. keep file name when changing path by entering path 3. add first extension in filter automatically if not given 4. remove directory in recent list if it's not valid anymore
2020-10-13 18:28:45 +00:00
file->set_current_path(path.replacen("." + ext, "." + extensions.front()->get()));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
Add project setting to change scene file casing
2021-09-12 11:21:24 +00:00
} else if (extensions.size()) {
String root_name = scene->get_name();
// Very similar to node naming logic.
switch (ProjectSettings::get_singleton()->get("editor/scene/scene_naming").operator int()) {
case SCENE_NAME_CASING_AUTO:
// Use casing of the root node.
break;
case SCENE_NAME_CASING_PASCAL_CASE: {
root_name = root_name.capitalize().replace(" ", "");
} break;
case SCENE_NAME_CASING_SNAKE_CASE:
root_name = root_name.capitalize().replace(" ", "").replace("-", "_").camelcase_to_underscore();
break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Add project setting to change scene file casing
2021-09-12 11:21:24 +00:00
file->set_current_path(root_name + "." + extensions.front()->get().to_lower());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 16:45:19 +00:00
file->popup_file_dialog();
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 17:36:01 +00:00
file->set_title(TTR("Save Scene As..."));
remove trailing whitespace
2016-03-08 23:00:52 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 03:54:17 +00:00
case FILE_SAVE_ALL_SCENES: {
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
_save_all_scenes();
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 22:28:25 +00:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case FILE_EXPORT_PROJECT: {
Editor Export Settings Dialog is completed!! Now on to make some exporters..
2017-02-20 02:19:30 +00:00
project_export->popup_export();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case FILE_EXPORT_MESH_LIBRARY: {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
if (!editor_data.get_edited_scene_root()) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("This operation can't be done without a scene."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
break;
}
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Ref<MeshLibrary> ml(memnew(MeshLibrary));
ResourceSaver::get_recognized_extensions(ml, &extensions);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
file_export_lib->clear_filters();
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const String &E : extensions) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
file_export_lib->add_filter("*." + E);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 16:45:19 +00:00
file_export_lib->popup_file_dialog();
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
file_export_lib->set_title(TTR("Export Mesh Library"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case FILE_EXTERNAL_OPEN_SCENE: {
if (unsaved_cache && !p_confirmed) {
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
confirmation->get_ok_button()->set_text(TTR("Open"));
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
confirmation->set_text(TTR("Current scene not saved. Open anyway?"));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
confirmation->popup_centered();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
break;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool oprev = opening_prev;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Error err = load_scene(external_file);
if (err == OK && oprev) {
previous_scenes.pop_back();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
opening_prev = false;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
} break;
case EDIT_UNDO: {
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if ((int)Input::get_singleton()->get_mouse_button_mask() & 0x7) {
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 03:41:46 +00:00
log->add_message(TTR("Can't undo while mouse buttons are pressed."), EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 02:41:19 +00:00
} else {
String action = editor_data.get_undo_redo().get_current_action_name();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Add a message when there is nothing to Undo or Redo
2018-05-27 02:41:19 +00:00
if (!editor_data.get_undo_redo().undo()) {
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 03:41:46 +00:00
log->add_message(TTR("Nothing to undo."), EditorLog::MSG_TYPE_EDITOR);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
} else if (!action.is_empty()) {
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 03:41:46 +00:00
log->add_message(vformat(TTR("Undo: %s"), action), EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 02:41:19 +00:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case EDIT_REDO: {
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if ((int)Input::get_singleton()->get_mouse_button_mask() & 0x7) {
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 03:41:46 +00:00
log->add_message(TTR("Can't redo while mouse buttons are pressed."), EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 02:41:19 +00:00
} else {
if (!editor_data.get_undo_redo().redo()) {
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 03:41:46 +00:00
log->add_message(TTR("Nothing to redo."), EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 02:41:19 +00:00
} else {
String action = editor_data.get_undo_redo().get_current_action_name();
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 03:41:46 +00:00
log->add_message(vformat(TTR("Redo: %s"), action), EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 02:41:19 +00:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Add a revert menu item.
2015-01-25 00:14:06 +00:00
Rename the editor action "Revert Scene" to "Reload Saved Scene" This option can be used to workaround various issues with stuff not reloading properly when changes are made. The option was renamed to clarify the fact that it actually reloads the scene saved on the filesystem.
2020-05-10 18:12:25 +00:00
case EDIT_RELOAD_SAVED_SCENE: {
Add a revert menu item.
2015-01-25 00:14:06 +00:00
Node *scene = get_edited_scene();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!scene) {
Add a revert menu item.
2015-01-25 00:14:06 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 21:28:30 +00:00
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
String filename = scene->get_scene_file_path();
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 21:28:30 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (filename.is_empty()) {
i18n: Proofreading of all strings Done to ensure that no important identifiers are translatable, to fix compound strings using the new vformat() function, and some general English proofreading here and there.
2016-05-18 22:08:12 +00:00
show_warning(TTR("Can't reload a scene that was never saved."));
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 21:28:30 +00:00
break;
}
Show a confirmation for the revert action.
2015-01-27 00:00:07 +00:00
if (unsaved_cache && !p_confirmed) {
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
confirmation->get_ok_button()->set_text(TTR("Reload Saved Scene"));
Rename the editor action "Revert Scene" to "Reload Saved Scene" This option can be used to workaround various issues with stuff not reloading properly when changes are made. The option was renamed to clarify the fact that it actually reloads the scene saved on the filesystem.
2020-05-10 18:12:25 +00:00
confirmation->set_text(
TTR("The current scene has unsaved changes.\nReload the saved scene anyway? This action cannot be undone."));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
confirmation->popup_centered();
Show a confirmation for the revert action.
2015-01-27 00:00:07 +00:00
break;
}
Add a revert menu item.
2015-01-25 00:14:06 +00:00
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 21:28:30 +00:00
int cur_idx = editor_data.get_edited_scene();
_remove_edited_scene();
Error err = load_scene(filename);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (err != OK) {
Fix unused variable warnings The forth in my quest to make Godot 3.x compile with -Werror on GCC7
2017-09-02 20:32:31 +00:00
ERR_PRINT("Failed to load scene");
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 21:28:30 +00:00
editor_data.move_edited_scene_to_index(cur_idx);
Add argument to UndoRedo's "clear_history()" to not increase the version
2018-11-18 20:07:38 +00:00
get_undo_redo()->clear_history(false);
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 21:28:30 +00:00
scene_tabs->set_current_tab(cur_idx);
Add a revert menu item.
2015-01-25 00:14:06 +00:00
Bug Fixes -=-=-=-=- -Fixed problem with scaling shapes (#827), related to not taking scale in consideration for calculating the moment of inertia -Added support for multiline strings (or comments) using """ -Save subscene bug, properties not being saved in root node (#806) -Fix Crash in CollisionPolygon2DEditor (#814) -Restored Ability to compile without 3D (#795) -Fix InterpolatedCamera (#803) -Fix UV Import for OBJ Meshes (#771) -Fixed issue with modifier gizmos (#794) -Fixed CapsuleShape gizmo handle (#50) -Fixed Import Button (not properly working in 3D) (#733) -Many misc fixes (though no new features)
2014-11-02 14:31:01 +00:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case RUN_PLAY: {
Expose methods to play scene from plugin code
2020-04-05 14:19:24 +00:00
run_play();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case RUN_PLAY_CUSTOM_SCENE: {
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (run_custom_filename.is_empty() || editor_run.get_status() == EditorRun::STATUS_STOP) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
_menu_option_confirm(RUN_STOP, true);
Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor] Fixes the following Clang 7 warnings: ``` editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual] servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual] core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] ```
2018-10-02 10:07:44 +00:00
quick_run->popup_dialog("PackedScene", true);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 17:36:01 +00:00
quick_run->set_title(TTR("Quick Run Scene..."));
Keep 'Play custom scene' button unpressed when not running
2016-02-18 12:16:31 +00:00
play_custom_scene_button->set_pressed(false);
Added option to restart custom scene
2016-02-17 19:51:56 +00:00
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
String last_custom_scene = run_custom_filename;
Expose methods to play scene from plugin code
2020-04-05 14:19:24 +00:00
run_play_custom(last_custom_scene);
Added option to restart custom scene
2016-02-17 19:51:56 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
case RUN_STOP: {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (editor_run.get_status() == EditorRun::STATUS_STOP) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
editor_run.stop();
Added option to restart custom scene
2016-02-17 19:51:56 +00:00
run_custom_filename.clear();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_button->set_pressed(false);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_button->set_icon(gui_base->get_theme_icon(SNAME("MainPlay"), SNAME("EditorIcons")));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_scene_button->set_pressed(false);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_scene_button->set_icon(gui_base->get_theme_icon(SNAME("PlayScene"), SNAME("EditorIcons")));
Added option to restart custom scene
2016-02-17 19:51:56 +00:00
play_custom_scene_button->set_pressed(false);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_custom_scene_button->set_icon(gui_base->get_theme_icon(SNAME("PlayCustom"), SNAME("EditorIcons")));
Fix stop button always enabled (issue #13933)
2017-12-04 19:48:46 +00:00
stop_button->set_disabled(true);
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 21:02:16 +00:00
if (bool(EDITOR_GET("run/output/always_close_output_on_stop"))) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == log) {
_bottom_panel_switch(false, i);
Add editor option for automatically closing the output when stopping the game.
2017-02-06 16:50:01 +00:00
break;
}
}
}
Support multiple debug protocols.
2020-03-16 08:37:43 +00:00
EditorDebuggerNode::get_singleton()->stop();
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("stop_pressed"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Replace the -show in filesystem- button by a RMB entry
2018-09-13 17:06:40 +00:00
case FILE_SHOW_IN_FILESYSTEM: {
String path = editor_data.get_scene_path(editor_data.get_edited_scene());
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!path.is_empty()) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
FileSystemDock::get_singleton()->navigate_to_path(path);
Replace the -show in filesystem- button by a RMB entry
2018-09-13 17:06:40 +00:00
}
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case RUN_PLAY_SCENE: {
Expose methods to play scene from plugin code
2020-04-05 14:19:24 +00:00
run_play_current();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Merged the file server with the live editing and remote debug -It is now really easy to deploy an android build with debug, and debug it
2015-08-06 05:37:40 +00:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case RUN_SETTINGS: {
Minor fixes/refactoring of project and editor setting dialogs
2022-01-31 23:19:01 +00:00
project_settings_editor->popup_project_settings();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
case FILE_INSTALL_ANDROID_SOURCE: {
if (p_confirmed) {
export_template_manager->install_android_template();
} else {
if (DirAccess::exists("res://android/build")) {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
remove_android_build_template->popup_centered();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
} else if (export_template_manager->can_install_android_template()) {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
install_android_build_template->popup_centered();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
} else {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
custom_build_manage_templates->popup_centered();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
}
}
} break;
Reword "Open Project Data Folder" as "Open User Data Folder" Clarifies that the button opens the user:// dir and for better consistency with certain ProjectSettings values: "Use Hidden Project Data Directory" is named similarly, but refers to data within res:// and two values refer to user:// as "User Dir" (Translations were not updated) and rename enum value accordingly
2021-12-28 00:51:45 +00:00
case RUN_USER_DATA_FOLDER: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Ensure_user_data_dir() to prevent the edge case: "Open User Data Folder" won't work after the project was renamed in ProjectSettingsEditor unless the project is saved.
creater user-dir, if non-existant and pressing 'Open Project Data Folder'
2020-09-13 12:49:53 +00:00
OS::get_singleton()->ensure_user_data_dir();
Fixed unable to open project data folder Removed `default` case to prevent hiding such errors in the future. Fixes #31939.
2019-09-04 17:46:12 +00:00
OS::get_singleton()->shell_open(String("file://") + OS::get_singleton()->get_user_data_dir());
} break;
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
case FILE_EXPLORE_ANDROID_BUILD_TEMPLATES: {
Remove useless cast from c-string to String
2019-06-16 12:12:01 +00:00
OS::get_singleton()->shell_open("file://" + ProjectSettings::get_singleton()->get_resource_path().plus_file("android"));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
} break;
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
case FILE_QUIT:
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
case RUN_PROJECT_MANAGER:
case RELOAD_CURRENT_PROJECT: {
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 04:21:06 +00:00
if (!p_confirmed) {
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 21:02:16 +00:00
bool save_each = EDITOR_GET("interface/editor/save_each_scene_on_quit");
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 11:29:45 +00:00
if (_next_unsaved_scene(!save_each) == -1) {
Remove the editor quit confirmation The editor will still ask for confirmation if the user is working on unsaved scenes.
2019-09-24 21:06:21 +00:00
_discard_changes();
break;
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
} else {
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
if (save_each) {
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
if (p_option == RELOAD_CURRENT_PROJECT) {
_menu_option_confirm(FILE_CLOSE_ALL_AND_RELOAD_CURRENT_PROJECT, false);
} else if (p_option == FILE_QUIT) {
_menu_option_confirm(FILE_CLOSE_ALL_AND_QUIT, false);
} else {
_menu_option_confirm(FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER, false);
}
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
} else {
String unsaved_scenes;
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 11:29:45 +00:00
int i = _next_unsaved_scene(true, 0);
while (i != -1) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
unsaved_scenes += "\n " + editor_data.get_edited_scene_root(i)->get_scene_file_path();
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 11:29:45 +00:00
i = _next_unsaved_scene(true, ++i);
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
}
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
if (p_option == RELOAD_CURRENT_PROJECT) {
save_confirmation->get_ok_button()->set_text(TTR("Save & Reload"));
save_confirmation->set_text(TTR("Save changes to the following scene(s) before reloading?") + unsaved_scenes);
} else {
save_confirmation->get_ok_button()->set_text(TTR("Save & Quit"));
save_confirmation->set_text((p_option == FILE_QUIT ? TTR("Save changes to the following scene(s) before quitting?") : TTR("Save changes to the following scene(s) before opening Project Manager?")) + unsaved_scenes);
}
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
save_confirmation->popup_centered();
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
}
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
}
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
DisplayServer::get_singleton()->window_request_attention();
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
break;
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
}
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 04:21:06 +00:00
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 11:29:45 +00:00
if (_next_unsaved_scene(true) != -1) {
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
_save_all_scenes();
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
}
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
_discard_changes();
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 04:21:06 +00:00
} break;
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
case SETTINGS_UPDATE_CONTINUOUSLY: {
EditorSettings::get_singleton()->set("interface/editor/update_continuously", true);
_update_update_spinner();
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("This option is deprecated. Situations where refresh must be forced are now considered a bug. Please report."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
case SETTINGS_UPDATE_WHEN_CHANGED: {
EditorSettings::get_singleton()->set("interface/editor/update_continuously", false);
_update_update_spinner();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
case SETTINGS_UPDATE_SPINNER_HIDE: {
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
EditorSettings::get_singleton()->set("interface/editor/show_update_spinner", false);
_update_update_spinner();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
case SETTINGS_PREFERENCES: {
Minor fixes/refactoring of project and editor setting dialogs
2022-01-31 23:19:01 +00:00
editor_settings_dialog->popup_edit_settings();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Add menu buttons to open the project and editor data folders
2018-07-25 17:53:12 +00:00
case SETTINGS_EDITOR_DATA_FOLDER: {
Implement shader caching * Shader compilation is now cached. Subsequent loads take less than a millisecond. * Improved game, editor and project manager startup time. * Editor uses .godot/shader_cache to store shaders. * Game uses user://shader_cache * Project manager uses $config_dir/shader_cache * Options to tweak shader caching in project settings. * Editor path configuration moved from EditorSettings to new class, EditorPaths, so it can be available early on (before shaders are compiled). * Reworked ShaderCompilerRD to ensure deterministic shader code creation (else shader may change and cache will be invalidated). * Added shader compression with SMOLV: https://github.com/aras-p/smol-v
2021-05-25 00:25:11 +00:00
OS::get_singleton()->shell_open(String("file://") + EditorPaths::get_singleton()->get_data_dir());
Add menu buttons to open the project and editor data folders
2018-07-25 17:53:12 +00:00
} break;
case SETTINGS_EDITOR_CONFIG_FOLDER: {
Replace get_settings_dir with get_config_dir when fetching configuration paths
2021-06-03 15:24:07 +00:00
OS::get_singleton()->shell_open(String("file://") + EditorPaths::get_singleton()->get_config_dir());
Add menu buttons to open the project and editor data folders
2018-07-25 17:53:12 +00:00
} break;
Export template management dialog. Missing download (need to discuss this!)
2017-03-21 02:31:41 +00:00
case SETTINGS_MANAGE_EXPORT_TEMPLATES: {
export_template_manager->popup_manager();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
} break;
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 13:12:56 +00:00
case SETTINGS_INSTALL_ANDROID_BUILD_TEMPLATE: {
custom_build_manage_templates->hide();
file_android_build_source->popup_centered_ratio();
} break;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
case SETTINGS_MANAGE_FEATURE_PROFILES: {
Add Popup::popup_centered_clamped method - Also replace redundant duplicate code in editor dialogs with calls to popup_centered_clamped()
2019-04-26 19:36:44 +00:00
feature_profile_manager->popup_centered_clamped(Size2(900, 800) * EDSCALE, 0.8);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 12:46:17 +00:00
} break;
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 05:53:25 +00:00
case SETTINGS_TOGGLE_FULLSCREEN: {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
DisplayServer::get_singleton()->window_set_mode(DisplayServer::get_singleton()->window_get_mode() == DisplayServer::WINDOW_MODE_FULLSCREEN ? DisplayServer::WINDOW_MODE_WINDOWED : DisplayServer::WINDOW_MODE_FULLSCREEN);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 12:46:17 +00:00
Add option to toggle console window on Windows This is an editor setting and its value can also be toggled using an entry in the Editor toolbar. The console will still appear briefly when starting the project manager or editor, as it's still compiled as console application. Does not impact exported games, which will still run without console in release and with console in debug mode. A project setting or export option could be added to disable it in debug mode if there's demand for it, but that would greatly reduce the usefulness of debug builds if Windows users can no longer report error and crash messages. Fixes #17889. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2018-12-18 13:17:43 +00:00
} break;
Add editor screenshot on control - f12.
2019-03-29 13:53:11 +00:00
case EDITOR_SCREENSHOT: {
screenshot_timer->start();
} break;
Ask about selecting a main scene if one has not been selected.
2016-06-27 22:59:33 +00:00
case SETTINGS_PICK_MAIN_SCENE: {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
file->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
Ask about selecting a main scene if one has not been selected.
2016-06-27 22:59:33 +00:00
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ResourceLoader::get_recognized_extensions_for_type("PackedScene", &extensions);
Ask about selecting a main scene if one has not been selected.
2016-06-27 22:59:33 +00:00
file->clear_filters();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < extensions.size(); i++) {
file->add_filter("*." + extensions[i] + " ; " + extensions[i].to_upper());
Ask about selecting a main scene if one has not been selected.
2016-06-27 22:59:33 +00:00
}
Node *scene = editor_data.get_edited_scene_root();
if (scene) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
file->set_current_path(scene->get_scene_file_path());
Ask about selecting a main scene if one has not been selected.
2016-06-27 22:59:33 +00:00
};
i18n: Corrected a typo (#5460)
2016-06-28 10:00:18 +00:00
file->set_title(TTR("Pick a Main Scene"));
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 16:45:19 +00:00
file->popup_file_dialog();
Ask about selecting a main scene if one has not been selected.
2016-06-27 22:59:33 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
case HELP_SEARCH: {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("request_help_search"), "");
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
} break;
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
case HELP_COMMAND_PALETTE: {
command_palette->open_popup();
} break;
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
case HELP_DOCS: {
Use versioned URL for "Online Documentation" buttons in the editor This also avoids a redirect, making the page appear to load faster.
2022-02-17 17:16:11 +00:00
OS::get_singleton()->shell_open(VERSION_DOCS_URL "/");
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
} break;
case HELP_QA: {
OS::get_singleton()->shell_open("https://godotengine.org/qa/");
} break;
Remove Request Docs button in the script editor due to various issues The Request Docs button is partly responsible for layout overflow issues on narrow displays, such as #31133. It also tended to attract spam and low-effort issues that were difficult to act upon. A "Send Docs Feedback" menu option has been added to replace it.
2020-01-29 22:10:09 +00:00
case HELP_REPORT_A_BUG: {
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
OS::get_singleton()->shell_open("https://github.com/godotengine/godot/issues");
} break;
Add "Suggest a Feature" to the help dialog. Links to Godot Proposals's readme.
2021-06-16 00:24:34 +00:00
case HELP_SUGGEST_A_FEATURE: {
OS::get_singleton()->shell_open("https://github.com/godotengine/godot-proposals#readme");
} break;
Remove Request Docs button in the script editor due to various issues The Request Docs button is partly responsible for layout overflow issues on narrow displays, such as #31133. It also tended to attract spam and low-effort issues that were difficult to act upon. A "Send Docs Feedback" menu option has been added to replace it.
2020-01-29 22:10:09 +00:00
case HELP_SEND_DOCS_FEEDBACK: {
OS::get_singleton()->shell_open("https://github.com/godotengine/godot-docs/issues");
} break;
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
case HELP_COMMUNITY: {
OS::get_singleton()->shell_open("https://godotengine.org/community");
} break;
case HELP_ABOUT: {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
about->popup_centered(Size2(780, 500) * EDSCALE);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
} break;
Add "Support Godot Development" option to the editor's Help menu
2021-05-14 23:57:21 +00:00
case HELP_SUPPORT_GODOT_DEVELOPMENT: {
OS::get_singleton()->shell_open("https://godotengine.org/donate");
} break;
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
case SET_RENDERING_DRIVER_SAVE_AND_RESTART: {
ProjectSettings::get_singleton()->set("rendering/driver/driver_name", rendering_driver_request);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
ProjectSettings::get_singleton()->save();
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 20:23:56 +00:00
save_all_scenes();
restart_editor();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
} break;
remove trailing whitespace
2016-03-08 23:00:52 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Add editor screenshot on control - f12.
2019-03-29 13:53:11 +00:00
void EditorNode::_request_screenshot() {
_screenshot();
}
void EditorNode::_screenshot(bool p_use_utc) {
Add Time singleton
2021-05-24 11:54:05 +00:00
String name = "editor_screenshot_" + Time::get_singleton()->get_datetime_string_from_system(p_use_utc).replace(":", "") + ".png";
Add editor screenshot on control - f12.
2019-03-29 13:53:11 +00:00
NodePath path = String("user://") + name;
_save_screenshot(path);
Move "Open Screenshot" from the "Editor" menu to the editor settings
2019-07-23 05:05:29 +00:00
if (EditorSettings::get_singleton()->get("interface/editor/automatically_open_screenshots")) {
Add editor screenshot on control - f12.
2019-03-29 13:53:11 +00:00
OS::get_singleton()->shell_open(String("file://") + ProjectSettings::get_singleton()->globalize_path(path));
}
}
void EditorNode::_save_screenshot(NodePath p_path) {
Rename EditorInterface get_editor_viewport to get_editor_main_control
2020-12-19 14:17:42 +00:00
Control *editor_main_control = EditorInterface::get_singleton()->get_editor_main_control();
ERR_FAIL_COND_MSG(!editor_main_control, "Cannot get editor main control.");
Viewport *viewport = editor_main_control->get_viewport();
ERR_FAIL_COND_MSG(!viewport, "Cannot get editor main control viewport.");
Restore screenshot button.
2020-11-11 22:12:31 +00:00
Ref<ViewportTexture> texture = viewport->get_texture();
Rename EditorInterface get_editor_viewport to get_editor_main_control
2020-12-19 14:17:42 +00:00
ERR_FAIL_COND_MSG(texture.is_null(), "Cannot get editor main control viewport texture.");
Rename Texture.get_data() to get_image()
2021-03-28 11:32:17 +00:00
Ref<Image> img = texture->get_image();
Rename EditorInterface get_editor_viewport to get_editor_main_control
2020-12-19 14:17:42 +00:00
ERR_FAIL_COND_MSG(img.is_null(), "Cannot get editor main control viewport texture image.");
Add editor screenshot on control - f12.
2019-03-29 13:53:11 +00:00
Error error = img->save_png(p_path);
Added some obvious errors explanations
2019-09-25 08:28:50 +00:00
ERR_FAIL_COND_MSG(error != OK, "Cannot save screenshot to file '" + p_path + "'.");
Add editor screenshot on control - f12.
2019-03-29 13:53:11 +00:00
}
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
void EditorNode::_tool_menu_option(int p_idx) {
switch (tool_menu->get_item_id(p_idx)) {
case TOOLS_ORPHAN_RESOURCES: {
orphan_resources->show();
} break;
case TOOLS_CUSTOM: {
if (tool_menu->get_item_submenu(p_idx) == "") {
Make tool menu plugins use Callables for callback
2020-12-15 23:04:21 +00:00
Callable callback = tool_menu->get_item_metadata(p_idx);
Reworked signal connection system, added support for Callable and Signal objects and made them default.
2020-02-19 19:27:19 +00:00
Callable::CallError ce;
Make tool menu plugins use Callables for callback
2020-12-15 23:04:21 +00:00
Variant result;
callback.call(nullptr, 0, result, ce);
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
Reworked signal connection system, added support for Callable and Signal objects and made them default.
2020-02-19 19:27:19 +00:00
if (ce.error != Callable::CallError::CALL_OK) {
Make tool menu plugins use Callables for callback
2020-12-15 23:04:21 +00:00
String err = Variant::get_callable_error_text(callback, nullptr, 0, ce);
Remove duplicate ERR_PRINT macro.
2019-11-06 16:03:04 +00:00
ERR_PRINT("Error calling function from tool menu: " + err);
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
} // Else it's a submenu so don't do anything.
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
} break;
}
}
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 11:29:45 +00:00
int EditorNode::_next_unsaved_scene(bool p_valid_filename, int p_start) {
for (int i = p_start; i < editor_data.get_edited_scene_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!editor_data.get_edited_scene_root(i)) {
Fix crash on closing [empty](*) scene tab
2017-07-09 18:48:39 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
int current = editor_data.get_edited_scene();
bool unsaved = (i == current) ? saved_version != editor_data.get_undo_redo().get_version() : editor_data.get_scene_version(i) != 0;
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
if (unsaved) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
String scene_filename = editor_data.get_edited_scene_root(i)->get_scene_file_path();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_valid_filename && scene_filename.length() == 0) {
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 11:29:45 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
return i;
}
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
}
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
return -1;
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
}
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 11:48:12 +00:00
void EditorNode::_exit_editor(int p_exit_code) {
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 12:09:01 +00:00
exiting = true;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
resource_preview->stop(); // Stop early to avoid crashes.
Restore script editor state between sessions
2019-04-13 11:43:35 +00:00
_save_docks();
Dim the editor window while it's quitting This makes it clearer that the editor window is busy while it's quitting (which can take a while on slower PCs). This also makes it feel more responsive to user input. Note that the effect is only visible if "Interface > Editor > Quit Confirmation" is disabled in the Editor Settings, as the quit confirmation already makes the editor window dim while quitting.
2019-07-04 21:45:51 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Dim the editor window while it's quitting to make it clearer that it's busy.
Remove `dim_editor_on_dialog_popup` from editor settings
2021-05-28 23:58:03 +00:00
dim_editor(true);
Dim the editor window while it's quitting This makes it clearer that the editor window is busy while it's quitting (which can take a while on slower PCs). This also makes it feel more responsive to user input. Note that the effect is only visible if "Interface > Editor > Quit Confirmation" is disabled in the Editor Settings, as the quit confirmation already makes the editor window dim while quitting.
2019-07-04 21:45:51 +00:00
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 11:48:12 +00:00
get_tree()->quit(p_exit_code);
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 12:09:01 +00:00
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
void EditorNode::_discard_changes(const String &p_str) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
switch (current_menu_option) {
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
case FILE_CLOSE_ALL_AND_QUIT:
case FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER:
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
case FILE_CLOSE_ALL_AND_RELOAD_CURRENT_PROJECT:
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
case FILE_CLOSE:
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
case FILE_CLOSE_OTHERS:
case FILE_CLOSE_RIGHT:
case FILE_CLOSE_ALL:
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
case SCENE_TAB_CLOSE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
Node *scene = editor_data.get_edited_scene_root(tab_closing_idx);
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
if (scene != nullptr) {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
String scene_filename = scene->get_scene_file_path();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!scene_filename.is_empty()) {
Don't add unsaved scene to previous scenes list
2019-07-31 21:49:16 +00:00
previous_scenes.push_back(scene_filename);
}
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
_remove_scene(tab_closing_idx);
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
_update_scene_tabs();
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (current_menu_option == FILE_CLOSE_ALL_AND_QUIT || current_menu_option == FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER || current_menu_option == FILE_CLOSE_ALL_AND_RELOAD_CURRENT_PROJECT) {
Fix #33326 by reopening scenes
2020-02-19 09:36:26 +00:00
// If restore tabs is enabled, reopen the scene that has just been closed, so it's remembered properly.
if (bool(EDITOR_GET("interface/scene_tabs/restore_scenes_on_load"))) {
_menu_option_confirm(FILE_OPEN_PREV, true);
}
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 11:29:45 +00:00
if (_next_unsaved_scene(false) == -1) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (current_menu_option == FILE_CLOSE_ALL_AND_RELOAD_CURRENT_PROJECT) {
current_menu_option = RELOAD_CURRENT_PROJECT;
} else if (current_menu_option == FILE_CLOSE_ALL_AND_QUIT) {
current_menu_option = FILE_QUIT;
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = RUN_PROJECT_MANAGER;
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
}
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
_discard_changes();
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
_menu_option_confirm(current_menu_option, false);
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
} else if (current_menu_option == FILE_CLOSE_OTHERS || current_menu_option == FILE_CLOSE_RIGHT) {
if (editor_data.get_edited_scene_count() == 1 || (current_menu_option == FILE_CLOSE_RIGHT && editor_data.get_edited_scene_count() <= editor_data.get_edited_scene() + 1)) {
current_menu_option = -1;
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
save_confirmation->hide();
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
_menu_option_confirm(current_menu_option, false);
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
} else if (current_menu_option == FILE_CLOSE_ALL && editor_data.get_edited_scene_count() > 0) {
_menu_option_confirm(current_menu_option, false);
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = -1;
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
save_confirmation->hide();
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
} break;
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
case FILE_QUIT: {
_menu_option_confirm(RUN_STOP, true);
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 11:48:12 +00:00
_exit_editor(EXIT_SUCCESS);
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 12:09:01 +00:00
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
} break;
case RUN_PROJECT_MANAGER: {
_menu_option_confirm(RUN_STOP, true);
Replace use of `OS::set_exit_code()` by `SceneTree::quit()` in `EditorNode`
2022-01-18 11:48:12 +00:00
_exit_editor(EXIT_SUCCESS);
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
String exec = OS::get_singleton()->get_executable_path();
List<String> args;
Tweak command-line arguments to make them more UNIX-like Also improves the command-line help text readability.
2017-06-21 09:09:30 +00:00
args.push_back("--path");
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
args.push_back(exec.get_base_dir());
Tweak command-line arguments to make them more UNIX-like Also improves the command-line help text readability.
2017-06-21 09:09:30 +00:00
args.push_back("--project-manager");
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
[macOS] Add `create_instance` function to spawn editor copies. [macOS] Modify `create_project` function to detect and run app bundles using NSWorkspace to ensure app window is registered and activated correctly.
2021-11-01 09:12:52 +00:00
Error err = OS::get_singleton()->create_instance(args);
EditorNode: enhance quit dialog
2017-06-24 10:57:30 +00:00
ERR_FAIL_COND(err);
} break;
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
case RELOAD_CURRENT_PROJECT: {
restart_editor();
} break;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
}
}
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
void EditorNode::_update_file_menu_opened() {
Rename ShortCut to Shortcut which is more grammatically correct See https://github.com/godotengine/godot/issues/16863#issuecomment-685236980.
2020-09-09 19:53:24 +00:00
Ref<Shortcut> close_scene_sc = ED_GET_SHORTCUT("editor/close_scene");
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
close_scene_sc->set_name(TTR("Close Scene"));
Rename ShortCut to Shortcut which is more grammatically correct See https://github.com/godotengine/godot/issues/16863#issuecomment-685236980.
2020-09-09 19:53:24 +00:00
Ref<Shortcut> reopen_closed_scene_sc = ED_GET_SHORTCUT("editor/reopen_closed_scene");
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
reopen_closed_scene_sc->set_name(TTR("Reopen Closed Scene"));
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 03:41:46 +00:00
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
PopupMenu *pop = file_menu->get_popup();
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
pop->set_item_disabled(pop->get_item_index(FILE_OPEN_PREV), previous_scenes.is_empty());
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 03:41:46 +00:00
const UndoRedo &undo_redo = editor_data.get_undo_redo();
pop->set_item_disabled(pop->get_item_index(EDIT_UNDO), !undo_redo.has_undo());
pop->set_item_disabled(pop->get_item_index(EDIT_REDO), !undo_redo.has_redo());
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
}
void EditorNode::_update_file_menu_closed() {
PopupMenu *pop = file_menu->get_popup();
pop->set_item_disabled(pop->get_item_index(FILE_OPEN_PREV), false);
}
Rename EditorInterface get_editor_viewport to get_editor_main_control
2020-12-19 14:17:42 +00:00
Control *EditorNode::get_main_control() {
return main_control;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
void EditorNode::_editor_select(int p_which) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
static bool selecting = false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (selecting || changing_scene) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ERR_FAIL_INDEX(p_which, editor_table.size());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (!main_editor_buttons[p_which]->is_visible()) { // Button hidden, no editor.
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
selecting = true;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < main_editor_buttons.size(); i++) {
main_editor_buttons[i]->set_pressed(i == p_which);
-fixed tabs
2015-11-18 07:47:41 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
selecting = false;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
EditorPlugin *new_editor = editor_table[p_which];
ERR_FAIL_COND(!new_editor);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (editor_plugin_screen == new_editor) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (editor_plugin_screen) {
editor_plugin_screen->make_visible(false);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
editor_plugin_screen = new_editor;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
editor_plugin_screen->make_visible(true);
editor_plugin_screen->selected_notify();
Separate fullscreen state for scene & script editor
2017-04-25 11:48:35 +00:00
Make available more informations about editor for Tool Plugins
2017-07-06 07:18:20 +00:00
int plugin_count = editor_data.get_editor_plugin_count();
for (int i = 0; i < plugin_count; i++) {
editor_data.get_editor_plugin(i)->notify_main_screen_changed(editor_plugin_screen->get_name());
}
EditorSettings: Move interface/ properties to interface/editor Fixes inconsistent behaviour where clicking on the "Interface" in the Editor Settings wouldn't collapse the category as is the case for all the other categories.
2017-09-29 16:52:56 +00:00
if (EditorSettings::get_singleton()->get("interface/editor/separate_distraction_mode")) {
Separate fullscreen state for scene & script editor
2017-04-25 11:48:35 +00:00
if (p_which == EDITOR_SCRIPT) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
set_distraction_free_mode(script_distraction_free);
Separate fullscreen state for scene & script editor
2017-04-25 11:48:35 +00:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
set_distraction_free_mode(scene_distraction_free);
Separate fullscreen state for scene & script editor
2017-04-25 11:48:35 +00:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Let EditorPlugins set editor/distraction-free mode
2019-08-05 17:57:23 +00:00
void EditorNode::select_editor_by_name(const String &p_name) {
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
ERR_FAIL_COND(p_name.is_empty());
Let EditorPlugins set editor/distraction-free mode
2019-08-05 17:57:23 +00:00
for (int i = 0; i < main_editor_buttons.size(); i++) {
if (main_editor_buttons[i]->get_text() == p_name) {
_editor_select(i);
return;
}
}
Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in 'core/' and 'editor/' Condensed some if and ERR statements. Added dots to end of error messages Couldn't figure out EXPLAINC. These files gave me trouble: core/error_macros.h, core/io/file_access_buffered_fa.h (where is it?), core/os/memory.cpp, drivers/png/png_driver_common.cpp, drivers/xaudio2/audio_driver_xaudio2.cpp (where is it?)
2019-08-15 02:57:49 +00:00
ERR_FAIL_MSG("The editor name '" + p_name + "' was not found.");
Let EditorPlugins set editor/distraction-free mode
2019-08-05 17:57:23 +00:00
}
Added basic support for custom resource savers and loaders
2018-06-11 00:59:53 +00:00
void EditorNode::add_editor_plugin(EditorPlugin *p_editor, bool p_config_changed) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (p_editor->has_main_screen()) {
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
Button *tb = memnew(Button);
tb->set_flat(true);
-fixed tabs
2015-11-18 07:47:41 +00:00
tb->set_toggle_mode(true);
Signals: Manually port most of remaining connect_compat uses It's tedious work... Some can't be ported as they depend on private or protected methods of different classes, which is not supported by callable_mp (even if it's a class inherited by the current one).
2020-02-21 22:26:13 +00:00
tb->connect("pressed", callable_mp(singleton, &EditorNode::_editor_select), varray(singleton->main_editor_buttons.size()));
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 03:14:39 +00:00
tb->set_name(p_editor->get_name());
Revert "Add new editor and default theme (WIP)" This reverts commit f045efe007cffb87238ee519b7f33d710814ded7.
2017-05-02 21:02:06 +00:00
tb->set_text(p_editor->get_name());
Add method to set main screen plugin icon
2017-12-06 22:27:45 +00:00
Make default main screen plugin work even if 2D and 3D are disabled
2020-08-05 03:14:39 +00:00
Ref<Texture2D> icon = p_editor->get_icon();
Add method to set main screen plugin icon
2017-12-06 22:27:45 +00:00
if (icon.is_valid()) {
tb->set_icon(icon);
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
} else if (singleton->gui_base->has_theme_icon(p_editor->get_name(), SNAME("EditorIcons"))) {
tb->set_icon(singleton->gui_base->get_theme_icon(p_editor->get_name(), SNAME("EditorIcons")));
Add method to set main screen plugin icon
2017-12-06 22:27:45 +00:00
}
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
tb->add_theme_font_override("font", singleton->gui_base->get_theme_font(SNAME("main_button_font"), SNAME("EditorFonts")));
tb->add_theme_font_size_override("font_size", singleton->gui_base->get_theme_font_size(SNAME("main_button_font_size"), SNAME("EditorFonts")));
Use bold fonts in editor * Labels are now bold * Categories in trees are bold * Main editor buttons are bold * Fixed section folding arrows in inspector
2021-05-27 15:32:30 +00:00
-fixed tabs
2015-11-18 07:47:41 +00:00
singleton->main_editor_buttons.push_back(tb);
singleton->main_editor_button_vb->add_child(tb);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
singleton->editor_table.push_back(p_editor);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 12:46:17 +00:00
singleton->distraction_free->raise();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
singleton->editor_data.add_editor_plugin(p_editor);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
singleton->add_child(p_editor);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_config_changed) {
Added basic support for custom resource savers and loaders
2018-06-11 00:59:53 +00:00
p_editor->enable_plugin();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Added basic support for custom resource savers and loaders
2018-06-11 00:59:53 +00:00
void EditorNode::remove_editor_plugin(EditorPlugin *p_editor, bool p_config_changed) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (p_editor->has_main_screen()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < singleton->main_editor_buttons.size(); i++) {
if (p_editor->get_name() == singleton->main_editor_buttons[i]->get_text()) {
Fix crash when disabling main screen plugin
2016-09-21 22:17:55 +00:00
if (singleton->main_editor_buttons[i]->is_pressed()) {
singleton->_editor_select(EDITOR_SCRIPT);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
memdelete(singleton->main_editor_buttons[i]);
Rename `remove()` to `remove_at()` when removing by index
2021-07-03 22:17:03 +00:00
singleton->main_editor_buttons.remove_at(i);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
break;
}
}
singleton->editor_table.erase(p_editor);
}
editor_node.cpp now takes care of removing plugin after deactivating it
2016-06-18 22:29:16 +00:00
p_editor->make_visible(false);
p_editor->clear();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_config_changed) {
Added basic support for custom resource savers and loaders
2018-06-11 00:59:53 +00:00
p_editor->disable_plugin();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fix crash after disabling plugin using set_force_draw_over_forwarding_enabled()
2021-05-17 08:46:59 +00:00
singleton->editor_plugins_over->remove_plugin(p_editor);
singleton->editor_plugins_force_over->remove_plugin(p_editor);
singleton->editor_plugins_force_input_forwarding->remove_plugin(p_editor);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
singleton->remove_child(p_editor);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
singleton->editor_data.remove_editor_plugin(p_editor);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
void EditorNode::_update_addon_config() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (_initializing_plugins) {
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
Vector<String> enabled_addons;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
for (const KeyValue<String, EditorPlugin *> &E : addon_name_to_plugin) {
Use range iterators for `Map`
2021-08-09 20:13:42 +00:00
enabled_addons.push_back(E.key);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (enabled_addons.size() == 0) {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 20:00:46 +00:00
ProjectSettings::get_singleton()->set("editor_plugins/enabled", Variant());
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
} else {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 20:00:46 +00:00
ProjectSettings::get_singleton()->set("editor_plugins/enabled", enabled_addons);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
}
Minor fixes/refactoring of project and editor setting dialogs
2022-01-31 23:19:01 +00:00
project_settings_editor->queue_save();
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
}
Added basic support for custom resource savers and loaders
2018-06-11 00:59:53 +00:00
void EditorNode::set_addon_plugin_enabled(const String &p_addon, bool p_enabled, bool p_config_changed) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
ERR_FAIL_COND(p_enabled && addon_name_to_plugin.has(p_addon));
ERR_FAIL_COND(!p_enabled && !addon_name_to_plugin.has(p_addon));
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
if (!p_enabled) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
EditorPlugin *addon = addon_name_to_plugin[p_addon];
Added basic support for custom resource savers and loaders
2018-06-11 00:59:53 +00:00
remove_editor_plugin(addon, p_config_changed);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
memdelete(addon);
addon_name_to_plugin.erase(p_addon);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
_update_addon_config();
return;
}
Ref<ConfigFile> cf;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
cf.instantiate();
Detect plugins recursively
2020-11-21 01:30:02 +00:00
if (!DirAccess::exists(p_addon.get_base_dir())) {
Remove plugin from enabled if there's an error inform user in warning message Co-authored-by: Rémi Verschelde <rverschelde@gmail.com> Refactor remove plugin from enabled
2021-05-09 12:17:15 +00:00
_remove_plugin_from_enabled(p_addon);
Remove duplicate WARN_PRINT macro.
2019-11-07 08:44:15 +00:00
WARN_PRINT("Addon '" + p_addon + "' failed to load. No directory found. Removing from enabled plugins.");
Auto-cleanup missing addons
2019-02-16 23:53:14 +00:00
return;
}
Detect plugins recursively
2020-11-21 01:30:02 +00:00
Error err = cf->load(p_addon);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err != OK) {
Detect plugins recursively
2020-11-21 01:30:02 +00:00
show_warning(vformat(TTR("Unable to enable addon plugin at: '%s' parsing of config failed."), p_addon));
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
return;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (!cf->has_section_key("plugin", "script")) {
Detect plugins recursively
2020-11-21 01:30:02 +00:00
show_warning(vformat(TTR("Unable to find script field for addon plugin at: '%s'."), p_addon));
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
return;
}
Allow plugins to not have an init script
2019-08-15 17:40:22 +00:00
String script_path = cf->get_value("plugin", "script");
Ref<Script> script; // We need to save it for creating "ep" below.
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
Allow plugins to not have an init script
2019-08-15 17:40:22 +00:00
// Only try to load the script if it has a name. Else, the plugin has no init script.
if (script_path.length() > 0) {
Detect plugins recursively
2020-11-21 01:30:02 +00:00
script_path = p_addon.get_base_dir().plus_file(script_path);
Allow plugins to not have an init script
2019-08-15 17:40:22 +00:00
script = ResourceLoader::load(script_path);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
Allow plugins to not have an init script
2019-08-15 17:40:22 +00:00
if (script.is_null()) {
show_warning(vformat(TTR("Unable to load addon script from path: '%s'."), script_path));
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
Refactor some object type checking code with `cast_to` Less stringly typed logic, and less String allocations and comparisons.
2022-02-06 13:12:19 +00:00
// Errors in the script cause the base_type to be an empty StringName.
if (script->get_instance_base_type() == StringName()) {
i18n: Sync translations with Weblate (cherry picked from commit bcedd097426403f25098f44038c79bc39a8131c6)
2021-05-18 10:09:09 +00:00
show_warning(vformat(TTR("Unable to load addon script from path: '%s'. This might be due to a code error in that script.\nDisabling the addon at '%s' to prevent further errors."), script_path, p_addon));
Remove plugin from enabled if there's an error inform user in warning message Co-authored-by: Rémi Verschelde <rverschelde@gmail.com> Refactor remove plugin from enabled
2021-05-09 12:17:15 +00:00
_remove_plugin_from_enabled(p_addon);
Allow plugins to not have an init script
2019-08-15 17:40:22 +00:00
return;
}
Better error message for malformed plugins
2018-10-13 12:20:18 +00:00
Allow plugins to not have an init script
2019-08-15 17:40:22 +00:00
// Plugin init scripts must inherit from EditorPlugin and be tools.
if (String(script->get_instance_base_type()) != "EditorPlugin") {
show_warning(vformat(TTR("Unable to load addon script from path: '%s' Base type is not EditorPlugin."), script_path));
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
Allow plugins to not have an init script
2019-08-15 17:40:22 +00:00
if (!script->is_tool()) {
show_warning(vformat(TTR("Unable to load addon script from path: '%s' Script is not in tool mode."), script_path));
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
EditorPlugin *ep = memnew(EditorPlugin);
Changed logic and optimized ObjectID in ObjectDB and Variant, removed RefPtr.
2020-02-13 19:03:10 +00:00
ep->set_script(script);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
addon_name_to_plugin[p_addon] = ep;
Added basic support for custom resource savers and loaders
2018-06-11 00:59:53 +00:00
add_editor_plugin(ep, p_config_changed);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
_update_addon_config();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool EditorNode::is_addon_plugin_enabled(const String &p_addon) const {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
return addon_name_to_plugin.has(p_addon);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
void EditorNode::_remove_edited_scene(bool p_change_tab) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
int new_index = editor_data.get_edited_scene();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int old_index = new_index;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (new_index > 0) {
new_index = new_index - 1;
} else if (editor_data.get_edited_scene_count() > 1) {
new_index = 1;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
} else {
editor_data.add_edited_scene(-1);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
new_index = 1;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_change_tab) {
Style: clang-format: Disable AllowShortIfStatementsOnASingleLine Part of #33027, also discussed in #29848. Enforcing the use of brackets even on single line statements would be preferred, but `clang-format` doesn't have this functionality yet.
2020-05-10 10:56:01 +00:00
_scene_tab_changed(new_index);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
editor_data.remove_scene(old_index);
Add argument to UndoRedo's "clear_history()" to not increase the version
2018-11-18 20:07:38 +00:00
editor_data.get_undo_redo().clear_history(false);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
_update_title();
_update_scene_tabs();
}
Fix #2623
2015-10-21 22:23:42 +00:00
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
void EditorNode::_remove_scene(int index, bool p_change_tab) {
Fix #2623
2015-10-21 22:23:42 +00:00
if (editor_data.get_edited_scene() == index) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Scene to remove is current scene.
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
_remove_edited_scene(p_change_tab);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Scene to remove is not active scene.
Fix #2623
2015-10-21 22:23:42 +00:00
editor_data.remove_scene(index);
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void EditorNode::set_edited_scene(Node *p_scene) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
if (get_editor_data().get_edited_scene_root()) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (get_editor_data().get_edited_scene_root()->get_parent() == scene_root) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
scene_root->remove_child(get_editor_data().get_edited_scene_root());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
remove trailing whitespace
2016-03-08 23:00:52 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
get_editor_data().set_edited_scene_root(p_scene);
remove trailing whitespace
2016-03-08 23:00:52 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (Object::cast_to<Popup>(p_scene)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
Object::cast_to<Popup>(p_scene)->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
SceneTreeDock::get_singleton()->set_edited_scene(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (get_tree()) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
get_tree()->set_edited_scene_root(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
if (p_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_scene->get_parent() != scene_root) {
Remove node_hrcr hack
2021-10-21 14:46:07 +00:00
scene_root->add_child(p_scene, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
}
-fixed tabs
2015-11-18 07:47:41 +00:00
int EditorNode::_get_current_main_editor() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < editor_table.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (editor_table[i] == editor_plugin_screen) {
-fixed tabs
2015-11-18 07:47:41 +00:00
return i;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-fixed tabs
2015-11-18 07:47:41 +00:00
}
return 0;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Dictionary EditorNode::_get_main_scene_state() {
Dictionary state;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
state["main_tab"] = _get_current_main_editor();
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
state["scene_tree_offset"] = SceneTreeDock::get_singleton()->get_tree_editor()->get_scene_tree()->get_vscroll_bar()->get_value();
state["property_edit_offset"] = InspectorDock::get_inspector_singleton()->get_scroll_offset();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
state["saved_version"] = saved_version;
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
state["node_filter"] = SceneTreeDock::get_singleton()->get_filter();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
return state;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_set_main_scene_state(Dictionary p_state, Node *p_for_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (get_edited_scene() != p_for_scene && p_for_scene != nullptr) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
return; // Not for this scene.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
changing_scene = false;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 21:45:04 +00:00
int current = -1;
for (int i = 0; i < editor_table.size(); i++) {
if (editor_plugin_screen == editor_table[i]) {
current = i;
break;
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 12:46:08 +00:00
}
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 21:45:04 +00:00
}
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 12:46:08 +00:00
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 21:45:04 +00:00
if (p_state.has("editor_index")) {
int index = p_state["editor_index"];
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (current < 2) { // If currently in spatial/2d, only switch to spatial/2d. If currently in script, stay there.
Improve guessing of what editor to switch to, fixes #10405
2017-09-04 21:00:09 +00:00
if (index < 2 || !get_edited_scene()) {
_editor_select(index);
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 21:45:04 +00:00
}
}
}
if (get_edited_scene()) {
if (current < 2) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Use heuristic instead.
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 21:45:04 +00:00
int n2d = 0, n3d = 0;
_find_node_types(get_edited_scene(), n2d, n3d);
if (n2d > n3d) {
_editor_select(EDITOR_2D);
} else if (n3d > n2d) {
_editor_select(EDITOR_3D);
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 12:46:08 +00:00
}
}
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_state.has("scene_tree_offset")) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
SceneTreeDock::get_singleton()->get_tree_editor()->get_scene_tree()->get_vscroll_bar()->set_value(p_state["scene_tree_offset"]);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
if (p_state.has("property_edit_offset")) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_inspector_singleton()->set_scroll_offset(p_state["property_edit_offset"]);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_state.has("node_filter")) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
SceneTreeDock::get_singleton()->set_filter(p_state["node_filter"]);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// This should only happen at the very end.
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 12:46:08 +00:00
Huge Debugger/EditorDebugger refactor.
2020-02-07 01:52:05 +00:00
EditorDebuggerNode::get_singleton()->update_live_edit_root();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ScriptEditor::get_singleton()->set_scene_root_script(editor_data.get_scene_root_script(editor_data.get_edited_scene()));
-ability to change scripts in external editor and still have properties reloaded in godot UI, fixes #3003
2015-12-09 12:08:41 +00:00
editor_data.notify_edited_scene_changed();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
void EditorNode::set_current_version(uint64_t p_version) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
saved_version = p_version;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
editor_data.set_edited_scene_version(p_version);
}
bool EditorNode::is_changing_scene() const {
return changing_scene;
}
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-13 23:39:01 +00:00
void EditorNode::_clear_undo_history() {
Fix misleading modified status of scenes If a scene is instanced in another scene, any changes to the first triggers _clear_undo_history in EditorNode::set_current_scene, which increments the version in UndoRedo::clear_history. This results in a modified status. Passing false to clear_history fixes this issue. Fixes #25942
2019-03-01 16:20:30 +00:00
get_undo_redo()->clear_history(false);
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-13 23:39:01 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
void EditorNode::set_current_scene(int p_idx) {
Rename `Tabs` to `TabBar`
2021-10-17 16:55:44 +00:00
// Save the folding in case the scene gets reloaded.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (editor_data.get_scene_path(p_idx) != "" && editor_data.get_edited_scene_root(p_idx)) {
Preserve folding when sub-scene is changed
2019-09-10 12:43:46 +00:00
editor_folding.save_scene_folding(editor_data.get_edited_scene_root(p_idx), editor_data.get_scene_path(p_idx));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Preserve folding when sub-scene is changed
2019-09-10 12:43:46 +00:00
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-13 23:39:01 +00:00
if (editor_data.check_and_update_scene(p_idx)) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (editor_data.get_scene_path(p_idx) != "") {
Preserve folding when sub-scene is changed
2019-09-10 12:43:46 +00:00
editor_folding.load_scene_folding(editor_data.get_edited_scene_root(p_idx), editor_data.get_scene_path(p_idx));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Preserve folding when sub-scene is changed
2019-09-10 12:43:46 +00:00
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
call_deferred(SNAME("_clear_undo_history"));
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-13 23:39:01 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
changing_scene = true;
editor_data.save_edited_scene_state(editor_selection, &editor_history, _get_main_scene_state());
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
if (get_editor_data().get_edited_scene_root()) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (get_editor_data().get_edited_scene_root()->get_parent() == scene_root) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
scene_root->remove_child(get_editor_data().get_edited_scene_root());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
editor_selection->clear();
editor_data.set_edited_scene(p_idx);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Node *new_scene = editor_data.get_edited_scene_root();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (Object::cast_to<Popup>(new_scene)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
Object::cast_to<Popup>(new_scene)->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
SceneTreeDock::get_singleton()->set_edited_scene(new_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (get_tree()) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
get_tree()->set_edited_scene_root(new_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
if (new_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (new_scene->get_parent() != scene_root) {
Remove node_hrcr hack
2021-10-21 14:46:07 +00:00
scene_root->add_child(new_scene, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Dictionary state = editor_data.restore_edited_scene_state(editor_selection, &editor_history);
Don't edit foreign resources when restoring scene
2021-09-12 19:17:34 +00:00
_edit_current(true);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
update window title when switching scenes
2018-09-11 10:28:32 +00:00
_update_title();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
call_deferred(SNAME("_set_main_scene_state"), state, get_edited_scene()); // Do after everything else is done setting up.
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool EditorNode::is_scene_open(const String &p_path) {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (editor_data.get_scene_path(i) == p_path) {
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
return true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
}
return false;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::fix_dependencies(const String &p_for_file) {
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
dependency_fixer->edit(p_for_file);
}
Allow to create scene from FileSystem dock
2019-08-15 17:47:21 +00:00
int EditorNode::new_scene() {
int idx = editor_data.add_edited_scene(-1);
_scene_tab_changed(idx);
editor_data.clear_editor_states();
_update_scene_tabs();
return idx;
}
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
Error EditorNode::load_scene(const String &p_scene, bool p_ignore_broken_deps, bool p_set_inherited, bool p_clear_errors, bool p_force_open_imported, bool p_silent_change_tab) {
SceneMainLoop -> SceneTree -=-=-=-=-=-=-=-=-=-=-=-=-=- *YOUR SOURCE MIGHT NOT WORK* For mor information on fix: https://github.com/okamstudio/godot/wiki/devel_scene_tree Other stuff: -Shower of bullets demo -Fixes all around
2014-11-06 00:20:42 +00:00
if (!is_inside_tree()) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
defer_load_scene = p_scene;
return OK;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (!p_set_inherited) {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == p_scene) {
You can create an inherited scene based on an already opened scene.
2016-01-02 22:42:41 +00:00
_scene_tab_changed(i);
return OK;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
completed scene importing (I hope?)
2017-02-04 23:31:15 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (!p_force_open_imported && FileAccess::exists(p_scene + ".import")) {
open_imported->set_text(vformat(TTR("Scene '%s' was automatically imported, so it can't be modified.\nTo make changes to it, a new inherited scene can be created."), p_scene.get_file()));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
open_imported->popup_centered();
completed scene importing (I hope?)
2017-02-04 23:31:15 +00:00
new_inherited_button->grab_focus();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
open_import_request = p_scene;
completed scene importing (I hope?)
2017-02-04 23:31:15 +00:00
return OK;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_clear_errors) {
Fix error reporting when a scene is not imported properly, closes #3968
2016-06-26 18:37:04 +00:00
load_errors->clear();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fix error reporting when a scene is not imported properly, closes #3968
2016-06-26 18:37:04 +00:00
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 20:00:46 +00:00
String lpath = ProjectSettings::get_singleton()->localize_path(p_scene);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (!lpath.begins_with("res://")) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 14:47:41 +00:00
show_accept(TTR("Error loading scene, it must be inside the project path. Use 'Import' to open the scene, then save it inside the project path."), TTR("OK"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
opening_prev = false;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return ERR_FILE_NOT_FOUND;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
int prev = editor_data.get_edited_scene();
int idx = editor_data.add_edited_scene(-1);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (!editor_data.get_edited_scene_root() && editor_data.get_edited_scene_count() == 2) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
_remove_edited_scene();
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
} else if (!p_silent_change_tab) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
_scene_tab_changed(idx);
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
} else {
set_current_scene(idx);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
dependency_errors.clear();
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
Error err;
Improve resource load cache -Added a new method in Resource: reset_state , used for reloading the same resource from disk -Added a new cache mode "replace" in ResourceLoader, which reuses existing loaded sub-resources but resets their data from disk (or replaces them if they chaged type) -Because the correct sub-resource paths are always loaded now, this fixes bugs with subresource folding or subresource ordering when saving.
2021-02-11 17:18:45 +00:00
Ref<PackedScene> sdata = ResourceLoader::load(lpath, "", ResourceFormatLoader::CACHE_MODE_REPLACE, &err);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (!sdata.is_valid()) {
EditorNode: enhance open scene error dialog
2017-08-28 03:24:50 +00:00
_dialog_display_load_error(lpath, err);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
opening_prev = false;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (prev != -1) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
set_current_scene(prev);
editor_data.remove_scene(idx);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return ERR_FILE_NOT_FOUND;
}
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
if (!p_ignore_broken_deps && dependency_errors.has(lpath)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = -1;
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
Vector<String> errors;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (Set<String>::Element *E = dependency_errors[lpath].front(); E; E = E->next()) {
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
errors.push_back(E->get());
}
Let user fix dependencies in resources
2018-11-02 03:44:40 +00:00
dependency_error->show(DependencyErrorDialog::MODE_SCENE, lpath, errors);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
opening_prev = false;
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (prev != -1) {
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
set_current_scene(prev);
editor_data.remove_scene(idx);
}
return ERR_FILE_MISSING_DEPENDENCIES;
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dependency_errors.erase(lpath); // At least not self path.
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
Use range iterators for `Map`
2021-08-09 20:13:42 +00:00
for (KeyValue<String, Set<String>> &E : dependency_errors) {
String txt = vformat(TTR("Scene '%s' has broken dependencies:"), E.key) + "\n";
for (Set<String>::Element *F = E.value.front(); F; F = F->next()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
txt += "\t" + F->get() + "\n";
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-23 23:15:56 +00:00
}
add_io_error(txt);
}
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 14:06:20 +00:00
if (ResourceCache::has(lpath)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Used from somewhere else? No problem! Update state and replace sdata.
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
Ref<PackedScene> ps = Ref<PackedScene>(Object::cast_to<PackedScene>(ResourceCache::get(lpath)));
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 14:06:20 +00:00
if (ps.is_valid()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ps->replace_state(sdata->get_state());
ps->set_last_modified_time(sdata->get_last_modified_time());
sdata = ps;
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 14:06:20 +00:00
}
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
sdata->set_path(lpath, true); // Take over path.
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 14:06:20 +00:00
}
improved get_node(), connect(), etc code completion. -properly completes text arguments -includes the "/root" autoloads
2015-06-26 04:14:31 +00:00
Add property value pinning
2021-10-26 19:12:25 +00:00
Node *new_scene = sdata->instantiate(p_set_inherited ? PackedScene::GEN_EDIT_STATE_MAIN_INHERITED : PackedScene::GEN_EDIT_STATE_MAIN);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (!new_scene) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
sdata.unref();
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 11:05:09 +00:00
_dialog_display_load_error(lpath, ERR_FILE_CORRUPT);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
opening_prev = false;
if (prev != -1) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
set_current_scene(prev);
editor_data.remove_scene(idx);
}
PackedScene: Prevent crash when root node has `parent` attribute The crash happens further down when setting an invalid owner in `Node::_set_owner_nocheck` but I couldn't figure out how to fix it. But here the proper fix is to catch the invalid scene file early on and fail loading it. Part of #17372.
2020-06-08 11:05:09 +00:00
return ERR_FILE_CORRUPT;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 12:09:09 +00:00
if (p_set_inherited) {
Ref<SceneState> state = sdata->get_state();
remove trailing whitespace
2016-03-08 23:00:52 +00:00
state->set_path(lpath);
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 12:09:09 +00:00
new_scene->set_scene_inherited_state(state);
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
new_scene->set_scene_file_path(String());
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 12:09:09 +00:00
}
-Fixed bug with scene inheritance, should work again -Proper .tscn and .tres parsing, should work, please test well!
2015-11-28 23:56:14 +00:00
new_scene->set_scene_instance_state(Ref<SceneState>());
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 12:09:09 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
set_edited_scene(new_scene);
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 03:31:00 +00:00
_get_scene_metadata(p_scene);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
saved_version = editor_data.get_undo_redo().get_version();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
_update_title();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
_update_scene_tabs();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
_add_to_recent_scenes(lpath);
Rewrite code for unfolding and make it automatic on scene load, which works better.
2018-11-25 13:46:26 +00:00
if (editor_folding.has_folding_data(lpath)) {
editor_folding.load_scene_folding(new_scene, lpath);
} else if (EDITOR_GET("interface/inspector/auto_unfold_foreign_scenes")) {
editor_folding.unfold_scene(new_scene);
editor_folding.save_scene_folding(new_scene, lpath);
}
Moved folding outside the resource files, now saved outside the project.
2018-10-29 19:36:31 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
prev_scene->set_disabled(previous_scenes.size() == 0);
opening_prev = false;
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
SceneTreeDock::get_singleton()->set_selected(new_scene);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Huge Debugger/EditorDebugger refactor.
2020-02-07 01:52:05 +00:00
EditorDebuggerNode::get_singleton()->update_live_edit_root();
Live edit WORK IN PROGRESS 1) press the heart while the game is running 2) select a scene to live edit from the opened scenes 3) edit/add/remove nodes or resources, change their properties, etc. 4) watch changes reflected in running game, in all places this scene is edited 5) It's not perfect obviously, but the aim of it is to try to reflect your changes as best as possible in the running game.
2015-08-02 15:29:37 +00:00
Polygon2D -=-=-=-=- Another gift for those who make 2D games: -Edit polygons, concave or convex, color them, texture them and uv-map them -Corresponding editor -Can have a custom pivot, so they are compatible with bones and IK
2014-07-07 20:44:21 +00:00
push_item(new_scene);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Restore scenes on startup, issue 2385
2017-11-24 23:32:54 +00:00
if (!restoring_scenes) {
save_layout();
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return OK;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::open_request(const String &p_path) {
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
if (!opening_prev) {
List<String>::Element *prev_scene = previous_scenes.find(p_path);
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
if (prev_scene != nullptr) {
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
prev_scene->erase();
}
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
load_scene(p_path); // As it will be opened in separate tab.
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Switch scene when editing foreign resource
2022-03-25 00:17:30 +00:00
void EditorNode::edit_foreign_resource(RES p_resource) {
load_scene(p_resource->get_path().get_slice("::", 0));
InspectorDock::get_singleton()->call_deferred("edit_resource", p_resource);
}
ability to drag scenes from filesystem to tree for instancing
2016-05-11 23:57:52 +00:00
void EditorNode::request_instance_scene(const String &p_path) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
SceneTreeDock::get_singleton()->instantiate(p_path);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
void EditorNode::request_instantiate_scenes(const Vector<String> &p_files) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
SceneTreeDock::get_singleton()->instantiate_scenes(p_files);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Make possible to create inherited scenes via the RMB menu in the FileSystem dock
2019-05-08 02:35:23 +00:00
void EditorNode::_inherit_request(String p_file) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = FILE_NEW_INHERITED_SCENE;
Make possible to create inherited scenes via the RMB menu in the FileSystem dock
2019-05-08 02:35:23 +00:00
_dialog_action(p_file);
}
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
void EditorNode::_instantiate_request(const Vector<String> &p_files) {
request_instantiate_scenes(p_files);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
void EditorNode::_close_messages() {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
old_split_ofs = center_split->get_split_offset();
center_split->set_split_offset(0);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
void EditorNode::_show_messages() {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
center_split->set_split_offset(old_split_ofs);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_add_to_recent_scenes(const String &p_scene) {
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
Array rc = EditorSettings::get_singleton()->get_project_metadata("recent_files", "scenes", Array());
Vectors: Use clear() and has(). Use clear() instead of resize(0). Use has() instead of "find(p_val) != -1".
2022-02-01 18:19:13 +00:00
if (rc.has(p_scene)) {
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
rc.erase(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
rc.push_front(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (rc.size() > 10) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
rc.resize(10);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
EditorSettings::get_singleton()->set_project_metadata("recent_files", "scenes", rc);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
_update_recent_scenes();
}
void EditorNode::_open_recent_scene(int p_idx) {
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 02:35:15 +00:00
if (p_idx == recent_scenes->get_item_count() - 1) {
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
EditorSettings::get_singleton()->set_project_metadata("recent_files", "scenes", Array());
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
call_deferred(SNAME("_update_recent_scenes"));
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 02:35:15 +00:00
} else {
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
Array rc = EditorSettings::get_singleton()->get_project_metadata("recent_files", "scenes", Array());
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 02:35:15 +00:00
ERR_FAIL_INDEX(p_idx, rc.size());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
if (load_scene(rc[p_idx]) != OK) {
Rename `remove()` to `remove_at()` when removing by index
2021-07-03 22:17:03 +00:00
rc.remove_at(p_idx);
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
EditorSettings::get_singleton()->set_project_metadata("recent_files", "scenes", rc);
_update_recent_scenes();
}
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 02:35:15 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
void EditorNode::_update_recent_scenes() {
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
Array rc = EditorSettings::get_singleton()->get_project_metadata("recent_files", "scenes", Array());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
recent_scenes->clear();
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 02:35:15 +00:00
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
String path;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < rc.size(); i++) {
Small changes to the "Recent Scenes" menu.
2018-01-09 12:42:45 +00:00
path = rc[i];
recent_scenes->add_item(path.replace("res://", ""), i);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 02:35:15 +00:00
recent_scenes->add_separator();
recent_scenes->add_shortcut(ED_SHORTCUT("editor/clear_recent", TTR("Clear Recent Scenes")));
Remove set_as_minsize()
2022-03-05 23:57:42 +00:00
recent_scenes->reset_size();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Quick open now can open multiple scenes and scripts
2016-01-08 11:27:34 +00:00
void EditorNode::_quick_opened() {
Vector<String> files = quick_open->get_selected_files();
Open scene selected from Quick Open dialog.
2020-06-28 23:04:28 +00:00
bool open_scene_dialog = quick_open->get_base_type() == "PackedScene";
Quick open now can open multiple scenes and scripts
2016-01-08 11:27:34 +00:00
for (int i = 0; i < files.size(); i++) {
String res_path = files[i];
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Open scene selected from Quick Open dialog.
2020-06-28 23:04:28 +00:00
List<String> scene_extensions;
ResourceLoader::get_recognized_extensions_for_type("PackedScene", &scene_extensions);
if (open_scene_dialog || scene_extensions.find(files[i].get_extension())) {
Quick open now can open multiple scenes and scripts
2016-01-08 11:27:34 +00:00
open_request(res_path);
} else {
load_resource(res_path);
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Fix _quick_run method (Play custom scene)
2016-02-17 18:40:06 +00:00
void EditorNode::_quick_run() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
_run(false, quick_run->get_selected());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Huge Debugger/EditorDebugger refactor.
2020-02-07 01:52:05 +00:00
void EditorNode::notify_all_debug_sessions_exited() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
_menu_option_confirm(RUN_STOP, false);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
stop_button->set_pressed(false);
editor_run.stop();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::add_io_error(const String &p_error) {
_load_error_notify(singleton, p_error);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_load_error_notify(void *p_ud, const String &p_text) {
EditorNode *en = (EditorNode *)p_ud;
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
en->load_errors->add_image(en->gui_base->get_theme_icon(SNAME("Error"), SNAME("EditorIcons")));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
en->load_errors->add_text(p_text + "\n");
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
en->load_error_dialog->popup_centered_ratio(0.5);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool EditorNode::_find_scene_in_use(Node *p_node, const String &p_path) const {
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
if (p_node->get_scene_file_path() == p_path) {
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 05:23:03 +00:00
return true;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < p_node->get_child_count(); i++) {
if (_find_scene_in_use(p_node->get_child(i), p_path)) {
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 05:23:03 +00:00
return true;
}
}
return false;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool EditorNode::is_scene_in_use(const String &p_path) {
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 05:23:03 +00:00
Node *es = get_edited_scene();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (es) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
return _find_scene_in_use(es, p_path);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 05:23:03 +00:00
return false;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void EditorNode::register_editor_types() {
Change global timestamp behaviour earlier
2018-10-03 20:12:59 +00:00
ResourceLoader::set_timestamp_on_load(true);
ResourceSaver::set_timestamp_on_save(true);
Implement the ability to disable classes * This PR adds the ability to disable classes when building. * For now it's only possible to do this via command like: `scons disable_classes=RayCast2D,Area3D` * Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-11 22:30:33 +00:00
GDREGISTER_CLASS(EditorPaths);
GDREGISTER_CLASS(EditorPlugin);
GDREGISTER_CLASS(EditorTranslationParserPlugin);
GDREGISTER_CLASS(EditorImportPlugin);
GDREGISTER_CLASS(EditorScript);
GDREGISTER_CLASS(EditorSelection);
GDREGISTER_CLASS(EditorFileDialog);
Discern between virtual and abstract class bindings * Previous "virtual" classes (which can't be instantiated) are not corretly named "abstract". * Added a new "virtual" category for classes, they can't be instantiated from the editor, but can be inherited from script and extensions. * Converted a large amount of classes from "abstract" to "virtual" where it makes sense. Most classes that make sense have been converted. Missing: * Physics servers * VideoStream * Script* classes. which will go in a separate PR due to the complexity involved.
2022-03-10 07:17:38 +00:00
GDREGISTER_ABSTRACT_CLASS(EditorSettings);
Implement the ability to disable classes * This PR adds the ability to disable classes when building. * For now it's only possible to do this via command like: `scons disable_classes=RayCast2D,Area3D` * Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-11 22:30:33 +00:00
GDREGISTER_CLASS(EditorNode3DGizmo);
GDREGISTER_CLASS(EditorNode3DGizmoPlugin);
Discern between virtual and abstract class bindings * Previous "virtual" classes (which can't be instantiated) are not corretly named "abstract". * Added a new "virtual" category for classes, they can't be instantiated from the editor, but can be inherited from script and extensions. * Converted a large amount of classes from "abstract" to "virtual" where it makes sense. Most classes that make sense have been converted. Missing: * Physics servers * VideoStream * Script* classes. which will go in a separate PR due to the complexity involved.
2022-03-10 07:17:38 +00:00
GDREGISTER_ABSTRACT_CLASS(EditorResourcePreview);
Implement the ability to disable classes * This PR adds the ability to disable classes when building. * For now it's only possible to do this via command like: `scons disable_classes=RayCast2D,Area3D` * Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-11 22:30:33 +00:00
GDREGISTER_CLASS(EditorResourcePreviewGenerator);
Discern between virtual and abstract class bindings * Previous "virtual" classes (which can't be instantiated) are not corretly named "abstract". * Added a new "virtual" category for classes, they can't be instantiated from the editor, but can be inherited from script and extensions. * Converted a large amount of classes from "abstract" to "virtual" where it makes sense. Most classes that make sense have been converted. Missing: * Physics servers * VideoStream * Script* classes. which will go in a separate PR due to the complexity involved.
2022-03-10 07:17:38 +00:00
GDREGISTER_ABSTRACT_CLASS(EditorFileSystem);
Implement the ability to disable classes * This PR adds the ability to disable classes when building. * For now it's only possible to do this via command like: `scons disable_classes=RayCast2D,Area3D` * Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-11 22:30:33 +00:00
GDREGISTER_CLASS(EditorFileSystemDirectory);
GDREGISTER_CLASS(EditorVCSInterface);
Discern between virtual and abstract class bindings * Previous "virtual" classes (which can't be instantiated) are not corretly named "abstract". * Added a new "virtual" category for classes, they can't be instantiated from the editor, but can be inherited from script and extensions. * Converted a large amount of classes from "abstract" to "virtual" where it makes sense. Most classes that make sense have been converted. Missing: * Physics servers * VideoStream * Script* classes. which will go in a separate PR due to the complexity involved.
2022-03-10 07:17:38 +00:00
GDREGISTER_ABSTRACT_CLASS(ScriptEditor);
GDREGISTER_ABSTRACT_CLASS(ScriptEditorBase);
Implement the ability to disable classes * This PR adds the ability to disable classes when building. * For now it's only possible to do this via command like: `scons disable_classes=RayCast2D,Area3D` * Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-11 22:30:33 +00:00
GDREGISTER_CLASS(EditorSyntaxHighlighter);
Discern between virtual and abstract class bindings * Previous "virtual" classes (which can't be instantiated) are not corretly named "abstract". * Added a new "virtual" category for classes, they can't be instantiated from the editor, but can be inherited from script and extensions. * Converted a large amount of classes from "abstract" to "virtual" where it makes sense. Most classes that make sense have been converted. Missing: * Physics servers * VideoStream * Script* classes. which will go in a separate PR due to the complexity involved.
2022-03-10 07:17:38 +00:00
GDREGISTER_ABSTRACT_CLASS(EditorInterface);
Implement the ability to disable classes * This PR adds the ability to disable classes when building. * For now it's only possible to do this via command like: `scons disable_classes=RayCast2D,Area3D` * Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-11 22:30:33 +00:00
GDREGISTER_CLASS(EditorExportPlugin);
GDREGISTER_CLASS(EditorResourceConversionPlugin);
Add scene Post-Import Plugin support. * New plugin system to control the whole import workflow * Can add options and run code at every import step (general, per node, mesh, animation, material etc.) This constitutes a first version of these plugins. The ability to interact with the import preview dialog will likely be added later on.
2021-10-14 17:34:27 +00:00
GDREGISTER_CLASS(EditorSceneFormatImporter);
GDREGISTER_CLASS(EditorScenePostImportPlugin);
Implement the ability to disable classes * This PR adds the ability to disable classes when building. * For now it's only possible to do this via command like: `scons disable_classes=RayCast2D,Area3D` * Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-11 22:30:33 +00:00
GDREGISTER_CLASS(EditorInspector);
GDREGISTER_CLASS(EditorInspectorPlugin);
GDREGISTER_CLASS(EditorProperty);
GDREGISTER_CLASS(AnimationTrackEditPlugin);
GDREGISTER_CLASS(ScriptCreateDialog);
GDREGISTER_CLASS(EditorFeatureProfile);
GDREGISTER_CLASS(EditorSpinSlider);
GDREGISTER_CLASS(EditorResourcePicker);
GDREGISTER_CLASS(EditorScriptPicker);
Discern between virtual and abstract class bindings * Previous "virtual" classes (which can't be instantiated) are not corretly named "abstract". * Added a new "virtual" category for classes, they can't be instantiated from the editor, but can be inherited from script and extensions. * Converted a large amount of classes from "abstract" to "virtual" where it makes sense. Most classes that make sense have been converted. Missing: * Physics servers * VideoStream * Script* classes. which will go in a separate PR due to the complexity involved.
2022-03-10 07:17:38 +00:00
GDREGISTER_ABSTRACT_CLASS(FileSystemDock);
Exposed EditorSceneImporter to script. Added APIs to use intermediate converters more easily.
2017-12-07 18:44:20 +00:00
Implement the ability to disable classes * This PR adds the ability to disable classes when building. * For now it's only possible to do this via command like: `scons disable_classes=RayCast2D,Area3D` * Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-11 22:30:33 +00:00
GDREGISTER_CLASS(EditorScenePostImport);
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
GDREGISTER_CLASS(EditorCommandPalette);
Implement the ability to disable classes * This PR adds the ability to disable classes when building. * For now it's only possible to do this via command like: `scons disable_classes=RayCast2D,Area3D` * Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-11 22:30:33 +00:00
GDREGISTER_CLASS(EditorDebuggerPlugin);
Implement native extension system * Deprecates GDNative in favor of a simpler, lower level interface. * New extension system allows registering core engine classes. * Simple header interface in gdnative_interace.h
2021-06-19 15:58:49 +00:00
NativeExtensionManager::get_singleton()->initialize_extensions(NativeExtension::INITIALIZATION_LEVEL_EDITOR);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 12:31:47 +00:00
void EditorNode::unregister_editor_types() {
Implement native extension system * Deprecates GDNative in favor of a simpler, lower level interface. * New extension system allows registering core engine classes. * Simple header interface in gdnative_interace.h
2021-06-19 15:58:49 +00:00
NativeExtensionManager::get_singleton()->deinitialize_extensions(NativeExtension::INITIALIZATION_LEVEL_EDITOR);
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 12:31:47 +00:00
_init_callbacks.clear();
Implement shader caching * Shader compilation is now cached. Subsequent loads take less than a millisecond. * Improved game, editor and project manager startup time. * Editor uses .godot/shader_cache to store shaders. * Game uses user://shader_cache * Project manager uses $config_dir/shader_cache * Options to tweak shader caching in project settings. * Editor path configuration moved from EditorSettings to new class, EditorPaths, so it can be available early on (before shaders are compiled). * Reworked ShaderCompilerRD to ensure deterministic shader code creation (else shader may change and cache will be invalidated). * Added shader compression with SMOLV: https://github.com/aras-p/smol-v
2021-05-25 00:25:11 +00:00
if (EditorPaths::get_singleton()) {
EditorPaths::free();
}
Cache EditorResourcePicker's allowed types
2021-08-03 13:52:12 +00:00
EditorResourcePicker::clear_caches();
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 12:31:47 +00:00
}
Huge Debugger/EditorDebugger refactor.
2020-02-07 01:52:05 +00:00
void EditorNode::stop_child_process(OS::ProcessID p_pid) {
if (has_child_process(p_pid)) {
editor_run.stop_child_process(p_pid);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!editor_run.get_child_process_count()) { // All children stopped. Closing.
Huge Debugger/EditorDebugger refactor.
2020-02-07 01:52:05 +00:00
_menu_option_confirm(RUN_STOP, false);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Huge Debugger/EditorDebugger refactor.
2020-02-07 01:52:05 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
Ref<Script> EditorNode::get_object_custom_type_base(const Object *p_object) const {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
ERR_FAIL_COND_V(!p_object, nullptr);
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
Ref<Script> script = p_object->get_script();
if (script.is_valid()) {
// Uncommenting would break things! Consider adding a parameter if you need it.
// StringName name = EditorNode::get_editor_data().script_class_get_name(base_script->get_path());
Style: Cleanup single-line blocks, semicolons, dead code Remove currently unused implementation of TextureBasisU, could be re-added later on if needed and ported.
2022-02-16 12:56:32 +00:00
// if (name != StringName()) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
// return name;
Style: Cleanup single-line blocks, semicolons, dead code Remove currently unused implementation of TextureBasisU, could be re-added later on if needed and ported.
2022-02-16 12:56:32 +00:00
// }
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// TODO: Should probably be deprecated in 4.x
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
StringName base = script->get_instance_base_type();
if (base != StringName() && EditorNode::get_editor_data().get_custom_types().has(base)) {
const Vector<EditorData::CustomType> &types = EditorNode::get_editor_data().get_custom_types()[base];
Ref<Script> base_script = script;
while (base_script.is_valid()) {
for (int i = 0; i < types.size(); ++i) {
if (types[i].script == base_script) {
return types[i].script;
}
}
base_script = base_script->get_base_script();
}
}
}
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
return nullptr;
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
}
StringName EditorNode::get_object_custom_type_name(const Object *p_object) const {
ERR_FAIL_COND_V(!p_object, StringName());
Ref<Script> script = p_object->get_script();
Refactor some object type checking code with `cast_to` Less stringly typed logic, and less String allocations and comparisons.
2022-02-06 13:12:19 +00:00
if (script.is_null() && Object::cast_to<Script>(p_object)) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
script = p_object;
}
if (script.is_valid()) {
Ref<Script> base_script = script;
while (base_script.is_valid()) {
StringName name = EditorNode::get_editor_data().script_class_get_name(base_script->get_path());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (name != StringName()) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
return name;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// TODO: Should probably be deprecated in 4.x.
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
StringName base = base_script->get_instance_base_type();
if (base != StringName() && EditorNode::get_editor_data().get_custom_types().has(base)) {
const Vector<EditorData::CustomType> &types = EditorNode::get_editor_data().get_custom_types()[base];
for (int i = 0; i < types.size(); ++i) {
if (types[i].script == base_script) {
return types[i].name;
}
}
}
base_script = base_script->get_base_script();
}
}
return StringName();
}
Resize custom class icon
2019-10-23 18:11:04 +00:00
Ref<ImageTexture> EditorNode::_load_custom_class_icon(const String &p_path) const {
if (p_path.length()) {
Ref<Image> img = memnew(Image);
Error err = ImageLoader::load_image(p_path, img);
if (err == OK) {
Ref<ImageTexture> icon = memnew(ImageTexture);
img->resize(16 * EDSCALE, 16 * EDSCALE, Image::INTERPOLATE_LANCZOS);
icon->create_from_image(img);
return icon;
}
}
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
return nullptr;
Resize custom class icon
2019-10-23 18:11:04 +00:00
}
Added 'Select Current' option when user is prompted to select main scene after clicking play
2021-07-06 14:10:07 +00:00
void EditorNode::_pick_main_scene_custom_action(const String &p_custom_action_name) {
if (p_custom_action_name == "select_current") {
Node *scene = editor_data.get_edited_scene_root();
if (!scene) {
show_accept(TTR("There is no defined scene to run."), TTR("OK"));
return;
}
pick_main_scene->hide();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = SETTINGS_PICK_MAIN_SCENE;
Rename Node's `filename` property to `scene_file_path` for clarity
2021-09-30 14:30:55 +00:00
_dialog_action(scene->get_scene_file_path());
Added 'Select Current' option when user is prompted to select main scene after clicking play
2021-07-06 14:10:07 +00:00
}
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
Ref<Texture2D> EditorNode::get_object_icon(const Object *p_object, const String &p_fallback) const {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
ERR_FAIL_COND_V(!p_object || !gui_base, nullptr);
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
Ref<Script> script = p_object->get_script();
if (script.is_null() && p_object->is_class("Script")) {
script = p_object;
}
if (script.is_valid()) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
Ref<Script> base_script = script;
while (base_script.is_valid()) {
StringName name = EditorNode::get_editor_data().script_class_get_name(base_script->get_path());
String icon_path = EditorNode::get_editor_data().script_class_get_icon_path(name);
Resize custom class icon
2019-10-23 18:11:04 +00:00
Ref<ImageTexture> icon = _load_custom_class_icon(icon_path);
if (icon.is_valid()) {
return icon;
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// TODO: should probably be deprecated in 4.x
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
StringName base = base_script->get_instance_base_type();
if (base != StringName() && EditorNode::get_editor_data().get_custom_types().has(base)) {
const Vector<EditorData::CustomType> &types = EditorNode::get_editor_data().get_custom_types()[base];
for (int i = 0; i < types.size(); ++i) {
if (types[i].script == base_script && types[i].icon.is_valid()) {
return types[i].icon;
Fix scene dock not showing custom icons
2018-11-11 04:46:20 +00:00
}
}
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 19:21:30 +00:00
base_script = base_script->get_base_script();
Fix scene dock not showing custom icons
2018-11-11 04:46:20 +00:00
}
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// TODO: Should probably be deprecated in 4.x.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_object->has_meta("_editor_icon")) {
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
return p_object->get_meta("_editor_icon");
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
if (gui_base->has_theme_icon(p_object->get_class(), SNAME("EditorIcons"))) {
return gui_base->get_theme_icon(p_object->get_class(), SNAME("EditorIcons"));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_fallback.length()) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
return gui_base->get_theme_icon(p_fallback, SNAME("EditorIcons"));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
return nullptr;
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
Ref<Texture2D> EditorNode::get_class_icon(const String &p_class, const String &p_fallback) const {
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
ERR_FAIL_COND_V_MSG(p_class.is_empty(), nullptr, "Class name cannot be empty.");
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
if (ScriptServer::is_global_class(p_class)) {
Optimize class icon loading `get_global_class_name` for `GDScriptLanguage` is slow because it forces to parse an entire script each time. This patch ensures that the icon is actually fetched from the EditorData where they are loaded beforehand. This change also makes the behavior consistent with the existing `get_object_icon` method in EditorNode.
2020-06-24 10:08:27 +00:00
Ref<ImageTexture> icon;
Ref<Script> script = EditorNode::get_editor_data().script_class_load_script(p_class);
Don't use arbitrary theme editor icons for scripts with the same name The existing theme editor icon could be unintentionally set for any global class with matching name (`Group` icon, `Group` class_name etc), which would only show up in the "Create Dialog" context, but not the scene tree dock. This change prevents this behavior, and ensures that the icon can be actually overidden by explicit icon path in `class_name`, if there's any custom icon to begin with. The correct built-in type's icon is fetched for child classes if there are no custom icons detected throughout base classes as well, so it isn't left empty for those cases.
2020-06-24 23:13:13 +00:00
StringName name = p_class;
Fix inherited icons for script classes
2019-02-06 23:53:24 +00:00
while (script.is_valid()) {
Don't use arbitrary theme editor icons for scripts with the same name The existing theme editor icon could be unintentionally set for any global class with matching name (`Group` icon, `Group` class_name etc), which would only show up in the "Create Dialog" context, but not the scene tree dock. This change prevents this behavior, and ensures that the icon can be actually overidden by explicit icon path in `class_name`, if there's any custom icon to begin with. The correct built-in type's icon is fetched for child classes if there are no custom icons detected throughout base classes as well, so it isn't left empty for those cases.
2020-06-24 23:13:13 +00:00
name = EditorNode::get_editor_data().script_class_get_name(script->get_path());
Optimize class icon loading `get_global_class_name` for `GDScriptLanguage` is slow because it forces to parse an entire script each time. This patch ensures that the icon is actually fetched from the EditorData where they are loaded beforehand. This change also makes the behavior consistent with the existing `get_object_icon` method in EditorNode.
2020-06-24 10:08:27 +00:00
String current_icon_path = EditorNode::get_editor_data().script_class_get_icon_path(name);
Resize custom class icon
2019-10-23 18:11:04 +00:00
icon = _load_custom_class_icon(current_icon_path);
if (icon.is_valid()) {
return icon;
Fix inherited icons for script classes
2019-02-06 23:53:24 +00:00
}
script = script->get_base_script();
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
}
Fix inherited icons for script classes
2019-02-06 23:53:24 +00:00
if (icon.is_null()) {
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
icon = gui_base->get_theme_icon(ScriptServer::get_global_class_base(name), SNAME("EditorIcons"));
Fix inherited icons for script classes
2019-02-06 23:53:24 +00:00
}
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
}
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 06:33:00 +00:00
const Map<String, Vector<EditorData::CustomType>> &p_map = EditorNode::get_editor_data().get_custom_types();
Use range iterators for `Map`
2021-08-09 20:13:42 +00:00
for (const KeyValue<String, Vector<EditorData::CustomType>> &E : p_map) {
const Vector<EditorData::CustomType> &ct = E.value;
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
for (int i = 0; i < ct.size(); ++i) {
if (ct[i].name == p_class) {
if (ct[i].icon.is_valid()) {
return ct[i].icon;
}
}
}
}
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
if (gui_base->has_theme_icon(p_class, SNAME("EditorIcons"))) {
return gui_base->get_theme_icon(p_class, SNAME("EditorIcons"));
Don't use arbitrary theme editor icons for scripts with the same name The existing theme editor icon could be unintentionally set for any global class with matching name (`Group` icon, `Group` class_name etc), which would only show up in the "Create Dialog" context, but not the scene tree dock. This change prevents this behavior, and ensures that the icon can be actually overidden by explicit icon path in `class_name`, if there's any custom icon to begin with. The correct built-in type's icon is fetched for child classes if there are no custom icons detected throughout base classes as well, so it isn't left empty for those cases.
2020-06-24 23:13:13 +00:00
}
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
if (p_fallback.length() && gui_base->has_theme_icon(p_fallback, SNAME("EditorIcons"))) {
return gui_base->get_theme_icon(p_fallback, SNAME("EditorIcons"));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
return nullptr;
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
}
-Add lightmapper -Fixes to unwrapper (remove degenerates), makes Thekla not crash -Added optional cancel button in EditorProgress -Added function to force processing of events (needed for cancel button)
2017-12-14 11:59:46 +00:00
void EditorNode::progress_add_task(const String &p_task, const String &p_label, int p_steps, bool p_can_cancel) {
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 10:32:15 +00:00
if (singleton->cmdline_export_mode) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 11:45:51 +00:00
print_line(p_task + ": begin: " + p_label + " steps: " + itos(p_steps));
} else {
singleton->progress_dialog->add_task(p_task, p_label, p_steps, p_can_cancel);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
-Add lightmapper -Fixes to unwrapper (remove degenerates), makes Thekla not crash -Added optional cancel button in EditorProgress -Added function to force processing of events (needed for cancel button)
2017-12-14 11:59:46 +00:00
bool EditorNode::progress_task_step(const String &p_task, const String &p_state, int p_step, bool p_force_refresh) {
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 10:32:15 +00:00
if (singleton->cmdline_export_mode) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 11:45:51 +00:00
print_line("\t" + p_task + ": step " + itos(p_step) + ": " + p_state);
return false;
} else {
return singleton->progress_dialog->task_step(p_task, p_state, p_step, p_force_refresh);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::progress_end_task(const String &p_task) {
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 10:32:15 +00:00
if (singleton->cmdline_export_mode) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 11:45:51 +00:00
print_line(p_task + ": end");
} else {
singleton->progress_dialog->end_task(p_task);
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::progress_add_task_bg(const String &p_task, const String &p_label, int p_steps) {
singleton->progress_hb->add_task(p_task, p_label, p_steps);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::progress_task_step_bg(const String &p_task, int p_step) {
singleton->progress_hb->task_step(p_task, p_step);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::progress_end_task_bg(const String &p_task) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
singleton->progress_hb->end_task(p_task);
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
Ref<Texture2D> EditorNode::_file_dialog_get_icon(const String &p_path) {
removed duplicated functions in class hierarchy that were bound more than once added a check to detect this case in the future
2017-01-14 14:07:57 +00:00
EditorFileSystemDirectory *efsd = EditorFileSystem::get_singleton()->get_filesystem_path(p_path.get_base_dir());
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
if (efsd) {
String file = p_path.get_file();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < efsd->get_file_count(); i++) {
if (efsd->get_file(i) == file) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
String type = efsd->get_file_type(i);
if (singleton->icon_type_cache.has(type)) {
return singleton->icon_type_cache[type];
} else {
return singleton->icon_type_cache["Object"];
}
}
}
}
return singleton->icon_type_cache["Object"];
}
Update icons when theme changed
2018-02-25 16:04:16 +00:00
void EditorNode::_build_icon_type_cache() {
List<StringName> tl;
Refactor some object type checking code with `cast_to` Less stringly typed logic, and less String allocations and comparisons.
2022-02-06 13:12:19 +00:00
theme_base->get_theme()->get_icon_list(SNAME("EditorIcons"), &tl);
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const StringName &E : tl) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (!ClassDB::class_exists(E)) {
Update icons when theme changed
2018-02-25 16:04:16 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Refactor some object type checking code with `cast_to` Less stringly typed logic, and less String allocations and comparisons.
2022-02-06 13:12:19 +00:00
icon_type_cache[E] = theme_base->get_theme()->get_icon(E, SNAME("EditorIcons"));
Update icons when theme changed
2018-02-25 16:04:16 +00:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
void EditorNode::_file_dialog_register(FileDialog *p_dialog) {
singleton->file_dialogs.insert(p_dialog);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_file_dialog_unregister(FileDialog *p_dialog) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
singleton->file_dialogs.erase(p_dialog);
}
work in progress, resource previews
2015-05-31 04:59:42 +00:00
void EditorNode::_editor_file_dialog_register(EditorFileDialog *p_dialog) {
singleton->editor_file_dialogs.insert(p_dialog);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_editor_file_dialog_unregister(EditorFileDialog *p_dialog) {
work in progress, resource previews
2015-05-31 04:59:42 +00:00
singleton->editor_file_dialogs.erase(p_dialog);
}
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 12:31:47 +00:00
Vector<EditorNodeInitCallback> EditorNode::_init_callbacks;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Export: Add dedicated --export-pack option to export data pack The previous behavior relying on the provided extension was problematic on macOS since .zip is the main extension used for the full project export (binary + data pack). We add a dedicated `--export-pack` command line option to define when only the data pack should be exported. Its extension will still be inferred from the path. Fixes #23073.
2020-01-08 13:22:50 +00:00
Error EditorNode::export_preset(const String &p_preset, const String &p_path, bool p_debug, bool p_pack_only) {
Renamed function arguments to keep them consistent between declaration and implementation
2017-09-14 17:49:11 +00:00
export_defer.preset = p_preset;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
export_defer.path = p_path;
export_defer.debug = p_debug;
Export: Add dedicated --export-pack option to export data pack The previous behavior relying on the provided extension was problematic on macOS since .zip is the main extension used for the full project export (binary + data pack). We add a dedicated `--export-pack` command line option to define when only the data pack should be exported. Its extension will still be inferred from the path. Fixes #23073.
2020-01-08 13:22:50 +00:00
export_defer.pack_only = p_pack_only;
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 10:32:15 +00:00
cmdline_export_mode = true;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
return OK;
}
Add a message when there is nothing to Undo or Redo
2018-05-27 02:41:19 +00:00
void EditorNode::show_accept(const String &p_text, const String &p_title) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = -1;
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
accept->get_ok_button()->set_text(p_title);
Add a message when there is nothing to Undo or Redo
2018-05-27 02:41:19 +00:00
accept->set_text(p_text);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
accept->popup_centered();
Add a message when there is nothing to Undo or Redo
2018-05-27 02:41:19 +00:00
}
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 01:35:13 +00:00
void EditorNode::show_save_accept(const String &p_text, const String &p_title) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = -1;
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 01:35:13 +00:00
save_accept->get_ok_button()->set_text(p_title);
save_accept->set_text(p_text);
save_accept->popup_centered();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::show_warning(const String &p_text, const String &p_title) {
EditorNode::show_warning displays a console warning instead of failing during project load Fixes #31522
2019-08-21 07:04:55 +00:00
if (warning->is_inside_tree()) {
warning->set_text(p_text);
warning->set_title(p_title);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
warning->popup_centered();
EditorNode::show_warning displays a console warning instead of failing during project load Fixes #31522
2019-08-21 07:04:55 +00:00
} else {
Remove duplicate WARN_PRINT macro.
2019-11-07 08:44:15 +00:00
WARN_PRINT(p_title + " " + p_text);
EditorNode::show_warning displays a console warning instead of failing during project load Fixes #31522
2019-08-21 07:04:55 +00:00
}
New Navigation & Pathfinding support for 2D -Added Navigation & NavigationPolygon nodes -Added corresponding visual editor -New pathfinding algorithm is modern and fast! -Similar API to 3D Pathfinding (more coherent)
2015-02-14 15:09:52 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Add a way to copy the text of warnings shown in the editor Closes #20662
2019-07-09 18:11:31 +00:00
void EditorNode::_copy_warning(const String &p_str) {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
DisplayServer::get_singleton()->clipboard_set(warning->get_text());
Add a way to copy the text of warnings shown in the editor Closes #20662
2019-07-09 18:11:31 +00:00
}
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
void EditorNode::_dock_floating_close_request(Control *p_control) {
General enhancements to floating docks
2020-03-27 19:48:42 +00:00
// Through the MarginContainer to the Window.
Window *window = (Window *)p_control->get_parent()->get_parent();
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
int window_slot = window->get_meta("dock_slot");
General enhancements to floating docks
2020-03-27 19:48:42 +00:00
p_control->get_parent()->remove_child(p_control);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
dock_slot[window_slot]->add_child(p_control);
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
dock_slot[window_slot]->move_child(p_control, MIN((int)window->get_meta("dock_index"), dock_slot[window_slot]->get_tab_count()));
General enhancements to floating docks
2020-03-27 19:48:42 +00:00
dock_slot[window_slot]->set_current_tab(window->get_meta("dock_index"));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
window->queue_delete();
_update_dock_containers();
floating_docks.erase(p_control);
Inspector retains content when detached and when docked
2022-01-29 18:32:36 +00:00
_edit_current();
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
}
void EditorNode::_dock_make_float() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
Control *dock = dock_slot[dock_popup_selected_idx]->get_current_tab_control();
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
ERR_FAIL_COND(!dock);
Fix theming for floating window docks
2022-01-13 21:13:45 +00:00
Size2 borders = Size2(4, 4) * EDSCALE;
// Remember size and position before removing it from the main window.
Size2 dock_size = dock->get_size() + borders * 2;
Take borders into account with floating dock initial position/size
2020-04-03 19:08:20 +00:00
Point2 dock_screen_pos = dock->get_global_position() + get_tree()->get_root()->get_position() - borders;
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
General enhancements to floating docks
2020-03-27 19:48:42 +00:00
int dock_index = dock->get_index();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_slot[dock_popup_selected_idx]->remove_child(dock);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
Window *window = memnew(Window);
window->set_title(dock->get_name());
Panel *p = memnew(Panel);
Fix theming for floating window docks
2022-01-13 21:13:45 +00:00
p->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("PanelForeground"), SNAME("EditorStyles")));
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
p->set_anchors_and_offsets_preset(Control::PRESET_WIDE);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
window->add_child(p);
General enhancements to floating docks
2020-03-27 19:48:42 +00:00
MarginContainer *margin = memnew(MarginContainer);
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
margin->set_anchors_and_offsets_preset(Control::PRESET_WIDE);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
margin->add_theme_constant_override("margin_right", borders.width);
margin->add_theme_constant_override("margin_top", borders.height);
margin->add_theme_constant_override("margin_left", borders.width);
margin->add_theme_constant_override("margin_bottom", borders.height);
General enhancements to floating docks
2020-03-27 19:48:42 +00:00
window->add_child(margin);
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
dock->set_anchors_and_offsets_preset(Control::PRESET_WIDE);
General enhancements to floating docks
2020-03-27 19:48:42 +00:00
margin->add_child(dock);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
window->set_wrap_controls(true);
window->set_size(dock_size);
window->set_position(dock_screen_pos);
window->set_transient(true);
window->connect("close_requested", callable_mp(this, &EditorNode::_dock_floating_close_request), varray(dock));
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
window->set_meta("dock_slot", dock_popup_selected_idx);
General enhancements to floating docks
2020-03-27 19:48:42 +00:00
window->set_meta("dock_index", dock_index);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
gui_base->add_child(window);
dock_select_popup->hide();
_update_dock_containers();
floating_docks.push_back(dock);
Inspector retains content when detached and when docked
2022-01-29 18:32:36 +00:00
_edit_current();
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
}
void EditorNode::_update_dock_containers() {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
if (dock_slot[i]->get_tab_count() == 0 && dock_slot[i]->is_visible()) {
dock_slot[i]->hide();
}
if (dock_slot[i]->get_tab_count() > 0 && !dock_slot[i]->is_visible()) {
dock_slot[i]->show();
}
}
for (int i = 0; i < vsplits.size(); i++) {
bool in_use = dock_slot[i * 2 + 0]->get_tab_count() || dock_slot[i * 2 + 1]->get_tab_count();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (in_use) {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
vsplits[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
vsplits[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (right_l_vsplit->is_visible() || right_r_vsplit->is_visible()) {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
right_hsplit->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
right_hsplit->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
void EditorNode::_dock_select_input(const Ref<InputEvent> &p_input) {
Ref<InputEventMouse> me = p_input;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (me.is_valid()) {
InputEvent: Renamed "pos" property to "position" Make the naming consistent with other classes.
2017-06-03 08:54:24 +00:00
Vector2 point = me->get_position();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
int nrect = -1;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
if (dock_select_rect[i].has_point(point)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
nrect = i;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
break;
}
}
fixes for dock motion
2015-06-14 03:41:08 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (nrect != dock_select_rect_over_idx) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_select->update();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_select_rect_over_idx = nrect;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (nrect == -1) {
fixes for dock motion
2015-06-14 03:41:08 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
fixes for dock motion
2015-06-14 03:41:08 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
Ref<InputEventMouseButton> mb = me;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (mb.is_valid() && mb->get_button_index() == MouseButton::LEFT && mb->is_pressed() && dock_popup_selected_idx != nrect) {
Control *dock = dock_slot[dock_popup_selected_idx]->get_current_tab_control();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
if (dock) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_slot[dock_popup_selected_idx]->remove_child(dock);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (dock_slot[dock_popup_selected_idx]->get_tab_count() == 0) {
dock_slot[dock_popup_selected_idx]->hide();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_slot[dock_popup_selected_idx]->set_current_tab(0);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
fixed small refresh issue when moving docks
2015-06-14 04:09:58 +00:00
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_slot[nrect]->add_child(dock);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_popup_selected_idx = nrect;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_slot[nrect]->set_current_tab(dock_slot[nrect]->get_tab_count() - 1);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_slot[nrect]->show();
dock_select->update();
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
_update_dock_containers();
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 18:49:14 +00:00
Inspector re-edits edited object when dock moves, closes #9287
2017-08-18 22:51:17 +00:00
_edit_current();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
_save_docks();
}
}
}
fixes for dock motion
2015-06-14 03:41:08 +00:00
void EditorNode::_dock_popup_exit() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_select_rect_over_idx = -1;
fixes for dock motion
2015-06-14 03:41:08 +00:00
dock_select->update();
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
void EditorNode::_dock_pre_popup(int p_which) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_popup_selected_idx = p_which;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
fixes for dock motion
2015-06-14 03:41:08 +00:00
void EditorNode::_dock_move_left() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (dock_popup_selected_idx < 0 || dock_popup_selected_idx >= DOCK_SLOT_MAX) {
fixes for dock motion
2015-06-14 03:41:08 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
Control *current = dock_slot[dock_popup_selected_idx]->get_tab_control(dock_slot[dock_popup_selected_idx]->get_current_tab());
Control *prev = dock_slot[dock_popup_selected_idx]->get_tab_control(dock_slot[dock_popup_selected_idx]->get_current_tab() - 1);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!current || !prev) {
fixes for dock motion
2015-06-14 03:41:08 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_slot[dock_popup_selected_idx]->move_child(current, prev->get_index());
dock_slot[dock_popup_selected_idx]->set_current_tab(dock_slot[dock_popup_selected_idx]->get_current_tab() - 1);
fixes for dock motion
2015-06-14 03:41:08 +00:00
dock_select->update();
Inspector re-edits edited object when dock moves, closes #9287
2017-08-18 22:51:17 +00:00
_edit_current();
fixes for dock motion
2015-06-14 03:41:08 +00:00
_save_docks();
}
void EditorNode::_dock_move_right() {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
Control *current = dock_slot[dock_popup_selected_idx]->get_tab_control(dock_slot[dock_popup_selected_idx]->get_current_tab());
Control *next = dock_slot[dock_popup_selected_idx]->get_tab_control(dock_slot[dock_popup_selected_idx]->get_current_tab() + 1);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!current || !next) {
fixes for dock motion
2015-06-14 03:41:08 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_slot[dock_popup_selected_idx]->move_child(next, current->get_index());
dock_slot[dock_popup_selected_idx]->set_current_tab(dock_slot[dock_popup_selected_idx]->get_current_tab() + 1);
fixes for dock motion
2015-06-14 03:41:08 +00:00
dock_select->update();
Inspector re-edits edited object when dock moves, closes #9287
2017-08-18 22:51:17 +00:00
_edit_current();
fixes for dock motion
2015-06-14 03:41:08 +00:00
_save_docks();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_dock_select_draw() {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
Size2 s = dock_select->get_size();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
s.y /= 2.0;
s.x /= 6.0;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Color used = Color(0.6, 0.6, 0.6, 0.8);
Color used_selected = Color(0.8, 0.8, 0.8, 0.8);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
Color tab_selected = theme_base->get_theme_color(SNAME("mono_color"), SNAME("Editor"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Color unused = used;
unused.a = 0.4;
Color unusable = unused;
unusable.a = 0.1;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Rect2 unr(s.x * 2, 0, s.x * 2, s.y * 2);
renamed all Rect2.pos to Rect2.position
2017-06-03 22:25:13 +00:00
unr.position += Vector2(2, 5);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
unr.size -= Vector2(4, 7);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_select->draw_rect(unr, unusable);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_tab_move_left->set_disabled(true);
dock_tab_move_right->set_disabled(true);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (dock_popup_selected_idx != -1 && dock_slot[dock_popup_selected_idx]->get_tab_count()) {
dock_tab_move_left->set_disabled(dock_slot[dock_popup_selected_idx]->get_current_tab() == 0);
dock_tab_move_right->set_disabled(dock_slot[dock_popup_selected_idx]->get_current_tab() >= dock_slot[dock_popup_selected_idx]->get_tab_count() - 1);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
Vector2 ofs;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
switch (i) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
case DOCK_SLOT_LEFT_UL: {
} break;
case DOCK_SLOT_LEFT_BL: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ofs.y += s.y;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
} break;
case DOCK_SLOT_LEFT_UR: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ofs.x += s.x;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
} break;
case DOCK_SLOT_LEFT_BR: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ofs += s;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
} break;
case DOCK_SLOT_RIGHT_UL: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ofs.x += s.x * 4;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
} break;
case DOCK_SLOT_RIGHT_BL: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ofs.x += s.x * 4;
ofs.y += s.y;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
} break;
case DOCK_SLOT_RIGHT_UR: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ofs.x += s.x * 4;
ofs.x += s.x;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
} break;
case DOCK_SLOT_RIGHT_BR: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ofs.x += s.x * 4;
ofs += s;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
} break;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Rect2 r(ofs, s);
dock_select_rect[i] = r;
renamed all Rect2.pos to Rect2.position
2017-06-03 22:25:13 +00:00
r.position += Vector2(2, 5);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
r.size -= Vector2(4, 7);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (i == dock_select_rect_over_idx) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_select->draw_rect(r, used_selected);
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
} else if (dock_slot[i]->get_tab_count() == 0) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_select->draw_rect(r, unused);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_select->draw_rect(r, used);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
for (int j = 0; j < MIN(3, dock_slot[i]->get_tab_count()); j++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int xofs = (r.size.width / 3) * j;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
Color c = used;
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (i == dock_popup_selected_idx && (dock_slot[i]->get_current_tab() > 3 || dock_slot[i]->get_current_tab() == j)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
c = tab_selected;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_select->draw_rect(Rect2(2 + ofs.x + xofs, ofs.y, r.size.width / 3 - 1, 3), c);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
}
}
void EditorNode::_save_docks() {
Avoid docks to be overriden while scanning, fixes #26359
2019-02-27 21:14:24 +00:00
if (waiting_for_first_scan) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
return; // Scanning, do not touch docks.
Avoid docks to be overriden while scanning, fixes #26359
2019-02-27 21:14:24 +00:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
config.instantiate();
Made Editor Log buttons save their state, per project.
2021-05-05 01:05:09 +00:00
// Load and amend existing config if it exists.
config->load(EditorSettings::get_singleton()->get_project_settings_dir().plus_file("editor_layout.cfg"));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
Editor layouts menu
2015-11-22 18:11:17 +00:00
_save_docks_to_config(config, "docks");
Restore scenes on startup, issue 2385
2017-11-24 23:32:54 +00:00
_save_open_scenes_to_config(config, "EditorNode");
Editor layouts menu
2015-11-22 18:11:17 +00:00
editor_data.get_plugin_window_layout(config);
EditorSettings: Rename settings_path to settings_dir Also to prepare for upcoming refactoring for XDG support.
2017-11-17 14:50:18 +00:00
config->save(EditorSettings::get_singleton()->get_project_settings_dir().plus_file("editor_layout.cfg"));
Editor layouts menu
2015-11-22 18:11:17 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_save_docks_to_config(Ref<ConfigFile> p_layout, const String &p_section) {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
String names;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int j = 0; j < dock_slot[i]->get_tab_count(); j++) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
String name = dock_slot[i]->get_tab_control(j)->get_name();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!names.is_empty()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
names += ",";
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
names += name;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!names.is_empty()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
p_layout->set_value(p_section, "dock_" + itos(i + 1), names);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
}
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
p_layout->set_value(p_section, "dock_filesystem_split", FileSystemDock::get_singleton()->get_split_offset());
p_layout->set_value(p_section, "dock_filesystem_display_mode", FileSystemDock::get_singleton()->get_display_mode());
p_layout->set_value(p_section, "dock_filesystem_file_sort", FileSystemDock::get_singleton()->get_file_sort());
p_layout->set_value(p_section, "dock_filesystem_file_list_display_mode", FileSystemDock::get_singleton()->get_file_list_display_mode());
Include filesystem dock split offset in editor layouts Cherry-picked from 2ac89f65403c606ad9a3cdf65e591cb375faf024
2017-01-25 01:46:44 +00:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < vsplits.size(); i++) {
if (vsplits[i]->is_visible_in_tree()) {
p_layout->set_value(p_section, "dock_split_" + itos(i + 1), vsplits[i]->get_split_offset());
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < hsplits.size(); i++) {
p_layout->set_value(p_section, "dock_hsplit_" + itos(i + 1), hsplits[i]->get_split_offset());
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
Restore scenes on startup, issue 2385
2017-11-24 23:32:54 +00:00
void EditorNode::_save_open_scenes_to_config(Ref<ConfigFile> p_layout, const String &p_section) {
Array scenes;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
String path = editor_data.get_scene_path(i);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (path.is_empty()) {
Restore scenes on startup, issue 2385
2017-11-24 23:32:54 +00:00
continue;
}
scenes.push_back(path);
}
p_layout->set_value(p_section, "open_scenes", scenes);
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
void EditorNode::save_layout() {
dock_drag_timer->start();
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
void EditorNode::_dock_split_dragged(int ofs) {
dock_drag_timer->start();
}
void EditorNode::_load_docks() {
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
config.instantiate();
EditorSettings: Rename settings_path to settings_dir Also to prepare for upcoming refactoring for XDG support.
2017-11-17 14:50:18 +00:00
Error err = config->load(EditorSettings::get_singleton()->get_project_settings_dir().plus_file("editor_layout.cfg"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err != OK) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// No config.
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (overridden_default_layout >= 0) {
Allow to override the default editor layout
2016-01-11 21:23:45 +00:00
_layout_menu_option(overridden_default_layout);
}
return;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
Editor layouts menu
2015-11-22 18:11:17 +00:00
_load_docks_from_config(config, "docks");
Restore scenes on startup, issue 2385
2017-11-24 23:32:54 +00:00
_load_open_scenes_from_config(config, "EditorNode");
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 03:14:04 +00:00
Editor layouts menu
2015-11-22 18:11:17 +00:00
editor_data.set_plugin_window_layout(config);
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
void EditorNode::_update_dock_slots_visibility() {
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
if (!docks_visible) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
dock_slot[i]->hide();
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < vsplits.size(); i++) {
vsplits[i]->hide();
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
right_hsplit->hide();
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
int tabs_visible = 0;
for (int j = 0; j < dock_slot[i]->get_tab_count(); j++) {
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
if (!dock_slot[i]->is_tab_hidden(j)) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
tabs_visible++;
}
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (tabs_visible) {
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
dock_slot[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
dock_slot[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < vsplits.size(); i++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool in_use = dock_slot[i * 2 + 0]->get_tab_count() || dock_slot[i * 2 + 1]->get_tab_count();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (in_use) {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
vsplits[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
vsplits[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
New API for visibility in both CanvasItem and Spatial visible (property) - access set_visible(bool) is_visible() is_visible_in_tree() - true when visible and parents visible show() hide() - for convenience
2017-01-13 13:45:50 +00:00
if (dock_slot[i]->is_visible() && dock_slot[i]->get_tab_count()) {
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
dock_slot[i]->set_current_tab(0);
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
}
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 18:49:14 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (right_l_vsplit->is_visible() || right_r_vsplit->is_visible()) {
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 18:49:14 +00:00
right_hsplit->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 18:49:14 +00:00
right_hsplit->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
}
}
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
void EditorNode::_dock_tab_changed(int p_tab) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Update visibility but don't set current tab.
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
if (!docks_visible) {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
dock_slot[i]->hide();
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < vsplits.size(); i++) {
vsplits[i]->hide();
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
}
right_hsplit->hide();
bottom_panel->hide();
} else {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (dock_slot[i]->get_tab_count()) {
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
dock_slot[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
dock_slot[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < vsplits.size(); i++) {
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
bool in_use = dock_slot[i * 2 + 0]->get_tab_count() || dock_slot[i * 2 + 1]->get_tab_count();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (in_use) {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
vsplits[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
vsplits[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
}
bottom_panel->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (right_l_vsplit->is_visible() || right_r_vsplit->is_visible()) {
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
right_hsplit->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
right_hsplit->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_load_docks_from_config(Ref<ConfigFile> p_layout, const String &p_section) {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!p_layout->has_section_key(p_section, "dock_" + itos(i + 1))) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Vector<String> names = String(p_layout->get_value(p_section, "dock_" + itos(i + 1))).split(",");
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int j = 0; j < names.size(); j++) {
String name = names[j];
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// FIXME: Find it, in a horribly inefficient way.
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int atidx = -1;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
Control *node = nullptr;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int k = 0; k < DOCK_SLOT_MAX; k++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!dock_slot[k]->has_node(name)) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
node = Object::cast_to<Control>(dock_slot[k]->get_node(name));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!node) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
atidx = k;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
break;
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (atidx == -1) { // Well, it's not anywhere.
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (atidx == i) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
node->raise();
continue;
}
dock_slot[atidx]->remove_child(node);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (dock_slot[atidx]->get_tab_count() == 0) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_slot[atidx]->hide();
}
dock_slot[i]->add_child(node);
dock_slot[i]->show();
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_layout->has_section_key(p_section, "dock_filesystem_split")) {
Fixes layout loading
2019-02-27 20:36:12 +00:00
int fs_split_ofs = p_layout->get_value(p_section, "dock_filesystem_split");
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
FileSystemDock::get_singleton()->set_split_offset(fs_split_ofs);
Move the FileSystem dock layout properties to the per-project layout file
2019-02-25 22:39:49 +00:00
}
if (p_layout->has_section_key(p_section, "dock_filesystem_display_mode")) {
FileSystemDock::DisplayMode dock_filesystem_display_mode = FileSystemDock::DisplayMode(int(p_layout->get_value(p_section, "dock_filesystem_display_mode")));
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
FileSystemDock::get_singleton()->set_display_mode(dock_filesystem_display_mode);
Move the FileSystem dock layout properties to the per-project layout file
2019-02-25 22:39:49 +00:00
}
Allow sorting files by type
2020-10-07 19:56:53 +00:00
if (p_layout->has_section_key(p_section, "dock_filesystem_file_sort")) {
FileSystemDock::FileSortOption dock_filesystem_file_sort = FileSystemDock::FileSortOption(int(p_layout->get_value(p_section, "dock_filesystem_file_sort")));
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
FileSystemDock::get_singleton()->set_file_sort(dock_filesystem_file_sort);
Allow sorting files by type
2020-10-07 19:56:53 +00:00
}
Move the FileSystem dock layout properties to the per-project layout file
2019-02-25 22:39:49 +00:00
if (p_layout->has_section_key(p_section, "dock_filesystem_file_list_display_mode")) {
FileSystemDock::FileListDisplayMode dock_filesystem_file_list_display_mode = FileSystemDock::FileListDisplayMode(int(p_layout->get_value(p_section, "dock_filesystem_file_list_display_mode")));
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
FileSystemDock::get_singleton()->set_file_list_display_mode(dock_filesystem_file_list_display_mode);
Include filesystem dock split offset in editor layouts Cherry-picked from 2ac89f65403c606ad9a3cdf65e591cb375faf024
2017-01-25 01:46:44 +00:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < vsplits.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!p_layout->has_section_key(p_section, "dock_split_" + itos(i + 1))) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int ofs = p_layout->get_value(p_section, "dock_split_" + itos(i + 1));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
vsplits[i]->set_split_offset(ofs);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < hsplits.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!p_layout->has_section_key(p_section, "dock_hsplit_" + itos(i + 1))) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int ofs = p_layout->get_value(p_section, "dock_hsplit_" + itos(i + 1));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
hsplits[i]->set_split_offset(ofs);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < vsplits.size(); i++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool in_use = dock_slot[i * 2 + 0]->get_tab_count() || dock_slot[i * 2 + 1]->get_tab_count();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (in_use) {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
vsplits[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
vsplits[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
fixes for dock motion
2015-06-14 03:41:08 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (right_l_vsplit->is_visible() || right_r_vsplit->is_visible()) {
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 18:49:14 +00:00
right_hsplit->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 18:49:14 +00:00
right_hsplit->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 18:49:14 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
New API for visibility in both CanvasItem and Spatial visible (property) - access set_visible(bool) is_visible() is_visible_in_tree() - true when visible and parents visible show() hide() - for convenience
2017-01-13 13:45:50 +00:00
if (dock_slot[i]->is_visible() && dock_slot[i]->get_tab_count()) {
fixes for dock motion
2015-06-14 03:41:08 +00:00
dock_slot[i]->set_current_tab(0);
}
}
Editor layouts menu
2015-11-22 18:11:17 +00:00
}
fixes for dock motion
2015-06-14 03:41:08 +00:00
Restore scenes on startup, issue 2385
2017-11-24 23:32:54 +00:00
void EditorNode::_load_open_scenes_from_config(Ref<ConfigFile> p_layout, const String &p_section) {
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 21:02:16 +00:00
if (!bool(EDITOR_GET("interface/scene_tabs/restore_scenes_on_load"))) {
Restore scenes on startup, issue 2385
2017-11-24 23:32:54 +00:00
return;
}
if (!p_layout->has_section(p_section) || !p_layout->has_section_key(p_section, "open_scenes")) {
return;
}
restoring_scenes = true;
Array scenes = p_layout->get_value(p_section, "open_scenes");
for (int i = 0; i < scenes.size(); i++) {
load_scene(scenes[i]);
}
Save opened scenes when necessary
2019-04-15 20:17:49 +00:00
save_layout();
Restore scenes on startup, issue 2385
2017-11-24 23:32:54 +00:00
restoring_scenes = false;
}
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 03:14:04 +00:00
bool EditorNode::has_scenes_in_session() {
if (!bool(EDITOR_GET("interface/scene_tabs/restore_scenes_on_load"))) {
return false;
}
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
config.instantiate();
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 03:14:04 +00:00
Error err = config->load(EditorSettings::get_singleton()->get_project_settings_dir().plus_file("editor_layout.cfg"));
if (err != OK) {
return false;
}
if (!config->has_section("EditorNode") || !config->has_section_key("EditorNode", "open_scenes")) {
return false;
}
Array scenes = config->get_value("EditorNode", "open_scenes");
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
return !scenes.is_empty();
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 03:14:04 +00:00
}
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
bool EditorNode::ensure_main_scene(bool p_from_native) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
pick_main_scene->set_meta("from_native", p_from_native); // Whether from play button or native run.
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
String main_scene = GLOBAL_DEF("application/run/main_scene", "");
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (main_scene.is_empty()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = -1;
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
pick_main_scene->set_text(TTR("No main scene has ever been defined, select one?\nYou can change it later in \"Project Settings\" under the 'application' category."));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
pick_main_scene->popup_centered();
Added 'Select Current' option when user is prompted to select main scene after clicking play
2021-07-06 14:10:07 +00:00
if (editor_data.get_edited_scene_root()) {
select_current_scene_button->set_disabled(false);
select_current_scene_button->grab_focus();
} else {
select_current_scene_button->set_disabled(true);
}
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
return false;
}
if (!FileAccess::exists(main_scene)) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = -1;
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
pick_main_scene->set_text(vformat(TTR("Selected scene '%s' does not exist, select a valid one?\nYou can change it later in \"Project Settings\" under the 'application' category."), main_scene));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
pick_main_scene->popup_centered();
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
return false;
}
if (ResourceLoader::get_resource_type(main_scene) != "PackedScene") {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = -1;
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
pick_main_scene->set_text(vformat(TTR("Selected scene '%s' is not a scene file, select a valid one?\nYou can change it later in \"Project Settings\" under the 'application' category."), main_scene));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
pick_main_scene->popup_centered();
Ensure main scene is set when running on device
2019-03-22 01:08:28 +00:00
return false;
}
return true;
}
Implemented advanced features of DAP Respect client "supportsVariableType" capability Implement "breakpointLocations" request Implement "restart" request Implement "evaluate" request Fix error messages not being shown, and improved wrong path message Removed thread option and behavior Implemented detailed inspection of complex variables Fix "const"ness of functions Added a configurable timeout for requests Implement Godot custom data request/event Implement syncing of breakpoints Added support for debugging native platforms
2021-07-20 11:24:56 +00:00
Error EditorNode::run_play_native(int p_idx, int p_platform) {
return run_native->run_native(p_idx, p_platform);
}
C#: Add Ide Connection library and server for the editor This will be used for communicating between the Godot editor and external IDEs/editors, for things like opening files, triggering hot-reload and running the game with a debugger attached.
2019-07-18 02:08:24 +00:00
void EditorNode::run_play() {
_menu_option_confirm(RUN_STOP, true);
_run(false);
}
Expose methods to play scene from plugin code
2020-04-05 14:19:24 +00:00
void EditorNode::run_play_current() {
_save_default_environment();
_menu_option_confirm(RUN_STOP, true);
_run(true);
}
void EditorNode::run_play_custom(const String &p_custom) {
_menu_option_confirm(RUN_STOP, true);
_run(false, p_custom);
}
C#: Add Ide Connection library and server for the editor This will be used for communicating between the Godot editor and external IDEs/editors, for things like opening files, triggering hot-reload and running the game with a debugger attached.
2019-07-18 02:08:24 +00:00
void EditorNode::run_stop() {
_menu_option_confirm(RUN_STOP, false);
}
Expose methods to play scene from plugin code
2020-04-05 14:19:24 +00:00
bool EditorNode::is_run_playing() const {
EditorRun::Status status = editor_run.get_status();
return (status == EditorRun::STATUS_PLAY || status == EditorRun::STATUS_PAUSED);
}
String EditorNode::get_run_playing_scene() const {
String run_filename = editor_run.get_running_scene();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (run_filename.is_empty() && is_run_playing()) {
Expose methods to play scene from plugin code
2020-04-05 14:19:24 +00:00
run_filename = GLOBAL_DEF("application/run/main_scene", ""); // Must be the main scene then.
}
return run_filename;
}
Implement Extension Loader * Extensions are now scanned and loaded on demand. * Extensions found are cached into a file that is used to load them (which is also exported). * Editor will ask to restart when an extension requires core functionality. * Editor will attempt to load extensions always before importing or loading scenes. This ensures extensions can register the relevant types.
2021-08-20 18:32:56 +00:00
void EditorNode::_immediate_dialog_confirmed() {
immediate_dialog_confirmed = true;
}
bool EditorNode::immediate_confirmation_dialog(const String &p_text, const String &p_ok_text, const String &p_cancel_text) {
ConfirmationDialog *cd = memnew(ConfirmationDialog);
cd->set_text(p_text);
cd->get_ok_button()->set_text(p_ok_text);
cd->get_cancel_button()->set_text(p_cancel_text);
cd->connect("confirmed", callable_mp(singleton, &EditorNode::_immediate_dialog_confirmed));
singleton->gui_base->add_child(cd);
cd->popup_centered();
while (true) {
OS::get_singleton()->delay_usec(1);
DisplayServer::get_singleton()->process_events();
Main::iteration();
if (singleton->immediate_dialog_confirmed || !cd->is_visible()) {
break;
}
}
memdelete(cd);
return singleton->immediate_dialog_confirmed;
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
int EditorNode::get_current_tab() {
return scene_tabs->get_current_tab();
}
void EditorNode::set_current_tab(int p_tab) {
scene_tabs->set_current_tab(p_tab);
}
Editor layouts menu
2015-11-22 18:11:17 +00:00
void EditorNode::_update_layouts_menu() {
editor_layouts->clear();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
overridden_default_layout = -1;
Allow to override the default editor layout
2016-01-11 21:23:45 +00:00
Added `reset_size` method to `Control` and `Window` classes
2021-11-20 08:04:57 +00:00
editor_layouts->reset_size();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
editor_layouts->add_shortcut(ED_SHORTCUT("layout/save", TTR("Save Layout")), SETTINGS_LAYOUT_SAVE);
editor_layouts->add_shortcut(ED_SHORTCUT("layout/delete", TTR("Delete Layout")), SETTINGS_LAYOUT_DELETE);
Editor layouts menu
2015-11-22 18:11:17 +00:00
editor_layouts->add_separator();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
editor_layouts->add_shortcut(ED_SHORTCUT("layout/default", TTR("Default")), SETTINGS_LAYOUT_DEFAULT);
Editor layouts menu
2015-11-22 18:11:17 +00:00
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
config.instantiate();
Use new XDG folders to dehardcode paths
2017-11-17 20:48:24 +00:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err != OK) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
return; // No config.
Editor layouts menu
2015-11-22 18:11:17 +00:00
}
List<String> layouts;
config.ptr()->get_sections(&layouts);
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const String &layout : layouts) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (layout == TTR("Default")) {
Allow to override the default editor layout
2016-01-11 21:23:45 +00:00
editor_layouts->remove_item(editor_layouts->get_item_index(SETTINGS_LAYOUT_DEFAULT));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
overridden_default_layout = editor_layouts->get_item_count();
Allow to override the default editor layout
2016-01-11 21:23:45 +00:00
}
editor_layouts->add_item(layout);
Editor layouts menu
2015-11-22 18:11:17 +00:00
}
}
void EditorNode::_layout_menu_option(int p_id) {
switch (p_id) {
case SETTINGS_LAYOUT_SAVE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = p_id;
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
layout_dialog->set_title(TTR("Save Layout"));
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
layout_dialog->get_ok_button()->set_text(TTR("Save"));
Editor layouts menu
2015-11-22 18:11:17 +00:00
layout_dialog->popup_centered();
editor save/delete layout dialog with layout list
2019-05-30 18:16:40 +00:00
layout_dialog->set_name_line_enabled(true);
Editor layouts menu
2015-11-22 18:11:17 +00:00
} break;
case SETTINGS_LAYOUT_DELETE: {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = p_id;
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
layout_dialog->set_title(TTR("Delete Layout"));
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
layout_dialog->get_ok_button()->set_text(TTR("Delete"));
Editor layouts menu
2015-11-22 18:11:17 +00:00
layout_dialog->popup_centered();
editor save/delete layout dialog with layout list
2019-05-30 18:16:40 +00:00
layout_dialog->set_name_line_enabled(false);
Editor layouts menu
2015-11-22 18:11:17 +00:00
} break;
case SETTINGS_LAYOUT_DEFAULT: {
Allow to override the default editor layout
2016-01-11 21:23:45 +00:00
_load_docks_from_config(default_layout, "docks");
Editor layouts menu
2015-11-22 18:11:17 +00:00
_save_docks();
} break;
default: {
Ref<ConfigFile> config;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
config.instantiate();
Use new XDG folders to dehardcode paths
2017-11-17 20:48:24 +00:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err != OK) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
return; // No config.
Editor layouts menu
2015-11-22 18:11:17 +00:00
}
Fix editor layouts broken after 9a7ff65
2015-12-14 15:44:15 +00:00
_load_docks_from_config(config, editor_layouts->get_item_text(p_id));
Editor layouts menu
2015-11-22 18:11:17 +00:00
_save_docks();
}
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
}
QOL, script buttons in scene tabs
2015-07-26 13:44:10 +00:00
void EditorNode::_scene_tab_script_edited(int p_tab) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Ref<Script> script = editor_data.get_scene_root_script(p_tab);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (script.is_valid()) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
InspectorDock::get_singleton()->edit_resource(script);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
QOL, script buttons in scene tabs
2015-07-26 13:44:10 +00:00
}
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
void EditorNode::_scene_tab_closed(int p_tab, int option) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
current_menu_option = option;
tab_closing_idx = p_tab;
EditorNode: enhance save/quit dialog
2017-06-26 14:04:53 +00:00
Node *scene = editor_data.get_edited_scene_root(p_tab);
Fix crash on closing [empty](*) scene tab
2017-07-09 18:48:39 +00:00
if (!scene) {
_discard_changes();
return;
}
Fix checking unsaved changes only in current scene
2016-05-02 11:40:44 +00:00
clang-format: Enable `BreakBeforeTernaryOperators` clang-format keeps breaking the way it handles break *after* ternary operators, so I give up and go with the only style they seem to actually test.
2021-10-28 13:57:41 +00:00
bool unsaved = (p_tab == editor_data.get_edited_scene())
? saved_version != editor_data.get_undo_redo().get_version()
: editor_data.get_scene_version(p_tab) != 0;
Fix checking unsaved changes only in current scene
2016-05-02 11:40:44 +00:00
if (unsaved) {
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
save_confirmation->get_ok_button()->set_text(TTR("Save & Close"));
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
save_confirmation->set_text(vformat(TTR("Save changes to '%s' before closing?"), !scene->get_scene_file_path().is_empty() ? scene->get_scene_file_path() : "unsaved scene"));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
save_confirmation->popup_centered();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
} else {
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
_discard_changes();
Ask confirmation on closing a scene tab
2015-11-19 13:15:17 +00:00
}
Restore scenes on startup, issue 2385
2017-11-24 23:32:54 +00:00
save_layout();
add scene button and tab scrolling
2017-11-16 22:57:57 +00:00
_update_scene_tabs();
Added close button to tab. Added 4 display policies for this close button (show always, show never, show active tab only, show hover). Set the scene tabs in editor to follow the hover policy.
2015-08-18 18:27:01 +00:00
}
Fix connections to CanvasItem and Tabs signals Follow-up to #44188 and #44189.
2020-12-09 11:04:02 +00:00
void EditorNode::_scene_tab_hovered(int p_tab) {
Remove redundant "== false" code Some of this code has been re-organized. f
2018-10-06 20:20:41 +00:00
if (!bool(EDITOR_GET("interface/scene_tabs/show_thumbnail_on_hover"))) {
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 15:30:03 +00:00
return;
}
int current_tab = scene_tabs->get_current_tab();
if (p_tab == current_tab || p_tab < 0) {
tab_preview_panel->hide();
} else {
String path = editor_data.get_scene_path(p_tab);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!path.is_empty()) {
Don't create scene thumbnail before its saved, issue 22890
2018-10-21 14:38:01 +00:00
EditorResourcePreview::get_singleton()->queue_resource_preview(path, this, "_thumbnail_done", p_tab);
}
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 15:30:03 +00:00
}
}
void EditorNode::_scene_tab_exit() {
tab_preview_panel->hide();
}
void EditorNode::_scene_tab_input(const Ref<InputEvent> &p_input) {
Ref<InputEventMouseButton> mb = p_input;
if (mb.is_valid()) {
SceneTab: MMB or double LMB to create new scene
2017-07-01 16:23:16 +00:00
if (scene_tabs->get_hovered_tab() >= 0) {
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (mb->get_button_index() == MouseButton::MIDDLE && mb->is_pressed()) {
SceneTab: MMB or double LMB to create new scene
2017-07-01 16:23:16 +00:00
_scene_tab_closed(scene_tabs->get_hovered_tab());
}
} else {
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if ((mb->get_button_index() == MouseButton::LEFT && mb->is_double_click()) || (mb->get_button_index() == MouseButton::MIDDLE && mb->is_pressed())) {
SceneTab: MMB or double LMB to create new scene
2017-07-01 16:23:16 +00:00
_menu_option_confirm(FILE_NEW_SCENE, true);
}
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 15:30:03 +00:00
}
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (mb->get_button_index() == MouseButton::RIGHT && mb->is_pressed()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Context menu.
context menu improvements
2018-01-02 07:10:49 +00:00
scene_tabs_context_menu->clear();
Added `reset_size` method to `Control` and `Window` classes
2021-11-20 08:04:57 +00:00
scene_tabs_context_menu->reset_size();
context menu improvements
2018-01-02 07:10:49 +00:00
scene_tabs_context_menu->add_shortcut(ED_GET_SHORTCUT("editor/new_scene"), FILE_NEW_SCENE);
if (scene_tabs->get_hovered_tab() >= 0) {
scene_tabs_context_menu->add_shortcut(ED_GET_SHORTCUT("editor/save_scene"), FILE_SAVE_SCENE);
scene_tabs_context_menu->add_shortcut(ED_GET_SHORTCUT("editor/save_scene_as"), FILE_SAVE_AS_SCENE);
}
scene_tabs_context_menu->add_shortcut(ED_GET_SHORTCUT("editor/save_all_scenes"), FILE_SAVE_ALL_SCENES);
if (scene_tabs->get_hovered_tab() >= 0) {
scene_tabs_context_menu->add_separator();
Small capitalization fixes across the editor
2018-10-26 19:11:36 +00:00
scene_tabs_context_menu->add_item(TTR("Show in FileSystem"), FILE_SHOW_IN_FILESYSTEM);
context menu improvements
2018-01-02 07:10:49 +00:00
scene_tabs_context_menu->add_item(TTR("Play This Scene"), RUN_PLAY_SCENE);
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
scene_tabs_context_menu->add_separator();
Rename ShortCut to Shortcut which is more grammatically correct See https://github.com/godotengine/godot/issues/16863#issuecomment-685236980.
2020-09-09 19:53:24 +00:00
Ref<Shortcut> close_tab_sc = ED_GET_SHORTCUT("editor/close_scene");
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
close_tab_sc->set_name(TTR("Close Tab"));
scene_tabs_context_menu->add_shortcut(close_tab_sc, FILE_CLOSE);
Rename ShortCut to Shortcut which is more grammatically correct See https://github.com/godotengine/godot/issues/16863#issuecomment-685236980.
2020-09-09 19:53:24 +00:00
Ref<Shortcut> undo_close_tab_sc = ED_GET_SHORTCUT("editor/reopen_closed_scene");
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
undo_close_tab_sc->set_name(TTR("Undo Close Tab"));
scene_tabs_context_menu->add_shortcut(undo_close_tab_sc, FILE_OPEN_PREV);
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (previous_scenes.is_empty()) {
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
scene_tabs_context_menu->set_item_disabled(scene_tabs_context_menu->get_item_index(FILE_OPEN_PREV), true);
}
Add Close Others/Right/All for scene tabs
2019-04-21 09:44:21 +00:00
scene_tabs_context_menu->add_item(TTR("Close Other Tabs"), FILE_CLOSE_OTHERS);
scene_tabs_context_menu->add_item(TTR("Close Tabs to the Right"), FILE_CLOSE_RIGHT);
scene_tabs_context_menu->add_item(TTR("Close All Tabs"), FILE_CLOSE_ALL);
context menu improvements
2018-01-02 07:10:49 +00:00
}
Fix bad popups offset in editor with single window off Co-authored-by: Gil Arasa Verge <gilarasaverge@gmail.com> Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
2021-08-31 15:43:35 +00:00
scene_tabs_context_menu->set_position(scene_tabs->get_screen_position() + mb->get_position());
scene_tabs_context_menu->reset_size();
context menu improvements
2018-01-02 07:10:49 +00:00
scene_tabs_context_menu->popup();
}
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (mb->get_button_index() == MouseButton::WHEEL_UP && mb->is_pressed()) {
Allow using the mouse wheel to navigate scene tabs This works in a way similar to tabs in KDE or some patched Chromium builds.
2021-04-07 13:25:44 +00:00
int previous_tab = editor_data.get_edited_scene() - 1;
previous_tab = previous_tab >= 0 ? previous_tab : editor_data.get_edited_scene_count() - 1;
_scene_tab_changed(previous_tab);
}
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (mb->get_button_index() == MouseButton::WHEEL_DOWN && mb->is_pressed()) {
Allow using the mouse wheel to navigate scene tabs This works in a way similar to tabs in KDE or some patched Chromium builds.
2021-04-07 13:25:44 +00:00
int next_tab = editor_data.get_edited_scene() + 1;
next_tab %= editor_data.get_edited_scene_count();
_scene_tab_changed(next_tab);
}
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 15:30:03 +00:00
}
}
ability to reposition scene tabs with drag & drop
2017-07-05 13:44:53 +00:00
void EditorNode::_reposition_active_tab(int idx_to) {
editor_data.move_edited_scene_to_index(idx_to);
_update_scene_tabs();
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
void EditorNode::_thumbnail_done(const String &p_path, const Ref<Texture2D> &p_preview, const Ref<Texture2D> &p_small_preview, const Variant &p_udata) {
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 15:30:03 +00:00
int p_tab = p_udata.operator signed int();
if (p_preview.is_valid()) {
Rect2 rect = scene_tabs->get_tab_rect(p_tab);
rect.position += scene_tabs->get_global_position();
tab_preview->set_texture(p_preview);
tab_preview_panel->set_position(rect.position + Vector2(0, rect.size.height));
tab_preview_panel->show();
}
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
void EditorNode::_scene_tab_changed(int p_tab) {
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 15:30:03 +00:00
tab_preview_panel->hide();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool unsaved = (saved_version != editor_data.get_undo_redo().get_version());
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_tab == editor_data.get_edited_scene()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
return; // Pointless.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
uint64_t next_scene_version = editor_data.get_scene_version(p_tab);
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
editor_data.get_undo_redo().create_action(TTR("Switch Scene Tab"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
editor_data.get_undo_redo().add_do_method(this, "set_current_version", unsaved ? saved_version : 0);
editor_data.get_undo_redo().add_do_method(this, "set_current_scene", p_tab);
editor_data.get_undo_redo().add_do_method(this, "set_current_version", next_scene_version == 0 ? editor_data.get_undo_redo().get_version() + 1 : next_scene_version);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
editor_data.get_undo_redo().add_undo_method(this, "set_current_version", next_scene_version);
editor_data.get_undo_redo().add_undo_method(this, "set_current_scene", editor_data.get_edited_scene());
editor_data.get_undo_redo().add_undo_method(this, "set_current_version", saved_version);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
editor_data.get_undo_redo().commit_action();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 05:23:03 +00:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
Button *EditorNode::add_bottom_panel_item(String p_text, Control *p_item) {
Button *tb = memnew(Button);
tb->set_flat(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
tb->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch), varray(bottom_panel_items.size()));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
tb->set_text(p_text);
tb->set_toggle_mode(true);
tb->set_focus_mode(Control::FOCUS_NONE);
bottom_panel_vb->add_child(p_item);
bottom_panel_hb->raise();
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
bottom_panel_hb_editors->add_child(tb);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
p_item->set_v_size_flags(Control::SIZE_EXPAND_FILL);
p_item->hide();
BottomPanelItem bpi;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bpi.button = tb;
bpi.control = p_item;
bpi.name = p_text;
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
bottom_panel_items.push_back(bpi);
return tb;
}
void EditorNode::hide_bottom_panel() {
Make bottom panel only try to hide editors when they're visible
2019-03-16 06:39:49 +00:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control->is_visible()) {
_bottom_panel_switch(false, i);
break;
}
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
}
void EditorNode::make_bottom_panel_item_visible(Control *p_item) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == p_item) {
_bottom_panel_switch(true, i);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
break;
}
}
}
void EditorNode::raise_bottom_panel_item(Control *p_item) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == p_item) {
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
bottom_panel_items[i].button->raise();
Reduce unnecessary COW on Vector by make writing explicit This commit makes operator[] on Vector const and adds a write proxy to it. From now on writes to Vectors need to happen through the .write proxy. So for instance: Vector<int> vec; vec.push_back(10); std::cout << vec[0] << std::endl; vec.write[0] = 20; Failing to use the .write proxy will cause a compilation error. In addition COWable datatypes can now embed a CowData pointer to their data. This means that String, CharString, and VMap no longer use or derive from Vector. _ALWAYS_INLINE_ and _FORCE_INLINE_ are now equivalent for debug and non-debug builds. This is a lot faster for Vector in the editor and while running tests. The reason why this difference used to exist is because force-inlined methods used to give a bad debugging experience. After extensive testing with modern compilers this is no longer the case.
2018-07-25 01:11:03 +00:00
SWAP(bottom_panel_items.write[i], bottom_panel_items.write[bottom_panel_items.size() - 1]);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
break;
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
bottom_panel_items[i].button->disconnect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch));
bottom_panel_items[i].button->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch), varray(i));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
}
}
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 19:58:17 +00:00
void EditorNode::remove_bottom_panel_item(Control *p_item) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == p_item) {
New API for visibility in both CanvasItem and Spatial visible (property) - access set_visible(bool) is_visible() is_visible_in_tree() - true when visible and parents visible show() hide() - for convenience
2017-01-13 13:45:50 +00:00
if (p_item->is_visible_in_tree()) {
Make bottom panel only try to hide editors when they're visible
2019-03-16 06:39:49 +00:00
_bottom_panel_switch(false, i);
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 19:58:17 +00:00
}
bottom_panel_vb->remove_child(bottom_panel_items[i].control);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
bottom_panel_hb_editors->remove_child(bottom_panel_items[i].button);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
memdelete(bottom_panel_items[i].button);
Rename `remove()` to `remove_at()` when removing by index
2021-07-03 22:17:03 +00:00
bottom_panel_items.remove_at(i);
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 19:58:17 +00:00
break;
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
bottom_panel_items[i].button->disconnect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch));
bottom_panel_items[i].button->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch), varray(i));
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 19:58:17 +00:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_bottom_panel_switch(bool p_enable, int p_idx) {
ERR_FAIL_INDEX(p_idx, bottom_panel_items.size());
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
Make bottom panel only try to hide editors when they're visible
2019-03-16 06:39:49 +00:00
if (bottom_panel_items[p_idx].control->is_visible() == p_enable) {
return;
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
if (p_enable) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
bottom_panel_items[i].button->set_pressed(i == p_idx);
bottom_panel_items[i].control->set_visible(i == p_idx);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (EditorDebuggerNode::get_singleton() == bottom_panel_items[p_idx].control) {
// This is the debug panel which uses tabs, so the top section should be smaller.
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("BottomPanelDebuggerOverride"), SNAME("EditorStyles")));
fixed bottom panel debugger exception - make it work in combination with the border for tabs - fixed updating when changing theme
2017-09-18 19:06:55 +00:00
} else {
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("panel"), SNAME("TabContainer")));
fixed bottom panel debugger exception - make it work in combination with the border for tabs - fixed updating when changing theme
2017-09-18 19:06:55 +00:00
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
center_split->set_dragger_visibility(SplitContainer::DRAGGER_VISIBLE);
center_split->set_collapsed(false);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
if (bottom_panel_raise->is_pressed()) {
top_split->hide();
}
bottom_panel_raise->show();
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
} else {
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("panel"), SNAME("TabContainer")));
Make bottom panel only try to hide editors when they're visible
2019-03-16 06:39:49 +00:00
bottom_panel_items[p_idx].button->set_pressed(false);
bottom_panel_items[p_idx].control->set_visible(false);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
center_split->set_dragger_visibility(SplitContainer::DRAGGER_HIDDEN);
center_split->set_collapsed(true);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
bottom_panel_raise->hide();
if (bottom_panel_raise->is_pressed()) {
top_split->show();
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
}
}
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
void EditorNode::set_docks_visible(bool p_show) {
docks_visible = p_show;
_update_dock_slots_visibility();
}
bool EditorNode::get_docks_visible() const {
return docks_visible;
}
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 12:46:17 +00:00
void EditorNode::_toggle_distraction_free_mode() {
EditorSettings: Move interface/ properties to interface/editor Fixes inconsistent behaviour where clicking on the "Interface" in the Editor Settings wouldn't collapse the category as is the case for all the other categories.
2017-09-29 16:52:56 +00:00
if (EditorSettings::get_singleton()->get("interface/editor/separate_distraction_mode")) {
Separate fullscreen state for scene & script editor
2017-04-25 11:48:35 +00:00
int screen = -1;
for (int i = 0; i < editor_table.size(); i++) {
if (editor_plugin_screen == editor_table[i]) {
screen = i;
break;
}
}
if (screen == EDITOR_SCRIPT) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
script_distraction_free = !script_distraction_free;
set_distraction_free_mode(script_distraction_free);
Separate fullscreen state for scene & script editor
2017-04-25 11:48:35 +00:00
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
scene_distraction_free = !scene_distraction_free;
set_distraction_free_mode(scene_distraction_free);
Separate fullscreen state for scene & script editor
2017-04-25 11:48:35 +00:00
}
} else {
set_distraction_free_mode(distraction_free->is_pressed());
}
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 12:46:17 +00:00
}
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
void EditorNode::set_distraction_free_mode(bool p_enter) {
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 12:46:17 +00:00
distraction_free->set_pressed(p_enter);
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
if (p_enter) {
if (docks_visible) {
set_docks_visible(false);
}
} else {
set_docks_visible(true);
}
}
Add a getter and property for the editor distraction-free mode
2020-05-31 17:58:15 +00:00
bool EditorNode::is_distraction_free_mode_enabled() const {
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 12:46:17 +00:00
return distraction_free->is_pressed();
Added fullscreen and distraction free modes
2016-05-30 18:29:43 +00:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::add_control_to_dock(DockSlot p_slot, Control *p_control) {
ERR_FAIL_INDEX(p_slot, DOCK_SLOT_MAX);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
dock_slot[p_slot]->add_child(p_control);
_update_dock_slots_visibility();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::remove_control_from_dock(Control *p_control) {
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
Control *dock = nullptr;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
if (p_control->get_parent() == dock_slot[i]) {
dock = dock_slot[i];
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
break;
}
}
Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in 'core/' and 'editor/' Condensed some if and ERR statements. Added dots to end of error messages Couldn't figure out EXPLAINC. These files gave me trouble: core/error_macros.h, core/io/file_access_buffered_fa.h (where is it?), core/os/memory.cpp, drivers/png/png_driver_common.cpp, drivers/xaudio2/audio_driver_xaudio2.cpp (where is it?)
2019-08-15 02:57:49 +00:00
ERR_FAIL_COND_MSG(!dock, "Control was not in dock.");
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 02:10:44 +00:00
dock->remove_child(p_control);
_update_dock_slots_visibility();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Variant EditorNode::drag_resource(const Ref<Resource> &p_res, Control *p_from) {
Control *drag_control = memnew(Control);
TextureRect *drag_preview = memnew(TextureRect);
Label *label = memnew(Label);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
Ref<Texture2D> preview;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
{
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// TODO: make proper previews
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
Ref<ImageTexture> texture = gui_base->get_theme_icon(SNAME("FileBigThumb"), SNAME("EditorIcons"));
Rename Texture.get_data() to get_image()
2021-03-28 11:32:17 +00:00
Ref<Image> img = texture->get_image();
Removal of Image from Variant, converted to a Resource.
2017-05-17 10:36:47 +00:00
img = img->duplicate();
Rename `Tabs` to `TabBar`
2021-10-17 16:55:44 +00:00
img->resize(48, 48); // meh
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Ref<ImageTexture> resized_pic = Ref<ImageTexture>(memnew(ImageTexture));
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
resized_pic->create_from_image(img);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
preview = resized_pic;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
}
drag_preview->set_texture(preview);
drag_control->add_child(drag_preview);
if (p_res->get_path().is_resource_file()) {
label->set_text(p_res->get_path().get_file());
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
} else if (!p_res->get_name().is_empty()) {
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
label->set_text(p_res->get_name());
} else {
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 02:03:46 +00:00
label->set_text(p_res->get_class());
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
}
drag_control->add_child(label);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
p_from->set_drag_preview(drag_control); // Wait until it enters scene.
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
Rename [gs]et_pos to [gs]et_position for Controls Control set_pos -> set_position Control set_global_pos -> set_global_position [gs]et_mouse_pos -> [gs]et_mouse_position [gs]et_global_mouse_pos -> [gs]et_global_mouse_position fixes #8005
2017-03-29 15:29:38 +00:00
label->set_position(Point2((preview->get_width() - label->get_minimum_size().width) / 2, preview->get_height()));
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
Dictionary drag_data;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
drag_data["type"] = "resource";
drag_data["resource"] = p_res;
drag_data["from"] = p_from;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
return drag_data;
}
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-24 22:09:04 +00:00
Variant EditorNode::drag_files_and_dirs(const Vector<String> &p_paths, Control *p_from) {
bool has_folder = false;
bool has_file = false;
for (int i = 0; i < p_paths.size(); i++) {
bool is_folder = p_paths[i].ends_with("/");
has_folder |= is_folder;
has_file |= !is_folder;
}
int max_rows = 6;
Minor visual adjustment in drag preview of the scene and file tree editors
2019-09-30 16:36:49 +00:00
int num_rows = p_paths.size() > max_rows ? max_rows - 1 : p_paths.size(); // Don't waste a row to say "1 more file" - list it instead.
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-24 22:09:04 +00:00
VBoxContainer *vbox = memnew(VBoxContainer);
for (int i = 0; i < num_rows; i++) {
HBoxContainer *hbox = memnew(HBoxContainer);
TextureRect *icon = memnew(TextureRect);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Label *label = memnew(Label);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-24 22:09:04 +00:00
if (p_paths[i].ends_with("/")) {
label->set_text(p_paths[i].substr(0, p_paths[i].length() - 1).get_file());
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
icon->set_texture(gui_base->get_theme_icon(SNAME("Folder"), SNAME("EditorIcons")));
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-24 22:09:04 +00:00
} else {
label->set_text(p_paths[i].get_file());
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
icon->set_texture(gui_base->get_theme_icon(SNAME("File"), SNAME("EditorIcons")));
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-24 22:09:04 +00:00
}
Minor visual adjustment in drag preview of the scene and file tree editors
2019-09-30 16:36:49 +00:00
icon->set_stretch_mode(TextureRect::STRETCH_KEEP_CENTERED);
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-24 22:09:04 +00:00
icon->set_size(Size2(16, 16));
hbox->add_child(icon);
hbox->add_child(label);
vbox->add_child(hbox);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
}
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-24 22:09:04 +00:00
if (p_paths.size() > num_rows) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Label *label = memnew(Label);
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-24 22:09:04 +00:00
if (has_file && has_folder) {
label->set_text(vformat(TTR("%d more files or folders"), p_paths.size() - num_rows));
} else if (has_folder) {
label->set_text(vformat(TTR("%d more folders"), p_paths.size() - num_rows));
} else {
label->set_text(vformat(TTR("%d more files"), p_paths.size() - num_rows));
}
vbox->add_child(label);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
p_from->set_drag_preview(vbox); // Wait until it enters scene.
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
Dictionary drag_data;
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-24 22:09:04 +00:00
drag_data["type"] = has_folder ? "files_and_dirs" : "files";
drag_data["files"] = p_paths;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
drag_data["from"] = p_from;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 14:46:08 +00:00
return drag_data;
}
Make tool menu plugins use Callables for callback
2020-12-15 23:04:21 +00:00
void EditorNode::add_tool_menu_item(const String &p_name, const Callable &p_callback) {
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
int idx = tool_menu->get_item_count();
tool_menu->add_item(p_name, TOOLS_CUSTOM);
Make tool menu plugins use Callables for callback
2020-12-15 23:04:21 +00:00
tool_menu->set_item_metadata(idx, p_callback);
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
}
void EditorNode::add_tool_submenu_item(const String &p_name, PopupMenu *p_submenu) {
ERR_FAIL_NULL(p_submenu);
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
ERR_FAIL_COND(p_submenu->get_parent() != nullptr);
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
tool_menu->add_child(p_submenu);
tool_menu->add_submenu_item(p_name, p_submenu->get_name(), TOOLS_CUSTOM);
}
void EditorNode::remove_tool_menu_item(const String &p_name) {
for (int i = 0; i < tool_menu->get_item_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (tool_menu->get_item_id(i) != TOOLS_CUSTOM) {
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
if (tool_menu->get_item_text(i) == p_name) {
if (tool_menu->get_item_submenu(i) != "") {
Node *n = tool_menu->get_node(tool_menu->get_item_submenu(i));
tool_menu->remove_child(n);
memdelete(n);
}
tool_menu->remove_item(i);
Remove set_as_minsize()
2022-03-05 23:57:42 +00:00
tool_menu->reset_size();
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
return;
}
}
}
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 16:02:54 +00:00
void EditorNode::_global_menu_scene(const Variant &p_tag) {
int idx = (int)p_tag;
scene_tabs->set_current_tab(idx);
}
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 13:57:06 +00:00
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 16:02:54 +00:00
void EditorNode::_global_menu_new_window(const Variant &p_tag) {
if (OS::get_singleton()->get_main_loop()) {
List<String> args;
args.push_back("-p");
[macOS] Add `create_instance` function to spawn editor copies. [macOS] Modify `create_project` function to detect and run app bundles using NSWorkspace to ensure app window is registered and activated correctly.
2021-11-01 09:12:52 +00:00
OS::get_singleton()->create_instance(args);
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 13:57:06 +00:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_dropped_files(const Vector<String> &p_files, int p_screen) {
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
String to_path = ProjectSettings::get_singleton()->globalize_path(FileSystemDock::get_singleton()->get_selected_path());
Editor: Drop files to copy to project.
2017-11-17 20:52:03 +00:00
Allow to drop folders onto editor
2019-03-25 21:39:45 +00:00
_add_dropped_files_recursive(p_files, to_path);
EditorFileSystem::get_singleton()->scan_changes();
}
void EditorNode::_add_dropped_files_recursive(const Vector<String> &p_files, String to_path) {
DirAccessRef dir = DirAccess::create(DirAccess::ACCESS_FILESYSTEM);
Editor: Drop files to copy to project.
2017-11-17 20:52:03 +00:00
for (int i = 0; i < p_files.size(); i++) {
String from = p_files[i];
Allow to drop folders onto editor
2019-03-25 21:39:45 +00:00
String to = to_path.plus_file(from.get_file());
if (dir->dir_exists(from)) {
Vector<String> sub_files;
DirAccessRef sub_dir = DirAccess::open(from);
sub_dir->list_dir_begin();
String next_file = sub_dir->get_next();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
while (!next_file.is_empty()) {
Allow to drop folders onto editor
2019-03-25 21:39:45 +00:00
if (next_file == "." || next_file == "..") {
next_file = sub_dir->get_next();
continue;
}
sub_files.push_back(from.plus_file(next_file));
next_file = sub_dir->get_next();
}
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (!sub_files.is_empty()) {
Allow to drop folders onto editor
2019-03-25 21:39:45 +00:00
dir->make_dir(to);
_add_dropped_files_recursive(sub_files, to);
}
continue;
}
Editor: Drop files to copy to project.
2017-11-17 20:52:03 +00:00
dir->copy(from, to);
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 17:18:40 +00:00
}
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_file_access_close_error_notify(const String &p_str) {
Add missing i18n to various strings
2022-03-07 13:50:02 +00:00
add_io_error(vformat(TTR("Unable to write to file '%s', file in use, locked or lacking permissions."), p_str));
-Add visible IO errors when closing a file fails due to it being locked (most likely on windows), closes #4760
2016-06-13 13:10:50 +00:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 17:18:40 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::reload_scene(const String &p_path) {
int scene_idx = -1;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == p_path) {
scene_idx = i;
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 21:53:31 +00:00
break;
}
}
int current_tab = editor_data.get_edited_scene();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (scene_idx == -1) {
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 21:53:31 +00:00
if (get_edited_scene()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Scene is not open, so at it might be instantiated. We'll refresh the whole scene later.
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 21:53:31 +00:00
editor_data.get_undo_redo().clear_history();
}
return;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (current_tab == scene_idx) {
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 21:53:31 +00:00
editor_data.apply_changes_in_editors();
_set_scene_metadata(p_path);
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Reload scene.
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
_remove_scene(scene_idx, false);
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 21:57:03 +00:00
load_scene(p_path, true, false, true, true);
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Adjust index so tab is back a the previous position.
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 21:53:31 +00:00
editor_data.move_edited_scene_to_index(scene_idx);
get_undo_redo()->clear_history();
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 03:36:23 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Recover the tab.
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 21:53:31 +00:00
scene_tabs->set_current_tab(current_tab);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int EditorNode::plugin_init_callback_count = 0;
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-06 22:00:54 +00:00
void EditorNode::add_plugin_init_callback(EditorPluginInitializeCallback p_callback) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ERR_FAIL_COND(plugin_init_callback_count == MAX_INIT_CALLBACKS);
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-06 22:00:54 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
plugin_init_callbacks[plugin_init_callback_count++] = p_callback;
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-06 22:00:54 +00:00
}
EditorPluginInitializeCallback EditorNode::plugin_init_callbacks[EditorNode::MAX_INIT_CALLBACKS];
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int EditorNode::build_callback_count = 0;
Added API version and hashing to ObjectTypeDB
2016-09-14 22:37:37 +00:00
void EditorNode::add_build_callback(EditorBuildCallback p_callback) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ERR_FAIL_COND(build_callback_count == MAX_INIT_CALLBACKS);
Added API version and hashing to ObjectTypeDB
2016-09-14 22:37:37 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
build_callbacks[build_callback_count++] = p_callback;
Added API version and hashing to ObjectTypeDB
2016-09-14 22:37:37 +00:00
}
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 21:59:20 +00:00
EditorBuildCallback EditorNode::build_callbacks[EditorNode::MAX_BUILD_CALLBACKS];
Added API version and hashing to ObjectTypeDB
2016-09-14 22:37:37 +00:00
Added an auto quit and auto build flag to the command line options.
2018-02-14 15:23:04 +00:00
bool EditorNode::call_build() {
Add EditorPlugin.build() build callbacks
2018-01-08 15:55:22 +00:00
bool builds_successful = true;
for (int i = 0; i < build_callback_count && builds_successful; i++) {
if (!build_callbacks[i]()) {
ERR_PRINT("A Godot Engine build callback failed.");
builds_successful = false;
}
Call run callback
2016-09-14 22:44:08 +00:00
}
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 21:59:20 +00:00
Add EditorPlugin.build() build callbacks
2018-01-08 15:55:22 +00:00
if (builds_successful && !editor_data.call_build()) {
ERR_PRINT("An EditorPlugin build callback failed.");
builds_successful = false;
}
return builds_successful;
Call run callback
2016-09-14 22:44:08 +00:00
}
Added API version and hashing to ObjectTypeDB
2016-09-14 22:37:37 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorNode::_inherit_imported(const String &p_action) {
completed scene importing (I hope?)
2017-02-04 23:31:15 +00:00
open_imported->hide();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
load_scene(open_import_request, true, true);
completed scene importing (I hope?)
2017-02-04 23:31:15 +00:00
}
void EditorNode::_open_imported() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
load_scene(open_import_request, true, false, true, true);
completed scene importing (I hope?)
2017-02-04 23:31:15 +00:00
}
Remove `dim_editor_on_dialog_popup` from editor settings
2021-05-28 23:58:03 +00:00
void EditorNode::dim_editor(bool p_dimming) {
dimmed = p_dimming;
gui_base->set_modulate(p_dimming ? Color(0.5, 0.5, 0.5) : Color(1, 1, 1));
Editor: Dim UI when a WindowDialog is shown. Darkens the editor on WindowDialog popup. This adds the following new Editor settings: - interface/dim_editor_on_dialog_popup (true) # Enable/Disable editor dimming - interface/dim_amount (0.6) # Percentage of how much the editor will be darkened (0-1) - interface/dim_transition_time # The duration (in seconds) of the color blending effect (0-1), 0 is instant. Please test this thoroughly, I haven't yet seen a case where it fails to work properly but I'm sure I didn't test all windows of the editor :P
2017-03-06 19:11:56 +00:00
}
Make the editor dimming smarter
2019-10-31 19:58:53 +00:00
bool EditorNode::is_editor_dimmed() const {
return dimmed;
}
Export template management dialog. Missing download (need to discuss this!)
2017-03-21 02:31:41 +00:00
void EditorNode::open_export_template_manager() {
export_template_manager->popup_manager();
}
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 12:20:28 +00:00
void EditorNode::add_resource_conversion_plugin(const Ref<EditorResourceConversionPlugin> &p_plugin) {
resource_conversion_plugins.push_back(p_plugin);
}
void EditorNode::remove_resource_conversion_plugin(const Ref<EditorResourceConversionPlugin> &p_plugin) {
resource_conversion_plugins.erase(p_plugin);
}
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 06:33:00 +00:00
Vector<Ref<EditorResourceConversionPlugin>> EditorNode::find_resource_conversion_plugin(const Ref<Resource> &p_for_resource) {
Vector<Ref<EditorResourceConversionPlugin>> ret;
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 12:20:28 +00:00
for (int i = 0; i < resource_conversion_plugins.size(); i++) {
if (resource_conversion_plugins[i].is_valid() && resource_conversion_plugins[i]->handles(p_for_resource)) {
ret.push_back(resource_conversion_plugins[i]);
}
}
return ret;
}
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
void EditorNode::_bottom_panel_raise_toggled(bool p_pressed) {
Make the expand icon in the bottom panel always be the same
2019-07-29 21:08:05 +00:00
top_split->set_visible(!p_pressed);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
}
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
void EditorNode::_update_rendering_driver_color() {
Use OpenGL 3.3 core profile instead of compatibility profile - Rename OpenGL to GLES3 in the source code per community feedback. - The renderer is still exposed as "OpenGL 3" to the user. - Hide renderer selection dropdown until OpenGL support is more mature. - The renderer can still be changed in the Project Settings or using the `--rendering-driver opengl` command line argument. - Remove commented out exporter code. - Remove some OpenGL/DisplayServer-related debugging prints.
2021-10-26 15:18:39 +00:00
if (rendering_driver->get_text() == "opengl3") {
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
rendering_driver->add_theme_color_override("font_color", Color::hex(0x5586a4ff));
Rename GLES2 driver to OpenGL to prepare for the upgrade to GLES3 - Use lowercase driver names for the `--rendering-driver` command line argument.
2021-09-26 23:07:10 +00:00
} else if (rendering_driver->get_text() == "vulkan") {
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
rendering_driver->add_theme_color_override("font_color", theme_base->get_theme_color(SNAME("vulkan_color"), SNAME("Editor")));
Reflection probe support in GLES2 back-end.
2018-09-28 19:40:20 +00:00
}
}
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
void EditorNode::_rendering_driver_selected(int p_which) {
String driver = rendering_driver->get_item_metadata(p_which);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
String current_driver = OS::get_singleton()->get_current_rendering_driver_name();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
if (driver == current_driver) {
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
return;
}
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
rendering_driver_request = driver;
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
video_restart_dialog->popup_centered();
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
rendering_driver->select(rendering_driver_current);
_update_rendering_driver_color();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
}
Moved folding outside the resource files, now saved outside the project.
2018-10-29 19:36:31 +00:00
void EditorNode::_resource_saved(RES p_resource, const String &p_path) {
if (EditorFileSystem::get_singleton()) {
EditorFileSystem::get_singleton()->update_file(p_path);
}
singleton->editor_folding.save_resource_folding(p_resource, p_path);
}
void EditorNode::_resource_loaded(RES p_resource, const String &p_path) {
singleton->editor_folding.load_resource_folding(p_resource, p_path);
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
void EditorNode::_feature_profile_changed() {
Ref<EditorFeatureProfile> profile = feature_profile_manager->get_current_profile();
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
TabContainer *import_tabs = cast_to<TabContainer>(ImportDock::get_singleton()->get_parent());
TabContainer *node_tabs = cast_to<TabContainer>(NodeDock::get_singleton()->get_parent());
TabContainer *fs_tabs = cast_to<TabContainer>(FileSystemDock::get_singleton()->get_parent());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
if (profile.is_valid()) {
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
node_tabs->set_tab_hidden(node_tabs->get_tab_idx_from_control(NodeDock::get_singleton()), profile->is_feature_disabled(EditorFeatureProfile::FEATURE_NODE_DOCK));
Make the Import dock depend on the FileSystem dock
2020-05-08 19:51:42 +00:00
// The Import dock is useless without the FileSystem dock. Ensure the configuration is valid.
bool fs_dock_disabled = profile->is_feature_disabled(EditorFeatureProfile::FEATURE_FILESYSTEM_DOCK);
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
fs_tabs->set_tab_hidden(fs_tabs->get_tab_idx_from_control(FileSystemDock::get_singleton()), fs_dock_disabled);
import_tabs->set_tab_hidden(import_tabs->get_tab_idx_from_control(ImportDock::get_singleton()), fs_dock_disabled || profile->is_feature_disabled(EditorFeatureProfile::FEATURE_IMPORT_DOCK));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
main_editor_buttons[EDITOR_3D]->set_visible(!profile->is_feature_disabled(EditorFeatureProfile::FEATURE_3D));
main_editor_buttons[EDITOR_SCRIPT]->set_visible(!profile->is_feature_disabled(EditorFeatureProfile::FEATURE_SCRIPT));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (StreamPeerSSL::is_available()) {
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 13:28:34 +00:00
main_editor_buttons[EDITOR_ASSETLIB]->set_visible(!profile->is_feature_disabled(EditorFeatureProfile::FEATURE_ASSET_LIB));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Enhancements and fixes for the editor feature profile
2019-06-05 04:12:08 +00:00
if ((profile->is_feature_disabled(EditorFeatureProfile::FEATURE_3D) && singleton->main_editor_buttons[EDITOR_3D]->is_pressed()) ||
(profile->is_feature_disabled(EditorFeatureProfile::FEATURE_SCRIPT) && singleton->main_editor_buttons[EDITOR_SCRIPT]->is_pressed()) ||
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 13:28:34 +00:00
(StreamPeerSSL::is_available() && profile->is_feature_disabled(EditorFeatureProfile::FEATURE_ASSET_LIB) && singleton->main_editor_buttons[EDITOR_ASSETLIB]->is_pressed())) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
_editor_select(EDITOR_2D);
}
} else {
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
import_tabs->set_tab_hidden(import_tabs->get_tab_idx_from_control(ImportDock::get_singleton()), false);
node_tabs->set_tab_hidden(node_tabs->get_tab_idx_from_control(NodeDock::get_singleton()), false);
fs_tabs->set_tab_hidden(fs_tabs->get_tab_idx_from_control(FileSystemDock::get_singleton()), false);
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
ImportDock::get_singleton()->set_visible(true);
NodeDock::get_singleton()->set_visible(true);
FileSystemDock::get_singleton()->set_visible(true);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
main_editor_buttons[EDITOR_3D]->set_visible(true);
Enhancements and fixes for the editor feature profile
2019-06-05 04:12:08 +00:00
main_editor_buttons[EDITOR_SCRIPT]->set_visible(true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (StreamPeerSSL::is_available()) {
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 13:28:34 +00:00
main_editor_buttons[EDITOR_ASSETLIB]->set_visible(true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
}
_update_dock_slots_visibility();
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
void EditorNode::_bind_methods() {
Add project setting to change scene file casing
2021-09-12 11:21:24 +00:00
GLOBAL_DEF("editor/scene/scene_naming", SCENE_NAME_CASING_SNAKE_CASE);
ProjectSettings::get_singleton()->set_custom_property_info("editor/scene/scene_naming", PropertyInfo(Variant::INT, "editor/scene/scene_naming", PROPERTY_HINT_ENUM, "Auto,PascalCase,snake_case"));
Improvements and fixes to occluders Improvements: * Occluder3D is now an abstract type inherited by: ArrayOccluder3D, QuadOccluder3D, BoxOccluder3D, SphereOccluder3D and PolygonOccluder3D. ArrayOccluder3D serves the same purpose as the old Occluder3D (triangle mesh occluder) while the rest are primitives that can be used to manually place simple occluders. * Occluder baking can now apply simplification. The "bake_simplification_distance" property can be used to set a world-space distance as the desired maximum error, set to 0.1 by default. * Occluders can now be generated on import. Using the "occ" and "occonly" keywords (similar to "col" and "colonly" for colliders) or by enabling on MeshInstance3Ds in the scene's import window. Fixes: * Fixed saving of occluder files after bake. * Fixed a small error where occluders didn't correctly update in the rendering server. Bonus content: * Generalized "CollisionPolygon3DEditor" so it can also be used to edit Resources. Renamed it to "Polygon3DEditor" since it was already being used by other things, not just colliders. * Fixed a small bug in "EditorPropertyArray" where a call to "remove" was left after the "remove_at" rename.
2022-02-04 15:28:18 +00:00
ClassDB::bind_method("edit_current", &EditorNode::edit_current);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ClassDB::bind_method("_editor_select", &EditorNode::_editor_select);
ClassDB::bind_method("_node_renamed", &EditorNode::_node_renamed);
ClassDB::bind_method("edit_node", &EditorNode::edit_node);
Fix "method not found" error when script is removed from object
2018-12-31 08:52:09 +00:00
ClassDB::bind_method(D_METHOD("push_item", "object", "property", "inspector_only"), &EditorNode::push_item, DEFVAL(""), DEFVAL(false));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ClassDB::bind_method("_get_scene_metadata", &EditorNode::_get_scene_metadata);
ClassDB::bind_method("set_edited_scene", &EditorNode::set_edited_scene);
ClassDB::bind_method("open_request", &EditorNode::open_request);
Switch scene when editing foreign resource
2022-03-25 00:17:30 +00:00
ClassDB::bind_method("edit_foreign_resource", &EditorNode::edit_foreign_resource);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ClassDB::bind_method("_close_messages", &EditorNode::_close_messages);
ClassDB::bind_method("_show_messages", &EditorNode::_show_messages);
ClassDB::bind_method("stop_child_process", &EditorNode::stop_child_process);
ClassDB::bind_method("set_current_scene", &EditorNode::set_current_scene);
ClassDB::bind_method("set_current_version", &EditorNode::set_current_version);
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 15:30:03 +00:00
ClassDB::bind_method("_thumbnail_done", &EditorNode::_thumbnail_done);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ClassDB::bind_method("_set_main_scene_state", &EditorNode::_set_main_scene_state);
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 02:35:15 +00:00
ClassDB::bind_method("_update_recent_scenes", &EditorNode::_update_recent_scenes);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ClassDB::bind_method("_clear_undo_history", &EditorNode::_clear_undo_history);
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 16:02:54 +00:00
Added a workaround to avoid crashes due to how TileSet editor works, fixes #23672 Also fixed a few uninitialized memory variables.
2019-02-22 20:42:29 +00:00
ClassDB::bind_method("edit_item_resource", &EditorNode::edit_item_resource);
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 13:38:59 +00:00
Rename the _MD macro to D_METHOD This new name also makes its purpose a little clearer This is a step towards fixing #56
2017-02-13 11:47:24 +00:00
ClassDB::bind_method(D_METHOD("get_gui_base"), &EditorNode::get_gui_base);
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 00:47:48 +00:00
Signals: Manually port most of remaining connect_compat uses It's tedious work... Some can't be ported as they depend on private or protected methods of different classes, which is not supported by callable_mp (even if it's a class inherited by the current one).
2020-02-21 22:26:13 +00:00
ClassDB::bind_method(D_METHOD("_on_plugin_ready"), &EditorNode::_on_plugin_ready); // Still used by some connect_compat.
Add editor screenshot on control - f12.
2019-03-29 13:53:11 +00:00
ClassDB::bind_method("_screenshot", &EditorNode::_screenshot);
ClassDB::bind_method("_save_screenshot", &EditorNode::_save_screenshot);
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 00:20:54 +00:00
ClassDB::bind_method("_version_button_pressed", &EditorNode::_version_button_pressed);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ADD_SIGNAL(MethodInfo("play_pressed"));
ADD_SIGNAL(MethodInfo("pause_pressed"));
ADD_SIGNAL(MethodInfo("stop_pressed"));
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 19:26:32 +00:00
ADD_SIGNAL(MethodInfo("request_help_search"));
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
ADD_SIGNAL(MethodInfo("script_add_function_request", PropertyInfo(Variant::OBJECT, "obj"), PropertyInfo(Variant::STRING, "function"), PropertyInfo(Variant::PACKED_STRING_ARRAY, "args")));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ADD_SIGNAL(MethodInfo("resource_saved", PropertyInfo(Variant::OBJECT, "obj")));
Improve save handling for built-in scripts
2021-11-06 01:15:19 +00:00
ADD_SIGNAL(MethodInfo("scene_saved", PropertyInfo(Variant::STRING, "path")));
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
ADD_SIGNAL(MethodInfo("project_settings_changed"));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
static Node *_resource_get_edited_scene() {
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
return EditorNode::get_singleton()->get_edited_scene();
}
Add a print handler for the editor output panel
2017-11-14 22:02:31 +00:00
void EditorNode::_print_handler(void *p_this, const String &p_string, bool p_error) {
EditorNode *en = (EditorNode *)p_this;
Add warning color to output log
2018-08-13 15:04:38 +00:00
en->log->add_message(p_string, p_error ? EditorLog::MSG_TYPE_ERROR : EditorLog::MSG_TYPE_STD);
Add a print handler for the editor output panel
2017-11-14 22:02:31 +00:00
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
static void _execute_thread(void *p_ud) {
EditorNode::ExecuteThreadArgs *eta = (EditorNode::ExecuteThreadArgs *)p_ud;
Split OS::execute into two methods 1. execute(): Executes a command and returns the results. 2. create_process(): Creates a new process and returns the new process' id.
2020-12-18 18:49:13 +00:00
Error err = OS::get_singleton()->execute(eta->path, eta->args, &eta->output, &eta->exitcode, true, &eta->execute_output_mutex);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
print_verbose("Thread exit status: " + itos(eta->exitcode));
if (err != OK) {
eta->exitcode = err;
}
Modernize atomics - Based on C++11's `atomic` - Reworked `SafeRefCount` (based on the rewrite by @hpvb) - Replaced free atomic functions by the new `SafeNumeric<T>` - Replaced wrong cases of `volatile bool` by the new `SafeFlag` - Platform-specific implementations no longer needed Co-authored-by: Hein-Pieter van Braam-Stewart <hp@tmm.cx>
2021-02-10 18:22:13 +00:00
eta->done.set();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
}
int EditorNode::execute_and_show_output(const String &p_title, const String &p_path, const List<String> &p_arguments, bool p_close_on_ok, bool p_close_on_errors) {
execute_output_dialog->set_title(p_title);
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
execute_output_dialog->get_ok_button()->set_disabled(true);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
execute_outputs->clear();
execute_outputs->set_scroll_follow(true);
execute_output_dialog->popup_centered_ratio();
ExecuteThreadArgs eta;
eta.path = p_path;
eta.args = p_arguments;
eta.exitcode = 255;
int prev_len = 0;
Modernize Thread - Based on C++11's `thread` and `thread_local` - No more need to allocate-deallocate or check for null - No pointer anymore, just a member variable - Platform-specific implementations no longer needed (except for the few cases of non-portable functions) - Simpler for `NO_THREADS` - Thread ids are now the same across platforms (main is 1; others follow)
2021-01-19 12:29:41 +00:00
eta.execute_output_thread.start(_execute_thread, &eta);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
Modernize atomics - Based on C++11's `atomic` - Reworked `SafeRefCount` (based on the rewrite by @hpvb) - Replaced free atomic functions by the new `SafeNumeric<T>` - Replaced wrong cases of `volatile bool` by the new `SafeFlag` - Platform-specific implementations no longer needed Co-authored-by: Hein-Pieter van Braam-Stewart <hp@tmm.cx>
2021-02-10 18:22:13 +00:00
while (!eta.done.is_set()) {
Reimplement Mutex with C++'s <mutex> Main: - It's now implemented thanks to `<mutex>`. No more platform-specific implementations. - `BinaryMutex` (non-recursive) is added, as an alternative for special cases. - Doesn't need allocation/deallocation anymore. It can live in the stack and be part of other classes. - Because of that, it's methods are now `const` and the inner mutex is `mutable` so it can be easily used in `const` contexts. - A no-op implementation is provided if `NO_THREADS` is defined. No more need to add `#ifdef NO_THREADS` just for this. - `MutexLock` now takes a reference. At this point the cases of null `Mutex`es are rare. If you ever need that, just don't use `MutexLock`. - Thread-safe utilities are therefore simpler now. Misc.: - `ScopedMutexLock` is dropped and replaced by `MutexLock`, because they were pretty much the same. - Every case of lock, do-something, unlock is replaced by `MutexLock` (complex cases where it's not straightfoward are kept as as explicit lock and unlock). - `ShaderRD` contained an `std::mutex`, which has been replaced by `Mutex`.
2020-02-26 10:28:13 +00:00
{
MutexLock lock(eta.execute_output_mutex);
if (prev_len != eta.output.length()) {
String to_add = eta.output.substr(prev_len, eta.output.length());
prev_len = eta.output.length();
execute_outputs->add_text(to_add);
Main::iteration();
}
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
OS::get_singleton()->delay_usec(1000);
}
Modernize Thread - Based on C++11's `thread` and `thread_local` - No more need to allocate-deallocate or check for null - No pointer anymore, just a member variable - Platform-specific implementations no longer needed (except for the few cases of non-portable functions) - Simpler for `NO_THREADS` - Thread ids are now the same across platforms (main is 1; others follow)
2021-01-19 12:29:41 +00:00
eta.execute_output_thread.wait_to_finish();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
execute_outputs->add_text("\nExit Code: " + itos(eta.exitcode));
if (p_close_on_errors && eta.exitcode != 0) {
execute_output_dialog->hide();
}
if (p_close_on_ok && eta.exitcode == 0) {
execute_output_dialog->hide();
}
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
execute_output_dialog->get_ok_button()->set_disabled(false);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
return eta.exitcode;
}
Fix editor always redrawing -Only update rendering settings when project settings change -Fixes the update spinner (and editor rendering) updating all the time. -Added a "project_settings_changed" signal to EditorNode and EditorPlugin
2021-02-13 14:06:56 +00:00
void EditorNode::notify_settings_changed() {
settings_changed = true;
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
EditorNode::EditorNode() {
i18n: Make property paths and categories translatable
2022-03-03 10:25:11 +00:00
EditorPropertyNameProcessor *epnp = memnew(EditorPropertyNameProcessor);
add_child(epnp);
Add PortableCompressedTexture * Resource that allows saving textures embedded in scenes or standalone. * Supports only formats that are portable: Lossy, Lossles or BasisUniversal This is something I wanted to add for a long time. I made it now because @fire requires it for importing GLTF2 files with embedded textures, but also this will allow saving Godot scenes as standalone binary files that will run in all platforms (because textures will load everywhere). This is ideal when you want to distribute individual standalone assets online in games that can be built from Godot scenes.
2022-03-24 17:18:55 +00:00
PortableCompressedTexture2D::set_keep_all_compressed_buffers(true);
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 13:19:37 +00:00
Input::get_singleton()->set_use_accumulated_input(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Resource::_get_local_scene_func = _resource_get_edited_scene;
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 04:04:31 +00:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 18:21:27 +00:00
RenderingServer::get_singleton()->set_debug_generate_wireframes(true);
baking now shows a proper button, and bakes can be saved.
2016-12-23 03:37:38 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// No navigation server by default if in editor.
NavigationServer3D::get_singleton()->set_active(false);
// No physics by default if in editor.
PhysicsServer3D::get_singleton()->set_active(false);
PhysicsServer2D::get_singleton()->set_active(false);
- Integrated NavigationServer and Navigation2DServer. - Added Navigation Agents and Obstacles. - Integrated Collision Avoidance. This work has been kindly sponsored by IMVU.
2020-01-10 11:22:34 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// No scripting by default if in editor.
ScriptServer::set_scripting_enabled(false);
Disable scripting and physics early in EditorNode This avoids issues with scripts being instanced before this is set, like autoloads.
2018-08-21 00:55:01 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
EditorHelp::generate_doc(); // Before any editor classes are created.
-fixes and more fixes to new scene system, seems stable now.. BUT DONT TRUST ME IT MAY STILL BREAK, USE WITH CARE!!
2015-10-16 22:11:23 +00:00
SceneState::set_disable_placeholders(true);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
ResourceLoader::clear_translation_remaps(); // Using no remaps if in editor.
GDScript files are converted to binary on export now.
2017-12-14 18:33:54 +00:00
ResourceLoader::clear_path_remaps();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 13:19:37 +00:00
Input *id = Input::get_singleton();
Added ability to set custom mouse cursors. Not hardware accelerated yet.
2015-09-24 21:06:15 +00:00
if (id) {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
bool found_touchscreen = false;
for (int i = 0; i < DisplayServer::get_singleton()->get_screen_count(); i++) {
if (DisplayServer::get_singleton()->screen_is_touchscreen(i)) {
found_touchscreen = true;
}
}
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 13:19:37 +00:00
if (!found_touchscreen && Input::get_singleton()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Only if no touchscreen ui hint, disable emulation just in case.
id->set_emulate_touch_from_mouse(false);
Added ability to set custom mouse cursors. Not hardware accelerated yet.
2015-09-24 21:06:15 +00:00
}
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
DisplayServer::get_singleton()->cursor_set_custom_image(RES());
-display/emulate_touchscreen now really emulates a touchscreen -icons to show node menus
2015-08-29 20:16:11 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
singleton = this;
last_checked_version = 0;
Separate fullscreen state for scene & script editor
2017-04-25 11:48:35 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
TranslationServer::get_singleton()->set_enabled(false);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Load settings.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!EditorSettings::get_singleton()) {
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
EditorSettings::create();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Make Godot detect if the screen is too small (<1200 pixels wide), and use single dock column like in 1.0 if that's the case.
2016-09-13 14:20:09 +00:00
Properly save the new save safe setting, avoid crash.
2018-01-12 20:18:40 +00:00
FileAccess::set_backup_save(EDITOR_GET("filesystem/on_save/safe_save_on_backup_then_rename"));
make hdpi manually configurable in project settings also added hidpi support to project manager
2016-06-05 21:43:45 +00:00
{
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 19:20:42 +00:00
int display_scale = EditorSettings::get_singleton()->get("interface/editor/display_scale");
switch (display_scale) {
EditorSettings: Factor code to compute auto display scale Also fixes typo introduced in https://github.com/godotengine/godot/pull/48597/files#r652636544.
2021-06-16 12:36:09 +00:00
case 0:
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 15:01:27 +00:00
// Try applying a suitable display scale automatically.
EditorSettings: Factor code to compute auto display scale Also fixes typo introduced in https://github.com/godotengine/godot/pull/48597/files#r652636544.
2021-06-16 12:36:09 +00:00
editor_set_scale(EditorSettings::get_singleton()->get_auto_display_scale());
break;
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 15:01:27 +00:00
case 1:
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 19:20:42 +00:00
editor_set_scale(0.75);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 15:01:27 +00:00
break;
case 2:
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 19:20:42 +00:00
editor_set_scale(1.0);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 15:01:27 +00:00
break;
case 3:
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 19:20:42 +00:00
editor_set_scale(1.25);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 15:01:27 +00:00
break;
case 4:
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 19:20:42 +00:00
editor_set_scale(1.5);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 15:01:27 +00:00
break;
case 5:
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 19:20:42 +00:00
editor_set_scale(1.75);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 15:01:27 +00:00
break;
case 6:
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 19:20:42 +00:00
editor_set_scale(2.0);
Use 75% editor scale on small displays automatically This also makes borders always display in the editor theme, even if the editor scale is below 100%. Otherwise, "focus" outlines would vanish when using an editor scale below 100%, which harms usability.
2020-11-12 15:01:27 +00:00
break;
default:
editor_set_scale(EditorSettings::get_singleton()->get("interface/editor/custom_display_scale"));
break;
make hdpi manually configurable in project settings also added hidpi support to project manager
2016-06-05 21:43:45 +00:00
}
}
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Define a minimum window size to prevent UI elements from overlapping or being cut off.
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 13:36:29 +00:00
DisplayServer::get_singleton()->window_set_min_size(Size2(1024, 600) * EDSCALE);
Define a minimum window size in the editor and project manager This prevents most UI elements from overlapping or being cut off as a result of the window being too small. This closes #20669.
2019-08-17 19:56:59 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
ResourceLoader::set_abort_on_missing_resources(false);
Editor settings categories are now tidy and beautiful!
2017-01-05 22:41:36 +00:00
FileDialog::set_default_show_hidden_files(EditorSettings::get_singleton()->get("filesystem/file_dialog/show_hidden_files"));
EditorFileDialog::set_default_show_hidden_files(EditorSettings::get_singleton()->get("filesystem/file_dialog/show_hidden_files"));
EditorFileDialog::set_default_display_mode((EditorFileDialog::DisplayMode)EditorSettings::get_singleton()->get("filesystem/file_dialog/display_mode").operator int());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ResourceLoader::set_error_notify_func(this, _load_error_notify);
ResourceLoader::set_dependency_error_notify_func(this, _dependency_error_report);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
{
// Register importers at the beginning, so dialogs are created with the right extensions.
Lot of work in new importer, importing textures now works.
2017-02-01 12:45:45 +00:00
Ref<ResourceImporterTexture> import_texture;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_texture.instantiate();
Lot of work in new importer, importing textures now works.
2017-02-01 12:45:45 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_texture);
CSV translation import plugin
2017-02-01 23:41:05 +00:00
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 12:34:23 +00:00
Ref<ResourceImporterLayeredTexture> import_cubemap;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_cubemap.instantiate();
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
import_cubemap->set_mode(ResourceImporterLayeredTexture::MODE_CUBEMAP);
ResourceFormatImporter::get_singleton()->add_importer(import_cubemap);
Added proper import support for 3D and Array textures
2018-08-06 17:56:06 +00:00
Ref<ResourceImporterLayeredTexture> import_array;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_array.instantiate();
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
import_array->set_mode(ResourceImporterLayeredTexture::MODE_2D_ARRAY);
Added proper import support for 3D and Array textures
2018-08-06 17:56:06 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_array);
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
Ref<ResourceImporterLayeredTexture> import_cubemap_array;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_cubemap_array.instantiate();
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
import_cubemap_array->set_mode(ResourceImporterLayeredTexture::MODE_CUBEMAP_ARRAY);
ResourceFormatImporter::get_singleton()->add_importer(import_cubemap_array);
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 12:34:23 +00:00
Implement 3D textures as import and resource format.
2020-09-09 15:40:51 +00:00
Ref<ResourceImporterLayeredTexture> import_3d;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_3d.instantiate();
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 12:34:23 +00:00
import_3d->set_mode(ResourceImporterLayeredTexture::MODE_3D);
Implement 3D textures as import and resource format.
2020-09-09 15:40:51 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_3d);
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 12:34:23 +00:00
It is now possible to import images as a separate resource, closes #5738 and likely many others
2018-07-29 19:45:23 +00:00
Ref<ResourceImporterImage> import_image;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_image.instantiate();
It is now possible to import images as a separate resource, closes #5738 and likely many others
2018-07-29 19:45:23 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_image);
Added ability for multiple images to be imported as an atlas This adds support for groups in the import system, which point to a single file. Add property hint for saving files in file field
2019-04-19 18:54:33 +00:00
Ref<ResourceImporterTextureAtlas> import_texture_atlas;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_texture_atlas.instantiate();
Added ability for multiple images to be imported as an atlas This adds support for groups in the import system, which point to a single file. Add property hint for saving files in file field
2019-04-19 18:54:33 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_texture_atlas);
Makes FontData importable resource. Adds multi-channel SDF font texture generation and rendering support. Adds per-font oversampling support. Adds FontData import plugins (for dynamic fonts, BMFonts and monospaced image fonts), font texture cache pre-generation and loading. Adds BMFont binary format and outline support.
2020-12-27 13:30:33 +00:00
Ref<ResourceImporterDynamicFont> import_font_data_dynamic;
import_font_data_dynamic.instantiate();
ResourceFormatImporter::get_singleton()->add_importer(import_font_data_dynamic);
Ref<ResourceImporterBMFont> import_font_data_bmfont;
import_font_data_bmfont.instantiate();
ResourceFormatImporter::get_singleton()->add_importer(import_font_data_bmfont);
Ref<ResourceImporterImageFont> import_font_data_image;
import_font_data_image.instantiate();
ResourceFormatImporter::get_singleton()->add_importer(import_font_data_image);
CSV translation import plugin
2017-02-01 23:41:05 +00:00
Ref<ResourceImporterCSVTranslation> import_csv_translation;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_csv_translation.instantiate();
CSV translation import plugin
2017-02-01 23:41:05 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_csv_translation);
wav file importing!
2017-02-03 01:51:26 +00:00
Ref<ResourceImporterWAV> import_wav;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_wav.instantiate();
wav file importing!
2017-02-03 01:51:26 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_wav);
Restored ability to import OBJ files as meshes directly. Finally closes #9445.
2017-09-29 23:38:27 +00:00
Ref<ResourceImporterOBJ> import_obj;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_obj.instantiate();
Restored ability to import OBJ files as meshes directly. Finally closes #9445.
2017-09-29 23:38:27 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_obj);
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 02:19:21 +00:00
Ref<ResourceImporterShaderFile> import_shader_file;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_shader_file.instantiate();
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 02:19:21 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_shader_file);
Scene import more or less working, needs some missing features.
2017-02-04 12:48:04 +00:00
Ref<ResourceImporterScene> import_scene;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_scene.instantiate();
Scene import more or less working, needs some missing features.
2017-02-04 12:48:04 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_scene);
{
Add scene Post-Import Plugin support. * New plugin system to control the whole import workflow * Can add options and run code at every import step (general, per node, mesh, animation, material etc.) This constitutes a first version of these plugins. The ability to interact with the import preview dialog will likely be added later on.
2021-10-14 17:34:27 +00:00
Ref<EditorSceneFormatImporterCollada> import_collada;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_collada.instantiate();
Scene import more or less working, needs some missing features.
2017-02-04 12:48:04 +00:00
import_scene->add_importer(import_collada);
-Reorganized all properties of project settings (Sorry, Again). (Lot's of bloat accumulated, so it was time for clean up.) -Made EditorSettings and ProjectSettings search more useful (search in sections too)
2017-07-18 00:05:38 +00:00
Add -Wshadow=local to warnings and fix reported issues. Fixes #25316.
2019-02-12 20:10:08 +00:00
Ref<EditorOBJImporter> import_obj2;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_obj2.instantiate();
Add -Wshadow=local to warnings and fix reported issues. Fixes #25316.
2019-02-12 20:10:08 +00:00
import_scene->add_importer(import_obj2);
-Added GLTF scene support (still missing animations and .glb extension) -Fixed bugs regarding tangent generation in SurfaceTool
2017-08-02 18:34:55 +00:00
Add scene Post-Import Plugin support. * New plugin system to control the whole import workflow * Can add options and run code at every import step (general, per node, mesh, animation, material etc.) This constitutes a first version of these plugins. The ability to interact with the import preview dialog will likely be added later on.
2021-10-14 17:34:27 +00:00
Ref<EditorSceneFormatImporterESCN> import_escn;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_escn.instantiate();
Ability to import .escn files, which is just a .tscn but with forced import. This works together with the new Blender to Godot exporter.
2018-01-30 14:03:46 +00:00
import_scene->add_importer(import_escn);
Scene import more or less working, needs some missing features.
2017-02-04 12:48:04 +00:00
}
Removed PBM bitmap loader, added abiliy to importi mages as bitmap. Fixes #14828
2018-01-06 19:36:49 +00:00
Ref<ResourceImporterBitMap> import_bitmap;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
import_bitmap.instantiate();
Removed PBM bitmap loader, added abiliy to importi mages as bitmap. Fixes #14828
2018-01-06 19:36:49 +00:00
ResourceFormatImporter::get_singleton()->add_importer(import_bitmap);
Lot of work in new importer, importing textures now works.
2017-02-01 12:45:45 +00:00
}
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 20:12:35 +00:00
{
Ref<EditorInspectorDefaultPlugin> eidp;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
eidp.instantiate();
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 20:12:35 +00:00
EditorInspector::add_inspector_plugin(eidp);
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-26 22:05:11 +00:00
Ref<EditorInspectorRootMotionPlugin> rmp;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
rmp.instantiate();
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-26 22:05:11 +00:00
EditorInspector::add_inspector_plugin(rmp);
Visual Shaders are back.
2018-07-14 21:15:42 +00:00
Ref<EditorInspectorShaderModePlugin> smp;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
smp.instantiate();
Visual Shaders are back.
2018-07-14 21:15:42 +00:00
EditorInspector::add_inspector_plugin(smp);
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 20:12:35 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
editor_selection = memnew(EditorSelection);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
EditorFileSystem *efs = memnew(EditorFileSystem);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
add_child(efs);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Used for previews.
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
FileDialog::get_icon_func = _file_dialog_get_icon;
FileDialog::register_func = _file_dialog_register;
FileDialog::unregister_func = _file_dialog_unregister;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
EditorFileDialog::get_icon_func = _file_dialog_get_icon;
EditorFileDialog::register_func = _editor_file_dialog_register;
EditorFileDialog::unregister_func = _editor_file_dialog_unregister;
work in progress, resource previews
2015-05-31 04:59:42 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
editor_export = memnew(EditorExport);
Editor Export Settings Dialog is completed!! Now on to make some exporters..
2017-02-20 02:19:30 +00:00
add_child(editor_export);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Exporters might need the theme.
Fix EditorNode.get_editor_theme EditorNode was not correctly setting the class memeber when creating the theme, using a local variable instead. Theme is now created before registering exporters (as they might need it).
2019-10-11 11:21:24 +00:00
theme = create_custom_theme();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
register_exporters();
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-26 22:05:11 +00:00
ClassDB::set_class_enabled("RootMotionView", true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Add a "save on focus loss" editor setting (disabled by default) This performs a Ctrl + S action every time the editor window loses focus, saving both scenes and scripts as needed.
2021-04-11 13:39:31 +00:00
EDITOR_DEF("interface/editor/save_on_focus_loss", false);
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
EDITOR_DEF("interface/editor/show_update_spinner", false);
EDITOR_DEF("interface/editor/update_continuously", false);
Add property name style toggle to Inspector
2022-03-23 01:46:59 +00:00
EDITOR_DEF("interface/editor/localize_settings", true);
Make restore_scenes_on_load true by default
2021-09-12 14:11:56 +00:00
EDITOR_DEF_RST("interface/scene_tabs/restore_scenes_on_load", true);
Add property name style toggle to Inspector
2022-03-23 01:46:59 +00:00
EDITOR_DEF_RST("interface/inspector/default_property_name_style", EditorPropertyNameProcessor::STYLE_CAPITALIZED);
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::INT, "interface/inspector/default_property_name_style", PROPERTY_HINT_ENUM, "Raw,Capitalized,Localized"));
Inspector: Make default float step configurable Also allow lifting the decimal step formatting with a hint range step of 0. A new `range_step_decimals()` is added for this to avoid breaking compatibility on the general purpose `step_decimals()` (which still returns 0 for an input step of 0). Supersedes #25470. Partial fix for #18251.
2019-07-23 15:27:55 +00:00
EDITOR_DEF_RST("interface/inspector/default_float_step", 0.001);
Variant: Added 64-bit packed arrays, renamed Variant::REAL to FLOAT. - Renames PackedIntArray to PackedInt32Array. - Renames PackedFloatArray to PackedFloat32Array. - Adds PackedInt64Array and PackedFloat64Array. - Renames Variant::REAL to Variant::FLOAT for consistency. Packed arrays are for storing large amount of data and creating stuff like meshes, buffers. textures, etc. Forcing them to be 64 is a huge waste of memory. That said, many users requested the ability to have 64 bits packed arrays for their games, so this is just an optional added type. For Variant, the float datatype is always 64 bits, and exposed as `float`. We still have `real_t` which is the datatype that can change from 32 to 64 bits depending on a compile flag (not entirely working right now, but that's the idea). It affects math related datatypes and code only. Neither Variant nor PackedArray make use of real_t, which is only intended for math precision, so the term is removed from there to keep only float.
2020-02-24 18:20:53 +00:00
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::FLOAT, "interface/inspector/default_float_step", PROPERTY_HINT_RANGE, "0,1,0"));
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
EDITOR_DEF_RST("interface/inspector/disable_folding", false);
Rewrite code for unfolding and make it automatic on scene load, which works better.
2018-11-25 13:46:26 +00:00
EDITOR_DEF_RST("interface/inspector/auto_unfold_foreign_scenes", true);
Several improvements to inspector. -Added optional horizontal/vertical modes for vector editing (default false for vec2, true for vec3) -Some clean ups with fonts and styles
2018-08-07 15:19:19 +00:00
EDITOR_DEF("interface/inspector/horizontal_vector2_editing", false);
Make Rect2 EditorProperty obey the horizontal setting
2018-09-23 03:20:36 +00:00
EDITOR_DEF("interface/inspector/horizontal_vector_types_editing", true);
Visual Shaders are back.
2018-07-14 21:15:42 +00:00
EDITOR_DEF("interface/inspector/open_resources_in_current_inspector", true);
Rework the TileSet resource and TileMap nodes: - Move most properties from TileMap to TileSet, - Make TileSet more flexible, supporting more feature (several collision layers, etc...), - Fusion both the TileMap and TileSet editor, - Implement TileSetSources, and thus a new way to index tiles in the TileSet, - Rework the TileSet and TileMap editors completely, - Implement an editor zoom widget (and use it in several places)
2021-05-07 13:41:39 +00:00
EDITOR_DEF("interface/inspector/resources_to_open_in_new_inspector", "Script,MeshLibrary");
Default ColorPicker color mode setting There is a new setting for Default ColorPicker color mode in Editor Settings->Interface->Inspector. Initially this setting will be RGB. Editor ColorPicker will always start with mode defined in this settiing. Fixes #30755 and #30754
2019-08-30 20:25:15 +00:00
EDITOR_DEF("interface/inspector/default_color_picker_mode", 0);
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::INT, "interface/inspector/default_color_picker_mode", PROPERTY_HINT_ENUM, "RGB,HSV,RAW", PROPERTY_USAGE_DEFAULT));
Add Various ColorPicker shapes
2021-02-23 10:22:46 +00:00
EDITOR_DEF("interface/inspector/default_color_picker_shape", (int32_t)ColorPicker::SHAPE_VHS_CIRCLE);
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::INT, "interface/inspector/default_color_picker_shape", PROPERTY_HINT_ENUM, "HSV Rectangle,HSV Rectangle Wheel,VHS Circle", PROPERTY_USAGE_DEFAULT));
Add ViewPanner to 2D editor
2022-01-19 18:59:12 +00:00
ED_SHORTCUT("canvas_item_editor/pan_view", TTR("Pan View"), Key::SPACE);
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 21:02:16 +00:00
Add TextFile support across the editor
2021-09-23 21:09:15 +00:00
const Vector<String> textfile_ext = ((String)(EditorSettings::get_singleton()->get("docks/filesystem/textfile_extensions"))).split(",", false);
for (const String &E : textfile_ext) {
textfile_extensions.insert(E);
}
New customizable editor theme
2017-05-02 20:13:12 +00:00
theme_base = memnew(Control);
-added missing .inc files -Made it possible to change the editor theme -Added two options to theme editor plugin to create empty template themes and editor themes -Make sure that saved themes to .tres keep the null theme fields, to make it easier to keep those when saving/loading the theme
2016-06-17 04:13:23 +00:00
add_child(theme_base);
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
theme_base->set_anchors_and_offsets_preset(Control::PRESET_WIDE);
-added missing .inc files -Made it possible to change the editor theme -Added two options to theme editor plugin to create empty template themes and editor themes -Make sure that saved themes to .tres keep the null theme fields, to make it easier to keep those when saving/loading the theme
2016-06-17 04:13:23 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
gui_base = memnew(Panel);
-added missing .inc files -Made it possible to change the editor theme -Added two options to theme editor plugin to create empty template themes and editor themes -Make sure that saved themes to .tres keep the null theme fields, to make it easier to keep those when saving/loading the theme
2016-06-17 04:13:23 +00:00
theme_base->add_child(gui_base);
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
gui_base->set_anchors_and_offsets_preset(Control::PRESET_WIDE);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
theme_base->set_theme(theme);
Fixed theme update and some widgets.
2017-11-11 17:57:54 +00:00
gui_base->set_theme(theme);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
gui_base->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("Background"), SNAME("EditorStyles")));
-added missing .inc files -Made it possible to change the editor theme -Added two options to theme editor plugin to create empty template themes and editor themes -Make sure that saved themes to .tres keep the null theme fields, to make it easier to keep those when saving/loading the theme
2016-06-17 04:13:23 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
resource_preview = memnew(EditorResourcePreview);
work in progress, resource previews
2015-05-31 04:59:42 +00:00
add_child(resource_preview);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
progress_dialog = memnew(ProgressDialog);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
gui_base->add_child(progress_dialog);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Take up all screen.
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
gui_base->set_anchor(SIDE_RIGHT, Control::ANCHOR_END);
gui_base->set_anchor(SIDE_BOTTOM, Control::ANCHOR_END);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
gui_base->set_end(Point2(0, 0));
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
main_vbox = memnew(VBoxContainer);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
gui_base->add_child(main_vbox);
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
main_vbox->set_anchors_and_offsets_preset(Control::PRESET_WIDE, Control::PRESET_MODE_MINSIZE, 8);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
main_vbox->add_theme_constant_override("separation", 8 * EDSCALE);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
menu_hb = memnew(HBoxContainer);
-fixed tabs
2015-11-18 07:47:41 +00:00
main_vbox->add_child(menu_hb);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
left_l_hsplit = memnew(HSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
main_vbox->add_child(left_l_hsplit);
left_l_hsplit->set_v_size_flags(Control::SIZE_EXPAND_FILL);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
left_l_vsplit = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
left_l_hsplit->add_child(left_l_vsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_slot[DOCK_SLOT_LEFT_UL] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
left_l_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_UL]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_slot[DOCK_SLOT_LEFT_BL] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
left_l_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_BL]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
left_r_hsplit = memnew(HSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
left_l_hsplit->add_child(left_r_hsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
left_r_vsplit = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
left_r_hsplit->add_child(left_r_vsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_slot[DOCK_SLOT_LEFT_UR] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
left_r_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_UR]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_slot[DOCK_SLOT_LEFT_BR] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
left_r_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_BR]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
main_hsplit = memnew(HSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
left_r_hsplit->add_child(main_hsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
VBoxContainer *center_vb = memnew(VBoxContainer);
-fixed tabs
2015-11-18 07:47:41 +00:00
main_hsplit->add_child(center_vb);
center_vb->set_h_size_flags(Control::SIZE_EXPAND_FILL);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
center_split = memnew(VSplitContainer);
-fixed tabs
2015-11-18 07:47:41 +00:00
center_split->set_v_size_flags(Control::SIZE_EXPAND_FILL);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
center_split->set_collapsed(false);
-fixed tabs
2015-11-18 07:47:41 +00:00
center_vb->add_child(center_split);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
right_hsplit = memnew(HSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
main_hsplit->add_child(right_hsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
right_l_vsplit = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
right_hsplit->add_child(right_l_vsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_slot[DOCK_SLOT_RIGHT_UL] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
right_l_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_UL]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_slot[DOCK_SLOT_RIGHT_BL] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
right_l_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_BL]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
right_r_vsplit = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
right_hsplit->add_child(right_r_vsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_slot[DOCK_SLOT_RIGHT_UR] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
right_r_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_UR]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_slot[DOCK_SLOT_RIGHT_BR] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
right_r_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_BR]);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Store them for easier access.
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
vsplits.push_back(left_l_vsplit);
vsplits.push_back(left_r_vsplit);
vsplits.push_back(right_l_vsplit);
vsplits.push_back(right_r_vsplit);
hsplits.push_back(left_l_hsplit);
hsplits.push_back(left_r_hsplit);
hsplits.push_back(main_hsplit);
hsplits.push_back(right_hsplit);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
for (int i = 0; i < vsplits.size(); i++) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
vsplits[i]->connect("dragged", callable_mp(this, &EditorNode::_dock_split_dragged));
hsplits[i]->connect("dragged", callable_mp(this, &EditorNode::_dock_split_dragged));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
EditorNode: remove obsolete comments in constructor
2017-07-18 13:04:20 +00:00
dock_select_popup = memnew(PopupPanel);
gui_base->add_child(dock_select_popup);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
VBoxContainer *dock_vb = memnew(VBoxContainer);
EditorNode: remove obsolete comments in constructor
2017-07-18 13:04:20 +00:00
dock_select_popup->add_child(dock_vb);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *dock_hb = memnew(HBoxContainer);
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
dock_tab_move_left = memnew(Button);
dock_tab_move_left->set_flat(true);
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
if (gui_base->is_layout_rtl()) {
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
dock_tab_move_left->set_icon(theme->get_icon(SNAME("Forward"), SNAME("EditorIcons")));
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
} else {
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
dock_tab_move_left->set_icon(theme->get_icon(SNAME("Back"), SNAME("EditorIcons")));
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_tab_move_left->set_focus_mode(Control::FOCUS_NONE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
dock_tab_move_left->connect("pressed", callable_mp(this, &EditorNode::_dock_move_left));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_hb->add_child(dock_tab_move_left);
Added a label to the Dock Positioner.
2017-11-19 05:00:42 +00:00
Label *dock_label = memnew(Label);
dock_label->set_text(TTR("Dock Position"));
dock_label->set_h_size_flags(Control::SIZE_EXPAND_FILL);
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 02:58:47 +00:00
dock_label->set_horizontal_alignment(HORIZONTAL_ALIGNMENT_CENTER);
Added a label to the Dock Positioner.
2017-11-19 05:00:42 +00:00
dock_hb->add_child(dock_label);
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
dock_tab_move_right = memnew(Button);
dock_tab_move_right->set_flat(true);
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
if (gui_base->is_layout_rtl()) {
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
dock_tab_move_right->set_icon(theme->get_icon(SNAME("Back"), SNAME("EditorIcons")));
Fix arrow pointing in the wrong direction in the Dock Position popup
2021-09-24 00:32:48 +00:00
} else {
Add missing SNAME macro optimization in some function calls
2022-02-06 14:53:53 +00:00
dock_tab_move_right->set_icon(theme->get_icon(SNAME("Forward"), SNAME("EditorIcons")));
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface. Implement interface mirroring. Add TextLine and TextParagraph classes. Handle UTF-16 input on macOS and Windows.
2020-09-03 11:22:16 +00:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_tab_move_right->set_focus_mode(Control::FOCUS_NONE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
dock_tab_move_right->connect("pressed", callable_mp(this, &EditorNode::_dock_move_right));
fixes for dock motion
2015-06-14 03:41:08 +00:00
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_hb->add_child(dock_tab_move_right);
dock_vb->add_child(dock_hb);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_select = memnew(Control);
Fixes the editor layout
2018-10-26 10:44:49 +00:00
dock_select->set_custom_minimum_size(Size2(128, 64) * EDSCALE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
dock_select->connect("gui_input", callable_mp(this, &EditorNode::_dock_select_input));
dock_select->connect("draw", callable_mp(this, &EditorNode::_dock_select_draw));
dock_select->connect("mouse_exited", callable_mp(this, &EditorNode::_dock_popup_exit));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_select->set_v_size_flags(Control::SIZE_EXPAND_FILL);
dock_vb->add_child(dock_select);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
dock_float = memnew(Button);
General enhancements to floating docks
2020-03-27 19:48:42 +00:00
dock_float->set_text(TTR("Make Floating"));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
dock_float->set_focus_mode(Control::FOCUS_NONE);
dock_float->set_h_size_flags(Control::SIZE_SHRINK_CENTER);
dock_float->connect("pressed", callable_mp(this, &EditorNode::_dock_make_float));
dock_vb->add_child(dock_float);
Remove set_as_minsize()
2022-03-05 23:57:42 +00:00
dock_select_popup->reset_size();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
dock_select_rect_over_idx = -1;
dock_popup_selected_idx = -1;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Fixes the editor layout
2018-10-26 10:44:49 +00:00
dock_slot[i]->set_custom_minimum_size(Size2(170, 0) * EDSCALE);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
dock_slot[i]->set_v_size_flags(Control::SIZE_EXPAND_FILL);
EditorNode: remove obsolete comments in constructor
2017-07-18 13:04:20 +00:00
dock_slot[i]->set_popup(dock_select_popup);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
dock_slot[i]->connect("pre_popup_pressed", callable_mp(this, &EditorNode::_dock_pre_popup), varray(i));
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
dock_slot[i]->set_drag_to_rearrange_enabled(true);
dock_slot[i]->set_tabs_rearrange_group(1);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
dock_slot[i]->connect("tab_changed", callable_mp(this, &EditorNode::_dock_tab_changed));
Make tab containers in editor, project settings, and export dialog, to use hidden tabs for min size computation.
2019-01-26 18:41:36 +00:00
dock_slot[i]->set_use_hidden_tabs_for_min_size(true);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
dock_drag_timer = memnew(Timer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
add_child(dock_drag_timer);
dock_drag_timer->set_wait_time(0.5);
dock_drag_timer->set_one_shot(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
dock_drag_timer->connect("timeout", callable_mp(this, &EditorNode::_save_docks));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
top_split = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
center_split->add_child(top_split);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
top_split->set_v_size_flags(Control::SIZE_EXPAND_FILL);
top_split->set_collapsed(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
VBoxContainer *srt = memnew(VBoxContainer);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
srt->set_v_size_flags(Control::SIZE_EXPAND_FILL);
top_split->add_child(srt);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
srt->add_theme_constant_override("separation", 0);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 15:30:03 +00:00
tab_preview_panel = memnew(Panel);
tab_preview_panel->set_size(Size2(100, 100) * EDSCALE);
tab_preview_panel->hide();
tab_preview_panel->set_self_modulate(Color(1, 1, 1, 0.7));
gui_base->add_child(tab_preview_panel);
tab_preview = memnew(TextureRect);
tab_preview->set_stretch_mode(TextureRect::STRETCH_KEEP_ASPECT_CENTERED);
tab_preview->set_size(Size2(96, 96) * EDSCALE);
tab_preview->set_position(Point2(2, 2) * EDSCALE);
tab_preview_panel->add_child(tab_preview);
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
tabbar_container = memnew(HBoxContainer);
srt->add_child(tabbar_container);
Rename `Tabs` to `TabBar`
2021-10-17 16:55:44 +00:00
scene_tabs = memnew(TabBar);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
scene_tabs->add_theme_style_override("tab_selected", gui_base->get_theme_stylebox(SNAME("SceneTabFG"), SNAME("EditorStyles")));
scene_tabs->add_theme_style_override("tab_unselected", gui_base->get_theme_stylebox(SNAME("SceneTabBG"), SNAME("EditorStyles")));
context menu improvements
2018-01-02 07:10:49 +00:00
scene_tabs->set_select_with_rmb(true);
-fixed tabs
2015-11-18 07:47:41 +00:00
scene_tabs->add_tab("unsaved");
Improve scene tab close button options
2022-03-13 01:03:26 +00:00
scene_tabs->set_tab_close_display_policy((TabBar::CloseButtonDisplayPolicy)EDITOR_GET("interface/scene_tabs/display_close_button").operator int());
Replace `TabBar`'s `min_width` with `max_tab_width` and expose it
2022-02-03 05:45:31 +00:00
scene_tabs->set_max_tab_width(int(EDITOR_GET("interface/scene_tabs/maximum_width")) * EDSCALE);
Drag to rearrange Tabs and TabContainer
2018-02-07 13:01:45 +00:00
scene_tabs->set_drag_to_rearrange_enabled(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
scene_tabs->connect("tab_changed", callable_mp(this, &EditorNode::_scene_tab_changed));
Bring `TabBar` to full parity with the `TabContainer` implementation.
2022-01-19 16:11:44 +00:00
scene_tabs->connect("tab_button_pressed", callable_mp(this, &EditorNode::_scene_tab_script_edited));
Rename `TabBar`'s `tab_closed` signal to `tab_close_pressed`
2021-10-27 22:39:13 +00:00
scene_tabs->connect("tab_close_pressed", callable_mp(this, &EditorNode::_scene_tab_closed), varray(SCENE_TAB_CLOSE));
Fix connections to CanvasItem and Tabs signals Follow-up to #44188 and #44189.
2020-12-09 11:04:02 +00:00
scene_tabs->connect("tab_hovered", callable_mp(this, &EditorNode::_scene_tab_hovered));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
scene_tabs->connect("mouse_exited", callable_mp(this, &EditorNode::_scene_tab_exit));
scene_tabs->connect("gui_input", callable_mp(this, &EditorNode::_scene_tab_input));
Rename some elements of `Tabs`
2021-09-30 23:18:23 +00:00
scene_tabs->connect("active_tab_rearranged", callable_mp(this, &EditorNode::_reposition_active_tab));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
scene_tabs->connect("resized", callable_mp(this, &EditorNode::_update_scene_tabs));
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
scene_tabs->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
tabbar_container->add_child(scene_tabs);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
context menu improvements
2018-01-02 07:10:49 +00:00
scene_tabs_context_menu = memnew(PopupMenu);
tabbar_container->add_child(scene_tabs_context_menu);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
scene_tabs_context_menu->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
context menu improvements
2018-01-02 07:10:49 +00:00
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
scene_tab_add = memnew(Button);
scene_tab_add->set_flat(true);
scene_tab_add->set_tooltip(TTR("Add a new scene."));
scene_tab_add->set_icon(gui_base->get_theme_icon(SNAME("Add"), SNAME("EditorIcons")));
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
scene_tab_add->add_theme_color_override("icon_normal_color", Color(0.6f, 0.6f, 0.6f, 0.8f));
Fix buggy behavior of the "Add tab" button in the scene tabs
2022-01-23 15:42:52 +00:00
scene_tabs->add_child(scene_tab_add);
scene_tab_add->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(FILE_NEW_SCENE));
scene_tab_add_ph = memnew(Control);
scene_tab_add_ph->set_mouse_filter(Control::MOUSE_FILTER_IGNORE);
scene_tab_add_ph->set_custom_minimum_size(scene_tab_add->get_minimum_size());
tabbar_container->add_child(scene_tab_add_ph);
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
distraction_free = memnew(Button);
distraction_free->set_flat(true);
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_AND_COMMAND("editor/distraction_free_mode", TTR("Distraction Free Mode"), KeyModifierMask::CMD | KeyModifierMask::SHIFT | Key::F11);
ED_SHORTCUT_OVERRIDE("editor/distraction_free_mode", "macos", KeyModifierMask::CMD | KeyModifierMask::CTRL | Key::D);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
distraction_free->set_shortcut(ED_GET_SHORTCUT("editor/distraction_free_mode"));
EditorNode: fix missing distraction-free tooltip
2017-07-24 06:07:53 +00:00
distraction_free->set_tooltip(TTR("Toggle distraction-free mode."));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
distraction_free->connect("pressed", callable_mp(this, &EditorNode::_toggle_distraction_free_mode));
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
distraction_free->set_icon(gui_base->get_theme_icon(SNAME("DistractionFree"), SNAME("EditorIcons")));
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
distraction_free->set_toggle_mode(true);
add scene button and tab scrolling
2017-11-16 22:57:57 +00:00
tabbar_container->add_child(distraction_free);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
scene_root_parent = memnew(PanelContainer);
scene_root_parent->set_custom_minimum_size(Size2(0, 80) * EDSCALE);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
scene_root_parent->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("Content"), SNAME("EditorStyles")));
Added border for tabs + container. - moved tabConetent position to be more reasonable. - fixed drawing order to allow those kind of styles.
2017-09-02 01:29:04 +00:00
scene_root_parent->set_draw_behind_parent(true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
srt->add_child(scene_root_parent);
scene_root_parent->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 01:51:12 +00:00
scene_root = memnew(SubViewport);
Cleanup embed subwindows getters
2022-03-13 15:18:44 +00:00
scene_root->set_embedding_subwindows(true);
Fixes to 2D viewport * Editor 2D viewport now uses embedded subwindows (windows no longer pop up) * Restored the ability to disable 3D on the 2D viewport (makes 3D not display on 2D when there is a camera on the scene)
2021-06-29 16:36:32 +00:00
scene_root->set_disable_3d(true);
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 04:26:35 +00:00
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 01:41:10 +00:00
scene_root->set_disable_input(true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
scene_root->set_as_audio_listener_2d(true);
Rename EditorInterface get_editor_viewport to get_editor_main_control
2020-12-19 14:17:42 +00:00
main_control = memnew(VBoxContainer);
main_control->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
main_control->add_theme_constant_override("separation", 0);
Rename EditorInterface get_editor_viewport to get_editor_main_control
2020-12-19 14:17:42 +00:00
scene_root_parent->add_child(main_control);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *left_menu_hb = memnew(HBoxContainer);
Cleanup editor's top bar of old nodes
2019-02-11 04:18:54 +00:00
menu_hb->add_child(left_menu_hb);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
file_menu = memnew(MenuButton);
fixed hover line for menu button
2017-09-02 01:25:40 +00:00
file_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-29 22:26:43 +00:00
file_menu->set_switch_on_hover(true);
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
file_menu->set_text(TTR("Scene"));
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
file_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
fixed hover line for menu button
2017-09-02 01:25:40 +00:00
left_menu_hb->add_child(file_menu);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
prev_scene = memnew(Button);
prev_scene->set_flat(true);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
prev_scene->set_icon(gui_base->get_theme_icon(SNAME("PrevScene"), SNAME("EditorIcons")));
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
prev_scene->set_tooltip(TTR("Go to previously opened scene."));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
prev_scene->set_disabled(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
prev_scene->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(FILE_OPEN_PREV));
-Changed Godot exit to be clean. -Added more debug information on memory cleanliness on exit (if run with -v) -Fixed several memory leaks, fixes #1731, fixes #755
2015-04-20 22:38:02 +00:00
gui_base->add_child(prev_scene);
Rename [gs]et_pos to [gs]et_position for Controls Control set_pos -> set_position Control set_global_pos -> set_global_position [gs]et_mouse_pos -> [gs]et_mouse_position [gs]et_global_mouse_pos -> [gs]et_global_mouse_position fixes #8005
2017-03-29 15:29:38 +00:00
prev_scene->set_position(Point2(3, 24));
-Changed Godot exit to be clean. -Added more debug information on memory cleanliness on exit (if run with -v) -Fixed several memory leaks, fixes #1731, fixes #755
2015-04-20 22:38:02 +00:00
prev_scene->hide();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
accept = memnew(AcceptDialog);
gui_base->add_child(accept);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
accept->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
Corrected Save Scene and Save All Scenes not working when the scene's dir no longer exists
2021-09-11 01:35:13 +00:00
save_accept = memnew(AcceptDialog);
gui_base->add_child(save_accept);
save_accept->connect("confirmed", callable_mp(this, &EditorNode::_menu_option), make_binds((int)MenuOptions::FILE_SAVE_AS_SCENE));
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
project_export = memnew(ProjectExportDialog);
gui_base->add_child(project_export);
dependency_error = memnew(DependencyErrorDialog);
gui_base->add_child(dependency_error);
dependency_fixer = memnew(DependencyEditor);
gui_base->add_child(dependency_fixer);
Minor fixes/refactoring of project and editor setting dialogs
2022-01-31 23:19:01 +00:00
editor_settings_dialog = memnew(EditorSettingsDialog);
gui_base->add_child(editor_settings_dialog);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
Minor fixes/refactoring of project and editor setting dialogs
2022-01-31 23:19:01 +00:00
project_settings_editor = memnew(ProjectSettingsEditor(&editor_data));
gui_base->add_child(project_settings_editor);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
Improved 3D Scene Importer * Added option for importers to show an Advanced settings dialog * Created advanced settings dialog for Scene Importer * Cleaned up importers (remove many old/unused options) * Added the ability to customize every node, material, mesh and animation individually * Saving to animations and meshes to files is now a manual process, making it more predictable * Added the ability for materials to be replaced by external files (or to be made external, up to you). * When doubleclicking an impoted scene in the filesystem dock, it automatically shows the import settings instead of asking to open it. WARNING: Lightmap UV unwrap is not working, it needs to be re-made.
2021-03-19 12:57:52 +00:00
scene_import_settings = memnew(SceneImportSettings);
gui_base->add_child(scene_import_settings);
Makes FontData importable resource. Adds multi-channel SDF font texture generation and rendering support. Adds per-font oversampling support. Adds FontData import plugins (for dynamic fonts, BMFonts and monospaced image fonts), font texture cache pre-generation and loading. Adds BMFont binary format and outline support.
2020-12-27 13:30:33 +00:00
fontdata_import_settings = memnew(DynamicFontImportSettings);
gui_base->add_child(fontdata_import_settings);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
export_template_manager = memnew(ExportTemplateManager);
gui_base->add_child(export_template_manager);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 22:18:03 +00:00
feature_profile_manager = memnew(EditorFeatureProfileManager);
gui_base->add_child(feature_profile_manager);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
about = memnew(EditorAbout);
gui_base->add_child(about);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
feature_profile_manager->connect("current_feature_profile_changed", callable_mp(this, &EditorNode::_feature_profile_changed));
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
warning = memnew(AcceptDialog);
Add a way to copy the text of warnings shown in the editor Closes #20662
2019-07-09 18:11:31 +00:00
warning->add_button(TTR("Copy Text"), true, "copy");
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
gui_base->add_child(warning);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
warning->connect("custom_action", callable_mp(this, &EditorNode::_copy_warning));
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 11:59:48 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT("editor/next_tab", TTR("Next Scene Tab"), KeyModifierMask::CMD + Key::TAB);
ED_SHORTCUT("editor/prev_tab", TTR("Previous Scene Tab"), KeyModifierMask::CMD + KeyModifierMask::SHIFT + Key::TAB);
ED_SHORTCUT("editor/filter_files", TTR("Focus FileSystem Filter"), KeyModifierMask::CMD + KeyModifierMask::ALT + Key::P);
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
command_palette = EditorCommandPalette::get_singleton();
command_palette->set_title(TTR("Command Palette"));
gui_base->add_child(command_palette);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 21:04:03 +00:00
PopupMenu *p;
Configurable shortcuts for tabs switching
2016-06-25 04:42:09 +00:00
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
file_menu->set_tooltip(TTR("Operations with scene files."));
Add Undo Close Tab option in tabs context menu
2019-04-10 15:21:26 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
p = file_menu->get_popup();
Popups are now windows also (broken!)
2020-03-12 12:37:40 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/new_scene", TTR("New Scene"), KeyModifierMask::CMD + Key::N), FILE_NEW_SCENE);
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/new_inherited_scene", TTR("New Inherited Scene..."), KeyModifierMask::CMD + KeyModifierMask::SHIFT + Key::N), FILE_NEW_INHERITED_SCENE);
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/open_scene", TTR("Open Scene..."), KeyModifierMask::CMD + Key::O), FILE_OPEN_SCENE);
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/reopen_closed_scene", TTR("Reopen Closed Scene"), KeyModifierMask::CMD + KeyModifierMask::SHIFT + Key::T), FILE_OPEN_PREV);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
p->add_submenu_item(TTR("Open Recent"), "RecentScenes", FILE_OPEN_RECENT);
issue #1715 - menu separator There was a request for a separator between Open Scene and Save Scene to avoid accidental mis-clicks. So here's that!
2015-04-26 02:45:49 +00:00
p->add_separator();
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/save_scene", TTR("Save Scene"), KeyModifierMask::CMD + Key::S), FILE_SAVE_SCENE);
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/save_scene_as", TTR("Save Scene As..."), KeyModifierMask::CMD + KeyModifierMask::SHIFT + Key::S), FILE_SAVE_AS_SCENE);
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/save_all_scenes", TTR("Save All Scenes"), KeyModifierMask::CMD + KeyModifierMask::SHIFT + KeyModifierMask::ALT + Key::S), FILE_SAVE_ALL_SCENES);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
p->add_separator();
Make internal editor key order consistent Godot already displays controls in the order Control+Shift+Alt, so the order used with the bitmask flags should be the same.
2019-05-11 04:03:30 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/quick_open", TTR("Quick Open..."), KeyModifierMask::SHIFT + KeyModifierMask::ALT + Key::O), FILE_QUICK_OPEN);
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/quick_open_scene", TTR("Quick Open Scene..."), KeyModifierMask::CMD + KeyModifierMask::SHIFT + Key::O), FILE_QUICK_OPEN_SCENE);
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/quick_open_script", TTR("Quick Open Script..."), KeyModifierMask::CMD + KeyModifierMask::ALT + Key::O), FILE_QUICK_OPEN_SCRIPT);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
p->add_separator();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
PopupMenu *pm_export = memnew(PopupMenu);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
pm_export->set_name("Export");
p->add_child(pm_export);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 17:36:01 +00:00
p->add_submenu_item(TTR("Convert To..."), "Export");
pm_export->add_shortcut(ED_SHORTCUT("editor/convert_to_MeshLibrary", TTR("MeshLibrary...")), FILE_EXPORT_MESH_LIBRARY);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
pm_export->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
p->add_separator();
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 11:32:00 +00:00
p->add_shortcut(ED_GET_SHORTCUT("ui_undo"), EDIT_UNDO, true);
p->add_shortcut(ED_GET_SHORTCUT("ui_redo"), EDIT_REDO, true);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
p->add_separator();
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/reload_saved_scene", TTR("Reload Saved Scene")), EDIT_RELOAD_SAVED_SCENE);
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/close_scene", TTR("Close Scene"), KeyModifierMask::CMD + KeyModifierMask::SHIFT + Key::W), FILE_CLOSE);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
recent_scenes = memnew(PopupMenu);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
recent_scenes->set_name("RecentScenes");
p->add_child(recent_scenes);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
recent_scenes->connect("id_pressed", callable_mp(this, &EditorNode::_open_recent_scene));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 21:04:03 +00:00
p->add_separator();
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/file_quit", TTR("Quit"), KeyModifierMask::CMD + Key::Q), FILE_QUIT, true);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 21:04:03 +00:00
project_menu = memnew(MenuButton);
fixed hover line for menu button
2017-09-02 01:25:40 +00:00
project_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-29 22:26:43 +00:00
project_menu->set_switch_on_hover(true);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 21:04:03 +00:00
project_menu->set_tooltip(TTR("Miscellaneous project or scene-wide tools."));
project_menu->set_text(TTR("Project"));
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
project_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 21:04:03 +00:00
left_menu_hb->add_child(project_menu);
p = project_menu->get_popup();
Popups are now windows also (broken!)
2020-03-12 12:37:40 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/project_settings", TTR("Project Settings..."), Key::NONE, TTR("Project Settings")), RUN_SETTINGS);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
p->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
Add VCS editor plugin UI elements to editor
2019-09-03 14:42:08 +00:00
vcs_actions_menu = VersionControlEditorPlugin::get_singleton()->get_version_control_actions_panel();
vcs_actions_menu->set_name("Version Control");
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
vcs_actions_menu->connect("index_pressed", callable_mp(this, &EditorNode::_version_control_menu_option));
Add VCS editor plugin UI elements to editor
2019-09-03 14:42:08 +00:00
p->add_separator();
p->add_child(vcs_actions_menu);
p->add_submenu_item(TTR("Version Control"), "Version Control");
Allow creating .gitignore and .gitattributes when creating a new project Also allow creating these files later, and also allow disabling creating the default environment in editor settings.
2020-09-29 19:01:26 +00:00
vcs_actions_menu->add_item(TTR("Create Version Control Metadata"), RUN_VCS_METADATA);
Add VCS editor plugin UI elements to editor
2019-09-03 14:42:08 +00:00
vcs_actions_menu->add_item(TTR("Set Up Version Control"), RUN_VCS_SETTINGS);
vcs_actions_menu->add_item(TTR("Shut Down Version Control"), RUN_VCS_SHUT_DOWN);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
p->add_separator();
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
p->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/export", TTR("Export..."), Key::NONE, TTR("Export")), FILE_EXPORT_PROJECT);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
p->add_item(TTR("Install Android Build Template..."), FILE_INSTALL_ANDROID_SOURCE);
Reword "Open Project Data Folder" as "Open User Data Folder" Clarifies that the button opens the user:// dir and for better consistency with certain ProjectSettings values: "Use Hidden Project Data Directory" is named similarly, but refers to data within res:// and two values refer to user:// as "User Dir" (Translations were not updated) and rename enum value accordingly
2021-12-28 00:51:45 +00:00
p->add_item(TTR("Open User Data Folder"), RUN_USER_DATA_FOLDER);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 21:04:03 +00:00
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 15:34:22 +00:00
plugin_config_dialog = memnew(PluginConfigDialog);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
plugin_config_dialog->connect("plugin_ready", callable_mp(this, &EditorNode::_on_plugin_ready));
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 15:34:22 +00:00
gui_base->add_child(plugin_config_dialog);
Added tool menu functions in EditorPlugin
2018-03-17 01:50:35 +00:00
tool_menu = memnew(PopupMenu);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 21:04:03 +00:00
tool_menu->set_name("Tools");
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
tool_menu->connect("index_pressed", callable_mp(this, &EditorNode::_tool_menu_option));
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 21:04:03 +00:00
p->add_child(tool_menu);
p->add_submenu_item(TTR("Tools"), "Tools");
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
tool_menu->add_item(TTR("Orphan Resource Explorer..."), TOOLS_ORPHAN_RESOURCES);
Add menu buttons to open the project and editor data folders
2018-07-25 17:53:12 +00:00
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
p->add_separator();
Made reload current project ask for confirmation with unsaved changes
2022-03-23 11:07:29 +00:00
p->add_shortcut(ED_SHORTCUT("editor/reload_current_project", TTR("Reload Current Project")), RELOAD_CURRENT_PROJECT);
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_AND_COMMAND("editor/quit_to_project_list", TTR("Quit to Project List"), KeyModifierMask::CMD + KeyModifierMask::SHIFT + Key::Q);
ED_SHORTCUT_OVERRIDE("editor/quit_to_project_list", "macos", KeyModifierMask::SHIFT + KeyModifierMask::ALT + Key::Q);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
p->add_shortcut(ED_GET_SHORTCUT("editor/quit_to_project_list"), RUN_PROJECT_MANAGER, true);
-fixed tabs
2015-11-18 07:47:41 +00:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
menu_hb->add_spacer();
Cleanup editor's top bar of old nodes
2019-02-11 04:18:54 +00:00
main_editor_button_vb = memnew(HBoxContainer);
menu_hb->add_child(main_editor_button_vb);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 12:46:17 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Options are added and handled by DebuggerEditorPlugin.
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
debug_menu = memnew(MenuButton);
fixed hover line for menu button
2017-09-02 01:25:40 +00:00
debug_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-29 22:26:43 +00:00
debug_menu->set_switch_on_hover(true);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
debug_menu->set_text(TTR("Debug"));
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
debug_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
left_menu_hb->add_child(debug_menu);
Popups are now windows also (broken!)
2020-03-12 12:37:40 +00:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
menu_hb->add_spacer();
-orphan resource explorer dialog + tools menu
2015-11-29 04:08:31 +00:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
settings_menu = memnew(MenuButton);
fixed hover line for menu button
2017-09-02 01:25:40 +00:00
settings_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-29 22:26:43 +00:00
settings_menu->set_switch_on_hover(true);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
settings_menu->set_text(TTR("Editor"));
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
settings_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
fixed hover line for menu button
2017-09-02 01:25:40 +00:00
left_menu_hb->add_child(settings_menu);
-orphan resource explorer dialog + tools menu
2015-11-29 04:08:31 +00:00
context menu improvements
2018-01-02 07:10:49 +00:00
p = settings_menu->get_popup();
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
ED_SHORTCUT_AND_COMMAND("editor/editor_settings", TTR("Editor Settings..."));
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_OVERRIDE("editor/editor_settings", "macos", KeyModifierMask::CMD + Key::COMMA);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
p->add_shortcut(ED_GET_SHORTCUT("editor/editor_settings"), SETTINGS_PREFERENCES);
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
p->add_shortcut(ED_SHORTCUT("editor/command_palette", TTR("Command Palette..."), KeyModifierMask::CMD | KeyModifierMask::SHIFT | Key::P), HELP_COMMAND_PALETTE);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
p->add_separator();
Add menu buttons to open the project and editor data folders
2018-07-25 17:53:12 +00:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
editor_layouts = memnew(PopupMenu);
editor_layouts->set_name("Layouts");
p->add_child(editor_layouts);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
editor_layouts->connect("id_pressed", callable_mp(this, &EditorNode::_layout_menu_option));
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
p->add_submenu_item(TTR("Editor Layout"), "Layouts");
Move "Open Screenshot" from the "Editor" menu to the editor settings
2019-07-23 05:05:29 +00:00
p->add_separator();
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_AND_COMMAND("editor/take_screenshot", TTR("Take Screenshot"), KeyModifierMask::CTRL | Key::F12);
ED_SHORTCUT_OVERRIDE("editor/take_screenshot", "macos", KeyModifierMask::CMD | Key::F12);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
p->add_shortcut(ED_GET_SHORTCUT("editor/take_screenshot"), EDITOR_SCREENSHOT);
Allow negative indexes in ItemList and PopupMenu
2022-03-12 00:06:45 +00:00
p->set_item_tooltip(-1, TTR("Screenshots are stored in the Editor Data/Settings Folder."));
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_AND_COMMAND("editor/fullscreen_mode", TTR("Toggle Fullscreen"), KeyModifierMask::SHIFT | Key::F11);
ED_SHORTCUT_OVERRIDE("editor/fullscreen_mode", "macos", KeyModifierMask::CMD | KeyModifierMask::CTRL | Key::F);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
p->add_shortcut(ED_GET_SHORTCUT("editor/fullscreen_mode"), SETTINGS_TOGGLE_FULLSCREEN);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
p->add_separator();
Add menu buttons to open the project and editor data folders
2018-07-25 17:53:12 +00:00
if (OS::get_singleton()->get_data_path() == OS::get_singleton()->get_config_path()) {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Configuration and data folders are located in the same place (Windows/MacOS).
Add menu buttons to open the project and editor data folders
2018-07-25 17:53:12 +00:00
p->add_item(TTR("Open Editor Data/Settings Folder"), SETTINGS_EDITOR_DATA_FOLDER);
} else {
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Separate configuration and data folders (Linux).
Add menu buttons to open the project and editor data folders
2018-07-25 17:53:12 +00:00
p->add_item(TTR("Open Editor Data Folder"), SETTINGS_EDITOR_DATA_FOLDER);
p->add_item(TTR("Open Editor Settings Folder"), SETTINGS_EDITOR_CONFIG_FOLDER);
}
p->add_separator();
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 20:23:00 +00:00
p->add_item(TTR("Manage Editor Features..."), SETTINGS_MANAGE_FEATURE_PROFILES);
p->add_item(TTR("Manage Export Templates..."), SETTINGS_MANAGE_EXPORT_TEMPLATES);
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
fixed hover line for menu button
2017-09-02 01:25:40 +00:00
help_menu = memnew(MenuButton);
help_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-29 22:26:43 +00:00
help_menu->set_switch_on_hover(true);
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
help_menu->set_text(TTR("Help"));
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
help_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox(SNAME("MenuHover"), SNAME("EditorStyles")));
fixed hover line for menu button
2017-09-02 01:25:40 +00:00
left_menu_hb->add_child(help_menu);
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
p = help_menu->get_popup();
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
p->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_AND_COMMAND("editor/editor_help", TTR("Search Help"), Key::F1);
ED_SHORTCUT_OVERRIDE("editor/editor_help", "macos", KeyModifierMask::ALT | Key::SPACE);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
p->add_icon_shortcut(gui_base->get_theme_icon(SNAME("HelpSearch"), SNAME("EditorIcons")), ED_GET_SHORTCUT("editor/editor_help"), HELP_SEARCH);
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 14:34:41 +00:00
p->add_separator();
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
p->add_icon_shortcut(gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")), ED_SHORTCUT_AND_COMMAND("editor/online_docs", TTR("Online Documentation")), HELP_DOCS);
p->add_icon_shortcut(gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")), ED_SHORTCUT_AND_COMMAND("editor/q&a", TTR("Questions & Answers")), HELP_QA);
p->add_icon_shortcut(gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")), ED_SHORTCUT_AND_COMMAND("editor/report_a_bug", TTR("Report a Bug")), HELP_REPORT_A_BUG);
p->add_icon_shortcut(gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")), ED_SHORTCUT_AND_COMMAND("editor/suggest_a_feature", TTR("Suggest a Feature")), HELP_SUGGEST_A_FEATURE);
p->add_icon_shortcut(gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")), ED_SHORTCUT_AND_COMMAND("editor/send_docs_feedback", TTR("Send Docs Feedback")), HELP_SEND_DOCS_FEEDBACK);
p->add_icon_shortcut(gui_base->get_theme_icon(SNAME("Instance"), SNAME("EditorIcons")), ED_SHORTCUT_AND_COMMAND("editor/community", TTR("Community")), HELP_COMMUNITY);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 10:00:55 +00:00
p->add_separator();
Added EditorCommandPalette
2021-05-29 13:28:16 +00:00
p->add_icon_shortcut(gui_base->get_theme_icon(SNAME("Godot"), SNAME("EditorIcons")), ED_SHORTCUT_AND_COMMAND("editor/about", TTR("About Godot")), HELP_ABOUT);
p->add_icon_shortcut(gui_base->get_theme_icon(SNAME("Heart"), SNAME("EditorIcons")), ED_SHORTCUT_AND_COMMAND("editor/support_development", TTR("Support Godot Development")), HELP_SUPPORT_GODOT_DEVELOPMENT);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *play_hb = memnew(HBoxContainer);
Cleanup editor's top bar of old nodes
2019-02-11 04:18:54 +00:00
menu_hb->add_child(play_hb);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
play_button = memnew(Button);
play_button->set_flat(true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_hb->add_child(play_button);
play_button->set_toggle_mode(true);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_button->set_icon(gui_base->get_theme_icon(SNAME("MainPlay"), SNAME("EditorIcons")));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_button->set_focus_mode(Control::FOCUS_NONE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
play_button->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(RUN_PLAY));
-customizable shortcuts in editor -editor settings now save to .tres instead of .xml -buttons can now hold a shortcut
2016-06-05 00:31:29 +00:00
play_button->set_tooltip(TTR("Play the project."));
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_AND_COMMAND("editor/play", TTR("Play"), Key::F5);
ED_SHORTCUT_OVERRIDE("editor/play", "macos", KeyModifierMask::CMD | Key::B);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
play_button->set_shortcut(ED_GET_SHORTCUT("editor/play"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
pause_button = memnew(Button);
pause_button->set_flat(true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
pause_button->set_toggle_mode(true);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
pause_button->set_icon(gui_base->get_theme_icon(SNAME("Pause"), SNAME("EditorIcons")));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
pause_button->set_focus_mode(Control::FOCUS_NONE);
EditorNode: Improve tooltip for pause button Closes #14742.
2019-11-14 10:44:03 +00:00
pause_button->set_tooltip(TTR("Pause the scene execution for debugging."));
First version of Profiler It is now possible to profile GDScript as well as some parts of Godot internals.
2016-05-22 00:18:16 +00:00
pause_button->set_disabled(true);
play_hb->add_child(pause_button);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT("editor/pause_scene", TTR("Pause Scene"), Key::F7);
ED_SHORTCUT_OVERRIDE("editor/pause_scene", "macos", KeyModifierMask::CMD | KeyModifierMask::CTRL | Key::Y);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
pause_button->set_shortcut(ED_GET_SHORTCUT("editor/pause_scene"));
Merge remote-tracking branch 'origin/master'
2016-05-22 01:34:55 +00:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
stop_button = memnew(Button);
stop_button->set_flat(true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_hb->add_child(stop_button);
stop_button->set_focus_mode(Control::FOCUS_NONE);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
stop_button->set_icon(gui_base->get_theme_icon(SNAME("Stop"), SNAME("EditorIcons")));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
stop_button->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(RUN_STOP));
-customizable shortcuts in editor -editor settings now save to .tres instead of .xml -buttons can now hold a shortcut
2016-06-05 00:31:29 +00:00
stop_button->set_tooltip(TTR("Stop the scene."));
Fix stop button always enabled (issue #13933)
2017-12-04 19:48:46 +00:00
stop_button->set_disabled(true);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT("editor/stop", TTR("Stop"), Key::F8);
ED_SHORTCUT_OVERRIDE("editor/stop", "macos", KeyModifierMask::CMD | Key::PERIOD);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
stop_button->set_shortcut(ED_GET_SHORTCUT("editor/stop"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
run_native = memnew(EditorRunNative);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_hb->add_child(run_native);
Support multiple debug protocols.
2020-03-16 08:37:43 +00:00
run_native->connect("native_run", callable_mp(this, &EditorNode::_run_native));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
play_scene_button = memnew(Button);
play_scene_button->set_flat(true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_hb->add_child(play_scene_button);
play_scene_button->set_toggle_mode(true);
play_scene_button->set_focus_mode(Control::FOCUS_NONE);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_scene_button->set_icon(gui_base->get_theme_icon(SNAME("PlayScene"), SNAME("EditorIcons")));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
play_scene_button->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(RUN_PLAY_SCENE));
-customizable shortcuts in editor -editor settings now save to .tres instead of .xml -buttons can now hold a shortcut
2016-06-05 00:31:29 +00:00
play_scene_button->set_tooltip(TTR("Play the edited scene."));
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_AND_COMMAND("editor/play_scene", TTR("Play Scene"), Key::F6);
ED_SHORTCUT_OVERRIDE("editor/play_scene", "macos", KeyModifierMask::CMD | Key::R);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
play_scene_button->set_shortcut(ED_GET_SHORTCUT("editor/play_scene"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
play_custom_scene_button = memnew(Button);
play_custom_scene_button->set_flat(true);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
play_hb->add_child(play_custom_scene_button);
play_custom_scene_button->set_toggle_mode(true);
play_custom_scene_button->set_focus_mode(Control::FOCUS_NONE);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
play_custom_scene_button->set_icon(gui_base->get_theme_icon(SNAME("PlayCustom"), SNAME("EditorIcons")));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
play_custom_scene_button->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(RUN_PLAY_CUSTOM_SCENE));
Fix "Play custom scene" keyboard shortcut
2016-07-11 17:46:41 +00:00
play_custom_scene_button->set_tooltip(TTR("Play custom scene"));
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_AND_COMMAND("editor/play_custom_scene", TTR("Play Custom Scene"), KeyModifierMask::CMD | KeyModifierMask::SHIFT | Key::F5);
ED_SHORTCUT_OVERRIDE("editor/play_custom_scene", "macos", KeyModifierMask::CMD | KeyModifierMask::SHIFT | Key::R);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
play_custom_scene_button->set_shortcut(ED_GET_SHORTCUT("editor/play_custom_scene"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Cleanup some unused controls in the editor's top bar
2018-12-09 18:10:07 +00:00
HBoxContainer *right_menu_hb = memnew(HBoxContainer);
menu_hb->add_child(right_menu_hb);
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
rendering_driver = memnew(OptionButton);
Use OpenGL 3.3 core profile instead of compatibility profile - Rename OpenGL to GLES3 in the source code per community feedback. - The renderer is still exposed as "OpenGL 3" to the user. - Hide renderer selection dropdown until OpenGL support is more mature. - The renderer can still be changed in the Project Settings or using the `--rendering-driver opengl` command line argument. - Remove commented out exporter code. - Remove some OpenGL/DisplayServer-related debugging prints.
2021-10-26 15:18:39 +00:00
// Hide the renderer selection dropdown until OpenGL support is more mature.
// The renderer can still be changed in the project settings or using `--rendering-driver opengl3`.
rendering_driver->set_visible(false);
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
rendering_driver->set_flat(true);
rendering_driver->set_focus_mode(Control::FOCUS_NONE);
rendering_driver->connect("item_selected", callable_mp(this, &EditorNode::_rendering_driver_selected));
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
rendering_driver->add_theme_font_override("font", gui_base->get_theme_font(SNAME("bold"), SNAME("EditorFonts")));
rendering_driver->add_theme_font_size_override("font_size", gui_base->get_theme_font_size(SNAME("bold_size"), SNAME("EditorFonts")));
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
right_menu_hb->add_child(rendering_driver);
Use OpenGL 3.3 core profile instead of compatibility profile - Rename OpenGL to GLES3 in the source code per community feedback. - The renderer is still exposed as "OpenGL 3" to the user. - Hide renderer selection dropdown until OpenGL support is more mature. - The renderer can still be changed in the Project Settings or using the `--rendering-driver opengl` command line argument. - Remove commented out exporter code. - Remove some OpenGL/DisplayServer-related debugging prints.
2021-10-26 15:18:39 +00:00
// Only display the render drivers that are available for this display driver.
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
int display_driver_idx = OS::get_singleton()->get_display_driver_id();
Vector<String> render_drivers = DisplayServer::get_create_function_rendering_drivers(display_driver_idx);
String current_rendering_driver = OS::get_singleton()->get_current_rendering_driver_name();
Use OpenGL 3.3 core profile instead of compatibility profile - Rename OpenGL to GLES3 in the source code per community feedback. - The renderer is still exposed as "OpenGL 3" to the user. - Hide renderer selection dropdown until OpenGL support is more mature. - The renderer can still be changed in the Project Settings or using the `--rendering-driver opengl` command line argument. - Remove commented out exporter code. - Remove some OpenGL/DisplayServer-related debugging prints.
2021-10-26 15:18:39 +00:00
// As we are doing string comparisons, keep in standard case to prevent problems with capitals
// "vulkan" in particular uses lowercase "v" in the code, and uppercase in the UI.
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
current_rendering_driver = current_rendering_driver.to_lower();
for (int i = 0; i < render_drivers.size(); i++) {
String driver = render_drivers[i];
Use OpenGL 3.3 core profile instead of compatibility profile - Rename OpenGL to GLES3 in the source code per community feedback. - The renderer is still exposed as "OpenGL 3" to the user. - Hide renderer selection dropdown until OpenGL support is more mature. - The renderer can still be changed in the Project Settings or using the `--rendering-driver opengl` command line argument. - Remove commented out exporter code. - Remove some OpenGL/DisplayServer-related debugging prints.
2021-10-26 15:18:39 +00:00
// Add the driver to the UI.
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
rendering_driver->add_item(driver);
rendering_driver->set_item_metadata(i, driver);
Use OpenGL 3.3 core profile instead of compatibility profile - Rename OpenGL to GLES3 in the source code per community feedback. - The renderer is still exposed as "OpenGL 3" to the user. - Hide renderer selection dropdown until OpenGL support is more mature. - The renderer can still be changed in the Project Settings or using the `--rendering-driver opengl` command line argument. - Remove commented out exporter code. - Remove some OpenGL/DisplayServer-related debugging prints.
2021-10-26 15:18:39 +00:00
// Lowercase for standard comparison.
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
driver = driver.to_lower();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
if (current_rendering_driver == driver) {
rendering_driver->select(i);
rendering_driver_current = i;
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
}
}
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
_update_rendering_driver_color();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
video_restart_dialog = memnew(ConfirmationDialog);
video_restart_dialog->set_text(TTR("Changing the video driver requires restarting the editor."));
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
video_restart_dialog->get_ok_button()->set_text(TTR("Save & Restart"));
Add GLES2 2D renderer + Linux display manager First implementation with Linux display manager. - Add single-threaded mode for EditorResourcePreview (needed for OpenGL). Co-authored-by: clayjohn <claynjohn@gmail.com> Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2020-11-18 18:11:30 +00:00
video_restart_dialog->connect("confirmed", callable_mp(this, &EditorNode::_menu_option), varray(SET_RENDERING_DRIVER_SAVE_AND_RESTART));
-Fix tooltips in inspector, now they show as rich text.
2018-07-20 21:14:33 +00:00
gui_base->add_child(video_restart_dialog);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 21:58:15 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
progress_hb = memnew(BackgroundProgress);
-fixed tabs
2015-11-18 07:47:41 +00:00
editor save/delete layout dialog with layout list
2019-05-30 18:16:40 +00:00
layout_dialog = memnew(EditorLayoutsDialog);
Editor layouts menu
2015-11-22 18:11:17 +00:00
gui_base->add_child(layout_dialog);
layout_dialog->set_hide_on_ok(false);
editor save/delete layout dialog with layout list
2019-05-30 18:16:40 +00:00
layout_dialog->set_size(Size2(225, 270) * EDSCALE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
layout_dialog->connect("name_confirmed", callable_mp(this, &EditorNode::_dialog_action));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
update_spinner = memnew(MenuButton);
right_menu_hb->add_child(update_spinner);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
update_spinner->set_icon(gui_base->get_theme_icon(SNAME("Progress1"), SNAME("EditorIcons")));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
update_spinner->get_popup()->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
p = update_spinner->get_popup();
p->add_radio_check_item(TTR("Update Continuously"), SETTINGS_UPDATE_CONTINUOUSLY);
p->add_radio_check_item(TTR("Update When Changed"), SETTINGS_UPDATE_WHEN_CHANGED);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
p->add_separator();
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
p->add_item(TTR("Hide Update Spinner"), SETTINGS_UPDATE_SPINNER_HIDE);
_update_update_spinner();
-fixed tabs
2015-11-18 07:47:41 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Instantiate and place editor docks.
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
memnew(SceneTreeDock(scene_root, editor_selection, editor_data));
memnew(InspectorDock(editor_data));
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
memnew(ImportDock);
memnew(NodeDock);
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
FileSystemDock *filesystem_dock = memnew(FileSystemDock);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
filesystem_dock->connect("inherit", callable_mp(this, &EditorNode::_inherit_request));
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
filesystem_dock->connect("instance", callable_mp(this, &EditorNode::_instantiate_request));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
filesystem_dock->connect("display_mode_changed", callable_mp(this, &EditorNode::_save_docks));
-removed resources dock, good bye old friend
2015-09-01 03:49:47 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Scene: Top left.
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
dock_slot[DOCK_SLOT_LEFT_UR]->add_child(SceneTreeDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
dock_slot[DOCK_SLOT_LEFT_UR]->set_tab_title(dock_slot[DOCK_SLOT_LEFT_UR]->get_tab_idx_from_control(SceneTreeDock::get_singleton()), TTR("Scene"));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Import: Top left, behind Scene.
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
dock_slot[DOCK_SLOT_LEFT_UR]->add_child(ImportDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
dock_slot[DOCK_SLOT_LEFT_UR]->set_tab_title(dock_slot[DOCK_SLOT_LEFT_UR]->get_tab_idx_from_control(ImportDock::get_singleton()), TTR("Import"));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// FileSystem: Bottom left.
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
dock_slot[DOCK_SLOT_LEFT_BR]->add_child(FileSystemDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
dock_slot[DOCK_SLOT_LEFT_BR]->set_tab_title(dock_slot[DOCK_SLOT_LEFT_BR]->get_tab_idx_from_control(FileSystemDock::get_singleton()), TTR("FileSystem"));
Lot of work in new importer, importing textures now works.
2017-02-01 12:45:45 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Inspector: Full height right.
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
dock_slot[DOCK_SLOT_RIGHT_UL]->add_child(InspectorDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
dock_slot[DOCK_SLOT_RIGHT_UL]->set_tab_title(dock_slot[DOCK_SLOT_RIGHT_UL]->get_tab_idx_from_control(InspectorDock::get_singleton()), TTR("Inspector"));
Only assume HiDPI mode if DPI >= 192 and width > 2000 Also fix detection of single-column dock if width < 1200, it only worked with hidpi_mode=auto.
2017-03-24 16:39:16 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Node: Full height right, behind Inspector.
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
dock_slot[DOCK_SLOT_RIGHT_UL]->add_child(NodeDock::get_singleton());
Make `TabContainer` use `TabBar` internally
2022-03-02 14:37:10 +00:00
dock_slot[DOCK_SLOT_RIGHT_UL]->set_tab_title(dock_slot[DOCK_SLOT_RIGHT_UL]->get_tab_idx_from_control(NodeDock::get_singleton()), TTR("Node"));
Signals became a tab added icons to contextual scene tree menu
2016-06-04 00:03:09 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Hide unused dock slots and vsplits.
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
dock_slot[DOCK_SLOT_LEFT_UL]->hide();
dock_slot[DOCK_SLOT_LEFT_BL]->hide();
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 15:07:46 +00:00
dock_slot[DOCK_SLOT_RIGHT_BL]->hide();
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
dock_slot[DOCK_SLOT_RIGHT_UR]->hide();
dock_slot[DOCK_SLOT_RIGHT_BR]->hide();
left_l_vsplit->hide();
right_r_vsplit->hide();
Make Godot detect if the screen is too small (<1200 pixels wide), and use single dock column like in 1.0 if that's the case.
2016-09-13 14:20:09 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Add some offsets to left_r and main hsplits to make LEFT_R and RIGHT_L docks wider than minsize.
Fixes the editor layout
2018-10-26 10:44:49 +00:00
left_r_hsplit->set_split_offset(70 * EDSCALE);
main_hsplit->set_split_offset(-70 * EDSCALE);
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 15:07:46 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Define corresponding default layout.
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Editor layouts menu
2015-11-22 18:11:17 +00:00
const String docks_section = "docks";
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
overridden_default_layout = -1;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
default_layout.instantiate();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Dock numbers are based on DockSlot enum value + 1.
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 15:07:46 +00:00
default_layout->set_value(docks_section, "dock_3", "Scene,Import");
default_layout->set_value(docks_section, "dock_4", "FileSystem");
default_layout->set_value(docks_section, "dock_5", "Inspector,Node");
Editor layouts menu
2015-11-22 18:11:17 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
for (int i = 0; i < vsplits.size(); i++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
default_layout->set_value(docks_section, "dock_split_" + itos(i + 1), 0);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 15:07:46 +00:00
default_layout->set_value(docks_section, "dock_hsplit_1", 0);
Fixes the editor layout
2018-10-26 10:44:49 +00:00
default_layout->set_value(docks_section, "dock_hsplit_2", 70 * EDSCALE);
default_layout->set_value(docks_section, "dock_hsplit_3", -70 * EDSCALE);
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 15:07:46 +00:00
default_layout->set_value(docks_section, "dock_hsplit_4", 0);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Editor layouts menu
2015-11-22 18:11:17 +00:00
_update_layouts_menu();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Bottom panels.
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 14:56:18 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bottom_panel = memnew(PanelContainer);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox(SNAME("panel"), SNAME("TabContainer")));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
center_split->add_child(bottom_panel);
center_split->set_dragger_visibility(SplitContainer::DRAGGER_HIDDEN);
-fixed tabs
2015-11-18 07:47:41 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bottom_panel_vb = memnew(VBoxContainer);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
bottom_panel->add_child(bottom_panel_vb);
-fixed tabs
2015-11-18 07:47:41 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bottom_panel_hb = memnew(HBoxContainer);
Make some small enhancements to the ColorPicker
2019-01-26 21:07:32 +00:00
bottom_panel_hb->set_custom_minimum_size(Size2(0, 24 * EDSCALE)); // Adjust for the height of the "Expand Bottom Dock" icon.
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
bottom_panel_vb->add_child(bottom_panel_hb);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
bottom_panel_hb_editors = memnew(HBoxContainer);
bottom_panel_hb_editors->set_h_size_flags(Control::SIZE_EXPAND_FILL);
bottom_panel_hb->add_child(bottom_panel_hb_editors);
Display version information in the editor at all times This closes #27811.
2019-07-22 21:14:51 +00:00
Implement toast notifications in the editor
2021-09-22 15:36:40 +00:00
editor_toaster = memnew(EditorToaster);
bottom_panel_hb->add_child(editor_toaster);
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 00:20:54 +00:00
VBoxContainer *version_info_vbc = memnew(VBoxContainer);
bottom_panel_hb->add_child(version_info_vbc);
// Add a dummy control node for vertical spacing.
Control *v_spacer = memnew(Control);
version_info_vbc->add_child(v_spacer);
version_btn = memnew(LinkButton);
version_btn->set_text(VERSION_FULL_CONFIG);
String hash = String(VERSION_HASH);
if (hash.length() != 0) {
Separate version hash from version number in editor and project manager When copy-pasting the version from About dialog to bug reports at GitHub, this makes the version hash linkable to commits at GitHub.
2021-06-07 21:51:18 +00:00
hash = " " + vformat("[%s]", hash.left(9));
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 00:20:54 +00:00
}
// Set the text to copy in metadata as it slightly differs from the button's text.
version_btn->set_meta(META_TEXT_TO_COPY, "v" VERSION_FULL_BUILD + hash);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Fade out the version label to be less prominent, but still readable.
Make it possible to copy the Godot version identifier by clicking it This closes #24317.
2019-12-24 00:20:54 +00:00
version_btn->set_self_modulate(Color(1, 1, 1, 0.65));
version_btn->set_underline_mode(LinkButton::UNDERLINE_MODE_ON_HOVER);
version_btn->set_tooltip(TTR("Click to copy."));
version_btn->connect("pressed", callable_mp(this, &EditorNode::_version_button_pressed));
version_info_vbc->add_child(version_btn);
// Add a dummy control node for horizontal spacing.
Control *h_spacer = memnew(Control);
bottom_panel_hb->add_child(h_spacer);
Display version information in the editor at all times This closes #27811.
2019-07-22 21:14:51 +00:00
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
bottom_panel_raise = memnew(Button);
bottom_panel_raise->set_flat(true);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
bottom_panel_raise->set_icon(gui_base->get_theme_icon(SNAME("ExpandBottomDock"), SNAME("EditorIcons")));
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
bottom_panel_raise->set_shortcut(ED_SHORTCUT_AND_COMMAND("editor/bottom_panel_expand", TTR("Expand Bottom Panel"), KeyModifierMask::SHIFT | Key::F12));
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
bottom_panel_hb->add_child(bottom_panel_raise);
bottom_panel_raise->hide();
bottom_panel_raise->set_toggle_mode(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
bottom_panel_raise->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_raise_toggled));
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 01:38:14 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
log = memnew(EditorLog);
Remove ToolButton in favor of Button ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes https://github.com/godotengine/godot-proposals/issues/1081.
2020-06-19 18:49:04 +00:00
Button *output_button = add_bottom_panel_item(TTR("Output"), log);
Show error icon at "Output" in case of errors
2018-03-11 13:20:32 +00:00
log->set_tool_button(output_button);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
old_split_ofs = 0;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
center_split->connect("resized", callable_mp(this, &EditorNode::_vp_resized));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Added ability to visualize native shaders
2021-01-05 23:01:50 +00:00
native_shader_source_visualizer = memnew(EditorNativeShaderSourceVisualizer);
gui_base->add_child(native_shader_source_visualizer);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
orphan_resources = memnew(OrphanResourcesDialog);
-orphan resource explorer dialog + tools menu
2015-11-29 04:08:31 +00:00
gui_base->add_child(orphan_resources);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
confirmation = memnew(ConfirmationDialog);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
gui_base->add_child(confirmation);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
confirmation->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
save_confirmation = memnew(ConfirmationDialog);
Fix cancel/OK button order on macOS The macOS platform convention regarding button order is cancel on left, OK on right.
2020-07-08 23:02:38 +00:00
save_confirmation->add_button(TTR("Don't Save"), DisplayServer::get_singleton()->get_swap_cancel_ok(), "discard");
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
gui_base->add_child(save_confirmation);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
save_confirmation->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
save_confirmation->connect("custom_action", callable_mp(this, &EditorNode::_discard_changes));
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 04:15:39 +00:00
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
custom_build_manage_templates = memnew(ConfirmationDialog);
custom_build_manage_templates->set_text(TTR("Android build template is missing, please install relevant templates."));
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
custom_build_manage_templates->get_ok_button()->set_text(TTR("Manage Templates"));
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 13:12:56 +00:00
custom_build_manage_templates->add_button(TTR("Install from file"))->connect("pressed", callable_mp(this, &EditorNode::_menu_option), varray(SETTINGS_INSTALL_ANDROID_BUILD_TEMPLATE));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
custom_build_manage_templates->connect("confirmed", callable_mp(this, &EditorNode::_menu_option), varray(SETTINGS_MANAGE_EXPORT_TEMPLATES));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
gui_base->add_child(custom_build_manage_templates);
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 13:12:56 +00:00
file_android_build_source = memnew(EditorFileDialog);
Improve various texts
2021-11-23 11:20:57 +00:00
file_android_build_source->set_title(TTR("Select Android sources file"));
Addes ability to load build sources from file. * If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
2021-07-15 13:12:56 +00:00
file_android_build_source->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
file_android_build_source->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
file_android_build_source->add_filter("*.zip");
file_android_build_source->connect("file_selected", callable_mp(this, &EditorNode::_android_build_source_selected));
gui_base->add_child(file_android_build_source);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
install_android_build_template = memnew(ConfirmationDialog);
Android: Improve dialogs about custom build template The language didn't make it clear that it's installing a *source* template to the project folder, for later use when compiling custom APKs. Fixes #28736.
2019-08-27 11:07:24 +00:00
install_android_build_template->set_text(TTR("This will set up your project for custom Android builds by installing the source template to \"res://android/build\".\nYou can then apply modifications and build your own custom APK on export (adding modules, changing the AndroidManifest.xml, etc.).\nNote that in order to make custom builds instead of using pre-built APKs, the \"Use Custom Build\" option should be enabled in the Android export preset."));
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
install_android_build_template->get_ok_button()->set_text(TTR("Install"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
install_android_build_template->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
gui_base->add_child(install_android_build_template);
remove_android_build_template = memnew(ConfirmationDialog);
Android: Improve dialogs about custom build template The language didn't make it clear that it's installing a *source* template to the project folder, for later use when compiling custom APKs. Fixes #28736.
2019-08-27 11:07:24 +00:00
remove_android_build_template->set_text(TTR("The Android build template is already installed in this project and it won't be overwritten.\nRemove the \"res://android/build\" directory manually before attempting this operation again."));
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
remove_android_build_template->get_ok_button()->set_text(TTR("Show in File Manager"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
remove_android_build_template->connect("confirmed", callable_mp(this, &EditorNode::_menu_option), varray(FILE_EXPLORE_ANDROID_BUILD_TEMPLATES));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
gui_base->add_child(remove_android_build_template);
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 22:45:08 +00:00
file_templates = memnew(EditorFileDialog);
i18n: Proofreading of all strings Done to ensure that no important identifiers are translatable, to fix compound strings using the new vformat() function, and some general English proofreading here and there.
2016-05-18 22:08:12 +00:00
file_templates->set_title(TTR("Import Templates From ZIP File"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
gui_base->add_child(file_templates);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
file_templates->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 22:45:08 +00:00
file_templates->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
file_templates->clear_filters();
Makes more strings in editor translatable * File type names in file dialogs * Layout option names * Visual shader editor UI
2019-12-16 05:18:44 +00:00
file_templates->add_filter("*.tpz ; " + TTR("Template Package"));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
file = memnew(EditorFileDialog);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
gui_base->add_child(file);
file->set_current_dir("res://");
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 22:45:08 +00:00
file_export_lib = memnew(EditorFileDialog);
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
file_export_lib->set_title(TTR("Export Library"));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
file_export_lib->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
file_export_lib->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
Use CheckBoxes in the editor instead of CheckButtons when applicable CheckButtons should only be used if toggling them has an immediate effect. Otherwise, CheckBoxes should be used.
2019-07-04 15:30:44 +00:00
file_export_lib_merge = memnew(CheckBox);
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
file_export_lib_merge->set_text(TTR("Merge With Existing"));
Improved some editor checkboxes
2021-11-21 20:29:34 +00:00
file_export_lib_merge->set_h_size_flags(Control::SIZE_SHRINK_CENTER);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
file_export_lib_merge->set_pressed(true);
file_export_lib->get_vbox()->add_child(file_export_lib_merge);
implement individual mesh transform for meshlibrary items
2021-08-31 23:17:33 +00:00
file_export_lib_apply_xforms = memnew(CheckBox);
file_export_lib_apply_xforms->set_text(TTR("Apply MeshInstance Transforms"));
Improved some editor checkboxes
2021-11-21 20:29:34 +00:00
file_export_lib_apply_xforms->set_h_size_flags(Control::SIZE_SHRINK_CENTER);
implement individual mesh transform for meshlibrary items
2021-08-31 23:17:33 +00:00
file_export_lib_apply_xforms->set_pressed(false);
file_export_lib->get_vbox()->add_child(file_export_lib_apply_xforms);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
gui_base->add_child(file_export_lib);
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 22:45:08 +00:00
file_script = memnew(EditorFileDialog);
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
file_script->set_title(TTR("Open & Run a Script"));
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 22:45:08 +00:00
file_script->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
file_script->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
-run script in editor -add search docs dialog that returns places string was found -added flash
2014-02-21 02:01:44 +00:00
List<String> sexts;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ResourceLoader::get_recognized_extensions_for_type("Script", &sexts);
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const String &E : sexts) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
file_script->add_filter("*." + E);
-run script in editor -add search docs dialog that returns places string was found -added flash
2014-02-21 02:01:44 +00:00
}
gui_base->add_child(file_script);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
file_script->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
-run script in editor -add search docs dialog that returns places string was found -added flash
2014-02-21 02:01:44 +00:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
file_menu->get_popup()->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Popups are now windows also (broken!)
2020-03-12 12:37:40 +00:00
file_menu->connect("about_to_popup", callable_mp(this, &EditorNode::_update_file_menu_opened));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
file_menu->get_popup()->connect("popup_hide", callable_mp(this, &EditorNode::_update_file_menu_closed));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
settings_menu->get_popup()->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
file->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
file_templates->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
audio_preview_gen = memnew(AudioStreamPreviewGenerator);
add_child(audio_preview_gen);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
add_editor_plugin(memnew(DebuggerEditorPlugin(debug_menu)));
Implemented initial DAP support Implemented "output" event Refactored "seq" field generation Prevent debugging when editor and client are in different projects Removed unneeded references to peer on the parser Refactored way to detect project path Implemented "setBreakpoints" request Fix double events when terminating from client Refactored "stopped" event Implemented "stopped" with breakpoint event Implemented "stackTrace", "scopes" and "variables" request Report incoming number of stack dump variables Implemented proper reporting of scopes and variables from stack frames Prevent editor from grabbing focus when a DAP session is active Implemented "next" and "stepIn" requests Implemented "Source" checksum computing Switched expected errors from macros to silent guards Refactored message_id Respect client settings regarding lines/columns behavior Refactored nested DAP fields Implement reporting of "Members" and "Globals" scopes as well Fix error messages not being shown, and improved wrong path message
2021-06-04 18:39:38 +00:00
add_editor_plugin(memnew(DebugAdapterServer()));
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
disk_changed = memnew(ConfirmationDialog);
{
VBoxContainer *vbc = memnew(VBoxContainer);
disk_changed->add_child(vbc);
Label *dl = memnew(Label);
dl->set_text(TTR("The following files are newer on disk.\nWhat action should be taken?"));
vbc->add_child(dl);
disk_changed_list = memnew(Tree);
vbc->add_child(disk_changed_list);
disk_changed_list->set_v_size_flags(Control::SIZE_EXPAND_FILL);
disk_changed->connect("confirmed", callable_mp(this, &EditorNode::_reload_modified_scenes));
Detect external modification of project.godot
2021-01-17 00:09:17 +00:00
disk_changed->connect("confirmed", callable_mp(this, &EditorNode::_reload_project_settings));
Detect external modification of scenes
2019-08-28 17:42:27 +00:00
disk_changed->get_ok_button()->set_text(TTR("Reload"));
disk_changed->add_button(TTR("Resave"), !DisplayServer::get_singleton()->get_swap_cancel_ok(), "resave");
disk_changed->connect("custom_action", callable_mp(this, &EditorNode::_resave_scenes));
}
gui_base->add_child(disk_changed);
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
add_editor_plugin(memnew(AnimationPlayerEditorPlugin));
add_editor_plugin(memnew(CanvasItemEditorPlugin));
add_editor_plugin(memnew(Node3DEditorPlugin));
add_editor_plugin(memnew(ScriptEditorPlugin));
WIP new AudioServer, with buses, effects, etc.
2017-01-21 22:00:25 +00:00
Audio bus editing is COMPLETE!
2017-01-25 17:30:40 +00:00
EditorAudioBuses *audio_bus_editor = EditorAudioBuses::register_editor();
WIP new AudioServer, with buses, effects, etc.
2017-01-21 22:00:25 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
ScriptTextEditor::register_editor(); // Register one for text scripts.
Allow opening and editing of any utf_8 file in script editor
2018-05-28 15:52:28 +00:00
TextEditor::register_editor();
WIP visual scripting, not working yet but you can check out stuff
2016-08-02 22:11:05 +00:00
Better way to disable asset library
2016-06-10 01:47:43 +00:00
if (StreamPeerSSL::is_available()) {
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
add_editor_plugin(memnew(AssetLibraryEditorPlugin));
Better way to disable asset library
2016-06-10 01:47:43 +00:00
} else {
WARN_PRINT("Asset Library not available, as it requires SSL to work.");
}
-Split EditorPlugin into EditorPlugin and EditorInterface -Added EditorInterface to EditorScript -Added functions to save the scene to EditorInterface
2017-08-26 13:32:15 +00:00
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Add interface before adding plugins.
-Split EditorPlugin into EditorPlugin and EditorInterface -Added EditorInterface to EditorScript -Added functions to save the scene to EditorInterface
2017-08-26 13:32:15 +00:00
editor_interface = memnew(EditorInterface);
add_child(editor_interface);
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// More visually meaningful to have this later.
Implemented SkeletonEditorGizmo Co-authored-by: Lyuma <xn.lyuma@gmail.com>
2021-02-04 08:20:26 +00:00
raise_bottom_panel_item(AnimationPlayerEditor::get_singleton());
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
add_editor_plugin(memnew(ReplicationEditorPlugin));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-17 23:03:57 +00:00
Add VCS editor plugin UI elements to editor
2019-09-03 14:42:08 +00:00
add_editor_plugin(VersionControlEditorPlugin::get_singleton());
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
add_editor_plugin(memnew(ShaderEditorPlugin));
add_editor_plugin(memnew(ShaderFileEditorPlugin));
add_editor_plugin(memnew(VisualShaderEditorPlugin));
add_editor_plugin(memnew(Camera3DEditorPlugin));
add_editor_plugin(memnew(ThemeEditorPlugin));
add_editor_plugin(memnew(MultiMeshEditorPlugin));
add_editor_plugin(memnew(MeshInstance3DEditorPlugin));
add_editor_plugin(memnew(AnimationTreeEditorPlugin));
add_editor_plugin(memnew(MeshLibraryEditorPlugin));
add_editor_plugin(memnew(StyleBoxEditorPlugin));
add_editor_plugin(memnew(Sprite2DEditorPlugin));
add_editor_plugin(memnew(Skeleton2DEditorPlugin));
add_editor_plugin(memnew(GPUParticles2DEditorPlugin));
add_editor_plugin(memnew(GPUParticles3DEditorPlugin));
add_editor_plugin(memnew(CPUParticles2DEditorPlugin));
add_editor_plugin(memnew(CPUParticles3DEditorPlugin));
add_editor_plugin(memnew(ResourcePreloaderEditorPlugin));
add_editor_plugin(memnew(Polygon3DEditorPlugin));
add_editor_plugin(memnew(CollisionPolygon2DEditorPlugin));
add_editor_plugin(memnew(TilesEditorPlugin));
add_editor_plugin(memnew(SpriteFramesEditorPlugin));
add_editor_plugin(memnew(TextureRegionEditorPlugin));
add_editor_plugin(memnew(VoxelGIEditorPlugin));
add_editor_plugin(memnew(LightmapGIEditorPlugin));
add_editor_plugin(memnew(OccluderInstance3DEditorPlugin));
add_editor_plugin(memnew(Path2DEditorPlugin));
add_editor_plugin(memnew(Path3DEditorPlugin));
add_editor_plugin(memnew(Line2DEditorPlugin));
add_editor_plugin(memnew(Polygon2DEditorPlugin));
add_editor_plugin(memnew(LightOccluder2DEditorPlugin));
add_editor_plugin(memnew(NavigationPolygonEditorPlugin));
add_editor_plugin(memnew(GradientEditorPlugin));
add_editor_plugin(memnew(CollisionShape2DEditorPlugin));
add_editor_plugin(memnew(CurveEditorPlugin));
add_editor_plugin(memnew(FontEditorPlugin));
add_editor_plugin(memnew(OpenTypeFeaturesEditorPlugin));
add_editor_plugin(memnew(TextureEditorPlugin));
add_editor_plugin(memnew(TextureLayeredEditorPlugin));
add_editor_plugin(memnew(Texture3DEditorPlugin));
add_editor_plugin(memnew(AudioStreamEditorPlugin));
add_editor_plugin(memnew(AudioStreamRandomizerEditorPlugin));
Add base support for 2D meshes in Godot, including Sprite -> Mesh2D conversion.
2018-02-21 12:38:21 +00:00
add_editor_plugin(memnew(AudioBusesEditorPlugin(audio_bus_editor)));
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
add_editor_plugin(memnew(Skeleton3DEditorPlugin));
add_editor_plugin(memnew(SkeletonIK3DEditorPlugin));
add_editor_plugin(memnew(PhysicalBone3DEditorPlugin));
add_editor_plugin(memnew(MeshEditorPlugin));
add_editor_plugin(memnew(MaterialEditorPlugin));
add_editor_plugin(memnew(GPUParticlesCollisionSDF3DEditorPlugin));
add_editor_plugin(memnew(InputEventEditorPlugin));
add_editor_plugin(memnew(SubViewportPreviewEditorPlugin));
add_editor_plugin(memnew(TextControlEditorPlugin));
add_editor_plugin(memnew(ControlEditorPlugin));
Add GradientTexture2D editor plugin
2022-02-22 04:35:20 +00:00
add_editor_plugin(memnew(GradientTexture2DEditorPlugin));
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 15:46:49 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
for (int i = 0; i < EditorPlugins::get_plugin_count(); i++) {
Remove the EditorNode parameter from EditorPlugins create methods Remove EditorNode usage from the Navigation editor plugin.
2022-02-14 16:59:06 +00:00
add_editor_plugin(EditorPlugins::create(i));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < plugin_init_callback_count; i++) {
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-06 22:00:54 +00:00
plugin_init_callbacks[i]();
}
work in progress, resource previews
2015-05-31 04:59:42 +00:00
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 03:23:50 +00:00
resource_preview->add_preview_generator(Ref<EditorTexturePreviewPlugin>(memnew(EditorTexturePreviewPlugin)));
Generate inspector preview for Image resources
2020-06-27 20:03:20 +00:00
resource_preview->add_preview_generator(Ref<EditorImagePreviewPlugin>(memnew(EditorImagePreviewPlugin)));
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 03:23:50 +00:00
resource_preview->add_preview_generator(Ref<EditorPackedScenePreviewPlugin>(memnew(EditorPackedScenePreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorMaterialPreviewPlugin>(memnew(EditorMaterialPreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorScriptPreviewPlugin>(memnew(EditorScriptPreviewPlugin)));
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
resource_preview->add_preview_generator(Ref<EditorAudioStreamPreviewPlugin>(memnew(EditorAudioStreamPreviewPlugin)));
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 03:23:50 +00:00
resource_preview->add_preview_generator(Ref<EditorMeshPreviewPlugin>(memnew(EditorMeshPreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorBitmapPreviewPlugin>(memnew(EditorBitmapPreviewPlugin)));
Adding font preview to file browsers
2018-04-16 03:00:56 +00:00
resource_preview->add_preview_generator(Ref<EditorFontPreviewPlugin>(memnew(EditorFontPreviewPlugin)));
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-06 22:00:54 +00:00
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 12:20:28 +00:00
{
Modernized default 3D material, fixes material bugs.
2019-09-15 04:01:52 +00:00
Ref<StandardMaterial3DConversionPlugin> spatial_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
spatial_mat_convert.instantiate();
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 12:20:28 +00:00
resource_conversion_plugins.push_back(spatial_mat_convert);
Create ParticlesMaterialConversionPlugin and format generated shader code
2017-10-12 11:12:50 +00:00
Added convertor from `ORMMaterial3D` to `ShaderMaterial`
2021-10-29 14:49:12 +00:00
Ref<ORMMaterial3DConversionPlugin> orm_mat_convert;
orm_mat_convert.instantiate();
resource_conversion_plugins.push_back(orm_mat_convert);
Finalized ability to convert from CanvasItem/Spatial/Particles materials to ShaderMaterial, closes #10242
2017-11-14 18:44:51 +00:00
Ref<CanvasItemMaterialConversionPlugin> canvas_item_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
canvas_item_mat_convert.instantiate();
Finalized ability to convert from CanvasItem/Spatial/Particles materials to ShaderMaterial, closes #10242
2017-11-14 18:44:51 +00:00
resource_conversion_plugins.push_back(canvas_item_mat_convert);
Create ParticlesMaterialConversionPlugin and format generated shader code
2017-10-12 11:12:50 +00:00
Ref<ParticlesMaterialConversionPlugin> particles_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
particles_mat_convert.instantiate();
Create ParticlesMaterialConversionPlugin and format generated shader code
2017-10-12 11:12:50 +00:00
resource_conversion_plugins.push_back(particles_mat_convert);
Added convertor from VisualShader to Shader
2019-06-28 11:51:51 +00:00
Working sky shader implementation
2020-03-20 00:32:19 +00:00
Ref<ProceduralSkyMaterialConversionPlugin> procedural_sky_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
procedural_sky_mat_convert.instantiate();
Working sky shader implementation
2020-03-20 00:32:19 +00:00
resource_conversion_plugins.push_back(procedural_sky_mat_convert);
Ref<PanoramaSkyMaterialConversionPlugin> panorama_sky_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
panorama_sky_mat_convert.instantiate();
Working sky shader implementation
2020-03-20 00:32:19 +00:00
resource_conversion_plugins.push_back(panorama_sky_mat_convert);
Ref<PhysicalSkyMaterialConversionPlugin> physical_sky_mat_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
physical_sky_mat_convert.instantiate();
Working sky shader implementation
2020-03-20 00:32:19 +00:00
resource_conversion_plugins.push_back(physical_sky_mat_convert);
Addition of FogVolumes, FogShaders, FogMaterial, and overhaul of VolumetricFog Co-authored-by: Brian Semrau <brian.semrau@gmail.com>
2021-10-03 11:28:55 +00:00
Ref<FogMaterialConversionPlugin> fog_mat_convert;
fog_mat_convert.instantiate();
resource_conversion_plugins.push_back(fog_mat_convert);
Added convertor from VisualShader to Shader
2019-06-28 11:51:51 +00:00
Ref<VisualShaderConversionPlugin> vshader_convert;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
vshader_convert.instantiate();
Added convertor from VisualShader to Shader
2019-06-28 11:51:51 +00:00
resource_conversion_plugins.push_back(vshader_convert);
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 12:20:28 +00:00
}
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 15:52:25 +00:00
update_spinner_step_msec = OS::get_singleton()->get_ticks_msec();
update_spinner_step_frame = Engine::get_singleton()->get_frames_drawn();
update_spinner_step = 0;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
editor_plugin_screen = nullptr;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
editor_plugins_over = memnew(EditorPluginList);
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 19:32:09 +00:00
editor_plugins_force_over = memnew(EditorPluginList);
EditorPlugin can request user inputs from editor 3d view
2017-06-08 17:57:35 +00:00
editor_plugins_force_input_forwarding = memnew(EditorPluginList);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
-Added new scene conversion to binary on export (disabled by default, please test) -This method works by directly converting text to binary, so the scene does not need to be loaded and saved
2017-12-15 11:38:24 +00:00
Ref<EditorExportTextSceneToBinaryPlugin> export_text_to_binary_plugin;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
export_text_to_binary_plugin.instantiate();
-Added new scene conversion to binary on export (disabled by default, please test) -This method works by directly converting text to binary, so the scene does not need to be loaded and saved
2017-12-15 11:38:24 +00:00
EditorExport::get_singleton()->add_export_plugin(export_text_to_binary_plugin);
Implement GDExtension export plugin.
2022-03-10 07:48:25 +00:00
Ref<GDExtensionExportPlugin> gdextension_export_plugin;
gdextension_export_plugin.instantiate();
EditorExport::get_singleton()->add_export_plugin(gdextension_export_plugin);
Add translation parser plugin support
2020-06-23 11:48:59 +00:00
Ref<PackedSceneEditorTranslationParserPlugin> packed_scene_translation_parser_plugin;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
packed_scene_translation_parser_plugin.instantiate();
Add translation parser plugin support
2020-06-23 11:48:59 +00:00
EditorTranslationParser::get_singleton()->add_parser(packed_scene_translation_parser_plugin, EditorTranslationParser::STANDARD);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
_edit_current();
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
current = nullptr;
Add Save option to resource property menu
2018-11-18 14:17:04 +00:00
saving_resource = Ref<Resource>();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
set_process(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
open_imported = memnew(ConfirmationDialog);
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
open_imported->get_ok_button()->set_text(TTR("Open Anyway"));
Fix cancel/OK button order on macOS The macOS platform convention regarding button order is cancel on left, OK on right.
2020-07-08 23:02:38 +00:00
new_inherited_button = open_imported->add_button(TTR("New Inherited"), !DisplayServer::get_singleton()->get_swap_cancel_ok(), "inherit");
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
open_imported->connect("confirmed", callable_mp(this, &EditorNode::_open_imported));
open_imported->connect("custom_action", callable_mp(this, &EditorNode::_inherit_imported));
completed scene importing (I hope?)
2017-02-04 23:31:15 +00:00
gui_base->add_child(open_imported);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
saved_version = 1;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
_last_instantiated_scene = nullptr;
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
quick_open = memnew(EditorQuickOpen);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
gui_base->add_child(quick_open);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
quick_open->connect("quick_open", callable_mp(this, &EditorNode::_quick_opened));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
quick_run = memnew(EditorQuickOpen);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
gui_base->add_child(quick_run);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
quick_run->connect("quick_open", callable_mp(this, &EditorNode::_quick_run));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
_update_recent_scenes();
editor_data.restore_editor_global_states();
set_process_unhandled_input(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
load_errors = memnew(RichTextLabel);
load_error_dialog = memnew(AcceptDialog);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
load_error_dialog->add_child(load_errors);
Modified editor strings to be translatable in the future
2016-05-04 01:25:37 +00:00
load_error_dialog->set_title(TTR("Load Errors"));
Ask about selecting a main scene if one has not been selected.
2016-06-27 22:59:33 +00:00
gui_base->add_child(load_error_dialog);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
execute_outputs = memnew(RichTextLabel);
Enable text selection in execute output of EditorNode
2020-06-04 12:38:55 +00:00
execute_outputs->set_selection_enabled(true);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
execute_output_dialog = memnew(AcceptDialog);
execute_output_dialog->add_child(execute_outputs);
i18n: Fix extract.py support for new TTRC Also make compatible with Python 3.
2019-06-16 19:57:34 +00:00
execute_output_dialog->set_title("");
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 18:46:52 +00:00
gui_base->add_child(execute_output_dialog);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
EditorFileSystem::get_singleton()->connect("sources_changed", callable_mp(this, &EditorNode::_sources_changed));
EditorFileSystem::get_singleton()->connect("filesystem_changed", callable_mp(this, &EditorNode::_fs_changed));
EditorFileSystem::get_singleton()->connect("resources_reimported", callable_mp(this, &EditorNode::_resources_reimported));
EditorFileSystem::get_singleton()->connect("resources_reload", callable_mp(this, &EditorNode::_resources_changed));
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Update icons when theme changed
2018-02-25 16:04:16 +00:00
_build_icon_type_cache();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
pick_main_scene = memnew(ConfirmationDialog);
Ask about selecting a main scene if one has not been selected.
2016-06-27 22:59:33 +00:00
gui_base->add_child(pick_main_scene);
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
pick_main_scene->get_ok_button()->set_text(TTR("Select"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
pick_main_scene->connect("confirmed", callable_mp(this, &EditorNode::_menu_option), varray(SETTINGS_PICK_MAIN_SCENE));
Added 'Select Current' option when user is prompted to select main scene after clicking play
2021-07-06 14:10:07 +00:00
select_current_scene_button = pick_main_scene->add_button(TTR("Select Current"), true, "select_current");
pick_main_scene->connect("custom_action", callable_mp(this, &EditorNode::_pick_main_scene_custom_action));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 01:12:53 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
for (int i = 0; i < _init_callbacks.size(); i++) {
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 12:31:47 +00:00
_init_callbacks[i]();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
editor_data.add_edited_scene(-1);
editor_data.set_edited_scene(0);
_update_scene_tabs();
Store panels and docks singletons in their own classes
2021-11-17 20:08:55 +00:00
ImportDock::get_singleton()->initialize_import_options();
Suppress get_edited_scene_root error
2017-07-23 14:44:42 +00:00
-Add visible IO errors when closing a file fails due to it being locked (most likely on windows), closes #4760
2016-06-13 13:10:50 +00:00
FileAccess::set_file_close_fail_notify_callback(_file_access_close_error_notify);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 03:03:19 +00:00
Add a print handler for the editor output panel
2017-11-14 22:02:31 +00:00
print_handler.printfunc = _print_handler;
print_handler.userdata = this;
add_print_handler(&print_handler);
Moved folding outside the resource files, now saved outside the project.
2018-10-29 19:36:31 +00:00
ResourceSaver::set_save_callback(_resource_saved);
ResourceLoader::set_load_callback(_resource_loaded);
Require Ctrl for switching between editors, bind F2 to Rename Node Switching between editors now requires holding Ctrl to avoid conflicts with the new F2 shortcut. The asset library can now be accessed by pressing Ctrl + F4 on Windows and Linux, or Alt + 4 on macOS. This partially addresses #38139.
2020-04-25 13:04:49 +00:00
// Use the Ctrl modifier so F2 can be used to rename nodes in the scene tree dock.
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
ED_SHORTCUT_AND_COMMAND("editor/editor_2d", TTR("Open 2D Editor"), KeyModifierMask::CTRL | Key::F1);
ED_SHORTCUT_AND_COMMAND("editor/editor_3d", TTR("Open 3D Editor"), KeyModifierMask::CTRL | Key::F2);
ED_SHORTCUT_AND_COMMAND("editor/editor_script", TTR("Open Script Editor"), KeyModifierMask::CTRL | Key::F3);
ED_SHORTCUT_AND_COMMAND("editor/editor_assetlib", TTR("Open Asset Library"), KeyModifierMask::CTRL | Key::F4);
ED_SHORTCUT_OVERRIDE("editor/editor_2d", "macos", KeyModifierMask::ALT | Key::KEY_1);
ED_SHORTCUT_OVERRIDE("editor/editor_3d", "macos", KeyModifierMask::ALT | Key::KEY_2);
ED_SHORTCUT_OVERRIDE("editor/editor_script", "macos", KeyModifierMask::ALT | Key::KEY_3);
ED_SHORTCUT_OVERRIDE("editor/editor_assetlib", "macos", KeyModifierMask::ALT | Key::KEY_4);
Added ability to override shortcut definitions for OSX (remove preprocessor defines)
2021-08-08 03:52:00 +00:00
ED_SHORTCUT_AND_COMMAND("editor/editor_next", TTR("Open the next Editor"));
ED_SHORTCUT_AND_COMMAND("editor/editor_prev", TTR("Open the previous Editor"));
Add editor screenshot on control - f12.
2019-03-29 13:53:11 +00:00
screenshot_timer = memnew(Timer);
screenshot_timer->set_one_shot(true);
screenshot_timer->set_wait_time(settings_menu->get_popup()->get_submenu_popup_delay() + 0.1f);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
screenshot_timer->connect("timeout", callable_mp(this, &EditorNode::_request_screenshot));
Add editor screenshot on control - f12.
2019-03-29 13:53:11 +00:00
add_child(screenshot_timer);
screenshot_timer->set_owner(get_owner());
for third-party tools - editor_path is stored in project's editor settings
2020-03-12 12:59:48 +00:00
String exec = OS::get_singleton()->get_executable_path();
Cleanup EditorNode and EditorData Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-03-30 18:12:26 +00:00
// Save editor executable path for third-party tools.
EditorSettings::get_singleton()->set_project_metadata("editor_metadata", "executable_path", exec);
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
}
remove trailing whitespace
2016-03-08 23:00:52 +00:00
EditorNode::~EditorNode() {
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 20:12:35 +00:00
EditorInspector::cleanup_plugins();
Fix EditorTranslationParser leak
2020-07-27 14:58:21 +00:00
EditorTranslationParser::get_singleton()->clean_parsers();
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 20:12:35 +00:00
Add a print handler for the editor output panel
2017-11-14 22:02:31 +00:00
remove_print_handler(&print_handler);
Generate editor docs on a thread * The main generation could not be moved to a thread, as it instantiates classes to get default values, interacts with ProjectSettings, etc. * Only uncompressing documentation and merging it is threaded. * Seems to improve editor load times by 0.5 seconds.
2021-07-25 17:44:03 +00:00
EditorHelp::cleanup_doc();
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
memdelete(editor_selection);
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
memdelete(editor_plugins_over);
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 19:32:09 +00:00
memdelete(editor_plugins_force_over);
EditorPlugin can request user inputs from editor 3d view
2017-06-08 17:57:35 +00:00
memdelete(editor_plugins_force_input_forwarding);
Fixed several memory leaks
2017-08-24 16:51:28 +00:00
memdelete(progress_hb);
-Moved EditorDefaultValue to ClassDB, made it core -Removed one and zero hints for properties, replaced by default value
2018-11-08 14:30:02 +00:00
GODOT IS OPEN SOURCE
2014-02-10 01:10:30 +00:00
EditorSettings::destroy();
}
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
/*
* EDITOR PLUGIN LIST
*/
void EditorPluginList::make_visible(bool p_visible) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 19:44:03 +00:00
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->make_visible(p_visible);
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorPluginList::edit(Object *p_object) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 19:44:03 +00:00
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->edit(p_object);
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
}
}
Fixes snapping and replaces the _draw_canvas by forward_canvas_draw
2017-10-15 20:33:25 +00:00
bool EditorPluginList::forward_gui_input(const Ref<InputEvent> &p_event) {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
bool discard = false;
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 19:44:03 +00:00
for (int i = 0; i < plugins_list.size(); i++) {
Fixes snapping and replaces the _draw_canvas by forward_canvas_draw
2017-10-15 20:33:25 +00:00
if (plugins_list[i]->forward_canvas_gui_input(p_event)) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 19:44:03 +00:00
discard = true;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
}
}
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 19:44:03 +00:00
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
return discard;
}
Implemented SkeletonEditorGizmo Co-authored-by: Lyuma <xn.lyuma@gmail.com>
2021-02-04 08:20:26 +00:00
EditorPlugin::AfterGUIInput EditorPluginList::forward_spatial_gui_input(Camera3D *p_camera, const Ref<InputEvent> &p_event, bool serve_when_force_input_enabled) {
EditorPlugin::AfterGUIInput after = EditorPlugin::AFTER_GUI_INPUT_PASS;
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 19:44:03 +00:00
for (int i = 0; i < plugins_list.size(); i++) {
EditorPlugin can request user inputs from editor 3d view
2017-06-08 17:57:35 +00:00
if ((!serve_when_force_input_enabled) && plugins_list[i]->is_input_event_forwarding_always_enabled()) {
continue;
}
Implemented SkeletonEditorGizmo Co-authored-by: Lyuma <xn.lyuma@gmail.com>
2021-02-04 08:20:26 +00:00
EditorPlugin::AfterGUIInput current_after = plugins_list[i]->forward_spatial_gui_input(p_camera, p_event);
if (current_after == EditorPlugin::AFTER_GUI_INPUT_STOP) {
after = EditorPlugin::AFTER_GUI_INPUT_STOP;
}
if (after != EditorPlugin::AFTER_GUI_INPUT_STOP && current_after == EditorPlugin::AFTER_GUI_INPUT_DESELECT) {
after = EditorPlugin::AFTER_GUI_INPUT_DESELECT;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
}
}
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 19:44:03 +00:00
Implemented SkeletonEditorGizmo Co-authored-by: Lyuma <xn.lyuma@gmail.com>
2021-02-04 08:20:26 +00:00
return after;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
}
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 18:00:07 +00:00
void EditorPluginList::forward_canvas_draw_over_viewport(Control *p_overlay) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 19:44:03 +00:00
for (int i = 0; i < plugins_list.size(); i++) {
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 18:00:07 +00:00
plugins_list[i]->forward_canvas_draw_over_viewport(p_overlay);
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 19:32:09 +00:00
}
}
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 18:00:07 +00:00
void EditorPluginList::forward_canvas_force_draw_over_viewport(Control *p_overlay) {
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 19:32:09 +00:00
for (int i = 0; i < plugins_list.size(); i++) {
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 18:00:07 +00:00
plugins_list[i]->forward_canvas_force_draw_over_viewport(p_overlay);
}
}
void EditorPluginList::forward_spatial_draw_over_viewport(Control *p_overlay) {
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->forward_spatial_draw_over_viewport(p_overlay);
}
}
void EditorPluginList::forward_spatial_force_draw_over_viewport(Control *p_overlay) {
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->forward_spatial_force_draw_over_viewport(p_overlay);
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 19:44:03 +00:00
}
}
EditorPlugin can request user inputs from editor 3d view
2017-06-08 17:57:35 +00:00
void EditorPluginList::add_plugin(EditorPlugin *p_plugin) {
plugins_list.push_back(p_plugin);
}
Fix editor crash after disabling plugin that used forward_spatial_gui_input Fixes #26124.
2019-02-25 15:49:06 +00:00
void EditorPluginList::remove_plugin(EditorPlugin *p_plugin) {
plugins_list.erase(p_plugin);
}
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
bool EditorPluginList::is_empty() {
return plugins_list.is_empty();
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-29 23:02:53 +00:00
}
void EditorPluginList::clear() {
plugins_list.clear();
}
EditorPluginList::EditorPluginList() {
}
EditorPluginList::~EditorPluginList() {
}
Reference in New Issue Copy Permalink