From cddcf3d3e7309a8c166004de7c117fbee1f6871d Mon Sep 17 00:00:00 2001
From: Ryan Kurtz <ryanmkurtz@users.noreply.github.com>
Date: Wed, 2 Nov 2022 11:01:47 -0400
Subject: [PATCH] GP-2786: A few improvements

---
 GPL/nativeBuildProperties.gradle  | 2 +-
 GPL/vsconfig.gradle               | 4 ++--
 GhidraDocs/InstallationGuide.html | 7 ++++++-
 README.md                         | 6 +++++-
 4 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/GPL/nativeBuildProperties.gradle b/GPL/nativeBuildProperties.gradle
index 730829463e..4d887dba10 100644
--- a/GPL/nativeBuildProperties.gradle
+++ b/GPL/nativeBuildProperties.gradle
@@ -52,7 +52,7 @@ model {
 				}
 			}
 		}
-		if (isCurrentWindows()) {
+		if (isCurrentWindows() && VISUAL_STUDIO_INSTALL_DIR) {
 			// specify installDir because Gradle doesn't find VS Build Tools.
 			// See https://github.com/gradle/gradle-native/issues/617#issuecomment-575735288
 			visualCpp(VisualCpp) {
diff --git a/GPL/vsconfig.gradle b/GPL/vsconfig.gradle
index d6dae0ee5a..4fe1edc223 100644
--- a/GPL/vsconfig.gradle
+++ b/GPL/vsconfig.gradle
@@ -29,13 +29,13 @@ def configureVisualStudio() {
 		println "Searching for latest Visual Studio and required components..."
 		def vswherePath = "C:\\Program Files (x86)\\Microsoft Visual Studio\\Installer\\vswhere.exe"
 		if (!file(vswherePath).exists()) {
-			println "Visual Studio not found!"
+			println "  -> Visual Studio vswhere.exe not found!"
 			return
 		}
 		def vswhereOutput = "${vswherePath} -products * -latest -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -format json".execute().text.trim()
 		def vswhereJson = new groovy.json.JsonSlurper().parseText(vswhereOutput);
 		if (vswhereJson.isEmpty()) {
-			println "Visual Studio not found!"
+			println "  -> Visual Studio not found!"
 			return
 		}
 		def vsInstallDir = vswhereJson[0].installationPath
diff --git a/GhidraDocs/InstallationGuide.html b/GhidraDocs/InstallationGuide.html
index 15d079a79c..25372f59b7 100644
--- a/GhidraDocs/InstallationGuide.html
+++ b/GhidraDocs/InstallationGuide.html
@@ -327,7 +327,12 @@ system:</p>
   <li>
     <a href="https://visualstudio.microsoft.com/vs/community/">Microsoft Visual Studio</a>
     2017 or later, or <a href="https://visualstudio.microsoft.com/visual-cpp-build-tools/">
-    Microsoft C++ Build Tools</a> (Windows-only)
+    Microsoft C++ Build Tools</a> with the following components installed (Windows-only):
+      <ul>
+        <li>MSVC</li>
+        <li>Windows SDK</li>
+        <li>C++ ATL</li>
+      </ul>
   </li>
 </ul>
 <p>To build the native binaries for your current platform, execute the following script:</p>
diff --git a/README.md b/README.md
index 72dd0cb84e..f6ca04aa62 100644
--- a/README.md
+++ b/README.md
@@ -46,7 +46,11 @@ To create the latest development build for your platform from this source reposi
 * [JDK 17 64-bit][jdk17]
 * [Gradle 7.3+][gradle]
 * make, gcc, and g++ (Linux/macOS-only)
-* [Microsoft Visual Studio][vs] or [Microsoft C++ Build Tools][vcbuildtools] (Windows-only)
+* [Microsoft Visual Studio][vs] or [Microsoft C++ Build Tools][vcbuildtools] with the following
+  components installed (Windows-only):
+  - MSVC
+  - Windows SDK
+  - C++ ATL
 
 ##### Download and extract the source:
 [Download from GitHub][master]