Nixyri/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2024-11-10 06:02:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

decompiler: Don't propagate types through call clobbers

Browse Source 
INDIRECT ops that model call-clobbered registers indicate that the value
may be changed arbitrarily by the call, so it doesn't make sense to
propagate types through them to the value it had before the call.

Fixes: #4639

Sponsored-by: RCS Lab at University of Waterloo, NSERC, WHJIL
This commit is contained in:
Tavian Barnes 2022-11-18 09:52:21 -05:00
parent 5b1eb8ef32
commit 3643859495
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Ghidra/Features/Decompiler/src/decompile/cpp/heritage.cc
View File

@ -1315,6 +1315,7 @@ void Heritage::guardCalls(uint4 fl,const Address &addr,int4 size,vector<Varnode
// We do not guard the call if the effect is "unaffected" or "reload"
if ((effecttype == EffectRecord::unknown_effect)||(effecttype == EffectRecord::return_address)) {
indop = fd->newIndirectOp(fc->getOp(),addr,size,0);
indop->setStopTypePropagation();
indop->getIn(0)->setActiveHeritage();
indop->getOut()->setActiveHeritage();
write.push_back(indop->getOut());
@ -1325,6 +1326,7 @@ void Heritage::guardCalls(uint4 fl,const Address &addr,int4 size,vector<Varnode
}
else if (effecttype == EffectRecord::killedbycall) {
indop = fd->newIndirectCreation(fc->getOp(),addr,size,possibleoutput);
indop->setStopTypePropagation();
indop->getOut()->setActiveHeritage();
write.push_back(indop->getOut());
}