mirror of
https://github.com/torvalds/linux.git
synced 2024-11-15 08:31:55 +00:00
dacbe41f77
While in theory user_enable_single_step/user_disable_single_step/
user_enable_blockstep could also be provided as an inline or macro there's
no good reason to do so, and having the prototype in one places keeps code
size and confusion down.
Roland said:
The original thought there was that user_enable_single_step() et al
might well be only an instruction or three on a sane machine (as if we
have any of those!), and since there is only one call site inlining
would be beneficial. But I agree that there is no strong reason to care
about inlining it.
As to the arch changes, there is only one thought I'd add to the
record. It was always my thinking that for an arch where
PTRACE_SINGLESTEP does text-modifying breakpoint insertion,
user_enable_single_step() should not be provided. That is,
arch_has_single_step()=>true means that there is an arch facility with
"pure" semantics that does not have any unexpected side effects.
Inserting a breakpoint might do very unexpected strange things in
multi-threaded situations. Aside from that, it is a peculiar side
effect that user_{enable,disable}_single_step() should cause COW
de-sharing of text pages and so forth. For PTRACE_SINGLESTEP, all these
peculiarities are the status quo ante for that arch, so having
arch_ptrace() itself do those is one thing. But for building other
things in the future, it is nicer to have a uniform "pure" semantics
that arch-independent code can expect.
OTOH, all such arch issues are really up to the arch maintainer. As
of today, there is nothing but ptrace using user_enable_single_step() et
al so it's a distinction without a practical difference. If/when there
are other facilities that use user_enable_single_step() and might care,
the affected arch's can revisit the question when someone cares about
the quality of the arch support for said new facility.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
91 lines
2.7 KiB
C
91 lines
2.7 KiB
C
/* ptrace.h: ptrace() relevant definitions
|
|
*
|
|
* Copyright (C) 2003 Red Hat, Inc. All Rights Reserved.
|
|
* Written by David Howells (dhowells@redhat.com)
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*/
|
|
#ifndef _ASM_PTRACE_H
|
|
#define _ASM_PTRACE_H
|
|
|
|
#include <asm/registers.h>
|
|
#ifdef __KERNEL__
|
|
#include <asm/irq_regs.h>
|
|
|
|
#define in_syscall(regs) (((regs)->tbr & TBR_TT) == TBR_TT_TRAP0)
|
|
#endif
|
|
|
|
|
|
#define PT_PSR 0
|
|
#define PT_ISR 1
|
|
#define PT_CCR 2
|
|
#define PT_CCCR 3
|
|
#define PT_LR 4
|
|
#define PT_LCR 5
|
|
#define PT_PC 6
|
|
|
|
#define PT__STATUS 7 /* exception status */
|
|
#define PT_SYSCALLNO 8 /* syscall number or -1 */
|
|
#define PT_ORIG_GR8 9 /* saved GR8 for signal handling */
|
|
#define PT_GNER0 10
|
|
#define PT_GNER1 11
|
|
#define PT_IACC0H 12
|
|
#define PT_IACC0L 13
|
|
|
|
#define PT_GR(j) ( 14 + (j)) /* GRj for 0<=j<=63 */
|
|
#define PT_FR(j) ( 78 + (j)) /* FRj for 0<=j<=63 */
|
|
#define PT_FNER(j) (142 + (j)) /* FNERj for 0<=j<=1 */
|
|
#define PT_MSR(j) (144 + (j)) /* MSRj for 0<=j<=2 */
|
|
#define PT_ACC(j) (146 + (j)) /* ACCj for 0<=j<=7 */
|
|
#define PT_ACCG(jklm) (154 + (jklm)) /* ACCGjklm for 0<=jklm<=1 (reads four regs per slot) */
|
|
#define PT_FSR(j) (156 + (j)) /* FSRj for 0<=j<=0 */
|
|
#define PT__GPEND 78
|
|
#define PT__END 157
|
|
|
|
#define PT_TBR PT_GR(0)
|
|
#define PT_SP PT_GR(1)
|
|
#define PT_FP PT_GR(2)
|
|
#define PT_PREV_FRAME PT_GR(28) /* previous exception frame pointer (old gr28 value) */
|
|
#define PT_CURR_TASK PT_GR(29) /* current task */
|
|
|
|
|
|
/* Arbitrarily choose the same ptrace numbers as used by the Sparc code. */
|
|
#define PTRACE_GETREGS 12
|
|
#define PTRACE_SETREGS 13
|
|
#define PTRACE_GETFPREGS 14
|
|
#define PTRACE_SETFPREGS 15
|
|
#define PTRACE_GETFDPIC 31 /* get the ELF fdpic loadmap address */
|
|
|
|
#define PTRACE_GETFDPIC_EXEC 0 /* [addr] request the executable loadmap */
|
|
#define PTRACE_GETFDPIC_INTERP 1 /* [addr] request the interpreter loadmap */
|
|
|
|
#ifdef __KERNEL__
|
|
#ifndef __ASSEMBLY__
|
|
|
|
struct task_struct;
|
|
|
|
/*
|
|
* we dedicate GR28 to keeping a pointer to the current exception frame
|
|
* - gr28 is destroyed on entry to the kernel from userspace
|
|
*/
|
|
register struct pt_regs *__frame asm("gr28");
|
|
|
|
#define user_mode(regs) (!((regs)->psr & PSR_S))
|
|
#define instruction_pointer(regs) ((regs)->pc)
|
|
#define user_stack_pointer(regs) ((regs)->sp)
|
|
|
|
extern unsigned long user_stack(const struct pt_regs *);
|
|
extern void show_regs(struct pt_regs *);
|
|
#define profile_pc(regs) ((regs)->pc)
|
|
|
|
#define task_pt_regs(task) ((task)->thread.frame0)
|
|
|
|
#define arch_has_single_step() (1)
|
|
|
|
#endif /* !__ASSEMBLY__ */
|
|
#endif /* __KERNEL__ */
|
|
#endif /* _ASM_PTRACE_H */
|