mirror of
https://github.com/torvalds/linux.git
synced 2024-11-18 10:01:43 +00:00
b01c1f69c8
When reporting on 'record' server we try to retrieve/use the mnt
namespace of the profiled tasks. We use following API with cookie to
hold the return namespace, roughly:
nsinfo__mountns_enter(struct nsinfo *nsi, struct nscookie *nc)
setns(newns, 0);
...
new ns related open..
...
nsinfo__mountns_exit(struct nscookie *nc)
setns(nc->oldns)
Once finished we setns to old namespace, which also sets the current
working directory (cwd) to "/", trashing the cwd we had.
This is mostly fine, because we use absolute paths almost everywhere,
but it screws up 'perf diff':
# perf diff
failed to open perf.data: No such file or directory (try 'perf record' first)
...
Adding the current working directory to be part of the cookie and
restoring it in the nsinfo__mountns_exit call.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Krister Johansen <kjlx@templeofstupid.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 843ff37bb5 ("perf symbols: Find symbols in different mount namespace")
Link: http://lkml.kernel.org/r/20181101170001.30019-1-jolsa@kernel.org
[ No need to check for NULL args for free(), use zfree() for struct members ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
68 lines
1.5 KiB
C
68 lines
1.5 KiB
C
/*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License, version 2, as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* Copyright (C) 2017 Hari Bathini, IBM Corporation
|
|
*/
|
|
|
|
#ifndef __PERF_NAMESPACES_H
|
|
#define __PERF_NAMESPACES_H
|
|
|
|
#include <sys/types.h>
|
|
#include <linux/stddef.h>
|
|
#include <linux/perf_event.h>
|
|
#include <linux/refcount.h>
|
|
#include <linux/types.h>
|
|
|
|
struct namespaces_event;
|
|
|
|
struct namespaces {
|
|
struct list_head list;
|
|
u64 end_time;
|
|
struct perf_ns_link_info link_info[];
|
|
};
|
|
|
|
struct namespaces *namespaces__new(struct namespaces_event *event);
|
|
void namespaces__free(struct namespaces *namespaces);
|
|
|
|
struct nsinfo {
|
|
pid_t pid;
|
|
pid_t tgid;
|
|
pid_t nstgid;
|
|
bool need_setns;
|
|
char *mntns_path;
|
|
refcount_t refcnt;
|
|
};
|
|
|
|
struct nscookie {
|
|
int oldns;
|
|
int newns;
|
|
char *oldcwd;
|
|
};
|
|
|
|
int nsinfo__init(struct nsinfo *nsi);
|
|
struct nsinfo *nsinfo__new(pid_t pid);
|
|
struct nsinfo *nsinfo__copy(struct nsinfo *nsi);
|
|
void nsinfo__delete(struct nsinfo *nsi);
|
|
|
|
struct nsinfo *nsinfo__get(struct nsinfo *nsi);
|
|
void nsinfo__put(struct nsinfo *nsi);
|
|
|
|
void nsinfo__mountns_enter(struct nsinfo *nsi, struct nscookie *nc);
|
|
void nsinfo__mountns_exit(struct nscookie *nc);
|
|
|
|
char *nsinfo__realpath(const char *path, struct nsinfo *nsi);
|
|
|
|
static inline void __nsinfo__zput(struct nsinfo **nsip)
|
|
{
|
|
if (nsip) {
|
|
nsinfo__put(*nsip);
|
|
*nsip = NULL;
|
|
}
|
|
}
|
|
|
|
#define nsinfo__zput(nsi) __nsinfo__zput(&nsi)
|
|
|
|
#endif /* __PERF_NAMESPACES_H */
|