mirror of
https://github.com/torvalds/linux.git
synced 2024-11-10 14:11:52 +00:00
3c938cc5ce
In case of PREEMPT_RT, there is a raw_spinlock -> spinlock dependency as the lockdep report shows. __irq_set_handler irq_get_desc_buslock __irq_get_desc_lock raw_spin_lock_irqsave(&desc->lock, *flags); // raw spinlock get here __irq_do_set_handler mask_ack_irq dwapb_irq_ack spin_lock_irqsave(&gc->bgpio_lock, flags); // sleep able spinlock irq_put_desc_busunlock Replace with a raw lock to avoid BUGs. This lock is only used to access registers, and It's safe to replace with the raw lock without bad influence. [ 15.090359][ T1] ============================= [ 15.090365][ T1] [ BUG: Invalid wait context ] [ 15.090373][ T1] 5.10.59-rt52-00983-g186a6841c682-dirty #3 Not tainted [ 15.090386][ T1] ----------------------------- [ 15.090392][ T1] swapper/0/1 is trying to lock: [ 15.090402][ T1] 70ff00018507c188 (&gc->bgpio_lock){....}-{3:3}, at: _raw_spin_lock_irqsave+0x1c/0x28 [ 15.090470][ T1] other info that might help us debug this: [ 15.090477][ T1] context-{5:5} [ 15.090485][ T1] 3 locks held by swapper/0/1: [ 15.090497][ T1] #0: c2ff0001816de1a0 (&dev->mutex){....}-{4:4}, at: __device_driver_lock+0x98/0x104 [ 15.090553][ T1] #1: ffff90001485b4b8 (irq_domain_mutex){+.+.}-{4:4}, at: irq_domain_associate+0xbc/0x6d4 [ 15.090606][ T1] #2: 4bff000185d7a8e0 (lock_class){....}-{2:2}, at: _raw_spin_lock_irqsave+0x1c/0x28 [ 15.090654][ T1] stack backtrace: [ 15.090661][ T1] CPU: 4 PID: 1 Comm: swapper/0 Not tainted 5.10.59-rt52-00983-g186a6841c682-dirty #3 [ 15.090682][ T1] Hardware name: Horizon Robotics Journey 5 DVB (DT) [ 15.090692][ T1] Call trace: ...... [ 15.090811][ T1] _raw_spin_lock_irqsave+0x1c/0x28 [ 15.090828][ T1] dwapb_irq_ack+0xb4/0x300 [ 15.090846][ T1] __irq_do_set_handler+0x494/0xb2c [ 15.090864][ T1] __irq_set_handler+0x74/0x114 [ 15.090881][ T1] irq_set_chip_and_handler_name+0x44/0x58 [ 15.090900][ T1] gpiochip_irq_map+0x210/0x644 Signed-off-by: Schspa Shi <schspa@gmail.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Doug Berger <opendmb@gmail.com> Acked-by: Serge Semin <fancer.lancer@gmail.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
215 lines
5.0 KiB
C
215 lines
5.0 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* MEN 16Z127 GPIO driver
|
|
*
|
|
* Copyright (C) 2016 MEN Mikroelektronik GmbH (www.men.de)
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/io.h>
|
|
#include <linux/err.h>
|
|
#include <linux/mcb.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/gpio/driver.h>
|
|
|
|
#define MEN_Z127_CTRL 0x00
|
|
#define MEN_Z127_PSR 0x04
|
|
#define MEN_Z127_IRQR 0x08
|
|
#define MEN_Z127_GPIODR 0x0c
|
|
#define MEN_Z127_IER1 0x10
|
|
#define MEN_Z127_IER2 0x14
|
|
#define MEN_Z127_DBER 0x18
|
|
#define MEN_Z127_ODER 0x1C
|
|
#define GPIO_TO_DBCNT_REG(gpio) ((gpio * 4) + 0x80)
|
|
|
|
#define MEN_Z127_DB_MIN_US 50
|
|
/* 16 bit compare register. Each bit represents 50us */
|
|
#define MEN_Z127_DB_MAX_US (0xffff * MEN_Z127_DB_MIN_US)
|
|
#define MEN_Z127_DB_IN_RANGE(db) ((db >= MEN_Z127_DB_MIN_US) && \
|
|
(db <= MEN_Z127_DB_MAX_US))
|
|
|
|
struct men_z127_gpio {
|
|
struct gpio_chip gc;
|
|
void __iomem *reg_base;
|
|
struct resource *mem;
|
|
};
|
|
|
|
static int men_z127_debounce(struct gpio_chip *gc, unsigned gpio,
|
|
unsigned debounce)
|
|
{
|
|
struct men_z127_gpio *priv = gpiochip_get_data(gc);
|
|
struct device *dev = gc->parent;
|
|
unsigned int rnd;
|
|
u32 db_en, db_cnt;
|
|
|
|
if (!MEN_Z127_DB_IN_RANGE(debounce)) {
|
|
dev_err(dev, "debounce value %u out of range", debounce);
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (debounce > 0) {
|
|
/* round up or down depending on MSB-1 */
|
|
rnd = fls(debounce) - 1;
|
|
|
|
if (rnd && (debounce & BIT(rnd - 1)))
|
|
debounce = roundup(debounce, MEN_Z127_DB_MIN_US);
|
|
else
|
|
debounce = rounddown(debounce, MEN_Z127_DB_MIN_US);
|
|
|
|
if (debounce > MEN_Z127_DB_MAX_US)
|
|
debounce = MEN_Z127_DB_MAX_US;
|
|
|
|
/* 50us per register unit */
|
|
debounce /= 50;
|
|
}
|
|
|
|
raw_spin_lock(&gc->bgpio_lock);
|
|
|
|
db_en = readl(priv->reg_base + MEN_Z127_DBER);
|
|
|
|
if (debounce == 0) {
|
|
db_en &= ~BIT(gpio);
|
|
db_cnt = 0;
|
|
} else {
|
|
db_en |= BIT(gpio);
|
|
db_cnt = debounce;
|
|
}
|
|
|
|
writel(db_en, priv->reg_base + MEN_Z127_DBER);
|
|
writel(db_cnt, priv->reg_base + GPIO_TO_DBCNT_REG(gpio));
|
|
|
|
raw_spin_unlock(&gc->bgpio_lock);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int men_z127_set_single_ended(struct gpio_chip *gc,
|
|
unsigned offset,
|
|
enum pin_config_param param)
|
|
{
|
|
struct men_z127_gpio *priv = gpiochip_get_data(gc);
|
|
u32 od_en;
|
|
|
|
raw_spin_lock(&gc->bgpio_lock);
|
|
od_en = readl(priv->reg_base + MEN_Z127_ODER);
|
|
|
|
if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN)
|
|
od_en |= BIT(offset);
|
|
else
|
|
/* Implicitly PIN_CONFIG_DRIVE_PUSH_PULL */
|
|
od_en &= ~BIT(offset);
|
|
|
|
writel(od_en, priv->reg_base + MEN_Z127_ODER);
|
|
raw_spin_unlock(&gc->bgpio_lock);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int men_z127_set_config(struct gpio_chip *gc, unsigned offset,
|
|
unsigned long config)
|
|
{
|
|
enum pin_config_param param = pinconf_to_config_param(config);
|
|
|
|
switch (param) {
|
|
case PIN_CONFIG_DRIVE_OPEN_DRAIN:
|
|
case PIN_CONFIG_DRIVE_PUSH_PULL:
|
|
return men_z127_set_single_ended(gc, offset, param);
|
|
|
|
case PIN_CONFIG_INPUT_DEBOUNCE:
|
|
return men_z127_debounce(gc, offset,
|
|
pinconf_to_config_argument(config));
|
|
|
|
default:
|
|
break;
|
|
}
|
|
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static int men_z127_probe(struct mcb_device *mdev,
|
|
const struct mcb_device_id *id)
|
|
{
|
|
struct men_z127_gpio *men_z127_gpio;
|
|
struct device *dev = &mdev->dev;
|
|
int ret;
|
|
|
|
men_z127_gpio = devm_kzalloc(dev, sizeof(struct men_z127_gpio),
|
|
GFP_KERNEL);
|
|
if (!men_z127_gpio)
|
|
return -ENOMEM;
|
|
|
|
men_z127_gpio->mem = mcb_request_mem(mdev, dev_name(dev));
|
|
if (IS_ERR(men_z127_gpio->mem)) {
|
|
dev_err(dev, "failed to request device memory");
|
|
return PTR_ERR(men_z127_gpio->mem);
|
|
}
|
|
|
|
men_z127_gpio->reg_base = ioremap(men_z127_gpio->mem->start,
|
|
resource_size(men_z127_gpio->mem));
|
|
if (men_z127_gpio->reg_base == NULL) {
|
|
ret = -ENXIO;
|
|
goto err_release;
|
|
}
|
|
|
|
mcb_set_drvdata(mdev, men_z127_gpio);
|
|
|
|
ret = bgpio_init(&men_z127_gpio->gc, &mdev->dev, 4,
|
|
men_z127_gpio->reg_base + MEN_Z127_PSR,
|
|
men_z127_gpio->reg_base + MEN_Z127_CTRL,
|
|
NULL,
|
|
men_z127_gpio->reg_base + MEN_Z127_GPIODR,
|
|
NULL, 0);
|
|
if (ret)
|
|
goto err_unmap;
|
|
|
|
men_z127_gpio->gc.set_config = men_z127_set_config;
|
|
|
|
ret = gpiochip_add_data(&men_z127_gpio->gc, men_z127_gpio);
|
|
if (ret) {
|
|
dev_err(dev, "failed to register MEN 16Z127 GPIO controller");
|
|
goto err_unmap;
|
|
}
|
|
|
|
dev_info(dev, "MEN 16Z127 GPIO driver registered");
|
|
|
|
return 0;
|
|
|
|
err_unmap:
|
|
iounmap(men_z127_gpio->reg_base);
|
|
err_release:
|
|
mcb_release_mem(men_z127_gpio->mem);
|
|
return ret;
|
|
}
|
|
|
|
static void men_z127_remove(struct mcb_device *mdev)
|
|
{
|
|
struct men_z127_gpio *men_z127_gpio = mcb_get_drvdata(mdev);
|
|
|
|
gpiochip_remove(&men_z127_gpio->gc);
|
|
iounmap(men_z127_gpio->reg_base);
|
|
mcb_release_mem(men_z127_gpio->mem);
|
|
}
|
|
|
|
static const struct mcb_device_id men_z127_ids[] = {
|
|
{ .device = 0x7f },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(mcb, men_z127_ids);
|
|
|
|
static struct mcb_driver men_z127_driver = {
|
|
.driver = {
|
|
.name = "z127-gpio",
|
|
},
|
|
.probe = men_z127_probe,
|
|
.remove = men_z127_remove,
|
|
.id_table = men_z127_ids,
|
|
};
|
|
module_mcb_driver(men_z127_driver);
|
|
|
|
MODULE_AUTHOR("Andreas Werner <andreas.werner@men.de>");
|
|
MODULE_DESCRIPTION("MEN 16z127 GPIO Controller");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("mcb:16z127");
|
|
MODULE_IMPORT_NS(MCB);
|