mirror of
https://github.com/torvalds/linux.git
synced 2024-11-11 14:42:24 +00:00
a68238a19c
Multiple overlay fragments adding or deleting the same node is not supported. An attempt to do so results in an incorrect devicetree. The node name will be munged for the second add. After adding this patch, the unittest messages will show: Duplicate name in motor-1, renamed to "controller#1" OF: overlay: of_overlay_apply() err=0 ### dt-test ### of_overlay_fdt_apply() expected -22, ret=0, overlay_bad_add_dup_node ### dt-test ### FAIL of_unittest_overlay_high_level():2419 Adding overlay 'overlay_bad_add_dup_node' failed ... ### dt-test ### end of unittest - 210 passed, 1 failed The incorrect (munged) node name "controller#1" can be seen in the /proc filesystem: $ pwd /proc/device-tree/testcase-data-2/substation@100/motor-1 $ ls compatible controller controller#1 name phandle spin $ ls controller power_bus $ ls controller#1 power_bus_emergency Tested-by: Alan Tull <atull@kernel.org> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
29 lines
510 B
Plaintext
29 lines
510 B
Plaintext
// SPDX-License-Identifier: GPL-2.0
|
|
/dts-v1/;
|
|
/plugin/;
|
|
|
|
/*
|
|
* &electric_1/motor-1 and &spin_ctrl_1 are the same node:
|
|
* /testcase-data-2/substation@100/motor-1
|
|
*
|
|
* Thus the new node "controller" in each fragment will
|
|
* result in an attempt to add the same node twice.
|
|
* This will result in an error and the overlay apply
|
|
* will fail.
|
|
*/
|
|
|
|
&electric_1 {
|
|
|
|
motor-1 {
|
|
controller {
|
|
power_bus = < 0x1 0x2 >;
|
|
};
|
|
};
|
|
};
|
|
|
|
&spin_ctrl_1 {
|
|
controller {
|
|
power_bus_emergency = < 0x101 0x102 >;
|
|
};
|
|
};
|