mirror of
https://github.com/torvalds/linux.git
synced 2024-11-15 00:21:59 +00:00
f2812227bb
The exynos-pcie driver called phy_power_on() before phy_init() for some historical reasons. However the generic PHY framework assumes that the proper sequence is to call phy_init() first, then phy_power_on(). The operations done by both functions should be considered as one action and as such they are called by the exynos-pcie driver (without doing anything between them). The initialization is just a sequence of register writes, which cannot be altered without breaking the hardware operation. To match the generic PHY framework requirement, simply move all register writes to the phy_init()/phy_exit() and drop power_on()/power_off() callbacks. This way the driver will also work with the old (incorrect) PHY initialization call sequence. Link: https://lore.kernel.org/r/20220628220409.26545-1-m.szyprowski@samsung.com Reported-by: Bjorn Helgaas <helgaas@kernel.org> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Chanho Park <chanho61.park@samsung.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-By: Vinod Koul <vkoul@kernel.org> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| phy-exynos4x12-usb2.c | ||
| phy-exynos5-usbdrd.c | ||
| phy-exynos7-ufs.c | ||
| phy-exynos4210-usb2.c | ||
| phy-exynos5250-sata.c | ||
| phy-exynos5250-usb2.c | ||
| phy-exynos-dp-video.c | ||
| phy-exynos-mipi-video.c | ||
| phy-exynos-pcie.c | ||
| phy-exynosautov9-ufs.c | ||
| phy-s5pv210-usb2.c | ||
| phy-samsung-ufs.c | ||
| phy-samsung-ufs.h | ||
| phy-samsung-usb2.c | ||
| phy-samsung-usb2.h | ||