linux/net/netlink
Pablo Neira Ayuso 4843b93c96 netlink: invert error code in netlink_set_err()
The callers of netlink_set_err() currently pass a negative value
as parameter for the error code. However, sk->sk_err wants a
positive error value. Without this patch, skb_recv_datagram() called
by netlink_recvmsg() may return a positive value to report an error.

Another choice to fix this is to change callers to pass a positive
error value, but this seems a bit inconsistent and error prone
to me. Indeed, the callers of netlink_set_err() assumed that the
(usual) negative value for error codes was fine before this patch :).

This patch also includes some documentation in docbook format
for netlink_set_err() to avoid this sort of confusion.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-03-03 23:37:30 -08:00
..
af_netlink.c netlink: invert error code in netlink_set_err() 2009-03-03 23:37:30 -08:00
attr.c netlink: allow empty nested attributes 2008-11-28 03:05:19 -08:00
genetlink.c genetlink: export genl_unregister_mc_group() 2009-01-07 10:00:17 -08:00
Makefile [NETLINK]: Generic netlink family 2005-11-10 02:26:41 +01:00