mirror of
https://github.com/torvalds/linux.git
synced 2024-11-18 10:01:43 +00:00
ccff2dface
Probing the TPIU driver under UBSan triggers an out-of-bounds shift
warning in coresight_timeout():
...
[ 5.677530] UBSAN: Undefined behaviour in drivers/hwtracing/coresight/coresight.c:929:16
[ 5.685542] shift exponent 64 is too large for 64-bit type 'long unsigned int'
...
On closer inspection things are exponentially out of whack because we're
passing a bitmask where a bit number should be. Amusingly, it seems that
both calls will find their expected values by sheer luck and appear to
succeed: 1 << FFCR_FON_MAN ends up at bit 64 which whilst undefined
evaluates as zero in practice, while 1 << FFSR_FT_STOPPED finds bit 2
(TCPresent) which apparently is usually tied high.
Following the examples of other drivers, define separate FOO and FOO_BIT
macros for masks vs. indices, and put things right.
CC: Robert Walker <robert.walker@arm.com>
CC: Mike Leach <mike.leach@linaro.org>
CC: Mathieu Poirier <mathieu.poirier@linaro.org>
Fixes:
|
||
|---|---|---|
| .. | ||
| coresight-catu.c | ||
| coresight-catu.h | ||
| coresight-cpu-debug.c | ||
| coresight-dynamic-replicator.c | ||
| coresight-etb10.c | ||
| coresight-etm3x-sysfs.c | ||
| coresight-etm3x.c | ||
| coresight-etm4x-sysfs.c | ||
| coresight-etm4x.c | ||
| coresight-etm4x.h | ||
| coresight-etm-cp14.c | ||
| coresight-etm-perf.c | ||
| coresight-etm-perf.h | ||
| coresight-etm.h | ||
| coresight-funnel.c | ||
| coresight-priv.h | ||
| coresight-replicator.c | ||
| coresight-stm.c | ||
| coresight-tmc-etf.c | ||
| coresight-tmc-etr.c | ||
| coresight-tmc.c | ||
| coresight-tmc.h | ||
| coresight-tpiu.c | ||
| coresight.c | ||
| Kconfig | ||
| Makefile | ||
| of_coresight.c | ||