mirror of
https://github.com/torvalds/linux.git
synced 2024-11-17 09:31:50 +00:00
27ac792ca0
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit boundary. For example: u64 val = PAGE_ALIGN(size); always returns a value < 4GB even if size is greater than 4GB. The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for example): #define PAGE_SHIFT 12 #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) #define PAGE_MASK (~(PAGE_SIZE-1)) ... #define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK) The "~" is performed on a 32-bit value, so everything in "and" with PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary. Using the ALIGN() macro seems to be the right way, because it uses typeof(addr) for the mask. Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in include/linux/mm.h. See also lkml discussion: http://lkml.org/lkml/2008/6/11/237 [akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c] [akpm@linux-foundation.org: fix v850] [akpm@linux-foundation.org: fix powerpc] [akpm@linux-foundation.org: fix arm] [akpm@linux-foundation.org: fix mips] [akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c] [akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c] [akpm@linux-foundation.org: fix powerpc] Signed-off-by: Andrea Righi <righi.andrea@gmail.com> Cc: <linux-arch@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
---|---|---|
.. | ||
boot | ||
kernel | ||
lib | ||
mm | ||
platform | ||
defconfig | ||
Kconfig | ||
Kconfig.cpu | ||
Kconfig.debug | ||
Kconfig.ide | ||
Makefile | ||
README |
linux-2.6 for H8/300 README Yoshinori Sato <ysato@users.sourceforge.jp> * Supported CPU H8/300H and H8S * Supported Target 1.simulator of GDB require patches. 2.AE 3068/AE 3069 more information MICROTRONIQUE <http://www.microtronique.com/> Akizuki Denshi Tsusho Ltd. <http://www.akizuki.ne.jp> (Japanese Only) 3.H8MAX see http://ip-sol.jp/h8max/ (Japanese Only) 4.EDOSK2674 see http://www.eu.renesas.com/products/mpumcu/tool/edk/support/edosk2674.html http://www.azpower.com/H8-uClinux/ * Toolchain Version gcc-3.1 or higher and patch see arch/h8300/tools_patch/README binutils-2.12 or higher gdb-5.2 or higher The environment that can compile a h8300-elf binary is necessary. * Userland Develop environment used h8300-elf toolchains. see http://www.uclinux.org/pub/uClinux/ports/h8/ * A few words of thanks Porting to H8/300 serieses is support of Information-technology Promotion Agency, Japan. I thank support. and All developer/user.