linux/arch/x86/power
David Fries e532c06f2a x86: fix i486 suspend to disk CR4 oops
arch/x86/power/cpu_32.c __save_processor_state calls read_cr4()
only a i486 CPU doesn't have the CR4 register.  Trying to read it
produces an invalid opcode oops during suspend to disk.

Use the safe rc4 reading op instead. If the value to be written is
zero the write is skipped.

arch/x86/power/hibernate_asm_32.S
done: swapped the use of %eax and %ecx to use jecxz for
the zero test and jump over store to %cr4.
restore_image: s/%ecx/%eax/ to be consistent with done:

In addition to __save_processor_state, acpi_save_state_mem,
efi_call_phys_prelog, and efi_call_phys_epilog had checks added
(acpi restore was in assembly and already had a check for
non-zero).  There were other reads and writes of CR4, but MCE and
virtualization shouldn't be executed on a i486 anyway.

Signed-off-by: David Fries <david@fries.net>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2008-08-18 08:50:19 +02:00
..
cpu_32.c x86: fix i486 suspend to disk CR4 oops 2008-08-18 08:50:19 +02:00
cpu_64.c x86 PM: consolidate suspend and hibernation code 2008-02-09 23:24:09 +01:00
hibernate_32.c x86 PM: update stale comments 2008-02-09 23:24:09 +01:00
hibernate_64.c x86: remove end_pfn in 64bit 2008-07-08 13:10:38 +02:00
hibernate_asm_32.S x86: fix i486 suspend to disk CR4 oops 2008-08-18 08:50:19 +02:00
hibernate_asm_64.S x86 cleanup: suspend_asm_64.S - use X86_CR4_PGE instead of numeric value 2008-02-19 16:18:33 +01:00
Makefile x86 PM: consolidate suspend and hibernation code 2008-02-09 23:24:09 +01:00