Eric Dumazet 7e692df393 tcp: fix skb_copy_ubufs() vs BIG TCP ... David Ahern reported crashes in skb_copy_ubufs() caused by TCP tx zerocopy using hugepages, and skb length bigger than ~68 KB. skb_copy_ubufs() assumed it could copy all payload using up to MAX_SKB_FRAGS order-0 pages. This assumption broke when BIG TCP was able to put up to 512 KB per skb. We did not hit this bug at Google because we use CONFIG_MAX_SKB_FRAGS=45 and limit gso_max_size to 180000. A solution is to use higher order pages if needed. v2: add missing __GFP_COMP, or we leak memory. Fixes: 7c4e983c4f ("net: allow gso_max_size to exceed 65536") Reported-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/netdev/c70000f6-baa4-4a05-46d0-4b3e0dc1ccc8@gmail.com/T/ Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Xin Long <lucien.xin@gmail.com> Cc: Willem de Bruijn <willemb@google.com> Cc: Coco Li <lixiaoyan@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2023-04-28 09:40:38 +01:00
..
bpf_sk_storage.c	bpf: Teach verifier that certain helpers accept NULL pointer.	2023-04-04 16:57:16 -07:00
datagram.c	net-zerocopy: Reduce compound page head access	2023-03-22 15:34:31 +01:00
dev_addr_lists_test.c	kunit: Use KUNIT_EXPECT_MEMEQ macro	2022-10-27 02:40:14 -06:00
dev_addr_lists.c
dev_ioctl.c	net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub	2023-04-09 15:35:49 +01:00
dev.c	net: optimize napi_threaded_poll() vs RPS/RFS	2023-04-23 13:35:07 +01:00
dev.h	net-sysctl: factor-out rpm mask manipulation helpers	2023-02-09 17:45:55 -08:00
drop_monitor.c	net: extend drop reasons for multiple subsystems	2023-04-20 20:20:49 -07:00
dst_cache.c
dst.c	net: dst: fix missing initialization of rt_uncached	2023-04-21 20:26:56 -07:00
failover.c	net: failover: use IFF_NO_ADDRCONF flag to prevent ipv6 addrconf	2022-12-12 15:18:25 -08:00
fib_notifier.c
fib_rules.c
filter.c	bpf: minimal support for programs hooked into netfilter framework	2023-04-21 11:34:14 -07:00
flow_dissector.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-11-29 13:04:52 -08:00
flow_offload.c	net: flow_offload: add support for ARP frame matching	2022-11-14 11:24:16 +00:00
gen_estimator.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
gen_stats.c	net: Remove the obsolte u64_stats_fetch_*_irq() users (net).	2022-10-28 20:13:54 -07:00
gro_cells.c	net: drop the weight argument from netif_napi_add	2022-09-28 18:57:14 -07:00
gro.c	net: skbuff: update and rename __kfree_skb_defer()	2023-04-20 19:25:08 -07:00
hwbm.c
link_watch.c	net: linkwatch: only report IF_OPER_LOWERLAYERDOWN if iflink is actually down	2022-11-16 09:45:00 +00:00
lwt_bpf.c
lwtunnel.c	xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available	2022-10-12 10:45:51 +02:00
Makefile	netdev-genl: create a simple family for netdev stuff	2023-02-02 20:48:23 -08:00
neighbour.c	neighbour: switch to standard rcu, instead of rcu_bh	2023-03-21 21:32:18 -07:00
net_namespace.c	kill the last remaining user of proc_ns_fget()	2023-04-20 22:55:35 -04:00
net-procfs.c	net-sysfs: display two backlog queue len separately	2023-03-22 12:03:52 +01:00
net-sysfs.c	net: make default_rps_mask a per netns attribute	2023-02-20 11:22:54 +00:00
net-sysfs.h
net-traces.c	net: bridge: Add a tracepoint for MDB overflows	2023-02-06 08:48:25 +00:00
netclassid_cgroup.c	core: Variable type completion	2022-08-31 09:40:34 +01:00
netdev-genl-gen.c	tools: ynl: skip the explicit op array size when not needed	2023-03-21 21:45:31 -07:00
netdev-genl-gen.h	ynl: broaden the license even more	2023-03-16 21:20:32 -07:00
netdev-genl.c	netdev-genl: create a simple family for netdev stuff	2023-02-02 20:48:23 -08:00
netevent.c
netpoll.c	net: don't let netpoll invoke NAPI if in xmit context	2023-04-02 13:26:21 +01:00
netprio_cgroup.c
of_net.c	of: net: export of_get_mac_address_nvmem()	2022-11-29 10:45:53 +01:00
page_pool.c	page_pool: unlink from napi during destroy	2023-04-20 19:13:37 -07:00
pktgen.c	treewide: use get_random_u32_inclusive() when possible	2022-11-18 02:18:02 +01:00
ptp_classifier.c
request_sock.c
rtnetlink.c	bridge: Allow setting per-{Port, VLAN} neighbor suppression state	2023-04-21 08:25:50 +01:00
scm.c	net: Ensure ->msg_control_user is used for user buffers	2023-04-14 11:09:27 +01:00
secure_seq.c	tcp: Fix data-races around sysctl knobs related to SYN option.	2022-07-20 10:14:49 +01:00
selftests.c
skbuff.c	tcp: fix skb_copy_ubufs() vs BIG TCP	2023-04-28 09:40:38 +01:00
skmsg.c	net/sock: Introduce trace_sk_data_ready()	2023-01-23 11:26:50 +00:00
sock_destructor.h
sock_diag.c	net: fix __sock_gen_cookie()	2022-11-21 20:36:30 -08:00
sock_map.c	bpf, sockmap: Revert buggy deadlock fix in the sockhash and sockmap	2023-04-13 20:36:32 +02:00
sock_reuseport.c	soreuseport: Fix socket selection for SO_INCOMING_CPU.	2022-10-25 11:35:16 +02:00
sock.c	net: make SO_BUSY_POLL available to all users	2023-04-07 20:07:07 -07:00
stream.c	net: Remove WARN_ON_ONCE(sk->sk_forward_alloc) from sk_stream_kill_queues().	2023-02-10 19:53:42 -08:00
sysctl_net_core.c	net/sysctl: Rename kvfree_rcu() to kvfree_rcu_mightsleep()	2023-04-05 13:48:04 +00:00
timestamping.c
tso.c	net: tso: inline tso_count_descs()	2022-12-12 15:04:39 -08:00
utils.c	net: core: inet[46]_pton strlen len types	2022-11-01 21:14:39 -07:00
xdp.c	bpf-next-for-netdev	2023-04-13 16:43:38 -07:00