Kees Cook ea84b580b9 pstore: Convert buf_lock to semaphore ... Instead of running with interrupts disabled, use a semaphore. This should make it easier for backends that may need to sleep (e.g. EFI) when performing a write: |BUG: sleeping function called from invalid context at kernel/sched/completion.c:99 |in_atomic(): 1, irqs_disabled(): 1, pid: 2236, name: sig-xstate-bum |Preemption disabled at: |[<ffffffff99d60512>] pstore_dump+0x72/0x330 |CPU: 26 PID: 2236 Comm: sig-xstate-bum Tainted: G D 4.20.0-rc3 #45 |Call Trace: | dump_stack+0x4f/0x6a | ___might_sleep.cold.91+0xd3/0xe4 | __might_sleep+0x50/0x90 | wait_for_completion+0x32/0x130 | virt_efi_query_variable_info+0x14e/0x160 | efi_query_variable_store+0x51/0x1a0 | efivar_entry_set_safe+0xa3/0x1b0 | efi_pstore_write+0x109/0x140 | pstore_dump+0x11c/0x330 | kmsg_dump+0xa4/0xd0 | oops_exit+0x22/0x30 ... Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Fixes: 21b3ddd39f ("efi: Don't use spinlocks for efi vars") Signed-off-by: Kees Cook <keescook@chromium.org>		2018-12-03 17:11:02 -08:00
..
ftrace.c	pstore: Fix bool initialization/comparison	2018-12-03 16:52:35 -08:00
inode.c	pstore: Map PSTORE_TYPE_* to strings	2018-12-03 16:52:35 -08:00
internal.h	pstore: Centralize init/exit routines	2018-10-22 07:11:58 -07:00
Kconfig	mm: remove CONFIG_HAVE_MEMBLOCK	2018-10-31 08:54:15 -07:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
platform.c	pstore: Convert buf_lock to semaphore	2018-12-03 17:11:02 -08:00
pmsg.c	pstore: Create common record initializer	2017-05-31 10:13:44 -07:00
ram_core.c	pstore/ram: Do not treat empty buffers as valid	2018-12-03 16:52:35 -08:00
ram.c	pstore: Convert buf_lock to semaphore	2018-12-03 17:11:02 -08:00