linux/net/mac80211
Michal Kazior e9de01907e mac80211: don't clear all tx flags when requeing
When acting as AP and a PS-Poll frame is received
associated station is marked as one in a Service
Period. This state is kept until Tx status for
released frame is reported. While a station is in
Service Period PS-Poll frames are ignored.

However if PS-Poll was received during A-MPDU
teardown it was possible to have the to-be
released frame re-queued back to pending queue.
In such case the frame was stripped of 2 important
flags:

 (a) IEEE80211_TX_CTL_NO_PS_BUFFER
 (b) IEEE80211_TX_STATUS_EOSP

Stripping of (a) led to the frame that was to be
released to be queued back to ps_tx_buf queue. If
station remained to use only PS-Poll frames the
re-queued frame (and new ones) was never actually
transmitted because mac80211 would ignore
subsequent PS-Poll frames due to station being in
Service Period. There was nothing left to clear
the Service Period bit (no xmit -> no tx status ->
no SP end), i.e. the AP would have the station
stuck in Service Period. Beacon TIM would
repeatedly prompt station to poll for frames but
it would get none.

Once (a) is not stripped (b) becomes important
because it's the main condition to clear the
Service Period bit of the station when Tx status
for the released frame is reported back.

This problem was observed with ath9k acting as P2P
GO in some testing scenarios but isn't limited to
it. AP operation with mac80211 based Tx A-MPDU
control combined with clients using PS-Poll frames
is subject to this race.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2015-07-17 11:06:21 +02:00
..
aes_ccm.c mac80211: Switch to new AEAD interface 2015-05-28 11:23:20 +08:00
aes_ccm.h mac80111: Add CCMP-256 cipher 2015-01-27 11:07:35 +01:00
aes_cmac.c mac80111: Add BIP-CMAC-256 cipher 2015-01-27 11:09:13 +01:00
aes_cmac.h mac80111: Add BIP-CMAC-256 cipher 2015-01-27 11:09:13 +01:00
aes_gcm.c mac80211: Switch to new AEAD interface 2015-05-28 11:23:20 +08:00
aes_gcm.h mac80111: Add GCMP and GCMP-256 ciphers 2015-01-27 11:06:09 +01:00
aes_gmac.c mac80211: Switch to new AEAD interface 2015-05-28 11:23:20 +08:00
aes_gmac.h mac80111: Add BIP-GMAC-128 and BIP-GMAC-256 ciphers 2015-01-27 11:10:13 +01:00
agg-rx.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2015-04-02 16:16:53 -04:00
agg-tx.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
cfg.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
cfg.h mac80211: make cfg80211 ops and privid const 2014-02-04 21:48:21 +01:00
chan.c mac80211: adjust reserved chan_ctx when assigned to vif 2015-05-07 14:24:52 +02:00
debug.h mac80211: 802.11p OCB mode support 2014-11-04 13:18:21 +01:00
debugfs_key.c mac80211: move TX PN to public part of key struct 2015-06-02 11:16:35 +02:00
debugfs_key.h
debugfs_netdev.c mac80211: clear subdir_stations when removing debugfs 2015-07-17 10:53:19 +02:00
debugfs_netdev.h mac80211: fix some missing includes 2014-04-09 14:49:43 +02:00
debugfs_sta.c mac80211: clean up station debugfs 2015-05-05 14:21:55 +02:00
debugfs_sta.h
debugfs.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
debugfs.h mac80211: fix some missing includes 2014-04-09 14:49:43 +02:00
driver-ops.h mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
ethtool.c mac80211: remove sta->tx_fragments counter 2015-05-05 14:21:55 +02:00
event.c
ht.c mac80211: add VHT support for IBSS 2015-03-30 10:48:26 +02:00
ibss.c mac80211: fix the beacon csa counter for mesh and ibss 2015-06-09 22:04:25 +02:00
ieee80211_i.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2015-06-01 22:51:30 -07:00
iface.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
Kconfig mac80211: move dot11 counters under MAC80211_DEBUG_COUNTERS 2015-05-05 14:21:54 +02:00
key.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2015-06-24 02:58:51 -07:00
key.h Merge remote-tracking branch 'net-next/master' into mac80211-next 2015-06-10 12:45:09 +02:00
led.c mac80211: fix throughput LED trigger 2015-05-11 19:16:04 +02:00
led.h mac80211: make LED triggering depend on activation 2015-05-05 14:21:56 +02:00
main.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
Makefile mac80111: Add BIP-GMAC-128 and BIP-GMAC-256 ciphers 2015-01-27 11:10:13 +01:00
mesh_hwmp.c mac80211: Fix a case of incorrect metric used when forwarding a PREQ 2015-06-10 11:52:59 +02:00
mesh_pathtbl.c mac80211: implement cfg80211_ops to query mesh proxy path table 2014-10-09 11:19:07 +02:00
mesh_plink.c mac80211: Always check rates and capabilities in mesh mode 2015-06-09 22:05:06 +02:00
mesh_ps.c mac80211: clear sequence/fragment number in QoS-null frames 2014-03-05 15:49:54 +01:00
mesh_sync.c mac80211: remove BUG_ON usage 2014-04-29 17:59:27 +02:00
mesh.c mac80211: fix the beacon csa counter for mesh and ibss 2015-06-09 22:04:25 +02:00
mesh.h mac80211: implement cfg80211_ops to query mesh proxy path table 2014-10-09 11:19:07 +02:00
michael.c
michael.h mac80211: fix some missing includes 2014-04-09 14:49:43 +02:00
mlme.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
ocb.c mac80211: 802.11p OCB mode support 2014-11-04 13:18:21 +01:00
offchannel.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
pm.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
rate.c Minor merge needed, due to function move. 2015-07-01 10:49:25 -07:00
rate.h mac80211: lock rate control 2015-04-20 13:05:29 +02:00
rc80211_minstrel_debugfs.c mac80211: add standard deviation to Minstrel stats 2015-04-01 20:44:33 +02:00
rc80211_minstrel_ht_debugfs.c mac80211: add standard deviation to Minstrel stats 2015-04-01 20:44:33 +02:00
rc80211_minstrel_ht.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
rc80211_minstrel_ht.h mac80211: add max lossless throughput per rate 2015-04-01 20:44:32 +02:00
rc80211_minstrel.c mac80211: add standard deviation to Minstrel stats 2015-04-01 20:44:33 +02:00
rc80211_minstrel.h mac80211: add standard deviation to Minstrel stats 2015-04-01 20:44:33 +02:00
rx.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
scan.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
spectmgmt.c mac80211: remove unused variable in ieee80211_parse_ch_switch_ie() 2014-12-17 15:45:17 +01:00
sta_info.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
sta_info.h mac80211: Always check rates and capabilities in mesh mode 2015-06-09 22:05:06 +02:00
status.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
tdls.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
tkip.c mac80211: fix checkpatch errors 2013-12-18 10:33:06 +01:00
tkip.h mac80211: fix TKIP races, make API easier to use 2011-07-08 11:11:19 -04:00
trace_msg.h mac80211: Move message tracepoints to their own header 2015-04-07 12:32:09 -04:00
trace.c mac80211: Move message tracepoints to their own header 2015-04-07 12:32:09 -04:00
trace.h mac80211: extend get_tkip_seq to all keys 2015-05-06 13:29:59 +02:00
tx.c mac80211: don't clear all tx flags when requeing 2015-07-17 11:06:21 +02:00
util.c mac80211: convert HW flags to unsigned long bitmap 2015-06-10 16:05:36 +02:00
vht.c mac80211: TDLS: support VHT between peers 2015-03-03 15:56:07 +01:00
wep.c mac80211: move WEP tailroom size check 2015-05-11 14:51:29 +02:00
wep.h mac80211: move RX WEP weak IV counting 2012-03-13 14:54:16 -04:00
wme.c mac80211: synchronously reserve TID per station 2014-11-19 18:45:36 +01:00
wme.h mac80211: add WMM admission control support 2014-10-22 10:42:09 +02:00
wpa.c mac80211: move TX PN to public part of key struct 2015-06-02 11:16:35 +02:00
wpa.h mac80111: Add BIP-GMAC-128 and BIP-GMAC-256 ciphers 2015-01-27 11:10:13 +01:00