mirror of
https://github.com/torvalds/linux.git
synced 2024-11-18 18:11:56 +00:00
1e027960ed
syzbot found another add_timer() issue, this time in net/hsr [1]
Let's use mod_timer() which is safe.
[1]
kernel BUG at kernel/time/timer.c:1136!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 15909 Comm: syz-executor.3 Not tainted 5.0.0+ #97
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
kobject: 'loop2' (00000000f5629718): kobject_uevent_env
RIP: 0010:add_timer kernel/time/timer.c:1136 [inline]
RIP: 0010:add_timer+0x654/0xbe0 kernel/time/timer.c:1134
Code: 0f 94 c5 31 ff 44 89 ee e8 09 61 0f 00 45 84 ed 0f 84 77 fd ff ff e8 bb 5f 0f 00 e8 07 10 a0 ff e9 68 fd ff ff e8 ac 5f 0f 00 <0f> 0b e8 a5 5f 0f 00 0f 0b e8 9e 5f 0f 00 4c 89 b5 58 ff ff ff e9
RSP: 0018:ffff8880656eeca0 EFLAGS: 00010246
kobject: 'loop2' (00000000f5629718): fill_kobj_path: path = '/devices/virtual/block/loop2'
RAX: 0000000000040000 RBX: 1ffff1100caddd9a RCX: ffffc9000c436000
RDX: 0000000000040000 RSI: ffffffff816056c4 RDI: ffff88806a2f6cc8
RBP: ffff8880656eed58 R08: ffff888067f4a300 R09: ffff888067f4abc8
R10: 0000000000000000 R11: 0000000000000000 R12: ffff88806a2f6cc0
R13: dffffc0000000000 R14: 0000000000000001 R15: ffff8880656eed30
FS: 00007fc2019bf700(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000738000 CR3: 0000000067e8e000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
hsr_check_announce net/hsr/hsr_device.c:99 [inline]
hsr_check_carrier_and_operstate+0x567/0x6f0 net/hsr/hsr_device.c:120
hsr_netdev_notify+0x297/0xa00 net/hsr/hsr_main.c:51
notifier_call_chain+0xc7/0x240 kernel/notifier.c:93
__raw_notifier_call_chain kernel/notifier.c:394 [inline]
raw_notifier_call_chain+0x2e/0x40 kernel/notifier.c:401
call_netdevice_notifiers_info+0x3f/0x90 net/core/dev.c:1739
call_netdevice_notifiers_extack net/core/dev.c:1751 [inline]
call_netdevice_notifiers net/core/dev.c:1765 [inline]
dev_open net/core/dev.c:1436 [inline]
dev_open+0x143/0x160 net/core/dev.c:1424
team_port_add drivers/net/team/team.c:1203 [inline]
team_add_slave+0xa07/0x15d0 drivers/net/team/team.c:1933
do_set_master net/core/rtnetlink.c:2358 [inline]
do_set_master+0x1d4/0x230 net/core/rtnetlink.c:2332
do_setlink+0x966/0x3510 net/core/rtnetlink.c:2493
rtnl_setlink+0x271/0x3b0 net/core/rtnetlink.c:2747
rtnetlink_rcv_msg+0x465/0xb00 net/core/rtnetlink.c:5192
netlink_rcv_skb+0x17a/0x460 net/netlink/af_netlink.c:2485
rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5210
netlink_unicast_kernel net/netlink/af_netlink.c:1310 [inline]
netlink_unicast+0x536/0x720 net/netlink/af_netlink.c:1336
netlink_sendmsg+0x8ae/0xd70 net/netlink/af_netlink.c:1925
sock_sendmsg_nosec net/socket.c:622 [inline]
sock_sendmsg+0xdd/0x130 net/socket.c:632
sock_write_iter+0x27c/0x3e0 net/socket.c:923
call_write_iter include/linux/fs.h:1869 [inline]
do_iter_readv_writev+0x5e0/0x8e0 fs/read_write.c:680
do_iter_write fs/read_write.c:956 [inline]
do_iter_write+0x184/0x610 fs/read_write.c:937
vfs_writev+0x1b3/0x2f0 fs/read_write.c:1001
do_writev+0xf6/0x290 fs/read_write.c:1036
__do_sys_writev fs/read_write.c:1109 [inline]
__se_sys_writev fs/read_write.c:1106 [inline]
__x64_sys_writev+0x75/0xb0 fs/read_write.c:1106
do_syscall_64+0x103/0x610 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x457f29
Code: ad b8 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b b8 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fc2019bec78 EFLAGS: 00000246 ORIG_RAX: 0000000000000014
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000457f29
RDX: 0000000000000001 RSI: 00000000200000c0 RDI: 0000000000000003
RBP: 000000000073bf00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fc2019bf6d4
R13: 00000000004c4a60 R14: 00000000004dd218 R15: 00000000ffffffff
Fixes: f421436a59
("net/hsr: Add support for the High-availability Seamless Redundancy protocol (HSRv0)")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: Arvid Brodin <arvid.brodin@alten.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
512 lines
12 KiB
C
512 lines
12 KiB
C
/* Copyright 2011-2014 Autronica Fire and Security AS
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the Free
|
|
* Software Foundation; either version 2 of the License, or (at your option)
|
|
* any later version.
|
|
*
|
|
* Author(s):
|
|
* 2011-2014 Arvid Brodin, arvid.brodin@alten.se
|
|
*
|
|
* This file contains device methods for creating, using and destroying
|
|
* virtual HSR devices.
|
|
*/
|
|
|
|
#include <linux/netdevice.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/etherdevice.h>
|
|
#include <linux/rtnetlink.h>
|
|
#include <linux/pkt_sched.h>
|
|
#include "hsr_device.h"
|
|
#include "hsr_slave.h"
|
|
#include "hsr_framereg.h"
|
|
#include "hsr_main.h"
|
|
#include "hsr_forward.h"
|
|
|
|
|
|
static bool is_admin_up(struct net_device *dev)
|
|
{
|
|
return dev && (dev->flags & IFF_UP);
|
|
}
|
|
|
|
static bool is_slave_up(struct net_device *dev)
|
|
{
|
|
return dev && is_admin_up(dev) && netif_oper_up(dev);
|
|
}
|
|
|
|
static void __hsr_set_operstate(struct net_device *dev, int transition)
|
|
{
|
|
write_lock_bh(&dev_base_lock);
|
|
if (dev->operstate != transition) {
|
|
dev->operstate = transition;
|
|
write_unlock_bh(&dev_base_lock);
|
|
netdev_state_change(dev);
|
|
} else {
|
|
write_unlock_bh(&dev_base_lock);
|
|
}
|
|
}
|
|
|
|
static void hsr_set_operstate(struct hsr_port *master, bool has_carrier)
|
|
{
|
|
if (!is_admin_up(master->dev)) {
|
|
__hsr_set_operstate(master->dev, IF_OPER_DOWN);
|
|
return;
|
|
}
|
|
|
|
if (has_carrier)
|
|
__hsr_set_operstate(master->dev, IF_OPER_UP);
|
|
else
|
|
__hsr_set_operstate(master->dev, IF_OPER_LOWERLAYERDOWN);
|
|
}
|
|
|
|
static bool hsr_check_carrier(struct hsr_port *master)
|
|
{
|
|
struct hsr_port *port;
|
|
bool has_carrier;
|
|
|
|
has_carrier = false;
|
|
|
|
rcu_read_lock();
|
|
hsr_for_each_port(master->hsr, port)
|
|
if ((port->type != HSR_PT_MASTER) && is_slave_up(port->dev)) {
|
|
has_carrier = true;
|
|
break;
|
|
}
|
|
rcu_read_unlock();
|
|
|
|
if (has_carrier)
|
|
netif_carrier_on(master->dev);
|
|
else
|
|
netif_carrier_off(master->dev);
|
|
|
|
return has_carrier;
|
|
}
|
|
|
|
|
|
static void hsr_check_announce(struct net_device *hsr_dev,
|
|
unsigned char old_operstate)
|
|
{
|
|
struct hsr_priv *hsr;
|
|
|
|
hsr = netdev_priv(hsr_dev);
|
|
|
|
if ((hsr_dev->operstate == IF_OPER_UP)
|
|
&& (old_operstate != IF_OPER_UP)) {
|
|
/* Went up */
|
|
hsr->announce_count = 0;
|
|
mod_timer(&hsr->announce_timer,
|
|
jiffies + msecs_to_jiffies(HSR_ANNOUNCE_INTERVAL));
|
|
}
|
|
|
|
if ((hsr_dev->operstate != IF_OPER_UP) && (old_operstate == IF_OPER_UP))
|
|
/* Went down */
|
|
del_timer(&hsr->announce_timer);
|
|
}
|
|
|
|
void hsr_check_carrier_and_operstate(struct hsr_priv *hsr)
|
|
{
|
|
struct hsr_port *master;
|
|
unsigned char old_operstate;
|
|
bool has_carrier;
|
|
|
|
master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
|
|
/* netif_stacked_transfer_operstate() cannot be used here since
|
|
* it doesn't set IF_OPER_LOWERLAYERDOWN (?)
|
|
*/
|
|
old_operstate = master->dev->operstate;
|
|
has_carrier = hsr_check_carrier(master);
|
|
hsr_set_operstate(master, has_carrier);
|
|
hsr_check_announce(master->dev, old_operstate);
|
|
}
|
|
|
|
int hsr_get_max_mtu(struct hsr_priv *hsr)
|
|
{
|
|
unsigned int mtu_max;
|
|
struct hsr_port *port;
|
|
|
|
mtu_max = ETH_DATA_LEN;
|
|
rcu_read_lock();
|
|
hsr_for_each_port(hsr, port)
|
|
if (port->type != HSR_PT_MASTER)
|
|
mtu_max = min(port->dev->mtu, mtu_max);
|
|
rcu_read_unlock();
|
|
|
|
if (mtu_max < HSR_HLEN)
|
|
return 0;
|
|
return mtu_max - HSR_HLEN;
|
|
}
|
|
|
|
|
|
static int hsr_dev_change_mtu(struct net_device *dev, int new_mtu)
|
|
{
|
|
struct hsr_priv *hsr;
|
|
struct hsr_port *master;
|
|
|
|
hsr = netdev_priv(dev);
|
|
master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
|
|
|
|
if (new_mtu > hsr_get_max_mtu(hsr)) {
|
|
netdev_info(master->dev, "A HSR master's MTU cannot be greater than the smallest MTU of its slaves minus the HSR Tag length (%d octets).\n",
|
|
HSR_HLEN);
|
|
return -EINVAL;
|
|
}
|
|
|
|
dev->mtu = new_mtu;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int hsr_dev_open(struct net_device *dev)
|
|
{
|
|
struct hsr_priv *hsr;
|
|
struct hsr_port *port;
|
|
char designation;
|
|
|
|
hsr = netdev_priv(dev);
|
|
designation = '\0';
|
|
|
|
rcu_read_lock();
|
|
hsr_for_each_port(hsr, port) {
|
|
if (port->type == HSR_PT_MASTER)
|
|
continue;
|
|
switch (port->type) {
|
|
case HSR_PT_SLAVE_A:
|
|
designation = 'A';
|
|
break;
|
|
case HSR_PT_SLAVE_B:
|
|
designation = 'B';
|
|
break;
|
|
default:
|
|
designation = '?';
|
|
}
|
|
if (!is_slave_up(port->dev))
|
|
netdev_warn(dev, "Slave %c (%s) is not up; please bring it up to get a fully working HSR network\n",
|
|
designation, port->dev->name);
|
|
}
|
|
rcu_read_unlock();
|
|
|
|
if (designation == '\0')
|
|
netdev_warn(dev, "No slave devices configured\n");
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
static int hsr_dev_close(struct net_device *dev)
|
|
{
|
|
/* Nothing to do here. */
|
|
return 0;
|
|
}
|
|
|
|
|
|
static netdev_features_t hsr_features_recompute(struct hsr_priv *hsr,
|
|
netdev_features_t features)
|
|
{
|
|
netdev_features_t mask;
|
|
struct hsr_port *port;
|
|
|
|
mask = features;
|
|
|
|
/* Mask out all features that, if supported by one device, should be
|
|
* enabled for all devices (see NETIF_F_ONE_FOR_ALL).
|
|
*
|
|
* Anything that's off in mask will not be enabled - so only things
|
|
* that were in features originally, and also is in NETIF_F_ONE_FOR_ALL,
|
|
* may become enabled.
|
|
*/
|
|
features &= ~NETIF_F_ONE_FOR_ALL;
|
|
hsr_for_each_port(hsr, port)
|
|
features = netdev_increment_features(features,
|
|
port->dev->features,
|
|
mask);
|
|
|
|
return features;
|
|
}
|
|
|
|
static netdev_features_t hsr_fix_features(struct net_device *dev,
|
|
netdev_features_t features)
|
|
{
|
|
struct hsr_priv *hsr = netdev_priv(dev);
|
|
|
|
return hsr_features_recompute(hsr, features);
|
|
}
|
|
|
|
|
|
static int hsr_dev_xmit(struct sk_buff *skb, struct net_device *dev)
|
|
{
|
|
struct hsr_priv *hsr = netdev_priv(dev);
|
|
struct hsr_port *master;
|
|
|
|
master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
|
|
skb->dev = master->dev;
|
|
hsr_forward_skb(skb, master);
|
|
|
|
return NETDEV_TX_OK;
|
|
}
|
|
|
|
|
|
static const struct header_ops hsr_header_ops = {
|
|
.create = eth_header,
|
|
.parse = eth_header_parse,
|
|
};
|
|
|
|
static void send_hsr_supervision_frame(struct hsr_port *master,
|
|
u8 type, u8 hsrVer)
|
|
{
|
|
struct sk_buff *skb;
|
|
int hlen, tlen;
|
|
struct hsr_tag *hsr_tag;
|
|
struct hsr_sup_tag *hsr_stag;
|
|
struct hsr_sup_payload *hsr_sp;
|
|
unsigned long irqflags;
|
|
|
|
hlen = LL_RESERVED_SPACE(master->dev);
|
|
tlen = master->dev->needed_tailroom;
|
|
skb = dev_alloc_skb(
|
|
sizeof(struct hsr_tag) +
|
|
sizeof(struct hsr_sup_tag) +
|
|
sizeof(struct hsr_sup_payload) + hlen + tlen);
|
|
|
|
if (skb == NULL)
|
|
return;
|
|
|
|
skb_reserve(skb, hlen);
|
|
|
|
skb->dev = master->dev;
|
|
skb->protocol = htons(hsrVer ? ETH_P_HSR : ETH_P_PRP);
|
|
skb->priority = TC_PRIO_CONTROL;
|
|
|
|
if (dev_hard_header(skb, skb->dev, (hsrVer ? ETH_P_HSR : ETH_P_PRP),
|
|
master->hsr->sup_multicast_addr,
|
|
skb->dev->dev_addr, skb->len) <= 0)
|
|
goto out;
|
|
skb_reset_mac_header(skb);
|
|
|
|
if (hsrVer > 0) {
|
|
hsr_tag = skb_put(skb, sizeof(struct hsr_tag));
|
|
hsr_tag->encap_proto = htons(ETH_P_PRP);
|
|
set_hsr_tag_LSDU_size(hsr_tag, HSR_V1_SUP_LSDUSIZE);
|
|
}
|
|
|
|
hsr_stag = skb_put(skb, sizeof(struct hsr_sup_tag));
|
|
set_hsr_stag_path(hsr_stag, (hsrVer ? 0x0 : 0xf));
|
|
set_hsr_stag_HSR_Ver(hsr_stag, hsrVer);
|
|
|
|
/* From HSRv1 on we have separate supervision sequence numbers. */
|
|
spin_lock_irqsave(&master->hsr->seqnr_lock, irqflags);
|
|
if (hsrVer > 0) {
|
|
hsr_stag->sequence_nr = htons(master->hsr->sup_sequence_nr);
|
|
hsr_tag->sequence_nr = htons(master->hsr->sequence_nr);
|
|
master->hsr->sup_sequence_nr++;
|
|
master->hsr->sequence_nr++;
|
|
} else {
|
|
hsr_stag->sequence_nr = htons(master->hsr->sequence_nr);
|
|
master->hsr->sequence_nr++;
|
|
}
|
|
spin_unlock_irqrestore(&master->hsr->seqnr_lock, irqflags);
|
|
|
|
hsr_stag->HSR_TLV_Type = type;
|
|
/* TODO: Why 12 in HSRv0? */
|
|
hsr_stag->HSR_TLV_Length = hsrVer ? sizeof(struct hsr_sup_payload) : 12;
|
|
|
|
/* Payload: MacAddressA */
|
|
hsr_sp = skb_put(skb, sizeof(struct hsr_sup_payload));
|
|
ether_addr_copy(hsr_sp->MacAddressA, master->dev->dev_addr);
|
|
|
|
if (skb_put_padto(skb, ETH_ZLEN + HSR_HLEN))
|
|
return;
|
|
|
|
hsr_forward_skb(skb, master);
|
|
return;
|
|
|
|
out:
|
|
WARN_ONCE(1, "HSR: Could not send supervision frame\n");
|
|
kfree_skb(skb);
|
|
}
|
|
|
|
|
|
/* Announce (supervision frame) timer function
|
|
*/
|
|
static void hsr_announce(struct timer_list *t)
|
|
{
|
|
struct hsr_priv *hsr;
|
|
struct hsr_port *master;
|
|
unsigned long interval;
|
|
|
|
hsr = from_timer(hsr, t, announce_timer);
|
|
|
|
rcu_read_lock();
|
|
master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
|
|
|
|
if (hsr->announce_count < 3 && hsr->protVersion == 0) {
|
|
send_hsr_supervision_frame(master, HSR_TLV_ANNOUNCE,
|
|
hsr->protVersion);
|
|
hsr->announce_count++;
|
|
|
|
interval = msecs_to_jiffies(HSR_ANNOUNCE_INTERVAL);
|
|
} else {
|
|
send_hsr_supervision_frame(master, HSR_TLV_LIFE_CHECK,
|
|
hsr->protVersion);
|
|
|
|
interval = msecs_to_jiffies(HSR_LIFE_CHECK_INTERVAL);
|
|
}
|
|
|
|
if (is_admin_up(master->dev))
|
|
mod_timer(&hsr->announce_timer, jiffies + interval);
|
|
|
|
rcu_read_unlock();
|
|
}
|
|
|
|
|
|
/* According to comments in the declaration of struct net_device, this function
|
|
* is "Called from unregister, can be used to call free_netdev". Ok then...
|
|
*/
|
|
static void hsr_dev_destroy(struct net_device *hsr_dev)
|
|
{
|
|
struct hsr_priv *hsr;
|
|
struct hsr_port *port;
|
|
|
|
hsr = netdev_priv(hsr_dev);
|
|
|
|
rtnl_lock();
|
|
hsr_for_each_port(hsr, port)
|
|
hsr_del_port(port);
|
|
rtnl_unlock();
|
|
|
|
del_timer_sync(&hsr->prune_timer);
|
|
del_timer_sync(&hsr->announce_timer);
|
|
|
|
synchronize_rcu();
|
|
}
|
|
|
|
static const struct net_device_ops hsr_device_ops = {
|
|
.ndo_change_mtu = hsr_dev_change_mtu,
|
|
.ndo_open = hsr_dev_open,
|
|
.ndo_stop = hsr_dev_close,
|
|
.ndo_start_xmit = hsr_dev_xmit,
|
|
.ndo_fix_features = hsr_fix_features,
|
|
};
|
|
|
|
static struct device_type hsr_type = {
|
|
.name = "hsr",
|
|
};
|
|
|
|
void hsr_dev_setup(struct net_device *dev)
|
|
{
|
|
eth_hw_addr_random(dev);
|
|
|
|
ether_setup(dev);
|
|
dev->min_mtu = 0;
|
|
dev->header_ops = &hsr_header_ops;
|
|
dev->netdev_ops = &hsr_device_ops;
|
|
SET_NETDEV_DEVTYPE(dev, &hsr_type);
|
|
dev->priv_flags |= IFF_NO_QUEUE;
|
|
|
|
dev->needs_free_netdev = true;
|
|
dev->priv_destructor = hsr_dev_destroy;
|
|
|
|
dev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA |
|
|
NETIF_F_GSO_MASK | NETIF_F_HW_CSUM |
|
|
NETIF_F_HW_VLAN_CTAG_TX;
|
|
|
|
dev->features = dev->hw_features;
|
|
|
|
/* Prevent recursive tx locking */
|
|
dev->features |= NETIF_F_LLTX;
|
|
/* VLAN on top of HSR needs testing and probably some work on
|
|
* hsr_header_create() etc.
|
|
*/
|
|
dev->features |= NETIF_F_VLAN_CHALLENGED;
|
|
/* Not sure about this. Taken from bridge code. netdev_features.h says
|
|
* it means "Does not change network namespaces".
|
|
*/
|
|
dev->features |= NETIF_F_NETNS_LOCAL;
|
|
}
|
|
|
|
|
|
/* Return true if dev is a HSR master; return false otherwise.
|
|
*/
|
|
inline bool is_hsr_master(struct net_device *dev)
|
|
{
|
|
return (dev->netdev_ops->ndo_start_xmit == hsr_dev_xmit);
|
|
}
|
|
|
|
/* Default multicast address for HSR Supervision frames */
|
|
static const unsigned char def_multicast_addr[ETH_ALEN] __aligned(2) = {
|
|
0x01, 0x15, 0x4e, 0x00, 0x01, 0x00
|
|
};
|
|
|
|
int hsr_dev_finalize(struct net_device *hsr_dev, struct net_device *slave[2],
|
|
unsigned char multicast_spec, u8 protocol_version)
|
|
{
|
|
struct hsr_priv *hsr;
|
|
struct hsr_port *port;
|
|
int res;
|
|
|
|
hsr = netdev_priv(hsr_dev);
|
|
INIT_LIST_HEAD(&hsr->ports);
|
|
INIT_LIST_HEAD(&hsr->node_db);
|
|
INIT_LIST_HEAD(&hsr->self_node_db);
|
|
|
|
ether_addr_copy(hsr_dev->dev_addr, slave[0]->dev_addr);
|
|
|
|
/* Make sure we recognize frames from ourselves in hsr_rcv() */
|
|
res = hsr_create_self_node(&hsr->self_node_db, hsr_dev->dev_addr,
|
|
slave[1]->dev_addr);
|
|
if (res < 0)
|
|
return res;
|
|
|
|
spin_lock_init(&hsr->seqnr_lock);
|
|
/* Overflow soon to find bugs easier: */
|
|
hsr->sequence_nr = HSR_SEQNR_START;
|
|
hsr->sup_sequence_nr = HSR_SUP_SEQNR_START;
|
|
|
|
timer_setup(&hsr->announce_timer, hsr_announce, 0);
|
|
timer_setup(&hsr->prune_timer, hsr_prune_nodes, 0);
|
|
|
|
ether_addr_copy(hsr->sup_multicast_addr, def_multicast_addr);
|
|
hsr->sup_multicast_addr[ETH_ALEN - 1] = multicast_spec;
|
|
|
|
hsr->protVersion = protocol_version;
|
|
|
|
/* FIXME: should I modify the value of these?
|
|
*
|
|
* - hsr_dev->flags - i.e.
|
|
* IFF_MASTER/SLAVE?
|
|
* - hsr_dev->priv_flags - i.e.
|
|
* IFF_EBRIDGE?
|
|
* IFF_TX_SKB_SHARING?
|
|
* IFF_HSR_MASTER/SLAVE?
|
|
*/
|
|
|
|
/* Make sure the 1st call to netif_carrier_on() gets through */
|
|
netif_carrier_off(hsr_dev);
|
|
|
|
res = hsr_add_port(hsr, hsr_dev, HSR_PT_MASTER);
|
|
if (res)
|
|
goto err_add_port;
|
|
|
|
res = register_netdevice(hsr_dev);
|
|
if (res)
|
|
goto fail;
|
|
|
|
res = hsr_add_port(hsr, slave[0], HSR_PT_SLAVE_A);
|
|
if (res)
|
|
goto fail;
|
|
res = hsr_add_port(hsr, slave[1], HSR_PT_SLAVE_B);
|
|
if (res)
|
|
goto fail;
|
|
|
|
mod_timer(&hsr->prune_timer, jiffies + msecs_to_jiffies(PRUNE_PERIOD));
|
|
|
|
return 0;
|
|
|
|
fail:
|
|
hsr_for_each_port(hsr, port)
|
|
hsr_del_port(port);
|
|
err_add_port:
|
|
hsr_del_node(&hsr->self_node_db);
|
|
|
|
return res;
|
|
}
|