mirror of
https://github.com/torvalds/linux.git
synced 2024-11-10 22:21:40 +00:00
41cd312dfe
of_find_i2c_device_by_node() takes a reference,
In error paths, we should call put_device() to drop
the reference to aviod refount leak.
Fixes: 81e8e49261
("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20220511065803.3957-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
227 lines
5.8 KiB
C
227 lines
5.8 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
//
|
|
// Copyright 2012 Freescale Semiconductor, Inc.
|
|
// Copyright 2012 Linaro Ltd.
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/clk.h>
|
|
#include <sound/soc.h>
|
|
|
|
#include "../codecs/sgtl5000.h"
|
|
#include "imx-audmux.h"
|
|
|
|
#define DAI_NAME_SIZE 32
|
|
|
|
struct imx_sgtl5000_data {
|
|
struct snd_soc_dai_link dai;
|
|
struct snd_soc_card card;
|
|
char codec_dai_name[DAI_NAME_SIZE];
|
|
char platform_name[DAI_NAME_SIZE];
|
|
struct clk *codec_clk;
|
|
unsigned int clk_frequency;
|
|
};
|
|
|
|
static int imx_sgtl5000_dai_init(struct snd_soc_pcm_runtime *rtd)
|
|
{
|
|
struct imx_sgtl5000_data *data = snd_soc_card_get_drvdata(rtd->card);
|
|
struct device *dev = rtd->card->dev;
|
|
int ret;
|
|
|
|
ret = snd_soc_dai_set_sysclk(asoc_rtd_to_codec(rtd, 0), SGTL5000_SYSCLK,
|
|
data->clk_frequency, SND_SOC_CLOCK_IN);
|
|
if (ret) {
|
|
dev_err(dev, "could not set codec driver clock params\n");
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct snd_soc_dapm_widget imx_sgtl5000_dapm_widgets[] = {
|
|
SND_SOC_DAPM_MIC("Mic Jack", NULL),
|
|
SND_SOC_DAPM_LINE("Line In Jack", NULL),
|
|
SND_SOC_DAPM_HP("Headphone Jack", NULL),
|
|
SND_SOC_DAPM_SPK("Line Out Jack", NULL),
|
|
SND_SOC_DAPM_SPK("Ext Spk", NULL),
|
|
};
|
|
|
|
static int imx_sgtl5000_probe(struct platform_device *pdev)
|
|
{
|
|
struct device_node *np = pdev->dev.of_node;
|
|
struct device_node *ssi_np, *codec_np;
|
|
struct platform_device *ssi_pdev;
|
|
struct i2c_client *codec_dev;
|
|
struct imx_sgtl5000_data *data = NULL;
|
|
struct snd_soc_dai_link_component *comp;
|
|
int int_port, ext_port;
|
|
int ret;
|
|
|
|
ret = of_property_read_u32(np, "mux-int-port", &int_port);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "mux-int-port missing or invalid\n");
|
|
return ret;
|
|
}
|
|
ret = of_property_read_u32(np, "mux-ext-port", &ext_port);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "mux-ext-port missing or invalid\n");
|
|
return ret;
|
|
}
|
|
|
|
/*
|
|
* The port numbering in the hardware manual starts at 1, while
|
|
* the audmux API expects it starts at 0.
|
|
*/
|
|
int_port--;
|
|
ext_port--;
|
|
ret = imx_audmux_v2_configure_port(int_port,
|
|
IMX_AUDMUX_V2_PTCR_SYN |
|
|
IMX_AUDMUX_V2_PTCR_TFSEL(ext_port) |
|
|
IMX_AUDMUX_V2_PTCR_TCSEL(ext_port) |
|
|
IMX_AUDMUX_V2_PTCR_TFSDIR |
|
|
IMX_AUDMUX_V2_PTCR_TCLKDIR,
|
|
IMX_AUDMUX_V2_PDCR_RXDSEL(ext_port));
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "audmux internal port setup failed\n");
|
|
return ret;
|
|
}
|
|
ret = imx_audmux_v2_configure_port(ext_port,
|
|
IMX_AUDMUX_V2_PTCR_SYN,
|
|
IMX_AUDMUX_V2_PDCR_RXDSEL(int_port));
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "audmux external port setup failed\n");
|
|
return ret;
|
|
}
|
|
|
|
ssi_np = of_parse_phandle(pdev->dev.of_node, "ssi-controller", 0);
|
|
codec_np = of_parse_phandle(pdev->dev.of_node, "audio-codec", 0);
|
|
if (!ssi_np || !codec_np) {
|
|
dev_err(&pdev->dev, "phandle missing or invalid\n");
|
|
ret = -EINVAL;
|
|
goto fail;
|
|
}
|
|
|
|
ssi_pdev = of_find_device_by_node(ssi_np);
|
|
if (!ssi_pdev) {
|
|
dev_dbg(&pdev->dev, "failed to find SSI platform device\n");
|
|
ret = -EPROBE_DEFER;
|
|
goto fail;
|
|
}
|
|
put_device(&ssi_pdev->dev);
|
|
codec_dev = of_find_i2c_device_by_node(codec_np);
|
|
if (!codec_dev) {
|
|
dev_dbg(&pdev->dev, "failed to find codec platform device\n");
|
|
ret = -EPROBE_DEFER;
|
|
goto fail;
|
|
}
|
|
|
|
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
|
|
if (!data) {
|
|
ret = -ENOMEM;
|
|
goto put_device;
|
|
}
|
|
|
|
comp = devm_kzalloc(&pdev->dev, 3 * sizeof(*comp), GFP_KERNEL);
|
|
if (!comp) {
|
|
ret = -ENOMEM;
|
|
goto put_device;
|
|
}
|
|
|
|
data->codec_clk = clk_get(&codec_dev->dev, NULL);
|
|
if (IS_ERR(data->codec_clk)) {
|
|
ret = PTR_ERR(data->codec_clk);
|
|
goto put_device;
|
|
}
|
|
|
|
data->clk_frequency = clk_get_rate(data->codec_clk);
|
|
|
|
data->dai.cpus = &comp[0];
|
|
data->dai.codecs = &comp[1];
|
|
data->dai.platforms = &comp[2];
|
|
|
|
data->dai.num_cpus = 1;
|
|
data->dai.num_codecs = 1;
|
|
data->dai.num_platforms = 1;
|
|
|
|
data->dai.name = "HiFi";
|
|
data->dai.stream_name = "HiFi";
|
|
data->dai.codecs->dai_name = "sgtl5000";
|
|
data->dai.codecs->of_node = codec_np;
|
|
data->dai.cpus->of_node = ssi_np;
|
|
data->dai.platforms->of_node = ssi_np;
|
|
data->dai.init = &imx_sgtl5000_dai_init;
|
|
data->dai.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
|
|
SND_SOC_DAIFMT_CBP_CFP;
|
|
|
|
data->card.dev = &pdev->dev;
|
|
ret = snd_soc_of_parse_card_name(&data->card, "model");
|
|
if (ret)
|
|
goto put_device;
|
|
ret = snd_soc_of_parse_audio_routing(&data->card, "audio-routing");
|
|
if (ret)
|
|
goto put_device;
|
|
data->card.num_links = 1;
|
|
data->card.owner = THIS_MODULE;
|
|
data->card.dai_link = &data->dai;
|
|
data->card.dapm_widgets = imx_sgtl5000_dapm_widgets;
|
|
data->card.num_dapm_widgets = ARRAY_SIZE(imx_sgtl5000_dapm_widgets);
|
|
|
|
platform_set_drvdata(pdev, &data->card);
|
|
snd_soc_card_set_drvdata(&data->card, data);
|
|
|
|
ret = devm_snd_soc_register_card(&pdev->dev, &data->card);
|
|
if (ret) {
|
|
dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed\n");
|
|
goto put_device;
|
|
}
|
|
|
|
of_node_put(ssi_np);
|
|
of_node_put(codec_np);
|
|
|
|
return 0;
|
|
|
|
put_device:
|
|
put_device(&codec_dev->dev);
|
|
fail:
|
|
if (data && !IS_ERR(data->codec_clk))
|
|
clk_put(data->codec_clk);
|
|
of_node_put(ssi_np);
|
|
of_node_put(codec_np);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int imx_sgtl5000_remove(struct platform_device *pdev)
|
|
{
|
|
struct snd_soc_card *card = platform_get_drvdata(pdev);
|
|
struct imx_sgtl5000_data *data = snd_soc_card_get_drvdata(card);
|
|
|
|
clk_put(data->codec_clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id imx_sgtl5000_dt_ids[] = {
|
|
{ .compatible = "fsl,imx-audio-sgtl5000", },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, imx_sgtl5000_dt_ids);
|
|
|
|
static struct platform_driver imx_sgtl5000_driver = {
|
|
.driver = {
|
|
.name = "imx-sgtl5000",
|
|
.pm = &snd_soc_pm_ops,
|
|
.of_match_table = imx_sgtl5000_dt_ids,
|
|
},
|
|
.probe = imx_sgtl5000_probe,
|
|
.remove = imx_sgtl5000_remove,
|
|
};
|
|
module_platform_driver(imx_sgtl5000_driver);
|
|
|
|
MODULE_AUTHOR("Shawn Guo <shawn.guo@linaro.org>");
|
|
MODULE_DESCRIPTION("Freescale i.MX SGTL5000 ASoC machine driver");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("platform:imx-sgtl5000");
|