mirror of
https://github.com/torvalds/linux.git
synced 2024-11-13 23:51:39 +00:00
f44aebcc56
inotify can have a watchs removed under filesystem reclaim. ================================= [ INFO: inconsistent lock state ] 2.6.31-rc2 #16 --------------------------------- inconsistent {IN-RECLAIM_FS-W} -> {RECLAIM_FS-ON-W} usage. khubd/217 [HC0[0]:SC0[0]:HE1:SE1] takes: (iprune_mutex){+.+.?.}, at: [<c10ba899>] invalidate_inodes+0x20/0xe3 {IN-RECLAIM_FS-W} state was registered at: [<c10536ab>] __lock_acquire+0x2c9/0xac4 [<c1053f45>] lock_acquire+0x9f/0xc2 [<c1308872>] __mutex_lock_common+0x2d/0x323 [<c1308c00>] mutex_lock_nested+0x2e/0x36 [<c10ba6ff>] shrink_icache_memory+0x38/0x1b2 [<c108bfb6>] shrink_slab+0xe2/0x13c [<c108c3e1>] kswapd+0x3d1/0x55d [<c10449b5>] kthread+0x66/0x6b [<c1003fdf>] kernel_thread_helper+0x7/0x10 [<ffffffff>] 0xffffffff Two things are needed to fix this. First we need a method to tell fsnotify_create_event() to use GFP_NOFS and second we need to stop using one global IN_IGNORED event and allocate them one at a time. This solves current issues with multiple IN_IGNORED on a queue having tail drop problems and simplifies the allocations since we don't have to worry about two tasks opperating on the IGNORED event concurrently. Signed-off-by: Eric Paris <eparis@redhat.com>
189 lines
5.7 KiB
C
189 lines
5.7 KiB
C
/*
|
|
* Copyright (C) 2008 Red Hat, Inc., Eric Paris <eparis@redhat.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2, or (at your option)
|
|
* any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; see the file COPYING. If not, write to
|
|
* the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*/
|
|
|
|
#include <linux/dcache.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <linux/srcu.h>
|
|
|
|
#include <linux/fsnotify_backend.h>
|
|
#include "fsnotify.h"
|
|
|
|
/*
|
|
* Clear all of the marks on an inode when it is being evicted from core
|
|
*/
|
|
void __fsnotify_inode_delete(struct inode *inode)
|
|
{
|
|
fsnotify_clear_marks_by_inode(inode);
|
|
}
|
|
EXPORT_SYMBOL_GPL(__fsnotify_inode_delete);
|
|
|
|
/*
|
|
* Given an inode, first check if we care what happens to our children. Inotify
|
|
* and dnotify both tell their parents about events. If we care about any event
|
|
* on a child we run all of our children and set a dentry flag saying that the
|
|
* parent cares. Thus when an event happens on a child it can quickly tell if
|
|
* if there is a need to find a parent and send the event to the parent.
|
|
*/
|
|
void __fsnotify_update_child_dentry_flags(struct inode *inode)
|
|
{
|
|
struct dentry *alias;
|
|
int watched;
|
|
|
|
if (!S_ISDIR(inode->i_mode))
|
|
return;
|
|
|
|
/* determine if the children should tell inode about their events */
|
|
watched = fsnotify_inode_watches_children(inode);
|
|
|
|
spin_lock(&dcache_lock);
|
|
/* run all of the dentries associated with this inode. Since this is a
|
|
* directory, there damn well better only be one item on this list */
|
|
list_for_each_entry(alias, &inode->i_dentry, d_alias) {
|
|
struct dentry *child;
|
|
|
|
/* run all of the children of the original inode and fix their
|
|
* d_flags to indicate parental interest (their parent is the
|
|
* original inode) */
|
|
list_for_each_entry(child, &alias->d_subdirs, d_u.d_child) {
|
|
if (!child->d_inode)
|
|
continue;
|
|
|
|
spin_lock(&child->d_lock);
|
|
if (watched)
|
|
child->d_flags |= DCACHE_FSNOTIFY_PARENT_WATCHED;
|
|
else
|
|
child->d_flags &= ~DCACHE_FSNOTIFY_PARENT_WATCHED;
|
|
spin_unlock(&child->d_lock);
|
|
}
|
|
}
|
|
spin_unlock(&dcache_lock);
|
|
}
|
|
|
|
/* Notify this dentry's parent about a child's events. */
|
|
void __fsnotify_parent(struct dentry *dentry, __u32 mask)
|
|
{
|
|
struct dentry *parent;
|
|
struct inode *p_inode;
|
|
bool send = false;
|
|
bool should_update_children = false;
|
|
|
|
if (!(dentry->d_flags & DCACHE_FSNOTIFY_PARENT_WATCHED))
|
|
return;
|
|
|
|
spin_lock(&dentry->d_lock);
|
|
parent = dentry->d_parent;
|
|
p_inode = parent->d_inode;
|
|
|
|
if (fsnotify_inode_watches_children(p_inode)) {
|
|
if (p_inode->i_fsnotify_mask & mask) {
|
|
dget(parent);
|
|
send = true;
|
|
}
|
|
} else {
|
|
/*
|
|
* The parent doesn't care about events on it's children but
|
|
* at least one child thought it did. We need to run all the
|
|
* children and update their d_flags to let them know p_inode
|
|
* doesn't care about them any more.
|
|
*/
|
|
dget(parent);
|
|
should_update_children = true;
|
|
}
|
|
|
|
spin_unlock(&dentry->d_lock);
|
|
|
|
if (send) {
|
|
/* we are notifying a parent so come up with the new mask which
|
|
* specifies these are events which came from a child. */
|
|
mask |= FS_EVENT_ON_CHILD;
|
|
|
|
fsnotify(p_inode, mask, dentry->d_inode, FSNOTIFY_EVENT_INODE,
|
|
dentry->d_name.name, 0);
|
|
dput(parent);
|
|
}
|
|
|
|
if (unlikely(should_update_children)) {
|
|
__fsnotify_update_child_dentry_flags(p_inode);
|
|
dput(parent);
|
|
}
|
|
}
|
|
EXPORT_SYMBOL_GPL(__fsnotify_parent);
|
|
|
|
/*
|
|
* This is the main call to fsnotify. The VFS calls into hook specific functions
|
|
* in linux/fsnotify.h. Those functions then in turn call here. Here will call
|
|
* out to all of the registered fsnotify_group. Those groups can then use the
|
|
* notification event in whatever means they feel necessary.
|
|
*/
|
|
void fsnotify(struct inode *to_tell, __u32 mask, void *data, int data_is, const char *file_name, u32 cookie)
|
|
{
|
|
struct fsnotify_group *group;
|
|
struct fsnotify_event *event = NULL;
|
|
int idx;
|
|
/* global tests shouldn't care about events on child only the specific event */
|
|
__u32 test_mask = (mask & ~FS_EVENT_ON_CHILD);
|
|
|
|
if (list_empty(&fsnotify_groups))
|
|
return;
|
|
|
|
if (!(test_mask & fsnotify_mask))
|
|
return;
|
|
|
|
if (!(test_mask & to_tell->i_fsnotify_mask))
|
|
return;
|
|
/*
|
|
* SRCU!! the groups list is very very much read only and the path is
|
|
* very hot. The VAST majority of events are not going to need to do
|
|
* anything other than walk the list so it's crazy to pre-allocate.
|
|
*/
|
|
idx = srcu_read_lock(&fsnotify_grp_srcu);
|
|
list_for_each_entry_rcu(group, &fsnotify_groups, group_list) {
|
|
if (test_mask & group->mask) {
|
|
if (!group->ops->should_send_event(group, to_tell, mask))
|
|
continue;
|
|
if (!event) {
|
|
event = fsnotify_create_event(to_tell, mask, data,
|
|
data_is, file_name, cookie,
|
|
GFP_KERNEL);
|
|
/* shit, we OOM'd and now we can't tell, maybe
|
|
* someday someone else will want to do something
|
|
* here */
|
|
if (!event)
|
|
break;
|
|
}
|
|
group->ops->handle_event(group, event);
|
|
}
|
|
}
|
|
srcu_read_unlock(&fsnotify_grp_srcu, idx);
|
|
/*
|
|
* fsnotify_create_event() took a reference so the event can't be cleaned
|
|
* up while we are still trying to add it to lists, drop that one.
|
|
*/
|
|
if (event)
|
|
fsnotify_put_event(event);
|
|
}
|
|
EXPORT_SYMBOL_GPL(fsnotify);
|
|
|
|
static __init int fsnotify_init(void)
|
|
{
|
|
return init_srcu_struct(&fsnotify_grp_srcu);
|
|
}
|
|
subsys_initcall(fsnotify_init);
|