mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 13:22:23 +00:00
49faa77759
Better handle the failure paths.
vmlinux.o: warning: objtool: debug_locks_off()+0x23: call to console_verbose() leaves .noinstr.text section
vmlinux.o: warning: objtool: debug_locks_off()+0x19: call to __kasan_check_write() leaves .noinstr.text section
debug_locks_off+0x19/0x40:
instrument_atomic_write at include/linux/instrumented.h:86
(inlined by) __debug_locks_off at include/linux/debug_locks.h:17
(inlined by) debug_locks_off at lib/debug_locks.c:41
Fixes: 6eebad1ad3 ("lockdep: __always_inline more for noinstr")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210621120120.784404944@infradead.org
50 lines
1.2 KiB
C
50 lines
1.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* lib/debug_locks.c
|
|
*
|
|
* Generic place for common debugging facilities for various locks:
|
|
* spinlocks, rwlocks, mutexes and rwsems.
|
|
*
|
|
* Started by Ingo Molnar:
|
|
*
|
|
* Copyright (C) 2006 Red Hat, Inc., Ingo Molnar <mingo@redhat.com>
|
|
*/
|
|
#include <linux/rwsem.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/export.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/debug_locks.h>
|
|
|
|
/*
|
|
* We want to turn all lock-debugging facilities on/off at once,
|
|
* via a global flag. The reason is that once a single bug has been
|
|
* detected and reported, there might be cascade of followup bugs
|
|
* that would just muddy the log. So we report the first one and
|
|
* shut up after that.
|
|
*/
|
|
int debug_locks __read_mostly = 1;
|
|
EXPORT_SYMBOL_GPL(debug_locks);
|
|
|
|
/*
|
|
* The locking-testsuite uses <debug_locks_silent> to get a
|
|
* 'silent failure': nothing is printed to the console when
|
|
* a locking bug is detected.
|
|
*/
|
|
int debug_locks_silent __read_mostly;
|
|
EXPORT_SYMBOL_GPL(debug_locks_silent);
|
|
|
|
/*
|
|
* Generic 'turn off all lock debugging' function:
|
|
*/
|
|
int debug_locks_off(void)
|
|
{
|
|
if (debug_locks && __debug_locks_off()) {
|
|
if (!debug_locks_silent) {
|
|
console_verbose();
|
|
return 1;
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(debug_locks_off);
|