Qiujun Huang dce8e23710 ext4: fix a data race at inode->i_disksize ... KCSAN find inode->i_disksize could be accessed concurrently. BUG: KCSAN: data-race in ext4_mark_iloc_dirty / ext4_write_end write (marked) to 0xffff8b8932f40090 of 8 bytes by task 66792 on cpu 0: ext4_write_end+0x53f/0x5b0 ext4_da_write_end+0x237/0x510 generic_perform_write+0x1c4/0x2a0 ext4_buffered_write_iter+0x13a/0x210 ext4_file_write_iter+0xe2/0x9b0 new_sync_write+0x29c/0x3a0 __vfs_write+0x92/0xa0 vfs_write+0xfc/0x2a0 ksys_write+0xe8/0x140 __x64_sys_write+0x4c/0x60 do_syscall_64+0x8a/0x2a0 entry_SYSCALL_64_after_hwframe+0x44/0xa9 read to 0xffff8b8932f40090 of 8 bytes by task 14414 on cpu 1: ext4_mark_iloc_dirty+0x716/0x1190 ext4_mark_inode_dirty+0xc9/0x360 ext4_convert_unwritten_extents+0x1bc/0x2a0 ext4_convert_unwritten_io_end_vec+0xc5/0x150 ext4_put_io_end+0x82/0x130 ext4_writepages+0xae7/0x16f0 do_writepages+0x64/0x120 __writeback_single_inode+0x7d/0x650 writeback_sb_inodes+0x3a4/0x860 __writeback_inodes_wb+0xc4/0x150 wb_writeback+0x43f/0x510 wb_workfn+0x3b2/0x8a0 process_one_work+0x39b/0x7e0 worker_thread+0x88/0x650 kthread+0x1d4/0x1f0 ret_from_fork+0x35/0x40 The plain read is outside of inode->i_data_sem critical section which results in a data race. Fix it by adding READ_ONCE(). Signed-off-by: Qiujun Huang <hqjagain@gmail.com> Link: https://lore.kernel.org/r/1582556566-3909-1-git-send-email-hqjagain@gmail.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>		2020-03-05 23:33:40 -05:00
..
acl.c	ext4: compare old and new mode before setting update_mode flag	2018-12-10 00:22:38 -05:00
acl.h	ext4: fix up remaining files with SPDX cleanups	2017-12-17 22:00:59 -05:00
balloc.c	ext4: fix potential race between online resizing and write operations	2020-02-21 00:37:09 -05:00
bitmap.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
block_validity.c	ext4: add cond_resched() to ext4_protect_reserved_inode	2020-02-13 11:56:26 -05:00
dir.c	ext4: fix checksum errors with indexed dirs	2020-02-13 11:56:19 -05:00
ext4_extents.h	ext4: make some functions static in extents.c	2020-01-17 16:24:54 -05:00
ext4_jbd2.c	ext4: force buffer up-to-date while marking it dirty	2020-03-05 15:35:39 -05:00
ext4_jbd2.h	ext4: uninline ext4_inode_journal_mode()	2020-01-17 16:24:52 -05:00
ext4.h	ext4: remove EXT4_EOFBLOCKS_FL and associated code	2020-03-05 15:55:30 -05:00
extents_status.c	ext4: use percpu_counters for extent_status cache hits/misses	2019-08-28 11:19:23 -04:00
extents_status.h	ext4: fix extent_status trace points	2020-01-25 02:03:03 -05:00
extents.c	ext4: clean up error return for convert_initialized_extent()	2020-03-05 20:27:59 -05:00
file.c	ext4: start to support iopoll method	2020-03-05 15:40:15 -05:00
fsmap.c	ext4: fix miscellaneous sparse warnings	2019-05-12 04:49:47 -04:00
fsmap.h	ext4: fix up remaining files with SPDX cleanups	2017-12-17 22:00:59 -05:00
fsync.c	ext4: update ext4_sync_file() to not use __generic_file_fsync()	2019-11-05 11:31:40 -05:00
hash.c	ext4: fix kernel oops caused by spurious casefold flag	2019-09-03 01:43:17 -04:00
ialloc.c	ext4: fix potential race between s_flex_groups online resizing and access	2020-02-21 19:31:46 -05:00
indirect.c	ext4: remove ext4_{ind,ext}_calc_metadata_amount()	2020-01-17 16:24:54 -05:00
inline.c	ext4,jbd2: fix comment and code style	2020-01-25 02:24:53 -05:00
inode-test.c	kunit: allow kunit tests to be loaded as a module	2020-01-09 16:42:29 -07:00
inode.c	ext4: fix a data race at inode->i_disksize	2020-03-05 23:33:40 -05:00
ioctl.c	ext4: remove EXT4_EOFBLOCKS_FL and associated code	2020-03-05 15:55:30 -05:00
Kconfig	This merge window, we've added some performance improvements in how we	2020-01-30 15:17:05 -08:00
Makefile	kunit: allow kunit tests to be loaded as a module	2020-01-09 16:42:29 -07:00
mballoc.c	ext4: use built-in RCU list checking in mballoc	2020-03-05 20:24:50 -05:00
mballoc.h	ext4: fix up remaining files with SPDX cleanups	2017-12-17 22:00:59 -05:00
migrate.c	ext4: fix race between writepages and enabling EXT4_EXTENTS_FL	2020-02-21 19:32:07 -05:00
mmp.c	ext4: don't assume that mmp_nodename/bdevname have NUL	2020-02-13 11:53:10 -05:00
move_extent.c	ext4: use jbd2_inode dirty range scoping	2019-06-20 17:26:26 -04:00
namei.c	ext4: use flexible-array members in struct dx_node and struct dx_root	2020-03-05 20:25:05 -05:00
page-io.c	ext4: fix deadlock allocating crypto bounce page from mempool	2020-01-17 16:24:54 -05:00
readpage.c	ext4: remove unneeded check for error allocating bio_post_read_ctx	2020-01-17 16:24:54 -05:00
resize.c	ext4: fix potential race between s_flex_groups online resizing and access	2020-02-21 19:31:46 -05:00
super.c	ext4: code cleanup for ext4_statfs_project()	2020-03-05 15:49:00 -05:00
symlink.c	ext4: switch to fscrypt_get_symlink()	2018-01-11 22:10:40 -05:00
sysfs.c	ext4: export information about first/last errors via /sys/fs/ext4/<dev>	2019-12-26 11:29:10 -05:00
truncate.h	ext4: handle layout changes to pinned DAX mappings	2018-07-29 17:00:22 -04:00
verity.c	fs-verity: implement readahead of Merkle tree pages	2020-01-14 13:27:32 -08:00
xattr_security.c	ext4: use XATTR_CREATE in ext4_initxattrs()	2018-05-10 11:52:14 -04:00
xattr_trusted.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xattr_user.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xattr.c	ext4: drop ext4_kvmalloc()	2020-01-17 16:24:55 -05:00
xattr.h	ext4: add extra checks to ext4_xattr_block_get()	2018-03-30 20:04:11 -04:00