mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 21:33:00 +00:00
b3c11ac267
The function's behaviour was changed in90844f0004, without changing its signature, causing people to keep using it the old way without realising they were now leaking memory. Rob Clark also noticed it was also allocating GFP_KERNEL memory in atomic contexts, breaking them. Instead of having to allocate GFP_ATOMIC memory and fixing the callers to make them cleanup the memory afterwards, let's change the function's signature by having the caller take care of the memory and passing it to the function. The new parameter is a single-field struct in order to enforce the size of its buffer and help callers to correctly manage their memory. Fixes:90844f0004("drm: make drm_get_format_name thread-safe") Cc: Rob Clark <robdclark@gmail.com> Cc: Christian König <christian.koenig@amd.com> Acked-by: Christian König <christian.koenig@amd.com> Acked-by: Rob Clark <robdclark@gmail.com> Acked-by: Sinclair Yeh <syeh@vmware.com> (vmwgfx) Reviewed-by: Jani Nikula <jani.nikula@intel.com> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Eric Engestrom <eric@engestrom.ch> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/20161112011309.9799-1-eric@engestrom.ch
68 lines
2.7 KiB
C
68 lines
2.7 KiB
C
/*
|
|
* Copyright (c) 2016 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
|
|
*
|
|
* Permission to use, copy, modify, distribute, and sell this software and its
|
|
* documentation for any purpose is hereby granted without fee, provided that
|
|
* the above copyright notice appear in all copies and that both that copyright
|
|
* notice and this permission notice appear in supporting documentation, and
|
|
* that the name of the copyright holders not be used in advertising or
|
|
* publicity pertaining to distribution of the software without specific,
|
|
* written prior permission. The copyright holders make no representations
|
|
* about the suitability of this software for any purpose. It is provided "as
|
|
* is" without express or implied warranty.
|
|
*
|
|
* THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
|
|
* INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO
|
|
* EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY SPECIAL, INDIRECT OR
|
|
* CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE,
|
|
* DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
|
|
* TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE
|
|
* OF THIS SOFTWARE.
|
|
*/
|
|
#ifndef __DRM_FOURCC_H__
|
|
#define __DRM_FOURCC_H__
|
|
|
|
#include <linux/types.h>
|
|
#include <uapi/drm/drm_fourcc.h>
|
|
|
|
/**
|
|
* struct drm_format_info - information about a DRM format
|
|
* @format: 4CC format identifier (DRM_FORMAT_*)
|
|
* @depth: Color depth (number of bits per pixel excluding padding bits),
|
|
* valid for a subset of RGB formats only. This is a legacy field, do not
|
|
* use in new code and set to 0 for new formats.
|
|
* @num_planes: Number of color planes (1 to 3)
|
|
* @cpp: Number of bytes per pixel (per plane)
|
|
* @hsub: Horizontal chroma subsampling factor
|
|
* @vsub: Vertical chroma subsampling factor
|
|
*/
|
|
struct drm_format_info {
|
|
u32 format;
|
|
u8 depth;
|
|
u8 num_planes;
|
|
u8 cpp[3];
|
|
u8 hsub;
|
|
u8 vsub;
|
|
};
|
|
|
|
/**
|
|
* struct drm_format_name_buf - name of a DRM format
|
|
* @str: string buffer containing the format name
|
|
*/
|
|
struct drm_format_name_buf {
|
|
char str[32];
|
|
};
|
|
|
|
const struct drm_format_info *__drm_format_info(u32 format);
|
|
const struct drm_format_info *drm_format_info(u32 format);
|
|
uint32_t drm_mode_legacy_fb_format(uint32_t bpp, uint32_t depth);
|
|
int drm_format_num_planes(uint32_t format);
|
|
int drm_format_plane_cpp(uint32_t format, int plane);
|
|
int drm_format_horz_chroma_subsampling(uint32_t format);
|
|
int drm_format_vert_chroma_subsampling(uint32_t format);
|
|
int drm_format_plane_width(int width, uint32_t format, int plane);
|
|
int drm_format_plane_height(int height, uint32_t format, int plane);
|
|
const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf);
|
|
|
|
#endif /* __DRM_FOURCC_H__ */
|