Nanyong Sun d612c3f3fa net: ipv4: fix memory leak in netlbl_cipsov4_add_std ... Reported by syzkaller: BUG: memory leak unreferenced object 0xffff888105df7000 (size 64): comm "syz-executor842", pid 360, jiffies 4294824824 (age 22.546s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<00000000e67ed558>] kmalloc include/linux/slab.h:590 [inline] [<00000000e67ed558>] kzalloc include/linux/slab.h:720 [inline] [<00000000e67ed558>] netlbl_cipsov4_add_std net/netlabel/netlabel_cipso_v4.c:145 [inline] [<00000000e67ed558>] netlbl_cipsov4_add+0x390/0x2340 net/netlabel/netlabel_cipso_v4.c:416 [<0000000006040154>] genl_family_rcv_msg_doit.isra.0+0x20e/0x320 net/netlink/genetlink.c:739 [<00000000204d7a1c>] genl_family_rcv_msg net/netlink/genetlink.c:783 [inline] [<00000000204d7a1c>] genl_rcv_msg+0x2bf/0x4f0 net/netlink/genetlink.c:800 [<00000000c0d6a995>] netlink_rcv_skb+0x134/0x3d0 net/netlink/af_netlink.c:2504 [<00000000d78b9d2c>] genl_rcv+0x24/0x40 net/netlink/genetlink.c:811 [<000000009733081b>] netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] [<000000009733081b>] netlink_unicast+0x4a0/0x6a0 net/netlink/af_netlink.c:1340 [<00000000d5fd43b8>] netlink_sendmsg+0x789/0xc70 net/netlink/af_netlink.c:1929 [<000000000a2d1e40>] sock_sendmsg_nosec net/socket.c:654 [inline] [<000000000a2d1e40>] sock_sendmsg+0x139/0x170 net/socket.c:674 [<00000000321d1969>] ____sys_sendmsg+0x658/0x7d0 net/socket.c:2350 [<00000000964e16bc>] ___sys_sendmsg+0xf8/0x170 net/socket.c:2404 [<000000001615e288>] __sys_sendmsg+0xd3/0x190 net/socket.c:2433 [<000000004ee8b6a5>] do_syscall_64+0x37/0x90 arch/x86/entry/common.c:47 [<00000000171c7cee>] entry_SYSCALL_64_after_hwframe+0x44/0xae The memory of doi_def->map.std pointing is allocated in netlbl_cipsov4_add_std, but no place has freed it. It should be freed in cipso_v4_doi_free which frees the cipso DOI resource. Fixes: 96cb8e3313 ("[NetLabel]: CIPSOv4 and Unlabeled packet integration") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Nanyong Sun <sunnanyong@huawei.com> Acked-by: Paul Moore <paul@paul-moore.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2021-06-08 11:36:04 -07:00
..
bpfilter	net: Revert "net: optimize the sockptr_t for unified kernel/user address spaces"	2020-08-10 12:06:44 -07:00
netfilter	netfilter: arptables: use pernet ops struct during unregister	2021-05-03 23:04:01 +02:00
af_inet.c	udp: Implement ->read_sock() for sockmap	2021-04-01 10:56:14 -07:00
ah4.c	xfrm: Use actual socket sk instead of skb socket for xfrm_output_resume	2021-03-03 09:32:52 +01:00
arp.c	net: Exempt multicast addresses from five-second neighbor lifetime	2020-11-13 14:24:39 -08:00
bpf_tcp_ca.c	bpf: Limit static tcp-cc functions in the .BTF_ids list to x86	2021-05-11 23:23:07 +02:00
cipso_ipv4.c	net: ipv4: fix memory leak in netlbl_cipsov4_add_std	2021-06-08 11:36:04 -07:00
datagram.c
devinet.c	ipv6: report errors for iftoken via netlink extack	2021-04-08 13:52:36 -07:00
esp4_offload.c	xfrm: Provide private skb extensions for segmented and hw offloaded ESP packets	2021-03-29 09:14:12 +02:00
esp4.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2021-04-14 13:15:12 -07:00
fib_frontend.c	ipv4: Ignore ECN bits for fib lookups in fib_compute_spec_dst()	2020-12-28 14:44:32 -08:00
fib_lookup.h	IPv4: Add "offload failed" indication to routes	2021-02-08 16:47:03 -08:00
fib_notifier.c
fib_rules.c	fib: use indirect call wrappers in the most common fib_rules_ops	2020-07-28 17:42:31 -07:00
fib_semantics.c	IPv4: Add "offload failed" indication to routes	2021-02-08 16:47:03 -08:00
fib_trie.c	IPv4: Extend 'fib_notify_on_flag_change' sysctl	2021-02-08 16:47:03 -08:00
fou.c	genetlink: move to smaller ops wherever possible	2020-10-02 19:11:11 -07:00
gre_demux.c	erspan: fix version 1 check in gre_parse_header()	2020-12-28 15:00:00 -08:00
gre_offload.c	ip_gre: add csum offload support for gre header	2021-01-29 20:39:14 -08:00
icmp.c	icmp: standardize naming of RFC 8335 PROBE constants	2021-04-28 13:42:23 -07:00
igmp.c
inet_connection_sock.c	tcp: relookup sock for RST+ACK packets handled by obsolete req sock	2021-03-15 14:34:29 -07:00
inet_diag.c	inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()	2020-11-17 16:08:36 -08:00
inet_fragment.c	inet: frags: batch fqdir destroy works	2020-12-12 15:08:54 -08:00
inet_hashtables.c	tcp: add some entropy in __inet_hash_connect()	2021-02-11 13:13:05 -08:00
inet_timewait_sock.c	net: Use generic ns_common::count	2020-08-19 14:06:36 +02:00
inetpeer.c	inetpeer: use div64_ul() and clamp_val() calculate inet_peer_threshold	2021-03-01 13:32:12 -08:00
ip_forward.c
ip_fragment.c
ip_gre.c	ipv4/ipv6: switch to dev_get_tstats64	2020-11-09 17:50:28 -08:00
ip_input.c	net: use indirect call helpers for dst_input	2021-02-03 14:51:39 -08:00
ip_options.c	net: clean up codestyle for net/ipv4	2020-08-25 06:28:02 -07:00
ip_output.c	ipv4: ip_output.c: Couple of typo fixes	2021-03-28 17:31:13 -07:00
ip_sockglue.c	net: Remove duplicated midx check against 0	2020-08-25 06:23:59 -07:00
ip_tunnel_core.c	net: ip_tunnel: clean up endianness conversions	2021-01-08 19:25:35 -08:00
ip_tunnel.c	net: always use icmp{,v6}_ndo_send from ndo_start_xmit	2021-03-01 13:11:35 -08:00
ip_vti.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec	2021-03-31 14:37:51 -07:00
ipcomp.c
ipconfig.c	net: ipconfig: Don't override command-line hostnames or domains	2021-06-02 13:27:03 -07:00
ipip.c	ipv4/ipv6: switch to dev_get_tstats64	2020-11-09 17:50:28 -08:00
ipmr_base.c
ipmr.c	ipmr: Use full VIF ID in netlink cache reports	2020-09-10 12:25:51 -07:00
Kconfig	net: ipv4: remove duplicate "the the" phrase in Kconfig text	2020-08-18 16:02:16 -07:00
Makefile	bpf: Clean up sockmap related Kconfigs	2021-02-26 12:28:03 -08:00
metrics.c	treewide: rename nla_strlcpy to nla_strscpy.	2020-11-16 08:08:54 -08:00
netfilter.c	netfilter: Dissect flow after packet mangling	2021-04-18 22:04:16 +02:00
netlink.c
nexthop.c	nexthop: Restart nexthop dump based on last dumped nexthop identifier	2021-04-19 15:20:34 -07:00
ping.c	net: add support for sending RFC 8335 PROBE messages	2021-03-30 13:29:39 -07:00
proc.c	net: proc: speedup /proc/net/netstat	2021-01-29 20:59:53 -08:00
protocol.c
raw_diag.c
raw.c	lsm,selinux: pass flowi_common instead of flowi to the LSM hooks	2020-11-23 18:36:21 -05:00
route.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-03-25 15:31:22 -07:00
syncookies.c	selinux/stable-5.11 PR 20201214	2020-12-16 11:01:04 -08:00
sysctl_net_ipv4.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-04-17 11:08:07 -07:00
tcp_bbr.c	tcp: only postpone PROBE_RTT if RTT is < current min_rtt estimate	2020-11-17 11:03:22 -08:00
tcp_bic.c
tcp_bpf.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-04-25 18:02:32 -07:00
tcp_cdg.c
tcp_cong.c	net: Only allow init netns to set default tcp cong to a restricted algo	2021-05-04 11:58:28 -07:00
tcp_cubic.c	tcp: Rename bictcp function prefix to cubictcp	2021-03-26 20:41:51 -07:00
tcp_dctcp.c
tcp_dctcp.h
tcp_diag.c
tcp_fastopen.c	bpf: tcp: Add bpf_skops_established()	2020-08-24 14:35:00 -07:00
tcp_highspeed.c
tcp_htcp.c
tcp_hybla.c
tcp_illinois.c
tcp_input.c	tcp: consider using standard rtx logic in tcp_rcv_fastopen_synack()	2021-03-11 18:35:31 -08:00
tcp_ipv4.c	mptcp: add mptcp reset option support	2021-04-02 14:21:50 -07:00
tcp_lp.c	ipv4: tcp_lp.c: Couple of typo fixes	2021-03-28 17:31:13 -07:00
tcp_metrics.c	fixes-v5.11	2020-12-14 16:40:27 -08:00
tcp_minisocks.c	tcp: relookup sock for RST+ACK packets handled by obsolete req sock	2021-03-15 14:34:29 -07:00
tcp_nv.c
tcp_offload.c
tcp_output.c	tcp: remove obsolete check in __tcp_retransmit_skb()	2021-03-11 18:35:31 -08:00
tcp_rate.c
tcp_recovery.c	tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN	2021-01-23 21:33:01 -08:00
tcp_scalable.c	net: ipv4: delete repeated words	2020-08-24 17:31:20 -07:00
tcp_timer.c	tcp: make TCP_USER_TIMEOUT accurate for zero window probes	2021-01-23 19:32:51 -08:00
tcp_ulp.c
tcp_vegas.c	tcp: use semicolons rather than commas to separate statements	2020-10-13 17:11:52 -07:00
tcp_vegas.h
tcp_veno.c
tcp_westwood.c
tcp_yeah.c
tcp.c	tcp: Specify cmsgbuf is user pointer for receive zerocopy.	2021-05-06 18:05:35 -07:00
tunnel4.c
udp_bpf.c	skmsg: Pass psock pointer to ->psock_update_sk_prot()	2021-04-12 17:34:27 +02:00
udp_diag.c	net: udp: remove redundant initialization in udp_dump_one	2020-11-09 16:42:49 -08:00
udp_impl.h	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
udp_offload.c	udp: properly complete L4 GRO over UDP tunnel packet	2021-03-30 17:06:49 -07:00
udp_tunnel_core.c	udp_tunnel: reshuffle NETIF_F_RX_UDP_TUNNEL_PORT checks	2021-01-07 12:53:29 -08:00
udp_tunnel_nic.c	udp_tunnel: add the ability to share port tables	2020-09-28 12:50:12 -07:00
udp_tunnel_stub.c	udp_tunnel: add central NIC RX port offload infrastructure	2020-07-10 13:54:00 -07:00
udp.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-04-09 20:48:35 -07:00
udplite.c	net/ipv4: remove compat_ip_{get,set}sockopt	2020-07-19 18:16:41 -07:00
xfrm4_input.c
xfrm4_output.c
xfrm4_policy.c
xfrm4_protocol.c
xfrm4_state.c
xfrm4_tunnel.c	xfrm: interface: fix the priorities for ipip and ipv6 tunnels	2020-10-09 12:29:48 +02:00