mirror of
https://github.com/torvalds/linux.git
synced 2024-11-10 14:11:52 +00:00
b036d8ef31
When a control changes value the return value from _put() should be 1 so
we get events generated to userspace notifying applications of the change.
While the I2S mux gets this right the S/PDIF mux does not, fix the return
value.
Fixes: c8609f3870 ("ASoC: meson: add g12a tohdmitx control")
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20240103-meson-enum-val-v1-4-424af7a8fb91@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
288 lines
8.8 KiB
C
288 lines
8.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
//
|
|
// Copyright (c) 2019 BayLibre, SAS.
|
|
// Author: Jerome Brunet <jbrunet@baylibre.com>
|
|
|
|
#include <linux/bitfield.h>
|
|
#include <linux/clk.h>
|
|
#include <linux/module.h>
|
|
#include <sound/pcm_params.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/reset.h>
|
|
#include <sound/soc.h>
|
|
#include <sound/soc-dai.h>
|
|
|
|
#include <dt-bindings/sound/meson-g12a-tohdmitx.h>
|
|
#include "meson-codec-glue.h"
|
|
|
|
#define G12A_TOHDMITX_DRV_NAME "g12a-tohdmitx"
|
|
|
|
#define TOHDMITX_CTRL0 0x0
|
|
#define CTRL0_ENABLE_SHIFT 31
|
|
#define CTRL0_I2S_DAT_SEL_SHIFT 12
|
|
#define CTRL0_I2S_DAT_SEL (0x3 << CTRL0_I2S_DAT_SEL_SHIFT)
|
|
#define CTRL0_I2S_LRCLK_SEL GENMASK(9, 8)
|
|
#define CTRL0_I2S_BLK_CAP_INV BIT(7)
|
|
#define CTRL0_I2S_BCLK_O_INV BIT(6)
|
|
#define CTRL0_I2S_BCLK_SEL GENMASK(5, 4)
|
|
#define CTRL0_SPDIF_CLK_CAP_INV BIT(3)
|
|
#define CTRL0_SPDIF_CLK_O_INV BIT(2)
|
|
#define CTRL0_SPDIF_SEL_SHIFT 1
|
|
#define CTRL0_SPDIF_SEL (0x1 << CTRL0_SPDIF_SEL_SHIFT)
|
|
#define CTRL0_SPDIF_CLK_SEL BIT(0)
|
|
|
|
static const char * const g12a_tohdmitx_i2s_mux_texts[] = {
|
|
"I2S A", "I2S B", "I2S C",
|
|
};
|
|
|
|
static int g12a_tohdmitx_i2s_mux_put_enum(struct snd_kcontrol *kcontrol,
|
|
struct snd_ctl_elem_value *ucontrol)
|
|
{
|
|
struct snd_soc_component *component =
|
|
snd_soc_dapm_kcontrol_component(kcontrol);
|
|
struct snd_soc_dapm_context *dapm =
|
|
snd_soc_dapm_kcontrol_dapm(kcontrol);
|
|
struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
|
|
unsigned int mux, changed;
|
|
|
|
if (ucontrol->value.enumerated.item[0] >= e->items)
|
|
return -EINVAL;
|
|
|
|
mux = snd_soc_enum_item_to_val(e, ucontrol->value.enumerated.item[0]);
|
|
changed = snd_soc_component_test_bits(component, e->reg,
|
|
CTRL0_I2S_DAT_SEL,
|
|
FIELD_PREP(CTRL0_I2S_DAT_SEL,
|
|
mux));
|
|
|
|
if (!changed)
|
|
return 0;
|
|
|
|
/* Force disconnect of the mux while updating */
|
|
snd_soc_dapm_mux_update_power(dapm, kcontrol, 0, NULL, NULL);
|
|
|
|
snd_soc_component_update_bits(component, e->reg,
|
|
CTRL0_I2S_DAT_SEL |
|
|
CTRL0_I2S_LRCLK_SEL |
|
|
CTRL0_I2S_BCLK_SEL,
|
|
FIELD_PREP(CTRL0_I2S_DAT_SEL, mux) |
|
|
FIELD_PREP(CTRL0_I2S_LRCLK_SEL, mux) |
|
|
FIELD_PREP(CTRL0_I2S_BCLK_SEL, mux));
|
|
|
|
snd_soc_dapm_mux_update_power(dapm, kcontrol, mux, e, NULL);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static SOC_ENUM_SINGLE_DECL(g12a_tohdmitx_i2s_mux_enum, TOHDMITX_CTRL0,
|
|
CTRL0_I2S_DAT_SEL_SHIFT,
|
|
g12a_tohdmitx_i2s_mux_texts);
|
|
|
|
static const struct snd_kcontrol_new g12a_tohdmitx_i2s_mux =
|
|
SOC_DAPM_ENUM_EXT("I2S Source", g12a_tohdmitx_i2s_mux_enum,
|
|
snd_soc_dapm_get_enum_double,
|
|
g12a_tohdmitx_i2s_mux_put_enum);
|
|
|
|
static const char * const g12a_tohdmitx_spdif_mux_texts[] = {
|
|
"SPDIF A", "SPDIF B",
|
|
};
|
|
|
|
static int g12a_tohdmitx_spdif_mux_put_enum(struct snd_kcontrol *kcontrol,
|
|
struct snd_ctl_elem_value *ucontrol)
|
|
{
|
|
struct snd_soc_component *component =
|
|
snd_soc_dapm_kcontrol_component(kcontrol);
|
|
struct snd_soc_dapm_context *dapm =
|
|
snd_soc_dapm_kcontrol_dapm(kcontrol);
|
|
struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
|
|
unsigned int mux, changed;
|
|
|
|
if (ucontrol->value.enumerated.item[0] >= e->items)
|
|
return -EINVAL;
|
|
|
|
mux = snd_soc_enum_item_to_val(e, ucontrol->value.enumerated.item[0]);
|
|
changed = snd_soc_component_test_bits(component, TOHDMITX_CTRL0,
|
|
CTRL0_SPDIF_SEL,
|
|
FIELD_PREP(CTRL0_SPDIF_SEL, mux));
|
|
|
|
if (!changed)
|
|
return 0;
|
|
|
|
/* Force disconnect of the mux while updating */
|
|
snd_soc_dapm_mux_update_power(dapm, kcontrol, 0, NULL, NULL);
|
|
|
|
snd_soc_component_update_bits(component, TOHDMITX_CTRL0,
|
|
CTRL0_SPDIF_SEL |
|
|
CTRL0_SPDIF_CLK_SEL,
|
|
FIELD_PREP(CTRL0_SPDIF_SEL, mux) |
|
|
FIELD_PREP(CTRL0_SPDIF_CLK_SEL, mux));
|
|
|
|
snd_soc_dapm_mux_update_power(dapm, kcontrol, mux, e, NULL);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static SOC_ENUM_SINGLE_DECL(g12a_tohdmitx_spdif_mux_enum, TOHDMITX_CTRL0,
|
|
CTRL0_SPDIF_SEL_SHIFT,
|
|
g12a_tohdmitx_spdif_mux_texts);
|
|
|
|
static const struct snd_kcontrol_new g12a_tohdmitx_spdif_mux =
|
|
SOC_DAPM_ENUM_EXT("SPDIF Source", g12a_tohdmitx_spdif_mux_enum,
|
|
snd_soc_dapm_get_enum_double,
|
|
g12a_tohdmitx_spdif_mux_put_enum);
|
|
|
|
static const struct snd_kcontrol_new g12a_tohdmitx_out_enable =
|
|
SOC_DAPM_SINGLE_AUTODISABLE("Switch", TOHDMITX_CTRL0,
|
|
CTRL0_ENABLE_SHIFT, 1, 0);
|
|
|
|
static const struct snd_soc_dapm_widget g12a_tohdmitx_widgets[] = {
|
|
SND_SOC_DAPM_MUX("I2S SRC", SND_SOC_NOPM, 0, 0,
|
|
&g12a_tohdmitx_i2s_mux),
|
|
SND_SOC_DAPM_SWITCH("I2S OUT EN", SND_SOC_NOPM, 0, 0,
|
|
&g12a_tohdmitx_out_enable),
|
|
SND_SOC_DAPM_MUX("SPDIF SRC", SND_SOC_NOPM, 0, 0,
|
|
&g12a_tohdmitx_spdif_mux),
|
|
SND_SOC_DAPM_SWITCH("SPDIF OUT EN", SND_SOC_NOPM, 0, 0,
|
|
&g12a_tohdmitx_out_enable),
|
|
};
|
|
|
|
static const struct snd_soc_dai_ops g12a_tohdmitx_input_ops = {
|
|
.probe = meson_codec_glue_input_dai_probe,
|
|
.remove = meson_codec_glue_input_dai_remove,
|
|
.hw_params = meson_codec_glue_input_hw_params,
|
|
.set_fmt = meson_codec_glue_input_set_fmt,
|
|
};
|
|
|
|
static const struct snd_soc_dai_ops g12a_tohdmitx_output_ops = {
|
|
.startup = meson_codec_glue_output_startup,
|
|
};
|
|
|
|
#define TOHDMITX_SPDIF_FORMATS \
|
|
(SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \
|
|
SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S24_LE)
|
|
|
|
#define TOHDMITX_I2S_FORMATS \
|
|
(SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \
|
|
SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S24_LE | \
|
|
SNDRV_PCM_FMTBIT_S32_LE)
|
|
|
|
#define TOHDMITX_STREAM(xname, xsuffix, xfmt, xchmax) \
|
|
{ \
|
|
.stream_name = xname " " xsuffix, \
|
|
.channels_min = 1, \
|
|
.channels_max = (xchmax), \
|
|
.rate_min = 8000, \
|
|
.rate_max = 192000, \
|
|
.formats = (xfmt), \
|
|
}
|
|
|
|
#define TOHDMITX_IN(xname, xid, xfmt, xchmax) { \
|
|
.name = xname, \
|
|
.id = (xid), \
|
|
.playback = TOHDMITX_STREAM(xname, "Playback", xfmt, xchmax), \
|
|
.ops = &g12a_tohdmitx_input_ops, \
|
|
}
|
|
|
|
#define TOHDMITX_OUT(xname, xid, xfmt, xchmax) { \
|
|
.name = xname, \
|
|
.id = (xid), \
|
|
.capture = TOHDMITX_STREAM(xname, "Capture", xfmt, xchmax), \
|
|
.ops = &g12a_tohdmitx_output_ops, \
|
|
}
|
|
|
|
static struct snd_soc_dai_driver g12a_tohdmitx_dai_drv[] = {
|
|
TOHDMITX_IN("I2S IN A", TOHDMITX_I2S_IN_A,
|
|
TOHDMITX_I2S_FORMATS, 8),
|
|
TOHDMITX_IN("I2S IN B", TOHDMITX_I2S_IN_B,
|
|
TOHDMITX_I2S_FORMATS, 8),
|
|
TOHDMITX_IN("I2S IN C", TOHDMITX_I2S_IN_C,
|
|
TOHDMITX_I2S_FORMATS, 8),
|
|
TOHDMITX_OUT("I2S OUT", TOHDMITX_I2S_OUT,
|
|
TOHDMITX_I2S_FORMATS, 8),
|
|
TOHDMITX_IN("SPDIF IN A", TOHDMITX_SPDIF_IN_A,
|
|
TOHDMITX_SPDIF_FORMATS, 2),
|
|
TOHDMITX_IN("SPDIF IN B", TOHDMITX_SPDIF_IN_B,
|
|
TOHDMITX_SPDIF_FORMATS, 2),
|
|
TOHDMITX_OUT("SPDIF OUT", TOHDMITX_SPDIF_OUT,
|
|
TOHDMITX_SPDIF_FORMATS, 2),
|
|
};
|
|
|
|
static int g12a_tohdmi_component_probe(struct snd_soc_component *c)
|
|
{
|
|
/* Initialize the static clock parameters */
|
|
return snd_soc_component_write(c, TOHDMITX_CTRL0,
|
|
CTRL0_I2S_BLK_CAP_INV | CTRL0_SPDIF_CLK_CAP_INV);
|
|
}
|
|
|
|
static const struct snd_soc_dapm_route g12a_tohdmitx_routes[] = {
|
|
{ "I2S SRC", "I2S A", "I2S IN A Playback" },
|
|
{ "I2S SRC", "I2S B", "I2S IN B Playback" },
|
|
{ "I2S SRC", "I2S C", "I2S IN C Playback" },
|
|
{ "I2S OUT EN", "Switch", "I2S SRC" },
|
|
{ "I2S OUT Capture", NULL, "I2S OUT EN" },
|
|
{ "SPDIF SRC", "SPDIF A", "SPDIF IN A Playback" },
|
|
{ "SPDIF SRC", "SPDIF B", "SPDIF IN B Playback" },
|
|
{ "SPDIF OUT EN", "Switch", "SPDIF SRC" },
|
|
{ "SPDIF OUT Capture", NULL, "SPDIF OUT EN" },
|
|
};
|
|
|
|
static const struct snd_soc_component_driver g12a_tohdmitx_component_drv = {
|
|
.probe = g12a_tohdmi_component_probe,
|
|
.dapm_widgets = g12a_tohdmitx_widgets,
|
|
.num_dapm_widgets = ARRAY_SIZE(g12a_tohdmitx_widgets),
|
|
.dapm_routes = g12a_tohdmitx_routes,
|
|
.num_dapm_routes = ARRAY_SIZE(g12a_tohdmitx_routes),
|
|
.endianness = 1,
|
|
};
|
|
|
|
static const struct regmap_config g12a_tohdmitx_regmap_cfg = {
|
|
.reg_bits = 32,
|
|
.val_bits = 32,
|
|
.reg_stride = 4,
|
|
};
|
|
|
|
static const struct of_device_id g12a_tohdmitx_of_match[] = {
|
|
{ .compatible = "amlogic,g12a-tohdmitx", },
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(of, g12a_tohdmitx_of_match);
|
|
|
|
static int g12a_tohdmitx_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
void __iomem *regs;
|
|
struct regmap *map;
|
|
int ret;
|
|
|
|
ret = device_reset(dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
regs = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(regs))
|
|
return PTR_ERR(regs);
|
|
|
|
map = devm_regmap_init_mmio(dev, regs, &g12a_tohdmitx_regmap_cfg);
|
|
if (IS_ERR(map)) {
|
|
dev_err(dev, "failed to init regmap: %ld\n",
|
|
PTR_ERR(map));
|
|
return PTR_ERR(map);
|
|
}
|
|
|
|
return devm_snd_soc_register_component(dev,
|
|
&g12a_tohdmitx_component_drv, g12a_tohdmitx_dai_drv,
|
|
ARRAY_SIZE(g12a_tohdmitx_dai_drv));
|
|
}
|
|
|
|
static struct platform_driver g12a_tohdmitx_pdrv = {
|
|
.driver = {
|
|
.name = G12A_TOHDMITX_DRV_NAME,
|
|
.of_match_table = g12a_tohdmitx_of_match,
|
|
},
|
|
.probe = g12a_tohdmitx_probe,
|
|
};
|
|
module_platform_driver(g12a_tohdmitx_pdrv);
|
|
|
|
MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre.com>");
|
|
MODULE_DESCRIPTION("Amlogic G12a To HDMI Tx Control Codec Driver");
|
|
MODULE_LICENSE("GPL v2");
|