linux/tools/perf/util
Arnaldo Carvalho de Melo d3379ab905 perf symbols: Fix comparision of build_ids
When we read the build_id from the DSO name to then index into
/usr/lib/debug/.buildid/DSO_BUILD_ID[0:2]/DSO_BUILD_ID[2:], we
were jumping directly to the comparision with the buildid we
already have in dso->build_id (that came from the perf.data
build_id section, collected at perf record time)
unconditionally, even if we didn't had recorded it, and
furthermore, comparing a formatted buildid with a rawbuildid, yikes.

Fix it by deleting the dso__read_build_id() function, that was
really misdesigned anyway, and do the necessary checks and
correct comparison of raw buildids.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1258582853-8579-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-11-19 08:28:11 +01:00
..
include perf tools: Bring linear set of section headers for features 2009-11-11 07:30:19 +01:00
abspath.c perf: Enable more compiler warnings 2009-08-16 10:47:47 +02:00
alias.c perf_counter tools: Add more warnings and fix/annotate them 2009-07-01 12:49:48 +02:00
cache.h perf tools: Do not manually count string lengths 2009-10-13 11:55:31 +02:00
callchain.c perf tools: Unify debug messages mechanisms 2009-10-23 08:22:47 +02:00
callchain.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
color.c perf tools: Librarize trace_event() helper 2009-08-16 23:06:45 +02:00
color.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
config.c perf: Enable more compiler warnings 2009-08-16 10:47:47 +02:00
ctype.c perf_counter tools: Add and use isprint() 2009-06-18 09:46:00 +02:00
data_map.c perf symbols: Pass the offset to perf_header__read_build_ids() 2009-11-16 22:05:49 +01:00
data_map.h perf symbols: Pass the offset to perf_header__read_build_ids() 2009-11-16 22:05:49 +01:00
debug.c perf tools: Unify debug messages mechanisms 2009-10-23 08:22:47 +02:00
debug.h perf tools: Debug.h needs to include event.h for event_t 2009-11-16 22:05:50 +01:00
debugfs.c perf tools: Add debugfs utility routines for perf 2009-11-08 18:01:34 +01:00
debugfs.h perf tools: Add debugfs utility routines for perf 2009-11-08 18:01:34 +01:00
environment.c perf_counter tools: Move from Documentation/perf_counter/ to tools/perf/ 2009-06-06 20:33:43 +02:00
event.c perf tools: Generalize event synthesizing routines 2009-10-27 13:51:53 +01:00
event.h perf tools: Split up build id saving into fetch and write 2009-11-11 07:30:18 +01:00
exec_cmd.c perf: Enable more compiler warnings 2009-08-16 10:47:47 +02:00
exec_cmd.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
generate-cmdlist.sh perf_counter tools: Move from Documentation/perf_counter/ to tools/perf/ 2009-06-06 20:33:43 +02:00
header.c perf tools: Don't die() in do_write() 2009-11-17 07:19:56 +01:00
header.h perf tools: Don't die() in perf_header_attr__add_id() 2009-11-17 07:19:55 +01:00
help.c perf_counter tools: Add more warnings and fix/annotate them 2009-07-01 12:49:48 +02:00
help.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
hist.c perf tools: Move hist_entry__add common code to hist.c 2009-10-03 16:01:59 +02:00
hist.h perf tools: Move hist_entry__add common code to hist.c 2009-10-03 16:01:59 +02:00
levenshtein.c perf_counter tools: Move from Documentation/perf_counter/ to tools/perf/ 2009-06-06 20:33:43 +02:00
levenshtein.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
map.c perf symbols: Use the buildids if present 2009-11-08 10:44:36 +01:00
pager.c perf_counter tools: Remove dead code 2009-06-27 06:06:39 +02:00
parse-events.c Merge branches 'perf/powerpc' and 'perf/bench' into perf/core 2009-11-15 09:51:24 +01:00
parse-events.h perf trace: Add filter Suppport 2009-10-15 11:35:23 +02:00
parse-options.c perf: Enable more compiler warnings 2009-08-16 10:47:47 +02:00
parse-options.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
path.c perf: Enable more compiler warnings 2009-08-16 10:47:47 +02:00
PERF-VERSION-GEN perf tools: Bump version to 0.0.2 2009-10-16 10:34:28 +02:00
probe-finder.c perf/probes: Fall back to non-dwarf if possible 2009-11-04 13:02:47 +01:00
probe-finder.h perf/probes: Support function entry relative line number 2009-10-29 08:47:49 +01:00
quote.c perf: Fix read buffer overflow 2009-08-04 11:09:56 +02:00
quote.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
run-command.c perf: Enable more compiler warnings 2009-08-16 10:47:47 +02:00
run-command.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
sigchain.c perf_counter tools: Move from Documentation/perf_counter/ to tools/perf/ 2009-06-06 20:33:43 +02:00
sigchain.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
sort.c perf tools: Bind callchains to the first sort dimension column 2009-10-23 07:55:18 +02:00
sort.h perf tools: Bind callchains to the first sort dimension column 2009-10-23 07:55:18 +02:00
strbuf.c perf_counter tools: Add more warnings and fix/annotate them 2009-07-01 12:49:48 +02:00
strbuf.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
string.c perf tools: Add new perf_atoll() function to parse string representing size in bytes 2009-11-15 14:54:23 +01:00
string.h perf tools: Add new perf_atoll() function to parse string representing size in bytes 2009-11-15 14:54:23 +01:00
strlist.c strlist: Introduce strlist__entry and strlist__nr_entries methods 2009-07-11 19:20:25 +02:00
strlist.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
svghelper.c perf timechart: Improve the visual appearance of scheduler delays 2009-10-20 03:39:21 +02:00
svghelper.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
symbol.c perf symbols: Fix comparision of build_ids 2009-11-19 08:28:11 +01:00
symbol.h perf symbols: Add a long_name_len member to struct dso 2009-11-19 06:03:34 +01:00
thread.c perf tools: Unify debug messages mechanisms 2009-10-23 08:22:47 +02:00
thread.h perf tools: Bind callchains to the first sort dimension column 2009-10-23 07:55:18 +02:00
trace-event-info.c perf tools: Merge trace.info content into perf.data 2009-10-07 08:36:10 +02:00
trace-event-parse.c perf tools: Use strsep() over strtok_r() for parsing single line 2009-10-21 13:39:57 +02:00
trace-event-read.c perf tools: Merge trace.info content into perf.data 2009-10-07 08:36:10 +02:00
trace-event.h perf tools: Add latency format to trace output 2009-10-15 10:42:39 +02:00
types.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
usage.c perf top: Fall back to cpu-clock-tick hrtimer sampling if no cycle counter available 2009-06-07 17:31:52 +02:00
util.h Merge branch 'perf/core' into perf/probes 2009-11-17 10:17:47 +01:00
values.c perf: Enable more compiler warnings 2009-08-16 10:47:47 +02:00
values.h perf tools: Protect header files with a consistent style 2009-09-24 21:27:51 +02:00
wrapper.c perf_counter tools: Add more warnings and fix/annotate them 2009-07-01 12:49:48 +02:00