Leon Romanovsky d086a1c65a net: sched: Fix suspicious RCU usage while accessing tcf_tunnel_info ... The access of tcf_tunnel_info() produces the following splat, so fix it by dereferencing the tcf_tunnel_key_params pointer with marker that internal tcfa_liock is held. ============================= WARNING: suspicious RCU usage 5.9.0+ #1 Not tainted ----------------------------- include/net/tc_act/tc_tunnel_key.h:59 suspicious rcu_dereference_protected() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 1 lock held by tc/34839: #0: ffff88828572c2a0 (&p->tcfa_lock){+...}-{2:2}, at: tc_setup_flow_action+0xb3/0x48b5 stack backtrace: CPU: 1 PID: 34839 Comm: tc Not tainted 5.9.0+ #1 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014 Call Trace: dump_stack+0x9a/0xd0 tc_setup_flow_action+0x14cb/0x48b5 fl_hw_replace_filter+0x347/0x690 [cls_flower] fl_change+0x2bad/0x4875 [cls_flower] tc_new_tfilter+0xf6f/0x1ba0 rtnetlink_rcv_msg+0x5f2/0x870 netlink_rcv_skb+0x124/0x350 netlink_unicast+0x433/0x700 netlink_sendmsg+0x6f1/0xbd0 sock_sendmsg+0xb0/0xe0 ____sys_sendmsg+0x4fa/0x6d0 ___sys_sendmsg+0x12e/0x1b0 __sys_sendmsg+0xa4/0x120 do_syscall_64+0x2d/0x40 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7f1f8cd4fe57 Code: 0c 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 2e 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 89 54 24 1c 48 89 74 24 10 RSP: 002b:00007ffdc1e193b8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f1f8cd4fe57 RDX: 0000000000000000 RSI: 00007ffdc1e19420 RDI: 0000000000000003 RBP: 000000005f85aafa R08: 0000000000000001 R09: 00007ffdc1e1936c R10: 000000000040522d R11: 0000000000000246 R12: 0000000000000001 R13: 0000000000000000 R14: 00007ffdc1e1d6f0 R15: 0000000000482420 Fixes: 3ebaf6da07 ("net: sched: Do not assume RTNL is held in tunnel key action helpers") Fixes: 7a47281439 ("net: sched: lock action when translating it to flow_action infra") Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2020-10-15 09:10:11 -07:00
..
tc_bpf.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tc_connmark.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tc_csum.h	net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE	2019-02-10 09:28:43 -08:00
tc_ct.h	net/sched: act_ct: Make tcf_ct_flow_table_restore_skb inline	2020-06-15 18:06:52 -07:00
tc_ctinfo.h	net: sched: act_ctinfo: tidy UAPI definition	2019-06-19 17:11:01 -04:00
tc_defact.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tc_gact.h	net/sched: don't dereference a->goto_chain to read the chain index	2019-03-21 13:26:42 -07:00
tc_gate.h	net: schedule: add action gate offloading	2020-05-01 16:08:19 -07:00
tc_ife.h	net: tc_act: drop include of module.h from tc_ife.h	2019-04-22 21:50:53 -07:00
tc_ipt.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tc_mirred.h	net: tc_act: add helpers to detect ingress mirred actions	2019-08-06 14:24:21 -07:00
tc_mpls.h	net: sched: include mpls actions in hardware intermediate representation	2019-07-23 13:52:50 -07:00
tc_nat.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tc_pedit.h	net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE	2019-02-10 09:28:43 -08:00
tc_police.h	net:qos: police action offloading parameter 'burst' change to the original value	2020-06-29 17:33:42 -07:00
tc_sample.h	net: sched: take reference to psample group in flow_action infra	2019-09-16 09:18:03 +02:00
tc_skbedit.h	net: tc_skbedit: Make the skbedit priority offloadable	2020-03-19 21:09:19 -07:00
tc_skbmod.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tc_tunnel_key.h	net: sched: Fix suspicious RCU usage while accessing tcf_tunnel_info	2020-10-15 09:10:11 -07:00
tc_vlan.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00