mirror of
https://github.com/torvalds/linux.git
synced 2024-11-10 22:21:40 +00:00
7a46404b3c
I noticed some error with: # perf list ex_ret_brn lzma: fopen failed on /usr/lib/modules/5.15.14-100.fc34.x86_64/kernel/net/bluetooth/bnep/bnep.ko.xz: 'No such file or directory' lzma: fopen failed on /usr/lib/modules/5.16.16-200.fc35.x86_64/kernel/drivers/gpu/drm/drm_kms_helper.ko.xz: 'No such file or directory' lzma: fopen failed on /usr/lib/modules/5.18.16-200.fc36.x86_64/kernel/arch/x86/crypto/crct10dif-pclmul.ko.xz: 'No such file or directory' lzma: fopen failed on /usr/lib/modules/5.16.16-200.fc35.x86_64/kernel/drivers/i2c/busses/i2c-piix4.ko.xz: 'No such file or directory' <BIG SNIP> Then using 'perf probe' + 'perf trace' to debug 'perf list', it seems its some inconsistency in the ~/.debug/ cache where broken build id symlinks that ends up making it try to uncompress some kernel modules using the lzma routines: 395.309 perf/3594447 probe_perf:lzma_decompress_to_file(__probe_ip: 6118448, input_string: "/usr/lib/modules/5.18.17-200.fc36.x86_64/kernel/drivers/nvme/host/nvme.ko.xz") lzma_decompress_to_file (/var/home/acme/bin/perf) filename__decompress (/var/home/acme/bin/perf) filename__read_build_id (/var/home/acme/bin/perf) filename__sprintf_build_id (inlined) build_id_cache__valid_id (inlined) build_id_cache__list_all (/var/home/acme/bin/perf) print_sdt_events (/var/home/acme/bin/perf) cmd_list (/var/home/acme/bin/perf) run_builtin (/var/home/acme/bin/perf) handle_internal_command (inlined) run_argv (inlined) main (/var/home/acme/bin/perf) __libc_start_call_main (/usr/lib64/libc.so.6) __libc_start_main@@GLIBC_2.34 (/usr/lib64/libc.so.6) _start (/var/home/acme/bin/perf) But callers of filename__decompress() already check its return and use pr_debug(), so be consistent and make functions it calls also use pr_debug(). Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://lore.kernel.org/lkml/ZOUD0+GkuCVkYF7n@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
123 lines
2.6 KiB
C
123 lines
2.6 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <errno.h>
|
|
#include <lzma.h>
|
|
#include <stdio.h>
|
|
#include <linux/compiler.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <fcntl.h>
|
|
#include "compress.h"
|
|
#include "debug.h"
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <internal/lib.h>
|
|
|
|
#define BUFSIZE 8192
|
|
|
|
static const char *lzma_strerror(lzma_ret ret)
|
|
{
|
|
switch ((int) ret) {
|
|
case LZMA_MEM_ERROR:
|
|
return "Memory allocation failed";
|
|
case LZMA_OPTIONS_ERROR:
|
|
return "Unsupported decompressor flags";
|
|
case LZMA_FORMAT_ERROR:
|
|
return "The input is not in the .xz format";
|
|
case LZMA_DATA_ERROR:
|
|
return "Compressed file is corrupt";
|
|
case LZMA_BUF_ERROR:
|
|
return "Compressed file is truncated or otherwise corrupt";
|
|
default:
|
|
return "Unknown error, possibly a bug";
|
|
}
|
|
}
|
|
|
|
int lzma_decompress_to_file(const char *input, int output_fd)
|
|
{
|
|
lzma_action action = LZMA_RUN;
|
|
lzma_stream strm = LZMA_STREAM_INIT;
|
|
lzma_ret ret;
|
|
int err = -1;
|
|
|
|
u8 buf_in[BUFSIZE];
|
|
u8 buf_out[BUFSIZE];
|
|
FILE *infile;
|
|
|
|
infile = fopen(input, "rb");
|
|
if (!infile) {
|
|
pr_debug("lzma: fopen failed on %s: '%s'\n", input, strerror(errno));
|
|
return -1;
|
|
}
|
|
|
|
ret = lzma_stream_decoder(&strm, UINT64_MAX, LZMA_CONCATENATED);
|
|
if (ret != LZMA_OK) {
|
|
pr_debug("lzma: lzma_stream_decoder failed %s (%d)\n", lzma_strerror(ret), ret);
|
|
goto err_fclose;
|
|
}
|
|
|
|
strm.next_in = NULL;
|
|
strm.avail_in = 0;
|
|
strm.next_out = buf_out;
|
|
strm.avail_out = sizeof(buf_out);
|
|
|
|
while (1) {
|
|
if (strm.avail_in == 0 && !feof(infile)) {
|
|
strm.next_in = buf_in;
|
|
strm.avail_in = fread(buf_in, 1, sizeof(buf_in), infile);
|
|
|
|
if (ferror(infile)) {
|
|
pr_debug("lzma: read error: %s\n", strerror(errno));
|
|
goto err_lzma_end;
|
|
}
|
|
|
|
if (feof(infile))
|
|
action = LZMA_FINISH;
|
|
}
|
|
|
|
ret = lzma_code(&strm, action);
|
|
|
|
if (strm.avail_out == 0 || ret == LZMA_STREAM_END) {
|
|
ssize_t write_size = sizeof(buf_out) - strm.avail_out;
|
|
|
|
if (writen(output_fd, buf_out, write_size) != write_size) {
|
|
pr_debug("lzma: write error: %s\n", strerror(errno));
|
|
goto err_lzma_end;
|
|
}
|
|
|
|
strm.next_out = buf_out;
|
|
strm.avail_out = sizeof(buf_out);
|
|
}
|
|
|
|
if (ret != LZMA_OK) {
|
|
if (ret == LZMA_STREAM_END)
|
|
break;
|
|
|
|
pr_debug("lzma: failed %s\n", lzma_strerror(ret));
|
|
goto err_lzma_end;
|
|
}
|
|
}
|
|
|
|
err = 0;
|
|
err_lzma_end:
|
|
lzma_end(&strm);
|
|
err_fclose:
|
|
fclose(infile);
|
|
return err;
|
|
}
|
|
|
|
bool lzma_is_compressed(const char *input)
|
|
{
|
|
int fd = open(input, O_RDONLY);
|
|
const uint8_t magic[6] = { 0xFD, '7', 'z', 'X', 'Z', 0x00 };
|
|
char buf[6] = { 0 };
|
|
ssize_t rc;
|
|
|
|
if (fd < 0)
|
|
return -1;
|
|
|
|
rc = read(fd, buf, sizeof(buf));
|
|
close(fd);
|
|
return rc == sizeof(buf) ?
|
|
memcmp(buf, magic, sizeof(buf)) == 0 : false;
|
|
}
|