mirror of
https://github.com/torvalds/linux.git
synced 2024-11-14 08:02:07 +00:00
e4ba4fc2b9
Checks introduced in commit4991e7251("romfs: do not use mtd->get_unmapped_area directly") re-introduce problems fixed in the earlier commit2b4b2482e("romfs: fix romfs_get_unmapped_area() argument check"). If a flat binary app is located at the end of a romfs, its page aligned length may be outside of the romfs filesystem. The flat binary loader, via nommu do_mmap_pgoff(), page aligns the length it is mmaping. So simple offset+size checks will fail - returning EINVAL. We can truncate the length to keep it inside the romfs filesystem, and that also keeps the call to mtd_get_unmapped_area() happy. Are there any side effects to truncating the size here though? Signed-off-by: Greg Ungerer <gerg@uclinux.org>
81 lines
2.3 KiB
C
81 lines
2.3 KiB
C
/* NOMMU mmap support for RomFS on MTD devices
|
|
*
|
|
* Copyright © 2007 Red Hat, Inc. All Rights Reserved.
|
|
* Written by David Howells (dhowells@redhat.com)
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*/
|
|
|
|
#include <linux/mm.h>
|
|
#include <linux/mtd/super.h>
|
|
#include "internal.h"
|
|
|
|
/*
|
|
* try to determine where a shared mapping can be made
|
|
* - only supported for NOMMU at the moment (MMU can't doesn't copy private
|
|
* mappings)
|
|
* - attempts to map through to the underlying MTD device
|
|
*/
|
|
static unsigned long romfs_get_unmapped_area(struct file *file,
|
|
unsigned long addr,
|
|
unsigned long len,
|
|
unsigned long pgoff,
|
|
unsigned long flags)
|
|
{
|
|
struct inode *inode = file->f_mapping->host;
|
|
struct mtd_info *mtd = inode->i_sb->s_mtd;
|
|
unsigned long isize, offset, maxpages, lpages;
|
|
int ret;
|
|
|
|
if (!mtd)
|
|
return (unsigned long) -ENOSYS;
|
|
|
|
/* the mapping mustn't extend beyond the EOF */
|
|
lpages = (len + PAGE_SIZE - 1) >> PAGE_SHIFT;
|
|
isize = i_size_read(inode);
|
|
offset = pgoff << PAGE_SHIFT;
|
|
|
|
maxpages = (isize + PAGE_SIZE - 1) >> PAGE_SHIFT;
|
|
if ((pgoff >= maxpages) || (maxpages - pgoff < lpages))
|
|
return (unsigned long) -EINVAL;
|
|
|
|
if (addr != 0)
|
|
return (unsigned long) -EINVAL;
|
|
|
|
if (len > mtd->size || pgoff >= (mtd->size >> PAGE_SHIFT))
|
|
return (unsigned long) -EINVAL;
|
|
|
|
offset += ROMFS_I(inode)->i_dataoffset;
|
|
if (offset >= mtd->size)
|
|
return (unsigned long) -EINVAL;
|
|
/* the mapping mustn't extend beyond the EOF */
|
|
if ((offset + len) > mtd->size)
|
|
len = mtd->size - offset;
|
|
|
|
ret = mtd_get_unmapped_area(mtd, len, offset, flags);
|
|
if (ret == -EOPNOTSUPP)
|
|
ret = -ENOSYS;
|
|
return (unsigned long) ret;
|
|
}
|
|
|
|
/*
|
|
* permit a R/O mapping to be made directly through onto an MTD device if
|
|
* possible
|
|
*/
|
|
static int romfs_mmap(struct file *file, struct vm_area_struct *vma)
|
|
{
|
|
return vma->vm_flags & (VM_SHARED | VM_MAYSHARE) ? 0 : -ENOSYS;
|
|
}
|
|
|
|
const struct file_operations romfs_ro_fops = {
|
|
.llseek = generic_file_llseek,
|
|
.read = do_sync_read,
|
|
.aio_read = generic_file_aio_read,
|
|
.splice_read = generic_file_splice_read,
|
|
.mmap = romfs_mmap,
|
|
.get_unmapped_area = romfs_get_unmapped_area,
|
|
};
|