mirror of
https://github.com/torvalds/linux.git
synced 2024-12-24 11:51:27 +00:00
9d50f95bc0
SPI devices can specify a cs-gpios property to enumerate their chip selects. Under device tree, a zero entry in this property can be used to specify that a particular chip select is using the SPI controllers native chip select, for example: cs-gpios = <&gpio1 0 0>, <0>; Here, the second chip select is native. However, when using swnodes there is currently no way to specify a native chip select. The proposal here is to register a swnode_gpio_undefined software node, that can be specified to allow the indication of a native chip select. For example: static const struct software_node_ref_args device_cs_refs[] = { { .node = &device_gpiochip_swnode, .nargs = 2, .args = { 0, GPIO_ACTIVE_LOW }, }, { .node = &swnode_gpio_undefined, .nargs = 0, }, }; Register the swnode as the gpiolib is initialised and check in swnode_get_gpio_device() if the returned node matches swnode_gpio_undefined and return -ENOENT, which matches the behaviour of the device tree system when it encounters a 0 phandle. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Andy Shevchenko <andy@kernel.org> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Link: https://lore.kernel.org/r/20240416100904.3738093-2-ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
168 lines
4.4 KiB
C
168 lines
4.4 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Software Node helpers for the GPIO API
|
|
*
|
|
* Copyright 2022 Google LLC
|
|
*/
|
|
|
|
#define pr_fmt(fmt) "gpiolib: swnode: " fmt
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/export.h>
|
|
#include <linux/init.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/printk.h>
|
|
#include <linux/property.h>
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/gpio/consumer.h>
|
|
#include <linux/gpio/driver.h>
|
|
|
|
#include "gpiolib.h"
|
|
#include "gpiolib-swnode.h"
|
|
|
|
#define GPIOLIB_SWNODE_UNDEFINED_NAME "swnode-gpio-undefined"
|
|
|
|
static void swnode_format_propname(const char *con_id, char *propname,
|
|
size_t max_size)
|
|
{
|
|
/*
|
|
* Note we do not need to try both -gpios and -gpio suffixes,
|
|
* as, unlike OF and ACPI, we can fix software nodes to conform
|
|
* to the proper binding.
|
|
*/
|
|
if (con_id)
|
|
snprintf(propname, max_size, "%s-gpios", con_id);
|
|
else
|
|
strscpy(propname, "gpios", max_size);
|
|
}
|
|
|
|
static struct gpio_device *swnode_get_gpio_device(struct fwnode_handle *fwnode)
|
|
{
|
|
const struct software_node *gdev_node;
|
|
struct gpio_device *gdev;
|
|
|
|
gdev_node = to_software_node(fwnode);
|
|
if (!gdev_node || !gdev_node->name)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
/*
|
|
* Check for a special node that identifies undefined GPIOs, this is
|
|
* primarily used as a key for internal chip selects in SPI bindings.
|
|
*/
|
|
if (IS_ENABLED(CONFIG_GPIO_SWNODE_UNDEFINED) &&
|
|
!strcmp(gdev_node->name, GPIOLIB_SWNODE_UNDEFINED_NAME))
|
|
return ERR_PTR(-ENOENT);
|
|
|
|
gdev = gpio_device_find_by_label(gdev_node->name);
|
|
return gdev ?: ERR_PTR(-EPROBE_DEFER);
|
|
}
|
|
|
|
struct gpio_desc *swnode_find_gpio(struct fwnode_handle *fwnode,
|
|
const char *con_id, unsigned int idx,
|
|
unsigned long *flags)
|
|
{
|
|
const struct software_node *swnode;
|
|
struct fwnode_reference_args args;
|
|
struct gpio_desc *desc;
|
|
char propname[32]; /* 32 is max size of property name */
|
|
int error;
|
|
|
|
swnode = to_software_node(fwnode);
|
|
if (!swnode)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
swnode_format_propname(con_id, propname, sizeof(propname));
|
|
|
|
/*
|
|
* We expect all swnode-described GPIOs have GPIO number and
|
|
* polarity arguments, hence nargs is set to 2.
|
|
*/
|
|
error = fwnode_property_get_reference_args(fwnode, propname, NULL, 2, idx, &args);
|
|
if (error) {
|
|
pr_debug("%s: can't parse '%s' property of node '%pfwP[%d]'\n",
|
|
__func__, propname, fwnode, idx);
|
|
return ERR_PTR(error);
|
|
}
|
|
|
|
struct gpio_device *gdev __free(gpio_device_put) =
|
|
swnode_get_gpio_device(args.fwnode);
|
|
fwnode_handle_put(args.fwnode);
|
|
if (IS_ERR(gdev))
|
|
return ERR_CAST(gdev);
|
|
|
|
/*
|
|
* FIXME: The GPIO device reference is put at return but the descriptor
|
|
* is passed on. Find a proper solution.
|
|
*/
|
|
desc = gpio_device_get_desc(gdev, args.args[0]);
|
|
*flags = args.args[1]; /* We expect native GPIO flags */
|
|
|
|
pr_debug("%s: parsed '%s' property of node '%pfwP[%d]' - status (%d)\n",
|
|
__func__, propname, fwnode, idx, PTR_ERR_OR_ZERO(desc));
|
|
|
|
return desc;
|
|
}
|
|
|
|
/**
|
|
* swnode_gpio_count - count the GPIOs associated with a device / function
|
|
* @fwnode: firmware node of the GPIO consumer, can be %NULL for
|
|
* system-global GPIOs
|
|
* @con_id: function within the GPIO consumer
|
|
*
|
|
* Return:
|
|
* The number of GPIOs associated with a device / function or %-ENOENT,
|
|
* if no GPIO has been assigned to the requested function.
|
|
*/
|
|
int swnode_gpio_count(const struct fwnode_handle *fwnode, const char *con_id)
|
|
{
|
|
struct fwnode_reference_args args;
|
|
char propname[32];
|
|
int count;
|
|
|
|
swnode_format_propname(con_id, propname, sizeof(propname));
|
|
|
|
/*
|
|
* This is not very efficient, but GPIO lists usually have only
|
|
* 1 or 2 entries.
|
|
*/
|
|
count = 0;
|
|
while (fwnode_property_get_reference_args(fwnode, propname, NULL, 0,
|
|
count, &args) == 0) {
|
|
fwnode_handle_put(args.fwnode);
|
|
count++;
|
|
}
|
|
|
|
return count ?: -ENOENT;
|
|
}
|
|
|
|
#if IS_ENABLED(CONFIG_GPIO_SWNODE_UNDEFINED)
|
|
/*
|
|
* A special node that identifies undefined GPIOs, this is primarily used as
|
|
* a key for internal chip selects in SPI bindings.
|
|
*/
|
|
const struct software_node swnode_gpio_undefined = {
|
|
.name = GPIOLIB_SWNODE_UNDEFINED_NAME,
|
|
};
|
|
EXPORT_SYMBOL_NS_GPL(swnode_gpio_undefined, GPIO_SWNODE);
|
|
|
|
static int __init swnode_gpio_init(void)
|
|
{
|
|
int ret;
|
|
|
|
ret = software_node_register(&swnode_gpio_undefined);
|
|
if (ret < 0)
|
|
pr_err("failed to register swnode: %d\n", ret);
|
|
|
|
return ret;
|
|
}
|
|
subsys_initcall(swnode_gpio_init);
|
|
|
|
static void __exit swnode_gpio_cleanup(void)
|
|
{
|
|
software_node_unregister(&swnode_gpio_undefined);
|
|
}
|
|
__exitcall(swnode_gpio_cleanup);
|
|
#endif
|