mirror of
https://github.com/torvalds/linux.git
synced 2024-11-19 02:21:47 +00:00
148fc55fd0
There is a msleep with spin lock held during ehci pci suspend, which will cause kernel BUG: scheduling while atomic. Fix that. [ 184.139620] BUG: scheduling while atomic: kworker/u:11/416/0x00000002 [ 184.139632] 4 locks held by kworker/u:11/416: [ 184.139640] #0: (events_unbound){+.+.+.}, at: [<c104ddd4>] process_one_work+0x1b3/0x4cb [ 184.139669] #1: ((&entry->work)){+.+.+.}, at: [<c104ddd4>] process_one_work+0x1b3/0x4cb [ 184.139686] #2: (&__lockdep_no_validate__){+.+.+.}, at: [<c127cde3>] __device_suspend+0x2c/0x154 [ 184.139706] #3: (&(&ehci->lock)->rlock){-.-...}, at: [<c132f3d8>] ehci_pci_suspend+0x35/0x7b [ 184.139725] Modules linked in: serio_raw pegasus joydev mrst_gfx(C) battery [ 184.139748] irq event stamp: 52 [ 184.139753] hardirqs last enabled at (51): [<c14fdaac>] mutex_lock_nested+0x258/0x293 [ 184.139766] hardirqs last disabled at (52): [<c14fe7b4>] _raw_spin_lock_irqsave+0xf/0x3e [ 184.139777] softirqs last enabled at (0): [<c10371c1>] copy_process+0x3d2/0x109d [ 184.139789] softirqs last disabled at (0): [< (null)>] (null) [ 184.139802] Pid: 416, comm: kworker/u:11 Tainted: G C 2.6.37-6.3-adaptation-oaktrail #37 [ 184.139809] Call Trace: [ 184.139820] [<c102eeff>] __schedule_bug+0x5e/0x65 [ 184.139829] [<c14fbca5>] schedule+0xac/0xc4c [ 184.139840] [<c11d4845>] ? string+0x37/0x8b [ 184.139853] [<c1044f21>] ? lock_timer_base+0x1f/0x3e [ 184.139863] [<c14fe7da>] ? _raw_spin_lock_irqsave+0x35/0x3e [ 184.139876] [<c1061590>] ? trace_hardirqs_off+0xb/0xd [ 184.139885] [<c14fccdc>] schedule_timeout+0x283/0x2d9 [ 184.139896] [<c104516f>] ? process_timeout+0x0/0xa [ 184.139906] [<c14fcd47>] schedule_timeout_uninterruptible+0x15/0x17 [ 184.139916] [<c104566a>] msleep+0x10/0x16 [ 184.139926] [<c132f316>] ehci_adjust_port_wakeup_flags+0x69/0xf6 [ 184.139937] [<c132f3eb>] ehci_pci_suspend+0x48/0x7b [ 184.139946] [<c1326587>] suspend_common+0x52/0xbb [ 184.139956] [<c1326625>] hcd_pci_suspend+0x26/0x28 [ 184.139967] [<c11e7182>] pci_pm_suspend+0x5f/0xd0 [ 184.139976] [<c127ca3a>] pm_op+0x5d/0xf0 [ 184.139986] [<c127ceac>] __device_suspend+0xf5/0x154 [ 184.139996] [<c127d2c8>] async_suspend+0x16/0x3a [ 184.140006] [<c1058f54>] async_run_entry_fn+0x89/0x111 [ 184.140016] [<c104deb6>] process_one_work+0x295/0x4cb [ 184.140026] [<c1058ecb>] ? async_run_entry_fn+0x0/0x111 [ 184.140036] [<c104e3d0>] worker_thread+0x17f/0x298 [ 184.140045] [<c104e251>] ? worker_thread+0x0/0x298 [ 184.140055] [<c105277f>] kthread+0x64/0x69 [ 184.140064] [<c105271b>] ? kthread+0x0/0x69 [ 184.140075] [<c1002efa>] kernel_thread_helper+0x6/0x1a Signed-off-by: Yin Kangkai <kangkai.yin@intel.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> CC: David Brownell <dbrownell@users.sourceforge.net> CC: stable@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
326 lines
8.0 KiB
C
326 lines
8.0 KiB
C
/*
|
|
* EHCI HCD (Host Controller Driver) for USB.
|
|
*
|
|
* Bus Glue for AMD Alchemy Au1xxx
|
|
*
|
|
* Based on "ohci-au1xxx.c" by Matt Porter <mporter@kernel.crashing.org>
|
|
*
|
|
* Modified for AMD Alchemy Au1200 EHC
|
|
* by K.Boge <karsten.boge@amd.com>
|
|
*
|
|
* This file is licenced under the GPL.
|
|
*/
|
|
|
|
#include <linux/platform_device.h>
|
|
#include <asm/mach-au1x00/au1000.h>
|
|
|
|
#define USB_HOST_CONFIG (USB_MSR_BASE + USB_MSR_MCFG)
|
|
#define USB_MCFG_PFEN (1<<31)
|
|
#define USB_MCFG_RDCOMB (1<<30)
|
|
#define USB_MCFG_SSDEN (1<<23)
|
|
#define USB_MCFG_PHYPLLEN (1<<19)
|
|
#define USB_MCFG_UCECLKEN (1<<18)
|
|
#define USB_MCFG_EHCCLKEN (1<<17)
|
|
#ifdef CONFIG_DMA_COHERENT
|
|
#define USB_MCFG_UCAM (1<<7)
|
|
#else
|
|
#define USB_MCFG_UCAM (0)
|
|
#endif
|
|
#define USB_MCFG_EBMEN (1<<3)
|
|
#define USB_MCFG_EMEMEN (1<<2)
|
|
|
|
#define USBH_ENABLE_CE (USB_MCFG_PHYPLLEN | USB_MCFG_EHCCLKEN)
|
|
#define USBH_ENABLE_INIT (USB_MCFG_PFEN | USB_MCFG_RDCOMB | \
|
|
USBH_ENABLE_CE | USB_MCFG_SSDEN | \
|
|
USB_MCFG_UCAM | USB_MCFG_EBMEN | \
|
|
USB_MCFG_EMEMEN)
|
|
|
|
#define USBH_DISABLE (USB_MCFG_EBMEN | USB_MCFG_EMEMEN)
|
|
|
|
extern int usb_disabled(void);
|
|
|
|
static void au1xxx_start_ehc(void)
|
|
{
|
|
/* enable clock to EHCI block and HS PHY PLL*/
|
|
au_writel(au_readl(USB_HOST_CONFIG) | USBH_ENABLE_CE, USB_HOST_CONFIG);
|
|
au_sync();
|
|
udelay(1000);
|
|
|
|
/* enable EHCI mmio */
|
|
au_writel(au_readl(USB_HOST_CONFIG) | USBH_ENABLE_INIT, USB_HOST_CONFIG);
|
|
au_sync();
|
|
udelay(1000);
|
|
}
|
|
|
|
static void au1xxx_stop_ehc(void)
|
|
{
|
|
unsigned long c;
|
|
|
|
/* Disable mem */
|
|
au_writel(au_readl(USB_HOST_CONFIG) & ~USBH_DISABLE, USB_HOST_CONFIG);
|
|
au_sync();
|
|
udelay(1000);
|
|
|
|
/* Disable EHC clock. If the HS PHY is unused disable it too. */
|
|
c = au_readl(USB_HOST_CONFIG) & ~USB_MCFG_EHCCLKEN;
|
|
if (!(c & USB_MCFG_UCECLKEN)) /* UDC disabled? */
|
|
c &= ~USB_MCFG_PHYPLLEN; /* yes: disable HS PHY PLL */
|
|
au_writel(c, USB_HOST_CONFIG);
|
|
au_sync();
|
|
}
|
|
|
|
static int au1xxx_ehci_setup(struct usb_hcd *hcd)
|
|
{
|
|
struct ehci_hcd *ehci = hcd_to_ehci(hcd);
|
|
int ret = ehci_init(hcd);
|
|
|
|
ehci->need_io_watchdog = 0;
|
|
return ret;
|
|
}
|
|
|
|
static const struct hc_driver ehci_au1xxx_hc_driver = {
|
|
.description = hcd_name,
|
|
.product_desc = "Au1xxx EHCI",
|
|
.hcd_priv_size = sizeof(struct ehci_hcd),
|
|
|
|
/*
|
|
* generic hardware linkage
|
|
*/
|
|
.irq = ehci_irq,
|
|
.flags = HCD_MEMORY | HCD_USB2,
|
|
|
|
/*
|
|
* basic lifecycle operations
|
|
*
|
|
* FIXME -- ehci_init() doesn't do enough here.
|
|
* See ehci-ppc-soc for a complete implementation.
|
|
*/
|
|
.reset = au1xxx_ehci_setup,
|
|
.start = ehci_run,
|
|
.stop = ehci_stop,
|
|
.shutdown = ehci_shutdown,
|
|
|
|
/*
|
|
* managing i/o requests and associated device resources
|
|
*/
|
|
.urb_enqueue = ehci_urb_enqueue,
|
|
.urb_dequeue = ehci_urb_dequeue,
|
|
.endpoint_disable = ehci_endpoint_disable,
|
|
.endpoint_reset = ehci_endpoint_reset,
|
|
|
|
/*
|
|
* scheduling support
|
|
*/
|
|
.get_frame_number = ehci_get_frame,
|
|
|
|
/*
|
|
* root hub support
|
|
*/
|
|
.hub_status_data = ehci_hub_status_data,
|
|
.hub_control = ehci_hub_control,
|
|
.bus_suspend = ehci_bus_suspend,
|
|
.bus_resume = ehci_bus_resume,
|
|
.relinquish_port = ehci_relinquish_port,
|
|
.port_handed_over = ehci_port_handed_over,
|
|
|
|
.clear_tt_buffer_complete = ehci_clear_tt_buffer_complete,
|
|
};
|
|
|
|
static int ehci_hcd_au1xxx_drv_probe(struct platform_device *pdev)
|
|
{
|
|
struct usb_hcd *hcd;
|
|
struct ehci_hcd *ehci;
|
|
struct resource *res;
|
|
int ret;
|
|
|
|
if (usb_disabled())
|
|
return -ENODEV;
|
|
|
|
#if defined(CONFIG_SOC_AU1200) && defined(CONFIG_DMA_COHERENT)
|
|
/* Au1200 AB USB does not support coherent memory */
|
|
if (!(read_c0_prid() & 0xff)) {
|
|
printk(KERN_INFO "%s: this is chip revision AB!\n", pdev->name);
|
|
printk(KERN_INFO "%s: update your board or re-configure"
|
|
" the kernel\n", pdev->name);
|
|
return -ENODEV;
|
|
}
|
|
#endif
|
|
|
|
if (pdev->resource[1].flags != IORESOURCE_IRQ) {
|
|
pr_debug("resource[1] is not IORESOURCE_IRQ");
|
|
return -ENOMEM;
|
|
}
|
|
hcd = usb_create_hcd(&ehci_au1xxx_hc_driver, &pdev->dev, "Au1xxx");
|
|
if (!hcd)
|
|
return -ENOMEM;
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
hcd->rsrc_start = res->start;
|
|
hcd->rsrc_len = resource_size(res);
|
|
|
|
if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len, hcd_name)) {
|
|
pr_debug("request_mem_region failed");
|
|
ret = -EBUSY;
|
|
goto err1;
|
|
}
|
|
|
|
hcd->regs = ioremap(hcd->rsrc_start, hcd->rsrc_len);
|
|
if (!hcd->regs) {
|
|
pr_debug("ioremap failed");
|
|
ret = -ENOMEM;
|
|
goto err2;
|
|
}
|
|
|
|
au1xxx_start_ehc();
|
|
|
|
ehci = hcd_to_ehci(hcd);
|
|
ehci->caps = hcd->regs;
|
|
ehci->regs = hcd->regs + HC_LENGTH(readl(&ehci->caps->hc_capbase));
|
|
/* cache this readonly data; minimize chip reads */
|
|
ehci->hcs_params = readl(&ehci->caps->hcs_params);
|
|
|
|
ret = usb_add_hcd(hcd, pdev->resource[1].start,
|
|
IRQF_DISABLED | IRQF_SHARED);
|
|
if (ret == 0) {
|
|
platform_set_drvdata(pdev, hcd);
|
|
return ret;
|
|
}
|
|
|
|
au1xxx_stop_ehc();
|
|
iounmap(hcd->regs);
|
|
err2:
|
|
release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
|
|
err1:
|
|
usb_put_hcd(hcd);
|
|
return ret;
|
|
}
|
|
|
|
static int ehci_hcd_au1xxx_drv_remove(struct platform_device *pdev)
|
|
{
|
|
struct usb_hcd *hcd = platform_get_drvdata(pdev);
|
|
|
|
usb_remove_hcd(hcd);
|
|
iounmap(hcd->regs);
|
|
release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
|
|
usb_put_hcd(hcd);
|
|
au1xxx_stop_ehc();
|
|
platform_set_drvdata(pdev, NULL);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
static int ehci_hcd_au1xxx_drv_suspend(struct device *dev)
|
|
{
|
|
struct usb_hcd *hcd = dev_get_drvdata(dev);
|
|
struct ehci_hcd *ehci = hcd_to_ehci(hcd);
|
|
unsigned long flags;
|
|
int rc;
|
|
|
|
return 0;
|
|
rc = 0;
|
|
|
|
if (time_before(jiffies, ehci->next_statechange))
|
|
msleep(10);
|
|
|
|
/* Root hub was already suspended. Disable irq emission and
|
|
* mark HW unaccessible. The PM and USB cores make sure that
|
|
* the root hub is either suspended or stopped.
|
|
*/
|
|
ehci_prepare_ports_for_controller_suspend(ehci, device_may_wakeup(dev));
|
|
spin_lock_irqsave(&ehci->lock, flags);
|
|
ehci_writel(ehci, 0, &ehci->regs->intr_enable);
|
|
(void)ehci_readl(ehci, &ehci->regs->intr_enable);
|
|
|
|
clear_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
|
|
|
|
au1xxx_stop_ehc();
|
|
spin_unlock_irqrestore(&ehci->lock, flags);
|
|
|
|
// could save FLADJ in case of Vaux power loss
|
|
// ... we'd only use it to handle clock skew
|
|
|
|
return rc;
|
|
}
|
|
|
|
static int ehci_hcd_au1xxx_drv_resume(struct device *dev)
|
|
{
|
|
struct usb_hcd *hcd = dev_get_drvdata(dev);
|
|
struct ehci_hcd *ehci = hcd_to_ehci(hcd);
|
|
|
|
au1xxx_start_ehc();
|
|
|
|
// maybe restore FLADJ
|
|
|
|
if (time_before(jiffies, ehci->next_statechange))
|
|
msleep(100);
|
|
|
|
/* Mark hardware accessible again as we are out of D3 state by now */
|
|
set_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
|
|
|
|
/* If CF is still set, we maintained PCI Vaux power.
|
|
* Just undo the effect of ehci_pci_suspend().
|
|
*/
|
|
if (ehci_readl(ehci, &ehci->regs->configured_flag) == FLAG_CF) {
|
|
int mask = INTR_MASK;
|
|
|
|
ehci_prepare_ports_for_controller_resume(ehci);
|
|
if (!hcd->self.root_hub->do_remote_wakeup)
|
|
mask &= ~STS_PCD;
|
|
ehci_writel(ehci, mask, &ehci->regs->intr_enable);
|
|
ehci_readl(ehci, &ehci->regs->intr_enable);
|
|
return 0;
|
|
}
|
|
|
|
ehci_dbg(ehci, "lost power, restarting\n");
|
|
usb_root_hub_lost_power(hcd->self.root_hub);
|
|
|
|
/* Else reset, to cope with power loss or flush-to-storage
|
|
* style "resume" having let BIOS kick in during reboot.
|
|
*/
|
|
(void) ehci_halt(ehci);
|
|
(void) ehci_reset(ehci);
|
|
|
|
/* emptying the schedule aborts any urbs */
|
|
spin_lock_irq(&ehci->lock);
|
|
if (ehci->reclaim)
|
|
end_unlink_async(ehci);
|
|
ehci_work(ehci);
|
|
spin_unlock_irq(&ehci->lock);
|
|
|
|
ehci_writel(ehci, ehci->command, &ehci->regs->command);
|
|
ehci_writel(ehci, FLAG_CF, &ehci->regs->configured_flag);
|
|
ehci_readl(ehci, &ehci->regs->command); /* unblock posted writes */
|
|
|
|
/* here we "know" root ports should always stay powered */
|
|
ehci_port_power(ehci, 1);
|
|
|
|
hcd->state = HC_STATE_SUSPENDED;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct dev_pm_ops au1xxx_ehci_pmops = {
|
|
.suspend = ehci_hcd_au1xxx_drv_suspend,
|
|
.resume = ehci_hcd_au1xxx_drv_resume,
|
|
};
|
|
|
|
#define AU1XXX_EHCI_PMOPS &au1xxx_ehci_pmops
|
|
|
|
#else
|
|
#define AU1XXX_EHCI_PMOPS NULL
|
|
#endif
|
|
|
|
static struct platform_driver ehci_hcd_au1xxx_driver = {
|
|
.probe = ehci_hcd_au1xxx_drv_probe,
|
|
.remove = ehci_hcd_au1xxx_drv_remove,
|
|
.shutdown = usb_hcd_platform_shutdown,
|
|
.driver = {
|
|
.name = "au1xxx-ehci",
|
|
.owner = THIS_MODULE,
|
|
.pm = AU1XXX_EHCI_PMOPS,
|
|
}
|
|
};
|
|
|
|
MODULE_ALIAS("platform:au1xxx-ehci");
|