mirror of
https://github.com/torvalds/linux.git
synced 2024-11-18 18:11:56 +00:00
125450f814
When the PCI hotplug core and its first user, cpqphp, were introduced in February 2002 with historic commit a8a2069f432c, cpqphp allocated a slot struct for its internal use plus a hotplug_slot struct to be registered with the hotplug core and linked the two with pointers: https://git.kernel.org/tglx/history/c/a8a2069f432c Nowadays, the predominant pattern in the tree is to embed ("subclass") such structures in one another and cast to the containing struct with container_of(). But it wasn't until July 2002 that container_of() was introduced with historic commit ec4f214232cf: https://git.kernel.org/tglx/history/c/ec4f214232cf pnv_php, introduced in 2016, did the right thing and embedded struct hotplug_slot in its internal struct pnv_php_slot, but all other drivers cargo-culted cpqphp's design and linked separate structs with pointers. Embedding structs is preferrable to linking them with pointers because it requires fewer allocations, thereby reducing overhead and simplifying error paths. Casting an embedded struct to the containing struct becomes a cheap subtraction rather than a dereference. And having fewer pointers reduces the risk of them pointing nowhere either accidentally or due to an attack. Convert all drivers to embed struct hotplug_slot in their internal slot struct. The "private" pointer in struct hotplug_slot thereby becomes unused, so drop it. Signed-off-by: Lukas Wunner <lukas@wunner.de> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> # drivers/pci/hotplug/rpa* Acked-by: Sebastian Ott <sebott@linux.ibm.com> # drivers/pci/hotplug/s390* Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> # drivers/platform/x86 Cc: Len Brown <lenb@kernel.org> Cc: Scott Murray <scott@spiteful.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Oliver OHalloran <oliveroh@au1.ibm.com> Cc: Gavin Shan <gwshan@linux.vnet.ibm.com> Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com> Cc: Corentin Chary <corentin.chary@gmail.com> Cc: Darren Hart <dvhart@infradead.org>
102 lines
2.6 KiB
C
102 lines
2.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* CompactPCI Hot Plug Core Functions
|
|
*
|
|
* Copyright (C) 2002 SOMA Networks, Inc.
|
|
* Copyright (C) 2001 Greg Kroah-Hartman (greg@kroah.com)
|
|
* Copyright (C) 2001 IBM Corp.
|
|
*
|
|
* All rights reserved.
|
|
*
|
|
* Send feedback to <scottm@somanetworks.com>
|
|
*/
|
|
|
|
#ifndef _CPCI_HOTPLUG_H
|
|
#define _CPCI_HOTPLUG_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/pci_hotplug.h>
|
|
|
|
/* PICMG 2.1 R2.0 HS CSR bits: */
|
|
#define HS_CSR_INS 0x0080
|
|
#define HS_CSR_EXT 0x0040
|
|
#define HS_CSR_PI 0x0030
|
|
#define HS_CSR_LOO 0x0008
|
|
#define HS_CSR_PIE 0x0004
|
|
#define HS_CSR_EIM 0x0002
|
|
#define HS_CSR_DHA 0x0001
|
|
|
|
struct slot {
|
|
u8 number;
|
|
unsigned int devfn;
|
|
struct pci_bus *bus;
|
|
struct pci_dev *dev;
|
|
unsigned int latch_status:1;
|
|
unsigned int adapter_status:1;
|
|
unsigned int extracting;
|
|
struct hotplug_slot hotplug_slot;
|
|
struct list_head slot_list;
|
|
};
|
|
|
|
struct cpci_hp_controller_ops {
|
|
int (*query_enum)(void);
|
|
int (*enable_irq)(void);
|
|
int (*disable_irq)(void);
|
|
int (*check_irq)(void *dev_id);
|
|
int (*hardware_test)(struct slot *slot, u32 value);
|
|
u8 (*get_power)(struct slot *slot);
|
|
int (*set_power)(struct slot *slot, int value);
|
|
};
|
|
|
|
struct cpci_hp_controller {
|
|
unsigned int irq;
|
|
unsigned long irq_flags;
|
|
char *devname;
|
|
void *dev_id;
|
|
char *name;
|
|
struct cpci_hp_controller_ops *ops;
|
|
};
|
|
|
|
static inline const char *slot_name(struct slot *slot)
|
|
{
|
|
return hotplug_slot_name(&slot->hotplug_slot);
|
|
}
|
|
|
|
static inline struct slot *to_slot(struct hotplug_slot *hotplug_slot)
|
|
{
|
|
return container_of(hotplug_slot, struct slot, hotplug_slot);
|
|
}
|
|
|
|
int cpci_hp_register_controller(struct cpci_hp_controller *controller);
|
|
int cpci_hp_unregister_controller(struct cpci_hp_controller *controller);
|
|
int cpci_hp_register_bus(struct pci_bus *bus, u8 first, u8 last);
|
|
int cpci_hp_unregister_bus(struct pci_bus *bus);
|
|
int cpci_hp_start(void);
|
|
int cpci_hp_stop(void);
|
|
|
|
/*
|
|
* Internal function prototypes, these functions should not be used by
|
|
* board/chassis drivers.
|
|
*/
|
|
u8 cpci_get_attention_status(struct slot *slot);
|
|
u8 cpci_get_latch_status(struct slot *slot);
|
|
u8 cpci_get_adapter_status(struct slot *slot);
|
|
u16 cpci_get_hs_csr(struct slot *slot);
|
|
int cpci_set_attention_status(struct slot *slot, int status);
|
|
int cpci_check_and_clear_ins(struct slot *slot);
|
|
int cpci_check_ext(struct slot *slot);
|
|
int cpci_clear_ext(struct slot *slot);
|
|
int cpci_led_on(struct slot *slot);
|
|
int cpci_led_off(struct slot *slot);
|
|
int cpci_configure_slot(struct slot *slot);
|
|
int cpci_unconfigure_slot(struct slot *slot);
|
|
|
|
#ifdef CONFIG_HOTPLUG_PCI_CPCI
|
|
int cpci_hotplug_init(int debug);
|
|
#else
|
|
static inline int cpci_hotplug_init(int debug) { return 0; }
|
|
#endif
|
|
|
|
#endif /* _CPCI_HOTPLUG_H */
|