Kees Cook 161d179261 net: core: Distribute switch variables for initialization ... Variables declared in a switch statement before any case statements cannot be automatically initialized with compiler instrumentation (as they are not part of any execution flow). With GCC's proposed automatic stack variable initialization feature, this triggers a warning (and they don't get initialized). Clang's automatic stack variable initialization (via CONFIG_INIT_STACK_ALL=y) doesn't throw a warning, but it also doesn't initialize such variables[1]. Note that these warnings (or silent skipping) happen before the dead-store elimination optimization phase, so even when the automatic initializations are later elided in favor of direct initializations, the warnings remain. To avoid these problems, move such variables into the "case" where they're used or lift them up into the main function body. net/core/skbuff.c: In function ‘skb_checksum_setup_ip’: net/core/skbuff.c:4809:7: warning: statement will never be executed [-Wswitch-unreachable] 4809 | int err; | ^~~ [1] https://bugs.llvm.org/show_bug.cgi?id=44916 Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-02-20 10:00:19 -08:00
..
bpf_sk_storage.c	bpf: Improve bucket_log calculation logic	2020-02-07 23:01:41 +01:00
datagram.c	net: add queue argument to __skb_wait_for_more_packets and __skb_{,try_}recv_datagram	2019-12-09 09:59:07 +01:00
datagram.h	net/core: Allow the compiler to verify declaration and definition consistency	2019-03-27 13:49:44 -07:00
dev_addr_lists.c	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
dev_ioctl.c	net: Introduce peer to peer one step PTP time stamping.	2019-12-25 19:51:34 -08:00
dev.c	Revert "net: dev: introduce support for sch BYPASS for lockless qdisc"	2020-02-18 12:37:45 -08:00
devlink.c	devlink: report 0 after hitting end in region read	2020-02-05 14:23:20 +01:00
drop_monitor.c	drop_monitor: Do not cancel uninitialized work item	2020-02-07 18:48:36 +01:00
dst_cache.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
dst.c	net: print proper warning on dst underflow	2019-09-26 09:05:56 +02:00
failover.c	failover: allow name change on IFF_UP slave interfaces	2019-04-10 22:12:26 -07:00
fib_notifier.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
fib_rules.c	net: fib_rules: Correctly set table field when table number exceeds 8 bits	2020-02-16 18:38:24 -08:00
filter.c	treewide: remove redundant IS_ERR() before error code check	2020-02-04 03:05:27 +00:00
flow_dissector.c	flow_dissector: Fix to use new variables for port ranges in bpf hook	2020-01-27 11:25:07 +01:00
flow_offload.c	net: core: rename indirect block ingress cb function	2019-12-06 20:45:09 -08:00
gen_estimator.c	net_sched: gen_estimator: extend packet counter to 64bit	2019-11-06 21:51:36 -08:00
gen_stats.c	net_sched: add TCA_STATS_PKT64 attribute	2019-11-05 18:20:55 -08:00
gro_cells.c	gro_cells: make sure device is up in gro_cells_receive()	2019-03-10 11:07:14 -07:00
hwbm.c	net: hwbm: Make the hwbm_pool lock a mutex	2019-06-09 19:40:10 -07:00
link_watch.c	net: link_watch: prevent starvation when processing linkwatch wq	2019-07-01 19:02:47 -07:00
lwt_bpf.c	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2019-12-04 12:27:13 -08:00
lwtunnel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
Makefile	ethtool: move to its own directory	2019-12-12 17:07:05 -08:00
neighbour.c	neigh_stat_seq_next() should increase position index	2020-01-24 11:42:18 +01:00
net_namespace.c	netns: Constify exported functions	2020-01-17 13:25:24 +01:00
net-procfs.c	net: procfs: use index hashlist instead of name hashlist	2019-10-01 14:47:19 -07:00
net-sysfs.c	net-sysfs: Call dev_hold always in rx_queue_add_kobject	2019-12-17 22:57:11 -08:00
net-sysfs.h
net-traces.c	page_pool: add tracepoints for page_pool with details need by XDP	2019-06-19 11:23:13 -04:00
netclassid_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netevent.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netpoll.c	net: fix skb use after free in netpoll	2019-08-27 20:52:02 -07:00
netprio_cgroup.c	netprio: use css ID instead of cgroup ID	2019-11-12 08:18:03 -08:00
page_pool.c	page_pool: refill page when alloc.count of pool is zero	2020-02-13 14:11:51 -08:00
pktgen.c	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
ptp_classifier.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
request_sock.c	tcp: add rcu protection around tp->fastopen_rsk	2019-10-13 10:13:08 -07:00
rtnetlink.c	net: rtnetlink: fix bugs in rtnl_alt_ifname()	2020-02-16 18:51:59 -08:00
scm.c	y2038: socket: remove timespec reference in timestamping	2019-11-15 14:38:29 +01:00
secure_seq.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
skbuff.c	net: core: Distribute switch variables for initialization	2020-02-20 10:00:19 -08:00
skmsg.c	net, sk_msg: Don't check if sock is locked when tearing down psock	2020-01-22 20:30:20 +01:00
sock_diag.c	sock: make cookie generation global instead of per netns	2019-08-09 13:14:46 -07:00
sock_map.c	bpf, sockhash: Synchronize_rcu before free'ing map	2020-02-07 22:36:26 +01:00
sock_reuseport.c	soreuseport: Cleanup duplicate initialization of more_reuse->max_socks.	2020-01-27 11:01:16 +01:00
sock.c	xsk, net: Make sock_def_readable() have external linkage	2020-01-22 00:08:52 +01:00
stream.c	tcp: make sure EPOLLOUT wont be missed	2019-08-19 13:07:43 -07:00
sysctl_net_core.c	net, sysctl: Fix compiler warning when only cBPF is present	2019-12-19 17:17:51 +01:00
timestamping.c	net: Introduce a new MII time stamping interface.	2019-12-25 19:51:33 -08:00
tso.c	net: Use skb accessors in network core	2019-07-22 20:47:56 -07:00
utils.c	net: Fix skb->csum update in inet_proto_csum_replace16().	2020-01-24 20:54:30 +01:00
xdp.c	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00