mirror of
https://github.com/torvalds/linux.git
synced 2024-11-15 00:21:59 +00:00
3c938cc5ce
In case of PREEMPT_RT, there is a raw_spinlock -> spinlock dependency as the lockdep report shows. __irq_set_handler irq_get_desc_buslock __irq_get_desc_lock raw_spin_lock_irqsave(&desc->lock, *flags); // raw spinlock get here __irq_do_set_handler mask_ack_irq dwapb_irq_ack spin_lock_irqsave(&gc->bgpio_lock, flags); // sleep able spinlock irq_put_desc_busunlock Replace with a raw lock to avoid BUGs. This lock is only used to access registers, and It's safe to replace with the raw lock without bad influence. [ 15.090359][ T1] ============================= [ 15.090365][ T1] [ BUG: Invalid wait context ] [ 15.090373][ T1] 5.10.59-rt52-00983-g186a6841c682-dirty #3 Not tainted [ 15.090386][ T1] ----------------------------- [ 15.090392][ T1] swapper/0/1 is trying to lock: [ 15.090402][ T1] 70ff00018507c188 (&gc->bgpio_lock){....}-{3:3}, at: _raw_spin_lock_irqsave+0x1c/0x28 [ 15.090470][ T1] other info that might help us debug this: [ 15.090477][ T1] context-{5:5} [ 15.090485][ T1] 3 locks held by swapper/0/1: [ 15.090497][ T1] #0: c2ff0001816de1a0 (&dev->mutex){....}-{4:4}, at: __device_driver_lock+0x98/0x104 [ 15.090553][ T1] #1: ffff90001485b4b8 (irq_domain_mutex){+.+.}-{4:4}, at: irq_domain_associate+0xbc/0x6d4 [ 15.090606][ T1] #2: 4bff000185d7a8e0 (lock_class){....}-{2:2}, at: _raw_spin_lock_irqsave+0x1c/0x28 [ 15.090654][ T1] stack backtrace: [ 15.090661][ T1] CPU: 4 PID: 1 Comm: swapper/0 Not tainted 5.10.59-rt52-00983-g186a6841c682-dirty #3 [ 15.090682][ T1] Hardware name: Horizon Robotics Journey 5 DVB (DT) [ 15.090692][ T1] Call trace: ...... [ 15.090811][ T1] _raw_spin_lock_irqsave+0x1c/0x28 [ 15.090828][ T1] dwapb_irq_ack+0xb4/0x300 [ 15.090846][ T1] __irq_do_set_handler+0x494/0xb2c [ 15.090864][ T1] __irq_set_handler+0x74/0x114 [ 15.090881][ T1] irq_set_chip_and_handler_name+0x44/0x58 [ 15.090900][ T1] gpiochip_irq_map+0x210/0x644 Signed-off-by: Schspa Shi <schspa@gmail.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Doug Berger <opendmb@gmail.com> Acked-by: Serge Semin <fancer.lancer@gmail.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
207 lines
5.2 KiB
C
207 lines
5.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Driver for IDT/Renesas 79RC3243x Interrupt Controller */
|
|
|
|
#include <linux/bitops.h>
|
|
#include <linux/gpio/driver.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/module.h>
|
|
#include <linux/mod_devicetable.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/spinlock.h>
|
|
|
|
#define IDT_PIC_IRQ_PEND 0x00
|
|
#define IDT_PIC_IRQ_MASK 0x08
|
|
|
|
#define IDT_GPIO_DIR 0x00
|
|
#define IDT_GPIO_DATA 0x04
|
|
#define IDT_GPIO_ILEVEL 0x08
|
|
#define IDT_GPIO_ISTAT 0x0C
|
|
|
|
struct idt_gpio_ctrl {
|
|
struct gpio_chip gc;
|
|
void __iomem *pic;
|
|
void __iomem *gpio;
|
|
u32 mask_cache;
|
|
};
|
|
|
|
static void idt_gpio_dispatch(struct irq_desc *desc)
|
|
{
|
|
struct gpio_chip *gc = irq_desc_get_handler_data(desc);
|
|
struct idt_gpio_ctrl *ctrl = gpiochip_get_data(gc);
|
|
struct irq_chip *host_chip = irq_desc_get_chip(desc);
|
|
unsigned int bit, virq;
|
|
unsigned long pending;
|
|
|
|
chained_irq_enter(host_chip, desc);
|
|
|
|
pending = readl(ctrl->pic + IDT_PIC_IRQ_PEND);
|
|
pending &= ~ctrl->mask_cache;
|
|
for_each_set_bit(bit, &pending, gc->ngpio) {
|
|
virq = irq_linear_revmap(gc->irq.domain, bit);
|
|
if (virq)
|
|
generic_handle_irq(virq);
|
|
}
|
|
|
|
chained_irq_exit(host_chip, desc);
|
|
}
|
|
|
|
static int idt_gpio_irq_set_type(struct irq_data *d, unsigned int flow_type)
|
|
{
|
|
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
|
|
struct idt_gpio_ctrl *ctrl = gpiochip_get_data(gc);
|
|
unsigned int sense = flow_type & IRQ_TYPE_SENSE_MASK;
|
|
unsigned long flags;
|
|
u32 ilevel;
|
|
|
|
/* hardware only supports level triggered */
|
|
if (sense == IRQ_TYPE_NONE || (sense & IRQ_TYPE_EDGE_BOTH))
|
|
return -EINVAL;
|
|
|
|
raw_spin_lock_irqsave(&gc->bgpio_lock, flags);
|
|
|
|
ilevel = readl(ctrl->gpio + IDT_GPIO_ILEVEL);
|
|
if (sense & IRQ_TYPE_LEVEL_HIGH)
|
|
ilevel |= BIT(d->hwirq);
|
|
else if (sense & IRQ_TYPE_LEVEL_LOW)
|
|
ilevel &= ~BIT(d->hwirq);
|
|
|
|
writel(ilevel, ctrl->gpio + IDT_GPIO_ILEVEL);
|
|
irq_set_handler_locked(d, handle_level_irq);
|
|
|
|
raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags);
|
|
return 0;
|
|
}
|
|
|
|
static void idt_gpio_ack(struct irq_data *d)
|
|
{
|
|
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
|
|
struct idt_gpio_ctrl *ctrl = gpiochip_get_data(gc);
|
|
|
|
writel(~BIT(d->hwirq), ctrl->gpio + IDT_GPIO_ISTAT);
|
|
}
|
|
|
|
static void idt_gpio_mask(struct irq_data *d)
|
|
{
|
|
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
|
|
struct idt_gpio_ctrl *ctrl = gpiochip_get_data(gc);
|
|
unsigned long flags;
|
|
|
|
raw_spin_lock_irqsave(&gc->bgpio_lock, flags);
|
|
|
|
ctrl->mask_cache |= BIT(d->hwirq);
|
|
writel(ctrl->mask_cache, ctrl->pic + IDT_PIC_IRQ_MASK);
|
|
|
|
raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags);
|
|
}
|
|
|
|
static void idt_gpio_unmask(struct irq_data *d)
|
|
{
|
|
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
|
|
struct idt_gpio_ctrl *ctrl = gpiochip_get_data(gc);
|
|
unsigned long flags;
|
|
|
|
raw_spin_lock_irqsave(&gc->bgpio_lock, flags);
|
|
|
|
ctrl->mask_cache &= ~BIT(d->hwirq);
|
|
writel(ctrl->mask_cache, ctrl->pic + IDT_PIC_IRQ_MASK);
|
|
|
|
raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags);
|
|
}
|
|
|
|
static int idt_gpio_irq_init_hw(struct gpio_chip *gc)
|
|
{
|
|
struct idt_gpio_ctrl *ctrl = gpiochip_get_data(gc);
|
|
|
|
/* Mask interrupts. */
|
|
ctrl->mask_cache = 0xffffffff;
|
|
writel(ctrl->mask_cache, ctrl->pic + IDT_PIC_IRQ_MASK);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct irq_chip idt_gpio_irqchip = {
|
|
.name = "IDTGPIO",
|
|
.irq_mask = idt_gpio_mask,
|
|
.irq_ack = idt_gpio_ack,
|
|
.irq_unmask = idt_gpio_unmask,
|
|
.irq_set_type = idt_gpio_irq_set_type
|
|
};
|
|
|
|
static int idt_gpio_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct gpio_irq_chip *girq;
|
|
struct idt_gpio_ctrl *ctrl;
|
|
int parent_irq;
|
|
int ngpios;
|
|
int ret;
|
|
|
|
|
|
ctrl = devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL);
|
|
if (!ctrl)
|
|
return -ENOMEM;
|
|
|
|
ctrl->gpio = devm_platform_ioremap_resource_byname(pdev, "gpio");
|
|
if (IS_ERR(ctrl->gpio))
|
|
return PTR_ERR(ctrl->gpio);
|
|
|
|
ctrl->gc.parent = dev;
|
|
|
|
ret = bgpio_init(&ctrl->gc, &pdev->dev, 4, ctrl->gpio + IDT_GPIO_DATA,
|
|
NULL, NULL, ctrl->gpio + IDT_GPIO_DIR, NULL, 0);
|
|
if (ret) {
|
|
dev_err(dev, "bgpio_init failed\n");
|
|
return ret;
|
|
}
|
|
|
|
ret = device_property_read_u32(dev, "ngpios", &ngpios);
|
|
if (!ret)
|
|
ctrl->gc.ngpio = ngpios;
|
|
|
|
if (device_property_read_bool(dev, "interrupt-controller")) {
|
|
ctrl->pic = devm_platform_ioremap_resource_byname(pdev, "pic");
|
|
if (IS_ERR(ctrl->pic))
|
|
return PTR_ERR(ctrl->pic);
|
|
|
|
parent_irq = platform_get_irq(pdev, 0);
|
|
if (parent_irq < 0)
|
|
return parent_irq;
|
|
|
|
girq = &ctrl->gc.irq;
|
|
girq->chip = &idt_gpio_irqchip;
|
|
girq->init_hw = idt_gpio_irq_init_hw;
|
|
girq->parent_handler = idt_gpio_dispatch;
|
|
girq->num_parents = 1;
|
|
girq->parents = devm_kcalloc(dev, girq->num_parents,
|
|
sizeof(*girq->parents),
|
|
GFP_KERNEL);
|
|
if (!girq->parents)
|
|
return -ENOMEM;
|
|
|
|
girq->parents[0] = parent_irq;
|
|
girq->default_type = IRQ_TYPE_NONE;
|
|
girq->handler = handle_bad_irq;
|
|
}
|
|
|
|
return devm_gpiochip_add_data(&pdev->dev, &ctrl->gc, ctrl);
|
|
}
|
|
|
|
static const struct of_device_id idt_gpio_of_match[] = {
|
|
{ .compatible = "idt,32434-gpio" },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, idt_gpio_of_match);
|
|
|
|
static struct platform_driver idt_gpio_driver = {
|
|
.probe = idt_gpio_probe,
|
|
.driver = {
|
|
.name = "idt3243x-gpio",
|
|
.of_match_table = idt_gpio_of_match,
|
|
},
|
|
};
|
|
module_platform_driver(idt_gpio_driver);
|
|
|
|
MODULE_DESCRIPTION("IDT 79RC3243x GPIO/PIC Driver");
|
|
MODULE_AUTHOR("Thomas Bogendoerfer <tsbogend@alpha.franken.de>");
|
|
MODULE_LICENSE("GPL");
|