linux/arch/um/drivers
Jeff Dike b4fd310e16 [PATCH] uml: preserve errno in error paths
The poster child for this patch is the third tuntap_user hunk.  When an ioctl
fails, it properly closes the opened file descriptor and returns.  However,
the close resets errno to 0, and the 'return errno' that follows returns 0
rather than the value that ioctl set.  This caused the caller to believe that
the device open succeeded and had opened file descriptor 0, which caused no
end of interesting behavior.

The rest of this patch is a pass through the UML sources looking for places
where errno could be reset before being passed back out.  A common culprit is
printk, which could call write, being called before errno is returned.

In some cases, where the code ends up being much smaller, I just deleted the
printk.

There was another case where a caller of run_helper looked at errno after a
failure, rather than the return value of run_helper, which was the errno value
that it wanted.

Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-17 11:50:00 -07:00
..
chan_kern.c [PATCH] uml: Change printf to printk in console driver 2005-05-20 15:48:19 -07:00
chan_user.c [PATCH] uml: fix SIGWINCH handler race while waiting for signals. 2005-09-05 00:06:21 -07:00
cow_sys.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cow_user.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cow.h [PATCH] turn many #if $undefined_string into #ifdef $undefined_string 2005-07-27 16:26:08 -07:00
daemon_kern.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
daemon_user.c [PATCH] uml: kfree cleanup 2005-06-25 16:24:35 -07:00
daemon.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
fd.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
harddog_kern.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
harddog_user.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
hostaudio_kern.c [PATCH] uml: update module interface 2005-07-27 16:25:48 -07:00
line.c [PATCH] uml: remove winch sem 2005-07-07 18:23:44 -07:00
Makefile [PATCH] uml: add host AIO support to block driver 2005-09-05 00:06:23 -07:00
mcast_kern.c [PATCH] uml: multicast driver cleanup 2005-05-20 15:48:17 -07:00
mcast_user.c [PATCH] uml: preserve errno in error paths 2005-09-17 11:50:00 -07:00
mcast.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
mconsole_kern.c [PATCH] uml: breakpoint an arbitrary thread 2005-09-17 11:49:59 -07:00
mconsole_user.c [PATCH] uml: preserve errno in error paths 2005-09-17 11:50:00 -07:00
mmapper_kern.c [PATCH] mmaper_kern.c fixes [buffer overruns] 2005-08-27 10:11:40 -07:00
net_kern.c [PATCH] uml: hot-unplug code cleanup 2005-06-25 16:24:36 -07:00
net_user.c [PATCH] uml: compile fixes for gcc 4 2005-06-08 16:21:12 -07:00
null.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pcap_kern.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pcap_user.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pcap_user.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
port_kern.c [PATCH] uml: add and use generic hw_controller_type->release 2005-06-21 19:07:32 -07:00
port_user.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
port.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pty.c [PATCH] uml: preserve errno in error paths 2005-09-17 11:50:00 -07:00
random.c [PATCH] uml: add MOD_LICENSE to random driver 2005-05-28 16:46:12 -07:00
slip_common.c [PATCH] uml: slirp and slip driver cleanups and fixes 2005-06-13 20:58:43 -07:00
slip_common.h [PATCH] uml: slirp and slip driver cleanups and fixes 2005-06-13 20:58:43 -07:00
slip_kern.c [PATCH] uml: slirp and slip driver cleanups and fixes 2005-06-13 20:58:43 -07:00
slip_user.c [PATCH] uml: slirp and slip driver cleanups and fixes 2005-06-13 20:58:43 -07:00
slip.h [PATCH] uml: slirp and slip driver cleanups and fixes 2005-06-13 20:58:43 -07:00
slirp_kern.c [PATCH] uml: slirp and slip driver cleanups and fixes 2005-06-13 20:58:43 -07:00
slirp_user.c [PATCH] uml: slirp and slip driver cleanups and fixes 2005-06-13 20:58:43 -07:00
slirp.h [PATCH] uml: slirp and slip driver cleanups and fixes 2005-06-13 20:58:43 -07:00
ssl.c [PATCH] uml: hot-unplug code cleanup 2005-06-25 16:24:36 -07:00
ssl.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
stderr_console.c [PATCH] uml: compile fixes for gcc 4 2005-06-08 16:21:12 -07:00
stdio_console.c [PATCH] uml: hot-unplug code cleanup 2005-06-25 16:24:36 -07:00
stdio_console.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
tty.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ubd_kern.c [PATCH] uml: add host AIO support to block driver 2005-09-05 00:06:23 -07:00
xterm_kern.c [PATCH] uml: add and use generic hw_controller_type->release 2005-06-21 19:07:32 -07:00
xterm.c [PATCH] uml: preserve errno in error paths 2005-09-17 11:50:00 -07:00
xterm.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00