Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-26 21:02:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
b0e302b408
linux/drivers/staging/goldfish
History
Arnd Bergmann b0e302b408 staging: goldfish: use div64_s64 instead of do_div 
The goldfish nand driver divides a signed 64-bit number (loff_t)
in multiple places using the do_div() function. This has always
been unreliable but now produces a compiler warning (since 4.5-rc1):

goldfish/goldfish_nand.c: In function 'goldfish_nand_erase':
goldfish/goldfish_nand.c:107:91: error: comparison of distinct pointer types lacks a cast [-Werror]
goldfish/goldfish_nand.c: In function 'goldfish_nand_read_oob':
goldfish/goldfish_nand.c:145:91: error: comparison of distinct pointer types lacks a cast [-Werror]

This changes the code to the equivalent div_s64{,_rem} that
works correctly for negative numbers (which we should never
get here).

The warning has shown up on ARM allmodconfig builds after the goldfish
bus driver has become visible on ARM.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: bd2f348db5 ("goldfish: refactor goldfish platform configs")
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-07 18:26:36 -08:00
..
goldfish_audio.c staging: goldfish: Fix pointer cast for 32 bits 2015-05-31 11:40:14 +09:00
goldfish_nand_reg.h staging: goldfish: Prefer kernel type u32 over uint32_t 2015-09-12 18:24:38 -07:00
goldfish_nand.c staging: goldfish: use div64_s64 instead of do_div 2016-02-07 18:26:36 -08:00
Kconfig
Makefile
README staging: goldfish: switch from spinlock to mutex 2014-04-16 20:12:55 -07:00

README 

Audio
-----
- Move to using the ALSA framework not faking it
- Fix the wrong user page DMA (moving to ALSA may fix that too)

NAND
----
- Remove excess checking of parameters in calls
- Use dma coherent memory not kmalloc/__pa for the memory (this is just
  a cleanliness issue not a correctness one)