linux/drivers/isdn/hysdn
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
boardergo.c isdn: whitespace coding style cleanup 2012-02-21 09:04:01 -08:00
boardergo.h isdn: whitespace coding style cleanup 2012-02-21 09:04:01 -08:00
hycapi.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
hysdn_boot.c Replace <asm/uaccess.h> with <linux/uaccess.h> globally 2016-12-24 11:46:01 -08:00
hysdn_defs.h isdn: whitespace coding style cleanup 2012-02-21 09:04:01 -08:00
hysdn_init.c Drivers: isdn: remove __dev* attributes. 2013-01-03 15:57:02 -08:00
hysdn_net.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
hysdn_pof.h isdn: whitespace coding style cleanup 2012-02-21 09:04:01 -08:00
hysdn_procconf.c procfs: new helper - PDE_DATA(inode) 2013-04-09 14:13:32 -04:00
hysdn_proclog.c isdn: divert, hysdn: fix interruptible_sleep_on race 2014-02-26 16:06:13 -05:00
hysdn_sched.c isdn: whitespace coding style cleanup 2012-02-21 09:04:01 -08:00
ince1pc.h isdn: whitespace coding style cleanup 2012-02-21 09:04:01 -08:00
Kconfig
Makefile