mirror of
https://github.com/torvalds/linux.git
synced 2024-09-21 15:33:19 +00:00
a5cd98b796
If there is more than one pca963x chips on the system and there are some LEDs without platform_data names, the driver wont be able to provide unique naming to them. This will cause led_class_dev_register to fail, unregistering all the LEDs of the chip. This patch adds the i2c address to the name of the unnamed LEDs, making them unique. [ 555.346827] ------------[ cut here ]------------ [ 555.346844] WARNING: at /build/linux-voe0Su/linux-3.9.8/fs/sysfs/dir.c:536 sysfs_add_one+0x8b/0x9d() [ 555.346847] Hardware name: QT5022 [ 555.346850] sysfs: cannot create duplicate filename '/class/leds/pca9633:6' [ 555.346853] Modules linked in: qt5038_platform(O+) leds_pca9633(O) hid_generic ledtrig_default_on rfcomm bnep bluetooth binfmt_misc nfsd auth_rpcgss nfs_acl nfs lockd dns_resolver fscache sunrpc nls_utf8 nls_cp437 vfat fat loop fuse joydev hid_multitouch usbhid hid acpi_cpufreq mperf kvm_amd kvm evdev pn533 nfc arc4 microcode pcspkr efivars k10temp ath9k ath9k_common ath9k_hw ath fglrx(PO) mac80211 cfg80211 video rfkill processor thermal_sys sp5100_tco button i2c_piix4 ext4 crc16 jbd2 mbcache sg sd_mod crc_t10dif ahci libahci igb i2c_algo_bit i2c_core dca ptp pps_core ehci_pci ohci_hcd ehci_hcd libata usbcore usb_common scsi_mod [last unloaded: leds_pca963x] [ 555.346940] Pid: 4766, comm: insmod Tainted: P W O 3.9-1-amd64 #1 Debian 3.9.8-1 [ 555.346943] Call Trace: [ 555.346956] [<ffffffff8103d153>] ? warn_slowpath_common+0x76/0x8c [ 555.346962] [<ffffffff8103d202>] ? warn_slowpath_fmt+0x47/0x49 [ 555.346968] [<ffffffff8116005d>] ? sysfs_pathname+0x3b/0x41 [ 555.346973] [<ffffffff81160767>] ? sysfs_add_one+0x8b/0x9d [ 555.346978] [<ffffffff811610a4>] ? sysfs_do_create_link_sd+0xe8/0x174 [ 555.346985] [<ffffffff81279250>] ? device_add+0x243/0x5ab [ 555.346991] [<ffffffff81060a16>] ? complete_all+0x31/0x40 [ 555.346998] [<ffffffff8104991a>] ? init_timer_key+0xc/0x56 [ 555.347004] [<ffffffff8127964c>] ? device_create_vargs+0x82/0xb6 [ 555.347009] [<ffffffff812796af>] ? device_create+0x2f/0x31 [ 555.347014] [<ffffffff81060add>] ? should_resched+0x5/0x23 [ 555.347021] [<ffffffff812a3a92>] ? led_classdev_register+0x24/0x103 [ 555.347028] [<ffffffffa09d01c0>] ? pca9633_probe+0x173/0x239 [leds_pca9633] [ 555.347035] [<ffffffff8127b504>] ? __driver_attach+0x73/0x73 [ 555.347049] [<ffffffffa009dfc9>] ? i2c_device_probe+0x63/0x88 [i2c_core] [ 555.347057] [<ffffffff8127b373>] ? driver_probe_device+0x92/0x1b0 [ 555.347064] [<ffffffff81279c5c>] ? bus_for_each_drv+0x43/0x7d [ 555.347070] [<ffffffff8127b2af>] ? device_attach+0x68/0x83 [ 555.347078] [<ffffffff8127a990>] ? bus_probe_device+0x25/0x8d [ 555.347083] [<ffffffff812793f7>] ? device_add+0x3ea/0x5ab [ 555.347088] [<ffffffff81060a16>] ? complete_all+0x31/0x40 [ 555.347094] [<ffffffff8104991a>] ? init_timer_key+0xc/0x56 [ 555.347104] [<ffffffffa009d3a1>] ? i2c_new_device+0x10d/0x179 [i2c_core] [ 555.347112] [<ffffffffa008f036>] ? qt5038_init+0x36/0x1000 [qt5038_platform] [ 555.347119] [<ffffffffa008f000>] ? 0xffffffffa008efff [ 555.347125] [<ffffffff8100209e>] ? do_one_initcall+0x74/0x128 [ 555.347131] [<ffffffffa008f000>] ? 0xffffffffa008efff [ 555.347137] [<ffffffff810836f5>] ? load_module+0x1af7/0x1dfc [ 555.347144] [<ffffffff810801c5>] ? free_notes_attrs+0x3c/0x3c [ 555.347150] [<ffffffff81083a98>] ? sys_init_module+0x9e/0xab [ 555.347157] [<ffffffff8138be29>] ? system_call_fastpath+0x16/0x1b [ 555.347161] ---[ end trace ad00b85794e0de4d ]--- [ 555.347448] leds-pca9633: probe of 0-006b failed with error -17 Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Bryan Wu <cooloney@gmail.com>
438 lines
11 KiB
C
438 lines
11 KiB
C
/*
|
|
* Copyright 2011 bct electronic GmbH
|
|
* Copyright 2013 Qtechnology/AS
|
|
*
|
|
* Author: Peter Meerwald <p.meerwald@bct-electronic.com>
|
|
* Author: Ricardo Ribalda <ricardo.ribalda@gmail.com>
|
|
*
|
|
* Based on leds-pca955x.c
|
|
*
|
|
* This file is subject to the terms and conditions of version 2 of
|
|
* the GNU General Public License. See the file COPYING in the main
|
|
* directory of this archive for more details.
|
|
*
|
|
* LED driver for the PCA9633 I2C LED driver (7-bit slave address 0x62)
|
|
* LED driver for the PCA9634 I2C LED driver (7-bit slave address set by hw.)
|
|
*
|
|
* Note that hardware blinking violates the leds infrastructure driver
|
|
* interface since the hardware only supports blinking all LEDs with the
|
|
* same delay_on/delay_off rates. That is, only the LEDs that are set to
|
|
* blink will actually blink but all LEDs that are set to blink will blink
|
|
* in identical fashion. The delay_on/delay_off values of the last LED
|
|
* that is set to blink will be used for all of the blinking LEDs.
|
|
* Hardware blinking is disabled by default but can be enabled by setting
|
|
* the 'blink_type' member in the platform_data struct to 'PCA9633_HW_BLINK'
|
|
* or by adding the 'nxp,hw-blink' property to the DTS.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/string.h>
|
|
#include <linux/ctype.h>
|
|
#include <linux/leds.h>
|
|
#include <linux/err.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/workqueue.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_data/leds-pca9633.h>
|
|
|
|
/* LED select registers determine the source that drives LED outputs */
|
|
#define PCA9633_LED_OFF 0x0 /* LED driver off */
|
|
#define PCA9633_LED_ON 0x1 /* LED driver on */
|
|
#define PCA9633_LED_PWM 0x2 /* Controlled through PWM */
|
|
#define PCA9633_LED_GRP_PWM 0x3 /* Controlled through PWM/GRPPWM */
|
|
|
|
#define PCA9633_MODE2_DMBLNK 0x20 /* Enable blinking */
|
|
|
|
#define PCA9633_MODE1 0x00
|
|
#define PCA9633_MODE2 0x01
|
|
#define PCA9633_PWM_BASE 0x02
|
|
|
|
enum pca9633_type {
|
|
pca9633,
|
|
pca9634,
|
|
};
|
|
|
|
struct pca9633_chipdef {
|
|
u8 grppwm;
|
|
u8 grpfreq;
|
|
u8 ledout_base;
|
|
int n_leds;
|
|
};
|
|
|
|
static struct pca9633_chipdef pca9633_chipdefs[] = {
|
|
[pca9633] = {
|
|
.grppwm = 0x6,
|
|
.grpfreq = 0x7,
|
|
.ledout_base = 0x8,
|
|
.n_leds = 4,
|
|
},
|
|
[pca9634] = {
|
|
.grppwm = 0xa,
|
|
.grpfreq = 0xb,
|
|
.ledout_base = 0xc,
|
|
.n_leds = 8,
|
|
},
|
|
};
|
|
|
|
/* Total blink period in milliseconds */
|
|
#define PCA9632_BLINK_PERIOD_MIN 42
|
|
#define PCA9632_BLINK_PERIOD_MAX 10667
|
|
|
|
static const struct i2c_device_id pca9633_id[] = {
|
|
{ "pca9632", pca9633 },
|
|
{ "pca9633", pca9633 },
|
|
{ "pca9634", pca9634 },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, pca9633_id);
|
|
|
|
enum pca9633_cmd {
|
|
BRIGHTNESS_SET,
|
|
BLINK_SET,
|
|
};
|
|
|
|
struct pca9633_led {
|
|
struct i2c_client *client;
|
|
struct pca9633_chipdef *chipdef;
|
|
struct work_struct work;
|
|
enum led_brightness brightness;
|
|
struct led_classdev led_cdev;
|
|
int led_num; /* 0 .. 7 potentially */
|
|
enum pca9633_cmd cmd;
|
|
char name[32];
|
|
u8 gdc;
|
|
u8 gfrq;
|
|
};
|
|
|
|
static void pca9633_brightness_work(struct pca9633_led *pca9633)
|
|
{
|
|
u8 ledout_addr = pca9633->chipdef->ledout_base + (pca9633->led_num / 4);
|
|
u8 ledout;
|
|
int shift = 2 * (pca9633->led_num % 4);
|
|
u8 mask = 0x3 << shift;
|
|
|
|
ledout = i2c_smbus_read_byte_data(pca9633->client, ledout_addr);
|
|
switch (pca9633->brightness) {
|
|
case LED_FULL:
|
|
i2c_smbus_write_byte_data(pca9633->client, ledout_addr,
|
|
(ledout & ~mask) | (PCA9633_LED_ON << shift));
|
|
break;
|
|
case LED_OFF:
|
|
i2c_smbus_write_byte_data(pca9633->client, ledout_addr,
|
|
ledout & ~mask);
|
|
break;
|
|
default:
|
|
i2c_smbus_write_byte_data(pca9633->client,
|
|
PCA9633_PWM_BASE + pca9633->led_num,
|
|
pca9633->brightness);
|
|
i2c_smbus_write_byte_data(pca9633->client, ledout_addr,
|
|
(ledout & ~mask) | (PCA9633_LED_PWM << shift));
|
|
break;
|
|
}
|
|
}
|
|
|
|
static void pca9633_blink_work(struct pca9633_led *pca9633)
|
|
{
|
|
u8 ledout_addr = pca9633->chipdef->ledout_base + (pca9633->led_num / 4);
|
|
u8 ledout = i2c_smbus_read_byte_data(pca9633->client, ledout_addr);
|
|
u8 mode2 = i2c_smbus_read_byte_data(pca9633->client, PCA9633_MODE2);
|
|
int shift = 2 * (pca9633->led_num % 4);
|
|
u8 mask = 0x3 << shift;
|
|
|
|
i2c_smbus_write_byte_data(pca9633->client, pca9633->chipdef->grppwm,
|
|
pca9633->gdc);
|
|
|
|
i2c_smbus_write_byte_data(pca9633->client, pca9633->chipdef->grpfreq,
|
|
pca9633->gfrq);
|
|
|
|
if (!(mode2 & PCA9633_MODE2_DMBLNK))
|
|
i2c_smbus_write_byte_data(pca9633->client, PCA9633_MODE2,
|
|
mode2 | PCA9633_MODE2_DMBLNK);
|
|
|
|
if ((ledout & mask) != (PCA9633_LED_GRP_PWM << shift))
|
|
i2c_smbus_write_byte_data(pca9633->client, ledout_addr,
|
|
(ledout & ~mask) | (PCA9633_LED_GRP_PWM << shift));
|
|
}
|
|
|
|
static void pca9633_work(struct work_struct *work)
|
|
{
|
|
struct pca9633_led *pca9633 = container_of(work,
|
|
struct pca9633_led, work);
|
|
|
|
switch (pca9633->cmd) {
|
|
case BRIGHTNESS_SET:
|
|
pca9633_brightness_work(pca9633);
|
|
break;
|
|
case BLINK_SET:
|
|
pca9633_blink_work(pca9633);
|
|
break;
|
|
}
|
|
}
|
|
|
|
static void pca9633_led_set(struct led_classdev *led_cdev,
|
|
enum led_brightness value)
|
|
{
|
|
struct pca9633_led *pca9633;
|
|
|
|
pca9633 = container_of(led_cdev, struct pca9633_led, led_cdev);
|
|
|
|
pca9633->cmd = BRIGHTNESS_SET;
|
|
pca9633->brightness = value;
|
|
|
|
/*
|
|
* Must use workqueue for the actual I/O since I2C operations
|
|
* can sleep.
|
|
*/
|
|
schedule_work(&pca9633->work);
|
|
}
|
|
|
|
static int pca9633_blink_set(struct led_classdev *led_cdev,
|
|
unsigned long *delay_on, unsigned long *delay_off)
|
|
{
|
|
struct pca9633_led *pca9633;
|
|
unsigned long time_on, time_off, period;
|
|
u8 gdc, gfrq;
|
|
|
|
pca9633 = container_of(led_cdev, struct pca9633_led, led_cdev);
|
|
|
|
time_on = *delay_on;
|
|
time_off = *delay_off;
|
|
|
|
/* If both zero, pick reasonable defaults of 500ms each */
|
|
if (!time_on && !time_off) {
|
|
time_on = 500;
|
|
time_off = 500;
|
|
}
|
|
|
|
period = time_on + time_off;
|
|
|
|
/* If period not supported by hardware, default to someting sane. */
|
|
if ((period < PCA9632_BLINK_PERIOD_MIN) ||
|
|
(period > PCA9632_BLINK_PERIOD_MAX)) {
|
|
time_on = 500;
|
|
time_off = 500;
|
|
period = time_on + time_off;
|
|
}
|
|
|
|
/*
|
|
* From manual: duty cycle = (GDC / 256) ->
|
|
* (time_on / period) = (GDC / 256) ->
|
|
* GDC = ((time_on * 256) / period)
|
|
*/
|
|
gdc = (time_on * 256) / period;
|
|
|
|
/*
|
|
* From manual: period = ((GFRQ + 1) / 24) in seconds.
|
|
* So, period (in ms) = (((GFRQ + 1) / 24) * 1000) ->
|
|
* GFRQ = ((period * 24 / 1000) - 1)
|
|
*/
|
|
gfrq = (period * 24 / 1000) - 1;
|
|
|
|
pca9633->cmd = BLINK_SET;
|
|
pca9633->gdc = gdc;
|
|
pca9633->gfrq = gfrq;
|
|
|
|
/*
|
|
* Must use workqueue for the actual I/O since I2C operations
|
|
* can sleep.
|
|
*/
|
|
schedule_work(&pca9633->work);
|
|
|
|
*delay_on = time_on;
|
|
*delay_off = time_off;
|
|
|
|
return 0;
|
|
}
|
|
|
|
#if IS_ENABLED(CONFIG_OF)
|
|
static struct pca9633_platform_data *
|
|
pca9633_dt_init(struct i2c_client *client, struct pca9633_chipdef *chip)
|
|
{
|
|
struct device_node *np = client->dev.of_node, *child;
|
|
struct pca9633_platform_data *pdata;
|
|
struct led_info *pca9633_leds;
|
|
int count;
|
|
|
|
count = of_get_child_count(np);
|
|
if (!count || count > chip->n_leds)
|
|
return ERR_PTR(-ENODEV);
|
|
|
|
pca9633_leds = devm_kzalloc(&client->dev,
|
|
sizeof(struct led_info) * chip->n_leds, GFP_KERNEL);
|
|
if (!pca9633_leds)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
for_each_child_of_node(np, child) {
|
|
struct led_info led;
|
|
u32 reg;
|
|
int res;
|
|
|
|
led.name =
|
|
of_get_property(child, "label", NULL) ? : child->name;
|
|
led.default_trigger =
|
|
of_get_property(child, "linux,default-trigger", NULL);
|
|
res = of_property_read_u32(child, "reg", ®);
|
|
if (res != 0)
|
|
continue;
|
|
pca9633_leds[reg] = led;
|
|
}
|
|
pdata = devm_kzalloc(&client->dev,
|
|
sizeof(struct pca9633_platform_data), GFP_KERNEL);
|
|
if (!pdata)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
pdata->leds.leds = pca9633_leds;
|
|
pdata->leds.num_leds = count;
|
|
|
|
/* default to open-drain unless totem pole (push-pull) is specified */
|
|
if (of_property_read_bool(np, "nxp,totem-pole"))
|
|
pdata->outdrv = PCA9633_TOTEM_POLE;
|
|
else
|
|
pdata->outdrv = PCA9633_OPEN_DRAIN;
|
|
|
|
/* default to software blinking unless hardware blinking is specified */
|
|
if (of_property_read_bool(np, "nxp,hw-blink"))
|
|
pdata->blink_type = PCA9633_HW_BLINK;
|
|
else
|
|
pdata->blink_type = PCA9633_SW_BLINK;
|
|
|
|
return pdata;
|
|
}
|
|
|
|
static const struct of_device_id of_pca9633_match[] = {
|
|
{ .compatible = "nxp,pca9632", },
|
|
{ .compatible = "nxp,pca9633", },
|
|
{ .compatible = "nxp,pca9634", },
|
|
{},
|
|
};
|
|
#else
|
|
static struct pca9633_platform_data *
|
|
pca9633_dt_init(struct i2c_client *client, struct pca9633_chipdef *chip)
|
|
{
|
|
return ERR_PTR(-ENODEV);
|
|
}
|
|
#endif
|
|
|
|
static int pca9633_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct pca9633_led *pca9633;
|
|
struct pca9633_platform_data *pdata;
|
|
struct pca9633_chipdef *chip;
|
|
int i, err;
|
|
|
|
chip = &pca9633_chipdefs[id->driver_data];
|
|
pdata = dev_get_platdata(&client->dev);
|
|
|
|
if (!pdata) {
|
|
pdata = pca9633_dt_init(client, chip);
|
|
if (IS_ERR(pdata)) {
|
|
dev_warn(&client->dev, "could not parse configuration\n");
|
|
pdata = NULL;
|
|
}
|
|
}
|
|
|
|
if (pdata && (pdata->leds.num_leds < 1 ||
|
|
pdata->leds.num_leds > chip->n_leds)) {
|
|
dev_err(&client->dev, "board info must claim 1-%d LEDs",
|
|
chip->n_leds);
|
|
return -EINVAL;
|
|
}
|
|
|
|
pca9633 = devm_kzalloc(&client->dev, chip->n_leds * sizeof(*pca9633),
|
|
GFP_KERNEL);
|
|
if (!pca9633)
|
|
return -ENOMEM;
|
|
|
|
i2c_set_clientdata(client, pca9633);
|
|
|
|
for (i = 0; i < chip->n_leds; i++) {
|
|
pca9633[i].client = client;
|
|
pca9633[i].led_num = i;
|
|
pca9633[i].chipdef = chip;
|
|
|
|
/* Platform data can specify LED names and default triggers */
|
|
if (pdata && i < pdata->leds.num_leds) {
|
|
if (pdata->leds.leds[i].name)
|
|
snprintf(pca9633[i].name,
|
|
sizeof(pca9633[i].name), "pca9633:%s",
|
|
pdata->leds.leds[i].name);
|
|
if (pdata->leds.leds[i].default_trigger)
|
|
pca9633[i].led_cdev.default_trigger =
|
|
pdata->leds.leds[i].default_trigger;
|
|
}
|
|
if (!pdata || i >= pdata->leds.num_leds ||
|
|
!pdata->leds.leds[i].name)
|
|
snprintf(pca9633[i].name, sizeof(pca9633[i].name),
|
|
"pca9633:%d:%.2x:%d", client->adapter->nr,
|
|
client->addr, i);
|
|
|
|
pca9633[i].led_cdev.name = pca9633[i].name;
|
|
pca9633[i].led_cdev.brightness_set = pca9633_led_set;
|
|
|
|
if (pdata && pdata->blink_type == PCA9633_HW_BLINK)
|
|
pca9633[i].led_cdev.blink_set = pca9633_blink_set;
|
|
|
|
INIT_WORK(&pca9633[i].work, pca9633_work);
|
|
|
|
err = led_classdev_register(&client->dev, &pca9633[i].led_cdev);
|
|
if (err < 0)
|
|
goto exit;
|
|
}
|
|
|
|
/* Disable LED all-call address and set normal mode */
|
|
i2c_smbus_write_byte_data(client, PCA9633_MODE1, 0x00);
|
|
|
|
/* Configure output: open-drain or totem pole (push-pull) */
|
|
if (pdata && pdata->outdrv == PCA9633_OPEN_DRAIN)
|
|
i2c_smbus_write_byte_data(client, PCA9633_MODE2, 0x01);
|
|
|
|
/* Turn off LEDs */
|
|
i2c_smbus_write_byte_data(client, chip->ledout_base, 0x00);
|
|
if (chip->n_leds > 4)
|
|
i2c_smbus_write_byte_data(client, chip->ledout_base + 1, 0x00);
|
|
|
|
return 0;
|
|
|
|
exit:
|
|
while (i--) {
|
|
led_classdev_unregister(&pca9633[i].led_cdev);
|
|
cancel_work_sync(&pca9633[i].work);
|
|
}
|
|
|
|
return err;
|
|
}
|
|
|
|
static int pca9633_remove(struct i2c_client *client)
|
|
{
|
|
struct pca9633_led *pca9633 = i2c_get_clientdata(client);
|
|
int i;
|
|
|
|
for (i = 0; i < pca9633->chipdef->n_leds; i++)
|
|
if (pca9633[i].client != NULL) {
|
|
led_classdev_unregister(&pca9633[i].led_cdev);
|
|
cancel_work_sync(&pca9633[i].work);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct i2c_driver pca9633_driver = {
|
|
.driver = {
|
|
.name = "leds-pca9633",
|
|
.owner = THIS_MODULE,
|
|
.of_match_table = of_match_ptr(of_pca9633_match),
|
|
},
|
|
.probe = pca9633_probe,
|
|
.remove = pca9633_remove,
|
|
.id_table = pca9633_id,
|
|
};
|
|
|
|
module_i2c_driver(pca9633_driver);
|
|
|
|
MODULE_AUTHOR("Peter Meerwald <p.meerwald@bct-electronic.com>");
|
|
MODULE_DESCRIPTION("PCA9633 LED driver");
|
|
MODULE_LICENSE("GPL v2");
|