mirror of
https://github.com/torvalds/linux.git
synced 2024-11-15 00:21:59 +00:00
6038f373a3
All file_operations should get a .llseek operation so we can make nonseekable_open the default for future file operations without a .llseek pointer. The three cases that we can automatically detect are no_llseek, seq_lseek and default_llseek. For cases where we can we can automatically prove that the file offset is always ignored, we use noop_llseek, which maintains the current behavior of not returning an error from a seek. New drivers should normally not use noop_llseek but instead use no_llseek and call nonseekable_open at open time. Existing drivers can be converted to do the same when the maintainer knows for certain that no user code relies on calling seek on the device file. The generated code is often incorrectly indented and right now contains comments that clarify for each added line why a specific variant was chosen. In the version that gets submitted upstream, the comments will be gone and I will manually fix the indentation, because there does not seem to be a way to do that using coccinelle. Some amount of new code is currently sitting in linux-next that should get the same modifications, which I will do at the end of the merge window. Many thanks to Julia Lawall for helping me learn to write a semantic patch that does all this. ===== begin semantic patch ===== // This adds an llseek= method to all file operations, // as a preparation for making no_llseek the default. // // The rules are // - use no_llseek explicitly if we do nonseekable_open // - use seq_lseek for sequential files // - use default_llseek if we know we access f_pos // - use noop_llseek if we know we don't access f_pos, // but we still want to allow users to call lseek // @ open1 exists @ identifier nested_open; @@ nested_open(...) { <+... nonseekable_open(...) ...+> } @ open exists@ identifier open_f; identifier i, f; identifier open1.nested_open; @@ int open_f(struct inode *i, struct file *f) { <+... ( nonseekable_open(...) | nested_open(...) ) ...+> } @ read disable optional_qualifier exists @ identifier read_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; expression E; identifier func; @@ ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off) { <+... ( *off = E | *off += E | func(..., off, ...) | E = *off ) ...+> } @ read_no_fpos disable optional_qualifier exists @ identifier read_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; @@ ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off) { ... when != off } @ write @ identifier write_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; expression E; identifier func; @@ ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off) { <+... ( *off = E | *off += E | func(..., off, ...) | E = *off ) ...+> } @ write_no_fpos @ identifier write_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; @@ ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off) { ... when != off } @ fops0 @ identifier fops; @@ struct file_operations fops = { ... }; @ has_llseek depends on fops0 @ identifier fops0.fops; identifier llseek_f; @@ struct file_operations fops = { ... .llseek = llseek_f, ... }; @ has_read depends on fops0 @ identifier fops0.fops; identifier read_f; @@ struct file_operations fops = { ... .read = read_f, ... }; @ has_write depends on fops0 @ identifier fops0.fops; identifier write_f; @@ struct file_operations fops = { ... .write = write_f, ... }; @ has_open depends on fops0 @ identifier fops0.fops; identifier open_f; @@ struct file_operations fops = { ... .open = open_f, ... }; // use no_llseek if we call nonseekable_open //////////////////////////////////////////// @ nonseekable1 depends on !has_llseek && has_open @ identifier fops0.fops; identifier nso ~= "nonseekable_open"; @@ struct file_operations fops = { ... .open = nso, ... +.llseek = no_llseek, /* nonseekable */ }; @ nonseekable2 depends on !has_llseek @ identifier fops0.fops; identifier open.open_f; @@ struct file_operations fops = { ... .open = open_f, ... +.llseek = no_llseek, /* open uses nonseekable */ }; // use seq_lseek for sequential files ///////////////////////////////////// @ seq depends on !has_llseek @ identifier fops0.fops; identifier sr ~= "seq_read"; @@ struct file_operations fops = { ... .read = sr, ... +.llseek = seq_lseek, /* we have seq_read */ }; // use default_llseek if there is a readdir /////////////////////////////////////////// @ fops1 depends on !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier readdir_e; @@ // any other fop is used that changes pos struct file_operations fops = { ... .readdir = readdir_e, ... +.llseek = default_llseek, /* readdir is present */ }; // use default_llseek if at least one of read/write touches f_pos ///////////////////////////////////////////////////////////////// @ fops2 depends on !fops1 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier read.read_f; @@ // read fops use offset struct file_operations fops = { ... .read = read_f, ... +.llseek = default_llseek, /* read accesses f_pos */ }; @ fops3 depends on !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier write.write_f; @@ // write fops use offset struct file_operations fops = { ... .write = write_f, ... + .llseek = default_llseek, /* write accesses f_pos */ }; // Use noop_llseek if neither read nor write accesses f_pos /////////////////////////////////////////////////////////// @ fops4 depends on !fops1 && !fops2 && !fops3 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier read_no_fpos.read_f; identifier write_no_fpos.write_f; @@ // write fops use offset struct file_operations fops = { ... .write = write_f, .read = read_f, ... +.llseek = noop_llseek, /* read and write both use no f_pos */ }; @ depends on has_write && !has_read && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier write_no_fpos.write_f; @@ struct file_operations fops = { ... .write = write_f, ... +.llseek = noop_llseek, /* write uses no f_pos */ }; @ depends on has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier read_no_fpos.read_f; @@ struct file_operations fops = { ... .read = read_f, ... +.llseek = noop_llseek, /* read uses no f_pos */ }; @ depends on !has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; @@ struct file_operations fops = { ... +.llseek = noop_llseek, /* no read or write fn */ }; ===== End semantic patch ===== Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Julia Lawall <julia@diku.dk> Cc: Christoph Hellwig <hch@infradead.org>
256 lines
5.5 KiB
C
256 lines
5.5 KiB
C
/*
|
|
* Watchdog driver for Cirrus Logic EP93xx family of devices.
|
|
*
|
|
* Copyright (c) 2004 Ray Lehtiniemi
|
|
* Copyright (c) 2006 Tower Technologies
|
|
* Based on ep93xx driver, bits from alim7101_wdt.c
|
|
*
|
|
* Authors: Ray Lehtiniemi <rayl@mail.com>,
|
|
* Alessandro Zummo <a.zummo@towertech.it>
|
|
*
|
|
* This file is licensed under the terms of the GNU General Public
|
|
* License version 2. This program is licensed "as is" without any
|
|
* warranty of any kind, whether express or implied.
|
|
*
|
|
* This watchdog fires after 250msec, which is a too short interval
|
|
* for us to rely on the user space daemon alone. So we ping the
|
|
* wdt each ~200msec and eventually stop doing it if the user space
|
|
* daemon dies.
|
|
*
|
|
* TODO:
|
|
*
|
|
* - Test last reset from watchdog status
|
|
* - Add a few missing ioctls
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/miscdevice.h>
|
|
#include <linux/watchdog.h>
|
|
#include <linux/timer.h>
|
|
#include <linux/uaccess.h>
|
|
#include <linux/io.h>
|
|
#include <mach/hardware.h>
|
|
|
|
#define WDT_VERSION "0.3"
|
|
#define PFX "ep93xx_wdt: "
|
|
|
|
/* default timeout (secs) */
|
|
#define WDT_TIMEOUT 30
|
|
|
|
static int nowayout = WATCHDOG_NOWAYOUT;
|
|
static int timeout = WDT_TIMEOUT;
|
|
|
|
static struct timer_list timer;
|
|
static unsigned long next_heartbeat;
|
|
static unsigned long wdt_status;
|
|
static unsigned long boot_status;
|
|
|
|
#define WDT_IN_USE 0
|
|
#define WDT_OK_TO_CLOSE 1
|
|
|
|
#define EP93XX_WDT_REG(x) (EP93XX_WATCHDOG_BASE + (x))
|
|
#define EP93XX_WDT_WATCHDOG EP93XX_WDT_REG(0x00)
|
|
#define EP93XX_WDT_WDSTATUS EP93XX_WDT_REG(0x04)
|
|
|
|
/* reset the wdt every ~200ms */
|
|
#define WDT_INTERVAL (HZ/5)
|
|
|
|
static void wdt_enable(void)
|
|
{
|
|
__raw_writew(0xaaaa, EP93XX_WDT_WATCHDOG);
|
|
}
|
|
|
|
static void wdt_disable(void)
|
|
{
|
|
__raw_writew(0xaa55, EP93XX_WDT_WATCHDOG);
|
|
}
|
|
|
|
static inline void wdt_ping(void)
|
|
{
|
|
__raw_writew(0x5555, EP93XX_WDT_WATCHDOG);
|
|
}
|
|
|
|
static void wdt_startup(void)
|
|
{
|
|
next_heartbeat = jiffies + (timeout * HZ);
|
|
|
|
wdt_enable();
|
|
mod_timer(&timer, jiffies + WDT_INTERVAL);
|
|
}
|
|
|
|
static void wdt_shutdown(void)
|
|
{
|
|
del_timer_sync(&timer);
|
|
wdt_disable();
|
|
}
|
|
|
|
static void wdt_keepalive(void)
|
|
{
|
|
/* user land ping */
|
|
next_heartbeat = jiffies + (timeout * HZ);
|
|
}
|
|
|
|
static int ep93xx_wdt_open(struct inode *inode, struct file *file)
|
|
{
|
|
if (test_and_set_bit(WDT_IN_USE, &wdt_status))
|
|
return -EBUSY;
|
|
|
|
clear_bit(WDT_OK_TO_CLOSE, &wdt_status);
|
|
|
|
wdt_startup();
|
|
|
|
return nonseekable_open(inode, file);
|
|
}
|
|
|
|
static ssize_t
|
|
ep93xx_wdt_write(struct file *file, const char __user *data, size_t len,
|
|
loff_t *ppos)
|
|
{
|
|
if (len) {
|
|
if (!nowayout) {
|
|
size_t i;
|
|
|
|
clear_bit(WDT_OK_TO_CLOSE, &wdt_status);
|
|
|
|
for (i = 0; i != len; i++) {
|
|
char c;
|
|
|
|
if (get_user(c, data + i))
|
|
return -EFAULT;
|
|
|
|
if (c == 'V')
|
|
set_bit(WDT_OK_TO_CLOSE, &wdt_status);
|
|
else
|
|
clear_bit(WDT_OK_TO_CLOSE, &wdt_status);
|
|
}
|
|
}
|
|
wdt_keepalive();
|
|
}
|
|
|
|
return len;
|
|
}
|
|
|
|
static const struct watchdog_info ident = {
|
|
.options = WDIOF_CARDRESET | WDIOF_MAGICCLOSE,
|
|
.identity = "EP93xx Watchdog",
|
|
};
|
|
|
|
static long ep93xx_wdt_ioctl(struct file *file,
|
|
unsigned int cmd, unsigned long arg)
|
|
{
|
|
int ret = -ENOTTY;
|
|
|
|
switch (cmd) {
|
|
case WDIOC_GETSUPPORT:
|
|
ret = copy_to_user((struct watchdog_info __user *)arg, &ident,
|
|
sizeof(ident)) ? -EFAULT : 0;
|
|
break;
|
|
|
|
case WDIOC_GETSTATUS:
|
|
ret = put_user(0, (int __user *)arg);
|
|
break;
|
|
|
|
case WDIOC_GETBOOTSTATUS:
|
|
ret = put_user(boot_status, (int __user *)arg);
|
|
break;
|
|
|
|
case WDIOC_KEEPALIVE:
|
|
wdt_keepalive();
|
|
ret = 0;
|
|
break;
|
|
|
|
case WDIOC_GETTIMEOUT:
|
|
/* actually, it is 0.250 seconds.... */
|
|
ret = put_user(1, (int __user *)arg);
|
|
break;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
static int ep93xx_wdt_release(struct inode *inode, struct file *file)
|
|
{
|
|
if (test_bit(WDT_OK_TO_CLOSE, &wdt_status))
|
|
wdt_shutdown();
|
|
else
|
|
printk(KERN_CRIT PFX
|
|
"Device closed unexpectedly - timer will not stop\n");
|
|
|
|
clear_bit(WDT_IN_USE, &wdt_status);
|
|
clear_bit(WDT_OK_TO_CLOSE, &wdt_status);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct file_operations ep93xx_wdt_fops = {
|
|
.owner = THIS_MODULE,
|
|
.write = ep93xx_wdt_write,
|
|
.unlocked_ioctl = ep93xx_wdt_ioctl,
|
|
.open = ep93xx_wdt_open,
|
|
.release = ep93xx_wdt_release,
|
|
.llseek = no_llseek,
|
|
};
|
|
|
|
static struct miscdevice ep93xx_wdt_miscdev = {
|
|
.minor = WATCHDOG_MINOR,
|
|
.name = "watchdog",
|
|
.fops = &ep93xx_wdt_fops,
|
|
};
|
|
|
|
static void ep93xx_timer_ping(unsigned long data)
|
|
{
|
|
if (time_before(jiffies, next_heartbeat))
|
|
wdt_ping();
|
|
|
|
/* Re-set the timer interval */
|
|
mod_timer(&timer, jiffies + WDT_INTERVAL);
|
|
}
|
|
|
|
static int __init ep93xx_wdt_init(void)
|
|
{
|
|
int err;
|
|
|
|
err = misc_register(&ep93xx_wdt_miscdev);
|
|
|
|
boot_status = __raw_readl(EP93XX_WDT_WATCHDOG) & 0x01 ? 1 : 0;
|
|
|
|
printk(KERN_INFO PFX "EP93XX watchdog, driver version "
|
|
WDT_VERSION "%s\n",
|
|
(__raw_readl(EP93XX_WDT_WATCHDOG) & 0x08)
|
|
? " (nCS1 disable detected)" : "");
|
|
|
|
if (timeout < 1 || timeout > 3600) {
|
|
timeout = WDT_TIMEOUT;
|
|
printk(KERN_INFO PFX
|
|
"timeout value must be 1<=x<=3600, using %d\n",
|
|
timeout);
|
|
}
|
|
|
|
setup_timer(&timer, ep93xx_timer_ping, 1);
|
|
return err;
|
|
}
|
|
|
|
static void __exit ep93xx_wdt_exit(void)
|
|
{
|
|
wdt_shutdown();
|
|
misc_deregister(&ep93xx_wdt_miscdev);
|
|
}
|
|
|
|
module_init(ep93xx_wdt_init);
|
|
module_exit(ep93xx_wdt_exit);
|
|
|
|
module_param(nowayout, int, 0);
|
|
MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started");
|
|
|
|
module_param(timeout, int, 0);
|
|
MODULE_PARM_DESC(timeout,
|
|
"Watchdog timeout in seconds. (1<=timeout<=3600, default="
|
|
__MODULE_STRING(WDT_TIMEOUT) ")");
|
|
|
|
MODULE_AUTHOR("Ray Lehtiniemi <rayl@mail.com>,"
|
|
"Alessandro Zummo <a.zummo@towertech.it>");
|
|
MODULE_DESCRIPTION("EP93xx Watchdog");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_VERSION(WDT_VERSION);
|
|
MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
|