mirror of
https://github.com/torvalds/linux.git
synced 2024-09-29 11:23:16 +00:00
87875c1084
The caller of this function (parisc_driver_remove() in arch/parisc/kernel/drivers.c) ignores the return value, so better don't return any value at all to not wake wrong expectations in driver authors. The only function that could return a non-zero value before was ipmi_parisc_remove() which returns the return value of ipmi_si_remove_by_dev(). Make this function return void, too, as for all other callers the value is ignored, too. Also fold in a small checkpatch fix for: WARNING: Unnecessary space before function pointer arguments + void (*remove) (struct parisc_device *dev); Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> (for drivers/input) Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Acked-by: Jiri Slaby <jirislaby@kernel.org> Signed-off-by: Helge Deller <deller@gmx.de>
108 lines
2.9 KiB
C
108 lines
2.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* ipmi_si.h
|
|
*
|
|
* Interface from the device-specific interfaces (OF, DMI, ACPI, PCI,
|
|
* etc) to the base ipmi system interface code.
|
|
*/
|
|
|
|
#ifndef __IPMI_SI_H__
|
|
#define __IPMI_SI_H__
|
|
|
|
#include <linux/ipmi.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#define SI_DEVICE_NAME "ipmi_si"
|
|
|
|
#define DEFAULT_REGSPACING 1
|
|
#define DEFAULT_REGSIZE 1
|
|
|
|
/* Numbers in this enumerator should be mapped to si_to_str[] */
|
|
enum si_type {
|
|
SI_TYPE_INVALID, SI_KCS, SI_SMIC, SI_BT, SI_TYPE_MAX
|
|
};
|
|
|
|
/* Array is defined in the ipmi_si_intf.c */
|
|
extern const char *const si_to_str[];
|
|
|
|
enum ipmi_addr_space {
|
|
IPMI_IO_ADDR_SPACE, IPMI_MEM_ADDR_SPACE
|
|
};
|
|
|
|
/*
|
|
* The structure for doing I/O in the state machine. The state
|
|
* machine doesn't have the actual I/O routines, they are done through
|
|
* this interface.
|
|
*/
|
|
struct si_sm_io {
|
|
unsigned char (*inputb)(const struct si_sm_io *io, unsigned int offset);
|
|
void (*outputb)(const struct si_sm_io *io,
|
|
unsigned int offset,
|
|
unsigned char b);
|
|
|
|
/*
|
|
* Generic info used by the actual handling routines, the
|
|
* state machine shouldn't touch these.
|
|
*/
|
|
void __iomem *addr;
|
|
unsigned int regspacing;
|
|
unsigned int regsize;
|
|
unsigned int regshift;
|
|
enum ipmi_addr_space addr_space;
|
|
unsigned long addr_data;
|
|
enum ipmi_addr_src addr_source; /* ACPI, PCI, SMBIOS, hardcode, etc. */
|
|
union ipmi_smi_info_union addr_info;
|
|
|
|
int (*io_setup)(struct si_sm_io *info);
|
|
void (*io_cleanup)(struct si_sm_io *info);
|
|
unsigned int io_size;
|
|
|
|
int irq;
|
|
int (*irq_setup)(struct si_sm_io *io);
|
|
void *irq_handler_data;
|
|
void (*irq_cleanup)(struct si_sm_io *io);
|
|
|
|
u8 slave_addr;
|
|
enum si_type si_type;
|
|
struct device *dev;
|
|
};
|
|
|
|
int ipmi_si_add_smi(struct si_sm_io *io);
|
|
irqreturn_t ipmi_si_irq_handler(int irq, void *data);
|
|
void ipmi_irq_start_cleanup(struct si_sm_io *io);
|
|
int ipmi_std_irq_setup(struct si_sm_io *io);
|
|
void ipmi_irq_finish_setup(struct si_sm_io *io);
|
|
void ipmi_si_remove_by_dev(struct device *dev);
|
|
struct device *ipmi_si_remove_by_data(int addr_space, enum si_type si_type,
|
|
unsigned long addr);
|
|
void ipmi_hardcode_init(void);
|
|
void ipmi_si_hardcode_exit(void);
|
|
void ipmi_si_hotmod_exit(void);
|
|
int ipmi_si_hardcode_match(int addr_space, unsigned long addr);
|
|
void ipmi_si_platform_init(void);
|
|
void ipmi_si_platform_shutdown(void);
|
|
void ipmi_remove_platform_device_by_name(char *name);
|
|
|
|
extern struct platform_driver ipmi_platform_driver;
|
|
|
|
#ifdef CONFIG_PCI
|
|
void ipmi_si_pci_init(void);
|
|
void ipmi_si_pci_shutdown(void);
|
|
#else
|
|
static inline void ipmi_si_pci_init(void) { }
|
|
static inline void ipmi_si_pci_shutdown(void) { }
|
|
#endif
|
|
#ifdef CONFIG_PARISC
|
|
void ipmi_si_parisc_init(void);
|
|
void ipmi_si_parisc_shutdown(void);
|
|
#else
|
|
static inline void ipmi_si_parisc_init(void) { }
|
|
static inline void ipmi_si_parisc_shutdown(void) { }
|
|
#endif
|
|
|
|
int ipmi_si_port_setup(struct si_sm_io *io);
|
|
int ipmi_si_mem_setup(struct si_sm_io *io);
|
|
|
|
#endif /* __IPMI_SI_H__ */
|