Kuninori Morimoto a122a116fc ASoC: rsnd: call rsnd_ssi_master_clk_start() from rsnd_ssi_init() ... Current rsnd needs to call .prepare (P) for clock settings, .trigger for playback start (S) and stop (E). It should be called as below from SSI point of view. P -> S -> E -> P -> S -> E -> ... But, if you used MIXer, below case might happen (2) 1: P -> S ---> E -> ... 2: P ----> S -> ... (1) (3) P(1) setups clock, but E(2) resets it. and starts playback (3). In such case, it will reports "SSI parent/child should use same rate". rsnd_ssi_master_clk_start() which is the main function at (P) was called from rsnd_ssi_init() (= S) before, but was moved by below patch to rsnd_soc_dai_prepare() (= P) to avoid using clk_get_rate() which shouldn't be used under atomic context. commit 4d230d1271 ("ASoC: rsnd: fixup not to call clk_get/set under non-atomic") Because of above patch, rsnd_ssi_master_clk_start() is now called at (P) which is for non atomic context. But (P) is assuming that spin lock is *not* used. One issue now is rsnd_ssi_master_clk_start() is checking ssi->xxx which should be protected by spin lock. After above patch, adg.c had below patch for other reasons. commit 06e8f5c842 ("ASoC: rsnd: don't call clk_get_rate() under atomic context") clk_get_rate() is used at probe() timing by this patch. In other words, rsnd_ssi_master_clk_start() is no longer using clk_get_rate() any more. This means we can call it from rsnd_ssi_init() (= S) again which is protected by spin lock. This patch re-move it to under spin lock, and solves 1. checking ssi->xxx without spin lock issue. 2. clk setting / device start / device stop race condition. Reported-by: Linh Phung T. Y. <linh.phung.jy@renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/875z0x1jt5.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org>		2021-04-14 15:24:09 +01:00
..
rcar	ASoC: rsnd: call rsnd_ssi_master_clk_start() from rsnd_ssi_init()	2021-04-14 15:24:09 +01:00
dma-sh7760.c	ASoC: sh: dma-sh7760: remove unused variable	2021-03-10 13:06:59 +00:00
fsi.c	ASoC: sh: use asoc_substream_to_rtd()	2020-07-23 19:07:25 +01:00
hac.c	ASoC: soc-core: remove bus_control	2020-01-21 17:07:08 +00:00
Kconfig	ASoC: sh: depend on COMMON_CLK to fix compile tests	2020-11-23 20:39:47 +00:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
migor.c	ASoC: sh: use asoc_substream_to_rtd()	2020-07-23 19:07:25 +01:00
sh7760-ac97.c	ASoC: sh: sh7760-ac97: use modern dai_link style	2019-06-06 21:37:35 +01:00
siu_dai.c	ASoC: siu: convert to SPDX identifiers	2018-06-18 12:16:42 +01:00
siu_pcm.c	ASoC: sh: siu_pcm: remove unused variable	2021-03-10 13:07:04 +00:00
siu.h	ASoC: siu: Fix build error by a wrong const prefix	2021-01-27 12:35:18 +00:00
ssi.c	ASoC: ssi: don't use discriminatory terms for debug log	2020-07-14 16:38:24 +01:00