mirror of
https://github.com/torvalds/linux.git
synced 2024-11-11 14:42:24 +00:00
8c26c4e269
The NILFS2 driver remounts itself in RO mode in the case of discovering metadata corruption (for example, discovering a broken bmap). But usually, this takes place when there have been file system operations before remounting in RO mode. Thereby, NILFS2 driver can be in RO mode with presence of dirty pages in modified inodes' address spaces. It results in flush kernel thread's infinite trying to flush dirty pages in RO mode. As a result, it is possible to see such side effects as: (1) flush kernel thread occupies 50% - 99% of CPU time; (2) system can't be shutdowned without manual power switch off. SYMPTOMS: (1) System log contains error message: "Remounting filesystem read-only". (2) The flush kernel thread occupies 50% - 99% of CPU time. (3) The system can't be shutdowned without manual power switch off. REPRODUCTION PATH: (1) Create volume group with name "unencrypted" by means of vgcreate utility. (2) Run script (prepared by Anthony Doggett <Anthony2486@interfaces.org.uk>): ----------------[BEGIN SCRIPT]-------------------- #!/bin/bash VG=unencrypted #apt-get install nilfs-tools darcs lvcreate --size 2G --name ntest $VG mkfs.nilfs2 -b 1024 -B 8192 /dev/mapper/$VG-ntest mkdir /var/tmp/n mkdir /var/tmp/n/ntest mount /dev/mapper/$VG-ntest /var/tmp/n/ntest mkdir /var/tmp/n/ntest/thedir cd /var/tmp/n/ntest/thedir sleep 2 date darcs init sleep 2 dmesg|tail -n 5 date darcs whatsnew || true date sleep 2 dmesg|tail -n 5 ----------------[END SCRIPT]-------------------- (3) Try to shutdown the system. REPRODUCIBILITY: 100% FIX: This patch implements checking mount state of NILFS2 driver in nilfs_writepage(), nilfs_writepages() and nilfs_mdt_write_page() methods. If it is detected the RO mount state then all dirty pages are simply discarded with warning messages is written in system log. [akpm@linux-foundation.org: fix printk warning] Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com> Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> Cc: Anthony Doggett <Anthony2486@interfaces.org.uk> Cc: ARAI Shun-ichi <hermes@ceres.dti.ne.jp> Cc: Piotr Szymaniak <szarpaj@grubelek.pl> Cc: Zahid Chowdhury <zahid.chowdhury@starsolutions.com> Cc: Elmer Zhang <freeboy6716@gmail.com> Cc: Wu Fengguang <fengguang.wu@intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
82 lines
2.7 KiB
C
82 lines
2.7 KiB
C
/*
|
|
* page.h - buffer/page management specific to NILFS
|
|
*
|
|
* Copyright (C) 2005-2008 Nippon Telegraph and Telephone Corporation.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*
|
|
* Written by Ryusuke Konishi <ryusuke@osrg.net>,
|
|
* Seiji Kihara <kihara@osrg.net>.
|
|
*/
|
|
|
|
#ifndef _NILFS_PAGE_H
|
|
#define _NILFS_PAGE_H
|
|
|
|
#include <linux/buffer_head.h>
|
|
#include "nilfs.h"
|
|
|
|
/*
|
|
* Extended buffer state bits
|
|
*/
|
|
enum {
|
|
BH_NILFS_Allocated = BH_PrivateStart,
|
|
BH_NILFS_Node,
|
|
BH_NILFS_Volatile,
|
|
BH_NILFS_Checked,
|
|
BH_NILFS_Redirected,
|
|
};
|
|
|
|
BUFFER_FNS(NILFS_Node, nilfs_node) /* nilfs node buffers */
|
|
BUFFER_FNS(NILFS_Volatile, nilfs_volatile)
|
|
BUFFER_FNS(NILFS_Checked, nilfs_checked) /* buffer is verified */
|
|
BUFFER_FNS(NILFS_Redirected, nilfs_redirected) /* redirected to a copy */
|
|
|
|
|
|
int __nilfs_clear_page_dirty(struct page *);
|
|
|
|
struct buffer_head *nilfs_grab_buffer(struct inode *, struct address_space *,
|
|
unsigned long, unsigned long);
|
|
void nilfs_forget_buffer(struct buffer_head *);
|
|
void nilfs_copy_buffer(struct buffer_head *, struct buffer_head *);
|
|
int nilfs_page_buffers_clean(struct page *);
|
|
void nilfs_page_bug(struct page *);
|
|
|
|
int nilfs_copy_dirty_pages(struct address_space *, struct address_space *);
|
|
void nilfs_copy_back_pages(struct address_space *, struct address_space *);
|
|
void nilfs_clear_dirty_page(struct page *, bool);
|
|
void nilfs_clear_dirty_pages(struct address_space *, bool);
|
|
void nilfs_mapping_init(struct address_space *mapping, struct inode *inode,
|
|
struct backing_dev_info *bdi);
|
|
unsigned nilfs_page_count_clean_buffers(struct page *, unsigned, unsigned);
|
|
unsigned long nilfs_find_uncommitted_extent(struct inode *inode,
|
|
sector_t start_blk,
|
|
sector_t *blkoff);
|
|
|
|
#define NILFS_PAGE_BUG(page, m, a...) \
|
|
do { nilfs_page_bug(page); BUG(); } while (0)
|
|
|
|
static inline struct buffer_head *
|
|
nilfs_page_get_nth_block(struct page *page, unsigned int count)
|
|
{
|
|
struct buffer_head *bh = page_buffers(page);
|
|
|
|
while (count-- > 0)
|
|
bh = bh->b_this_page;
|
|
get_bh(bh);
|
|
return bh;
|
|
}
|
|
|
|
#endif /* _NILFS_PAGE_H */
|