mirror of
https://github.com/torvalds/linux.git
synced 2024-11-19 10:31:48 +00:00
083e472176
On Tue, May 04, 2010 at 06:06:41PM +0200, Dan Carpenter wrote: > On Tue, May 04, 2010 at 10:03:18AM -0400, Jarod Wilson wrote: > > @@ -1205,7 +1204,7 @@ static u32 imon_panel_key_lookup(u64 hw_code) > > if (imon_panel_key_table[i].hw_code == (code | 0xffee)) > > break; > > > > - keycode = imon_panel_key_table[i % IMON_KEY_RELEASE_OFFSET].keycode; > > + keycode = imon_panel_key_table[i].keycode; > > > > return keycode; > > } > > There is still potentially a problem here because if we don't hit the > break statement, then we're one past the end of the array. D'oh. Okay, here's v2, should fix that buglet too. This hack was used when the imon driver was using internal key lookup routines, but became dead weight when the driver was converted to use ir-core's key lookup routines. These bits simply didn't get removed, drop 'em now. Pointed out by Dan Carpenter. v2: fix possible attempt to access beyond end of key table array, also pointed out by Dan. Signed-off-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> |
||
|---|---|---|
| .. | ||
| keymaps | ||
| imon.c | ||
| ir-core-priv.h | ||
| ir-functions.c | ||
| ir-jvc-decoder.c | ||
| ir-keytable.c | ||
| ir-nec-decoder.c | ||
| ir-raw-event.c | ||
| ir-rc5-decoder.c | ||
| ir-rc6-decoder.c | ||
| ir-sony-decoder.c | ||
| ir-sysfs.c | ||
| Kconfig | ||
| Makefile | ||
| rc-map.c | ||