Vlad Buslov 9e35552ae1 net: sched: flower: use correct ht function to prevent duplicates ... Implementation of function rhashtable_insert_fast() check if its internal helper function __rhashtable_insert_fast() returns non-NULL pointer and seemingly return -EEXIST in such case. However, since __rhashtable_insert_fast() is called with NULL key pointer, it never actually checks for duplicates, which means that -EEXIST is never returned to the user. Use rhashtable_lookup_insert_fast() hash table API instead. In order to verify that it works as expected and prevent the problem from happening in future, extend tc-tests with new test that verifies that no new filters with existing key can be inserted to flower classifier. Fixes: 1f17f7742e ("net: sched: flower: insert filter to ht before offloading it to hw") Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-04-11 11:33:06 -07:00
..
act_api.c	net/sched: let actions use RCU to access 'goto_chain'	2019-03-21 13:26:42 -07:00
act_bpf.c	net/sched: act_bpf: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_connmark.c	net/sched: act_connmark: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_csum.c	net/sched: act_csum: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_gact.c	net/sched: act_gact: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_ife.c	net/sched: act_ife: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_ipt.c	net/sched: prepare TC actions to properly validate the control action	2019-03-21 13:26:41 -07:00
act_meta_mark.c	net: remove duplicate includes	2017-12-13 13:18:46 -05:00
act_meta_skbprio.c	net sched actions: change IFE modules alias names	2017-10-12 22:13:20 -07:00
act_meta_skbtcindex.c	net: remove duplicate includes	2017-12-13 13:18:46 -05:00
act_mirred.c	net: sched: fix cleanup NULL pointer exception in act_mirr	2019-03-23 21:36:04 -04:00
act_nat.c	net/sched: act_nat: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_pedit.c	net/sched: act_pedit: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_police.c	net/sched: act_police: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_sample.c	net/sched: act_sample: fix divide by zero in the traffic path	2019-04-04 10:46:33 -07:00
act_simple.c	net/sched: act_simple: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_skbedit.c	net/sched: act_skbedit: validate the control action inside init()	2019-03-21 13:26:41 -07:00
act_skbmod.c	net/sched: act_skbmod: validate the control action inside init()	2019-03-21 13:26:42 -07:00
act_tunnel_key.c	net/sched: act_tunnel_key: validate the control action inside init()	2019-03-21 13:26:42 -07:00
act_vlan.c	net/sched: act_vlan: validate the control action inside init()	2019-03-21 13:26:42 -07:00
cls_api.c	net: sched: don't set tunnel for decap action	2019-04-02 13:20:30 -07:00
cls_basic.c	net_sched: initialize net pointer inside tcf_exts_init()	2019-02-22 15:26:51 -08:00
cls_bpf.c	net_sched: initialize net pointer inside tcf_exts_init()	2019-02-22 15:26:51 -08:00
cls_cgroup.c	net_sched: initialize net pointer inside tcf_exts_init()	2019-02-22 15:26:51 -08:00
cls_flow.c	net_sched: initialize net pointer inside tcf_exts_init()	2019-02-22 15:26:51 -08:00
cls_flower.c	net: sched: flower: use correct ht function to prevent duplicates	2019-04-11 11:33:06 -07:00
cls_fw.c	Revert "net: sched: fw: don't set arg->stop in fw_walk() when empty"	2019-02-27 10:12:19 -08:00
cls_matchall.c	net/sched: fix ->get helper of the matchall cls	2019-04-01 14:13:25 -07:00
cls_route.c	net_sched: initialize net pointer inside tcf_exts_init()	2019-02-22 15:26:51 -08:00
cls_rsvp6.c
cls_rsvp.c
cls_rsvp.h	net_sched: initialize net pointer inside tcf_exts_init()	2019-02-22 15:26:51 -08:00
cls_tcindex.c	net_sched: initialize net pointer inside tcf_exts_init()	2019-02-22 15:26:51 -08:00
cls_u32.c	net_sched: initialize net pointer inside tcf_exts_init()	2019-02-22 15:26:51 -08:00
em_canid.c
em_cmp.c
em_ipset.c
em_ipt.c	net: sched: add em_ipt ematch for calling xtables matches	2018-02-21 13:15:33 -05:00
em_meta.c	net: convert sock.sk_refcnt from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
em_nbyte.c	net: sched: em_nbyte: don't add the data offset twice	2018-01-24 14:52:40 -05:00
em_text.c
em_u32.c
ematch.c	net: sched: ematch: obtain net pointer from blocks	2017-10-16 21:00:40 +01:00
Kconfig	net: sched: Kconfig: update reference link for PIE	2019-03-26 11:17:09 -07:00
Makefile	tc: Add support for configuring the taprio scheduler	2018-10-04 13:52:23 -07:00
sch_api.c	net: sched: when clearing NOLOCK, clear TCQ_F_CPUSTATS, too	2019-04-10 12:20:46 -07:00
sch_atm.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_blackhole.c	net_sched: blackhole: tell upper qdisc about dropped packets	2018-06-17 08:42:33 +09:00
sch_cake.c	sch_cake: Make sure we can write the IP header before changing DSCP bits	2019-04-04 10:55:59 -07:00
sch_cbq.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_cbs.c	net/sched: cbs: fix port_rate miscalculation	2019-04-10 19:27:43 -07:00
sch_choke.c	net: sched: sch: add extack for change qdisc ops	2017-12-21 12:32:50 -05:00
sch_codel.c	net: sched: sch: add extack for change qdisc ops	2017-12-21 12:32:50 -05:00
sch_drr.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_dsmark.c	sched: Avoid dereferencing skb pointer after child enqueue	2019-01-15 20:12:00 -08:00
sch_etf.c	etf: Drop all expired packets	2018-11-16 20:39:34 -08:00
sch_fifo.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_fq_codel.c	net: Add and use skb_mark_not_on_list().	2018-09-10 10:06:54 -07:00
sch_fq.c	net_sched: sch_fq: avoid calling ktime_get_ns() if not needed	2018-11-20 09:51:32 -08:00
sch_generic.c	Revert: "net: sched: put back q.qlen into a single location"	2019-04-10 12:20:46 -07:00
sch_gred.c	net: sched: gred: support reporting stats from offloads	2018-11-19 18:53:46 -08:00
sch_hfsc.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_hhf.c	net: Add and use skb_mark_not_on_list().	2018-09-10 10:06:54 -07:00
sch_htb.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_ingress.c	net: sched: allow ingress and clsact qdiscs to share filter blocks	2018-01-17 14:53:57 -05:00
sch_mq.c	net: sched: introduce and use qstats read helpers	2019-04-01 14:50:13 -07:00
sch_mqprio.c	net: sched: introduce and use qstats read helpers	2019-04-01 14:50:13 -07:00
sch_multiq.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_netem.c	net: netem: fix skb length BUG_ON in __skb_to_sgvec	2019-02-28 10:31:31 -08:00
sch_pie.c	net: sched: pie: avoid slow division in drop probability decay	2019-02-28 10:35:41 -08:00
sch_plug.c	net: sched: sch: add extack for change qdisc ops	2017-12-21 12:32:50 -05:00
sch_prio.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_qfq.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_red.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_sfb.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_sfq.c	net: sch: api: add extack support in tcf_block_get	2017-12-21 12:32:51 -05:00
sch_skbprio.c	net/sched: add skbprio scheduler	2018-07-24 14:44:00 -07:00
sch_taprio.c	net/sched: taprio: fix picos_per_byte miscalculation	2019-04-10 19:27:43 -07:00
sch_tbf.c	net: sched: introduce and use qdisc tree flush/purge helpers	2019-04-01 14:50:13 -07:00
sch_teql.c	net: sched: sch: add extack for init callback	2017-12-21 12:32:50 -05:00