linux/drivers/tee/amdtee
Rijo Thomas f4384b3e54 tee: amdtee: fix use-after-free vulnerability in amdtee_close_session
There is a potential race condition in amdtee_close_session that may
cause use-after-free in amdtee_open_session. For instance, if a session
has refcount == 1, and one thread tries to free this session via:

    kref_put(&sess->refcount, destroy_session);

the reference count will get decremented, and the next step would be to
call destroy_session(). However, if in another thread,
amdtee_open_session() is called before destroy_session() has completed
execution, alloc_session() may return 'sess' that will be freed up
later in destroy_session() leading to use-after-free in
amdtee_open_session.

To fix this issue, treat decrement of sess->refcount and removal of
'sess' from session list in destroy_session() as a critical section, so
that it is executed atomically.

Fixes: 757cc3e9ff ("tee: add AMD-TEE driver")
Cc: stable@vger.kernel.org
Signed-off-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
2023-10-03 19:13:53 +02:00
..
amdtee_if.h tee: amdtee: Add return_origin to 'struct tee_cmd_load_ta' 2023-05-15 08:29:52 +02:00
amdtee_private.h tee: amdtee: unload TA only when its refcount becomes 0 2021-05-05 13:00:11 +02:00
call.c tee: amdtee: Add return_origin to 'struct tee_cmd_load_ta' 2023-05-15 08:29:52 +02:00
core.c tee: amdtee: fix use-after-free vulnerability in amdtee_close_session 2023-10-03 19:13:53 +02:00
Kconfig tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD 2020-02-13 16:55:04 +08:00
Makefile
shm_pool.c crypto: ccp - Add a header for multiple drivers to use __psp_pa 2023-03-17 11:16:43 +08:00