linux

mirror of https://github.com/torvalds/linux.git synced 2024-11-10 14:11:52 +00:00

A mirror of the official Linux kernel repository just in case

Go to file

Qi Zheng 998ad18b00 mm: swap: fix performance regression on sparsetruncate-tiny The ->percpu_pvec_drained was originally introduced by commit `d9ed0d08b6` ("mm: only drain per-cpu pagevecs once per pagevec usage") to drain per-cpu pagevecs only once per pagevec usage. But after converting the swap code to be more folio-based, the commit `c2bc16817a` ("mm/swap: add folio_batch_move_lru()") breaks this logic, which would cause ->percpu_pvec_drained to be reset to false, that means per-cpu pagevecs will be drained multiple times per pagevec usage. In theory, there should be no functional changes when converting code to be more folio-based. We should call folio_batch_reinit() in folio_batch_move_lru() instead of folio_batch_init(). And to verify that we still need ->percpu_pvec_drained, I ran mmtests/sparsetruncate-tiny and got the following data: baseline with baseline/ patch/ Min Time 326.00 ( 0.00%) 328.00 ( -0.61%) 1st-qrtle Time 334.00 ( 0.00%) 336.00 ( -0.60%) 2nd-qrtle Time 338.00 ( 0.00%) 341.00 ( -0.89%) 3rd-qrtle Time 343.00 ( 0.00%) 347.00 ( -1.17%) Max-1 Time 326.00 ( 0.00%) 328.00 ( -0.61%) Max-5 Time 327.00 ( 0.00%) 330.00 ( -0.92%) Max-10 Time 328.00 ( 0.00%) 331.00 ( -0.91%) Max-90 Time 350.00 ( 0.00%) 357.00 ( -2.00%) Max-95 Time 395.00 ( 0.00%) 390.00 ( 1.27%) Max-99 Time 508.00 ( 0.00%) 434.00 ( 14.57%) Max Time 547.00 ( 0.00%) 476.00 ( 12.98%) Amean Time 344.61 ( 0.00%) 345.56 * -0.28%* Stddev Time 30.34 ( 0.00%) 19.51 ( 35.69%) CoeffVar Time 8.81 ( 0.00%) 5.65 ( 35.87%) BAmean-99 Time 342.38 ( 0.00%) 344.27 ( -0.55%) BAmean-95 Time 338.58 ( 0.00%) 341.87 ( -0.97%) BAmean-90 Time 336.89 ( 0.00%) 340.26 ( -1.00%) BAmean-75 Time 335.18 ( 0.00%) 338.40 ( -0.96%) BAmean-50 Time 332.54 ( 0.00%) 335.42 ( -0.87%) BAmean-25 Time 329.30 ( 0.00%) 332.00 ( -0.82%) From the above it can be seen that we get similar data to when ->percpu_pvec_drained was introduced, so we still need it. Let's call folio_batch_reinit() in folio_batch_move_lru() to restore the original logic. Link: https://lkml.kernel.org/r/20230405161854.6931-1-zhengqi.arch@bytedance.com Fixes: `c2bc16817a` ("mm/swap: add folio_batch_move_lru()") Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> Acked-by: Mel Gorman <mgorman@suse.de> Cc: Lorenzo Stoakes <lstoakes@gmail.com> Cc: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>		2023-04-16 10:41:24 -07:00
arch	- Properly clear perf event status tracking in the AMD perf event	2023-03-26 09:13:35 -07:00
block	block: remove obsolete config BLOCK_COMPAT	2023-03-16 09:35:44 -06:00
certs	Kbuild updates for v6.3	2023-02-26 11:53:25 -08:00
crypto	asymmetric_keys: log on fatal failures in PE/pkcs7	2023-03-21 16:23:56 +00:00
Documentation	zsmalloc: document freeable stats	2023-04-05 18:06:23 -07:00
drivers	USB/Thunderbolt driver fixes for 6.3-rc4	2023-03-26 10:22:44 -07:00
fs	nilfs2: fix sysfs interface lifetime	2023-04-05 18:06:24 -07:00
include	mm: enable maple tree RCU mode by default	2023-04-05 18:06:22 -07:00
init	bootconfig: Change message if no bootconfig with CONFIG_BOOT_CONFIG_FORCE=y	2023-03-22 22:21:43 +09:00
io_uring	block-6.3-2023-03-24	2023-03-24 14:10:39 -07:00
ipc	Merge branch 'work.namespace' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2023-02-24 19:20:07 -08:00
kernel	mm: enable maple tree RCU mode by default	2023-04-05 18:06:22 -07:00
lib	maple_tree: fix a potential concurrency bug in RCU mode	2023-04-05 18:06:25 -07:00
LICENSES	LICENSES: Add the copyleft-next-0.3.1 license	2022-11-08 15:44:01 +01:00
mm	mm: swap: fix performance regression on sparsetruncate-tiny	2023-04-16 10:41:24 -07:00
net	nfsd-6.3 fixes:	2023-03-25 13:32:43 -07:00
rust	Rust fixes for 6.3-rc1	2023-03-03 14:51:15 -08:00
samples	LoongArch changes for v6.3	2023-03-01 09:27:00 -08:00
scripts	checksyscalls: ignore fstat to silence build warning on LoongArch	2023-03-23 17:18:32 -07:00
security	keys: Do not cache key in task struct if key is requested from kernel thread	2023-03-21 16:22:40 +00:00
sound	ALSA: hda/ca0132: fixup buffer overrun at tuning_ctl_set()	2023-03-14 17:04:53 +01:00
tools	maple_tree: fix write memory barrier of nodes once dead for RCU mode	2023-04-05 18:06:21 -07:00
usr	usr/gen_init_cpio.c: remove unnecessary -1 values from int file	2022-10-03 14:21:44 -07:00
virt	KVM/riscv changes for 6.3	2023-02-15 12:33:28 -05:00
.clang-format	cpumask: re-introduce constant-sized cpumask optimizations	2023-03-05 14:30:34 -08:00
.cocciconfig
.get_maintainer.ignore	get_maintainer: add Alan to .get_maintainer.ignore	2022-08-20 15:17:44 -07:00
.gitattributes	.gitattributes: use 'dts' diff driver for *.dtso files	2023-02-26 15:28:23 +09:00
.gitignore	kbuild: rpm-pkg: move source components to rpmbuild/SOURCES	2023-03-16 22:45:56 +09:00
.mailmap	mailmap: add an entry for Leonard Crestez	2023-03-28 15:24:32 -07:00
.rustfmt.toml	rust: add `.rustfmt.toml`	2022-09-28 09:02:20 +02:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	There is no particular theme here - mainly quick hits all over the tree.	2023-02-23 17:55:40 -08:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	USB/Thunderbolt driver fixes for 6.3-rc4	2023-03-26 10:22:44 -07:00
Makefile	Linux 6.3-rc4	2023-03-26 14:40:20 -07:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.