Niklas Cassel fa0db8e568 Revert "ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error" ... This reverts commit 28ab976911. Sense data can be in either fixed format or descriptor format. SAT-6 revision 1, "10.4.6 Control mode page", defines the D_SENSE bit: "The SATL shall support this bit as defined in SPC-5 with the following exception: if the D_ SENSE bit is set to zero (i.e., fixed format sense data), then the SATL should return fixed format sense data for ATA PASS-THROUGH commands." The libata SATL has always kept D_SENSE set to zero by default. (It is however possible to change the value using a MODE SELECT SG_IO command.) Failed ATA PASS-THROUGH commands correctly respected the D_SENSE bit, however, successful ATA PASS-THROUGH commands incorrectly returned the sense data in descriptor format (regardless of the D_SENSE bit). Commit 28ab976911 ("ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error") fixed this bug for successful ATA PASS-THROUGH commands. However, after commit 28ab976911 ("ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error"), there were bug reports that hdparm, hddtemp, and udisks were no longer working as expected. These applications incorrectly assume the returned sense data is in descriptor format, without even looking at the RESPONSE CODE field in the returned sense data (to see which format the returned sense data is in). Considering that there will be broken versions of these applications around roughly forever, we are stuck with being bug compatible with older kernels. Cc: stable@vger.kernel.org # 4.19+ Reported-by: Stephan Eisvogel <eisvogel@seitics.de> Reported-by: Christian Heusel <christian@heusel.eu> Closes: https://lore.kernel.org/linux-ide/0bf3f2f0-0fc6-4ba5-a420-c0874ef82d64@heusel.eu/ Fixes: 28ab976911 ("ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error") Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Link: https://lore.kernel.org/r/20240813131900.1285842-2-cassel@kernel.org Signed-off-by: Niklas Cassel <cassel@kernel.org>		2024-08-14 15:49:37 +02:00
..
pata_parport	parport: Remove parport_driver.devmodel	2024-07-03 16:44:22 +02:00
acard-ahci.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
ahci_brcm.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_ceva.c	ata: ahci_ceva: fix error handling for Xilinx GT PHY support	2024-02-19 10:44:37 +01:00
ahci_da850.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_dm816.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_dwc.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_imx.c	ata: imx: Use device_get_match_data()	2023-10-11 17:54:05 +09:00
ahci_mtk.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_mvebu.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_octeon.c	ata: ahci_octeon: Convert to devm_platform_ioremap_resource()	2023-08-02 17:37:06 +09:00
ahci_platform.c	driver core changes for 6.5-rc1	2023-07-03 12:56:23 -07:00
ahci_qoriq.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
ahci_seattle.c	ata: ahci_seattle: Convert to devm_platform_ioremap_resource()	2023-08-02 17:37:06 +09:00
ahci_st.c	ata: ahci_st: Remove an unused field in struct st_ahci_drv_data	2024-04-02 12:18:15 +09:00
ahci_sunxi.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_tegra.c	ata: ahci_tegra: Convert to devm_platform_ioremap_resource()	2023-08-02 17:37:06 +09:00
ahci_xgene.c	ata: xgene: Use of_device_get_match_data()	2023-10-11 17:53:37 +09:00
ahci.c	ata: ahci: Add debug print for external port	2024-07-04 11:52:32 +02:00
ahci.h	scsi: libata: Switch to using ->device_configure	2024-04-11 21:37:50 -04:00
ata_generic.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
ata_piix.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
Kconfig	ata: Kconfig: Update SATA_MOBILE_LPM_POLICY default to med_power_with_dipm	2024-05-27 11:34:50 +02:00
libahci_platform.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
libahci.c	ata: libata-core: Set ATA_QCFLAG_RTF_FILLED in fill_result_tf()	2024-07-03 10:51:41 +02:00
libata-acpi.c	ata: make use of ata_port_is_frozen() helper	2022-10-18 13:53:27 +09:00
libata-core.c	ata,scsi: Remove wrapper ata_sas_port_alloc()	2024-07-04 11:52:32 +02:00
libata-eh.c	scsi: sd: Fix TCG OPAL unlock on system resume	2024-03-25 15:46:12 -04:00
libata-pata-timings.c	ata: separate PATA timings code from libata-core.c	2020-03-26 10:28:19 -06:00
libata-pmp.c	ata: libata: add tracepoints for ATA error handling	2022-01-05 19:33:01 +09:00
libata-sata.c	ata,scsi: Remove wrapper ata_sas_port_alloc()	2024-07-04 11:52:32 +02:00
libata-scsi.c	Revert "ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error"	2024-08-14 15:49:37 +02:00
libata-sff.c	ata: add HAS_IOPORT dependencies	2024-04-08 10:07:28 +09:00
libata-trace.c	ata: scsi: rename flag ATA_QCFLAG_FAILED to ATA_QCFLAG_EH	2023-01-04 13:36:26 +09:00
libata-transport.c	ata: libata-core: Remove local_port_no struct member	2024-07-04 11:52:32 +02:00
libata-transport.h	ata,scsi: Remove wrappers ata_sas_tport_{add,delete}()	2024-07-04 11:52:31 +02:00
libata-zpodd.c	libata: zpodd: Fix small read overflow in zpodd_get_mech_type()	2019-07-29 16:00:14 -06:00
libata.h	ata,scsi: Remove wrapper ata_sas_port_alloc()	2024-07-04 11:52:32 +02:00
Makefile	ATA changes for 6.3-rc1	2023-02-22 13:35:51 -08:00
pata_acpi.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ali.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_amd.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_arasan_cf.c	ata: pata_arasan_cf: Convert to platform remove callback returning void	2023-08-02 17:53:09 +09:00
pata_artop.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_atiixp.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_atp867x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_buddha.c	ata: pata_buddha: Remove #include <asm/ide.h>	2023-08-24 08:09:59 +09:00
pata_cmd64x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cmd640.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5520.c	ata: pata_cs5520: Remove unnecessary call to pci_enable_device_io()	2024-05-16 14:35:08 -05:00
pata_cs5530.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5535.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5536.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cypress.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_efar.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ep93xx.c	ata: pata_ep93xx: use soc_device_match for UDMA modes	2023-08-25 22:09:43 +09:00
pata_falcon.c	ata: pata_falcon: Convert to platform remove callback returning void	2023-11-08 09:00:44 +09:00
pata_ftide010.c	ata: pata_ftide010: Add missing MODULE_DESCRIPTION	2023-08-25 08:21:03 +09:00
pata_gayle.c	ata: pata_gayle: Convert to platform remove callback returning void	2023-11-08 09:00:49 +09:00
pata_hpt3x2n.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_hpt3x3.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_hpt37x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_hpt366.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_icside.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_imx.c	ata: pata_imx: Use helper function devm_clk_get_enabled()	2023-08-17 07:45:32 +09:00
pata_isapnp.c	ata: pata_isapnp: Add missing error check for devm_ioport_map()	2023-11-20 09:22:26 +09:00
pata_it821x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_it8213.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ixp4xx_cf.c	ata: pata_ixp4xx: Remove unnecessary return value check	2023-08-02 17:37:06 +09:00
pata_jmicron.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_legacy.c	ata: pata_legacy: make legacy_exit() work again	2024-05-07 07:23:31 +09:00
pata_macio.c	block: move dma_pad_mask into queue_limits	2024-06-26 09:37:35 -06:00
pata_marvell.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_mpc52xx.c	ata: pata_mpc52xx: Convert to platform remove callback returning void	2023-08-02 17:55:49 +09:00
pata_mpiix.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_netcell.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ninja32.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ns87410.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ns87415.c	ata: pata_ns87415: mark ns87560_tf_read static	2023-07-28 08:52:42 +09:00
pata_octeon_cf.c	ata: pata_octeon_cf: fix error return code in octeon_cf_probe()	2023-07-26 08:32:21 +09:00
pata_of_platform.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
pata_oldpiix.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_opti.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_optidma.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_pcmcia.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_pdc202xx_old.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_pdc2027x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_piccolo.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_platform.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
pata_pxa.c	ata: pata_pxa: convert not to use dma_request_slave_channel()	2023-11-20 09:28:25 +09:00
pata_radisys.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_rb532_cf.c	ata: pata_rb532_cf: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
pata_rdc.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_rz1000.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sc1200.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sch.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_serverworks.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sil680.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sis.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sl82c105.c	ata: libata: remove deprecated EH callbacks	2023-08-02 17:45:42 +09:00
pata_triflex.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_via.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pdc_adma.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_dwc_460ex.c	ata: sata_dwc_460ex: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
sata_fsl.c	ata: sata_fsl: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
sata_gemini.c	ata: sata_gemini: Check clk_enable() result	2024-04-04 12:42:00 +09:00
sata_gemini.h
sata_highbank.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
sata_inic162x.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
sata_mv.c	SCSI misc on 20240514	2024-05-14 18:25:53 -07:00
sata_nv.c	scsi: libata: Switch to using ->device_configure	2024-04-11 21:37:50 -04:00
sata_promise.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_promise.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18	2019-05-21 11:28:46 +02:00
sata_qstor.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_rcar.c	ata: sata_rcar: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
sata_sil24.c	scsi: libata: Switch to using ->device_configure	2024-04-11 21:37:50 -04:00
sata_sil.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_sis.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_svw.c	ata: Use of_property_read_reg() to parse "reg"	2023-06-13 15:38:48 +09:00
sata_sx4.c	ata: sata_sx4: fix pdc20621_get_from_dimm() on 64-bit	2024-04-01 07:52:17 +09:00
sata_uli.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_via.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_vsc.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sis.h