linux/drivers/bcma
Colin Ian King 857f837d85 bcma: gpio: remove redundant re-assignment of chip->owner
There are two identical assignments of chip->owner to the same value,
the second assignment is redundant and can be removed.

Cleans up cppcheck warning:
drivers/bcma/driver_gpio.c:184:15: style: Variable 'chip->owner' is
reassigned a value before the old one has been used. [redundantAssignment]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220303085841.1124766-1-colin.i.king@gmail.com
2022-03-10 18:17:53 +02:00
..
bcma_private.h bcma: use dev_* printing functions 2019-01-10 13:39:19 +02:00
core.c
driver_chipcommon_b.c remove ioremap_nocache and devm_ioremap_nocache 2020-01-06 09:45:59 +01:00
driver_chipcommon_nflash.c
driver_chipcommon_pflash.c bcma: move parallel flash support to separated file 2016-03-07 14:41:08 +02:00
driver_chipcommon_pmu.c bcma: cleanup comments 2022-02-21 10:58:14 +02:00
driver_chipcommon_sflash.c mtd: bcm47xxsflash: use ioremap_cache() instead of KSEG0ADDR() 2016-04-04 00:07:57 -07:00
driver_chipcommon.c bcma: cleanup comments 2022-02-21 10:58:14 +02:00
driver_gmac_cmn.c
driver_gpio.c bcma: gpio: remove redundant re-assignment of chip->owner 2022-03-10 18:17:53 +02:00
driver_mips.c bcma: remove unused function 2021-04-18 09:36:56 +03:00
driver_pci_host.c bcma: cleanup comments 2022-02-21 10:58:14 +02:00
driver_pci.c bcma: fix incorrect update of BCMA_CORE_PCI_MDIO_DATA 2019-09-03 16:44:02 +03:00
driver_pcie2.c bcma: Adjust block comment 2017-12-07 15:33:02 +02:00
host_pci.c bcma: simplify reference to driver name 2021-10-12 17:50:12 -05:00
host_soc.c remove ioremap_nocache and devm_ioremap_nocache 2020-01-06 09:45:59 +01:00
Kconfig bcma: Allow selection of this driver when COMPILE_TEST=y 2018-07-18 09:34:19 +02:00
main.c bcma: cleanup comments 2022-02-21 10:58:14 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
README
scan.c bcma: Drop the unused parameter of bcma_scan_read32() 2021-08-29 14:44:57 +03:00
scan.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
sprom.c bcma: cleanup comments 2022-02-21 10:58:14 +02:00
TODO

Broadcom introduced new bus as replacement for older SSB. It is based on AMBA,
however from programming point of view there is nothing AMBA specific we use.

Standard AMBA drivers are platform specific, have hardcoded addresses and use
AMBA standard fields like CID and PID.

In case of Broadcom's cards every device consists of:
1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated
   as standard AMBA device. Reading it's CID or PID can cause machine lockup.
2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID)
   and PIDs (0x103BB369), but we do not use that info for anything. One of that
   devices is used for managing Broadcom specific core.

Addresses of AMBA devices are not hardcoded in driver and have to be read from
EPROM.

In this situation we decided to introduce separated bus. It can contain up to
16 devices identified by Broadcom specific fields: manufacturer, id, revision
and class.